Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43631?usp=email )
Change subject: proxy: make max TRXD PDU version VTY-configurable
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43631?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ibd384ee57a728b709b1e43726b46c8c3840b5535
Gerrit-Change-Number: 43631
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Sep 2026 08:51:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email )
Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick
......................................................................
Patch Set 2:
(2 comments)
File proxy/src/burst_fwd.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/d1fff980_89feedd7?usp… :
PS2, Line 151: llist_for_each_entry(cur, &c->tx_burst_queue, list) {
I guess 99.9999% of the time the bursts will arrive in order, which means probably iterating from the end of the queue towards the start makes sense. Or a t least have a fast path simply testing last value in the list.
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/b46e64f0_9f6264be?usp… :
PS2, Line 251: if (rc < 0) { /* br->fn is behind fn */
OSMO_UNLIKELY()
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ib147983e97638d2a2e487ccf76184912caf0941d
Gerrit-Change-Number: 43612
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 14 Sep 2026 08:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No