- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: testenv/osmo-dev: split get_targets to own func

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email ) Change subject: testenv/osmo-dev: split get_targets to own func ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf Gerrit-Change-Number: 40841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:10:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: osmo_dev: remove unused limit_section arg

by fixeria

Attention is currently required from: jolly, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email ) Change subject: testenv: osmo_dev: remove unused limit_section arg ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 Gerrit-Change-Number: 40840 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:09:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: add --targets

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40839?usp=email ) Change subject: gen_makefile: add --targets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I89bb60e94dd03606dbba5a3609d5e1a95993af5b Gerrit-Change-Number: 40839 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: generate convenience targets

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40838?usp=email ) Change subject: gen_makefile: generate convenience targets ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I64cd267cb1accda308585144b154f5f3837bf3e7 Gerrit-Change-Number: 40838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:05:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: turn projects_deps into a dict

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40837?usp=email ) Change subject: gen_makefile: turn projects_deps into a dict ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I74c53f4d6dda791c5d9e14f2274260f0e8cbbad2 Gerrit-Change-Number: 40837 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:03:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[M] Change in libosmo-abis[master]: Create rpm make targets and add libosmo-abis.spec.in

by fixeria

Attention is currently required from: Paul Bichis. fixeria has posted comments on this change by Paul Bichis. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40833?usp=email ) Change subject: Create rpm make targets and add libosmo-abis.spec.in ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: We did have RPM spec files in the past, but they have been removed: https://gerrit.osmocom.org/c/libosmo-abis/+/36723 For more details, please see: * https://osmocom.org/news/246 * https://osmocom.org/news/255 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I86c2c621887d1d9352f3ddfa1270c1379cf50fd9 Gerrit-Change-Number: 40833 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Bichis <paul(a)afk.ro> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Paul Bichis <paul(a)afk.ro> Gerrit-Comment-Date: Wed, 06 Aug 2025 09:02:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 days, 8 hours

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: turn projects_deps into a dict

by jolly

Attention is currently required from: fixeria, osmith. jolly has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40837?usp=email ) Change subject: gen_makefile: turn projects_deps into a dict ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I74c53f4d6dda791c5d9e14f2274260f0e8cbbad2 Gerrit-Change-Number: 40837 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 08:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[XS] Change in libosmo-abis[master]: Declare contrib/libosmo-abis.spec in AC_LOCAL

by fixeria

Attention is currently required from: Paul Bichis. fixeria has posted comments on this change by Paul Bichis. ( https://gerrit.osmocom.org/c/libosmo-abis/+/40836?usp=email ) Change subject: Declare contrib/libosmo-abis.spec in AC_LOCAL ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-abis/+/40836/comment/6ca020cd_7a0c630d… : PS1, Line 7: contrib/libosmo-abis.spec File `contrib/libosmo-abis.spec.in` is no longer present in the repository. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/40836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c99d0d19908000e5e6ae521faeb25e7e6ecd32d Gerrit-Change-Number: 40836 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Bichis <paul(a)afk.ro> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Paul Bichis <paul(a)afk.ro> Gerrit-Comment-Date: Wed, 06 Aug 2025 08:54:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: osmo_dev: remove unused limit_section arg

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email ) Change subject: testenv: osmo_dev: remove unused limit_section arg ...................................................................... testenv: osmo_dev: remove unused limit_section arg Remove the unused limit_section argument in testenv.osmo_dev.make(). The idea was to use osmo-dev to build programs where no packages are available when using --binary-packages, but this didn't work because when using --binary-packages, we must install all package dependencies from the binary repository (so testing nightly / latest use the expected library versions). Nowadays this use case is handled by podman_install.from_source_* functions without using osmo-dev. Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/40840/1 diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 5852063..fd5fa4e 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -99,7 +99,7 @@ init_done = True -def make(cfg, limit_section=None): +def make(cfg): targets = [] for section in cfg: @@ -107,11 +107,6 @@ if section == "testsuite": # Gets built with testenv.testsuite.build() continue - if limit_section and limit_section != section: - # When called from testenv.podman.install_packages as fallback to - # not having a package available, then we only want to run make - # for the target of one specific config section - continue if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in targets: targets += [section_data["make"]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 Gerrit-Change-Number: 40840 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 days, 9 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/osmo-dev: split get_targets to own func

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email ) Change subject: testenv/osmo-dev: split get_targets to own func ...................................................................... testenv/osmo-dev: split get_targets to own func Split the code for getting osmo-dev targets into a separate function, so this can be reused in the next patch. Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf --- M _testenv/testenv/osmo_dev.py 1 file changed, 16 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/41/40841/1 diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index fd5fa4e..8f9667e 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -51,6 +51,21 @@ sys.exit(1) +def get_targets(cfg): + ret = [] + + for section in cfg: + section_data = cfg[section] + if section == "testsuite": + # Gets built with testenv.testsuite.build() + continue + + if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in ret: + ret += [section_data["make"]] + + return ret + + def init(): global init_done @@ -100,17 +115,7 @@ def make(cfg): - targets = [] - - for section in cfg: - section_data = cfg[section] - if section == "testsuite": - # Gets built with testenv.testsuite.build() - continue - - if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in targets: - targets += [section_data["make"]] - + targets = get_targets(cfg) if not targets: logging.debug("No osmo-dev make targets found in testenv.cfg") return -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf Gerrit-Change-Number: 40841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

3 days, 9 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log