- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: transceiver: replace sprintf() with snprintf() in ctrl_sock_handle_rx
by pespin 17 Mar '26

17 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/42422?usp=email ) Change subject: transceiver: replace sprintf() with snprintf() in ctrl_sock_handle_rx ...................................................................... transceiver: replace sprintf() with snprintf() in ctrl_sock_handle_rx Change-Id: I7b725534c83a759e7b8f72f605dbcc38d778b1f2 --- M Transceiver52M/Transceiver.cpp 1 file changed, 30 insertions(+), 29 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index fa66625..17bf148 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -900,6 +900,7 @@ ctrl_msg cmd_to_send; char *buffer = cmd_received.data; char *response = cmd_to_send.data; + const size_t response_size = sizeof(cmd_to_send.data); const char *command, *params; int msgLen; ctrl_sock_state& s = mCtrlSockets[chan]; @@ -929,12 +930,12 @@ if (match_cmd(command, "POWEROFF", NULL)) { stop(); - sprintf(response,"RSP POWEROFF 0"); + snprintf(response, response_size, "RSP POWEROFF 0"); } else if (match_cmd(command, "POWERON", NULL)) { if (!start()) { - sprintf(response,"RSP POWERON 1"); + snprintf(response, response_size, "RSP POWERON 1"); } else { - sprintf(response,"RSP POWERON 0"); + snprintf(response, response_size, "RSP POWERON 0"); for (int i = 0; i < 8; i++) { for (int j = 0; j < 8; j++) mHandover[i][j] = false; @@ -944,62 +945,62 @@ unsigned ts = 0, ss = 0; sscanf(params, "%u %u", &ts, &ss); if (ts > 7 || ss > 7) { - sprintf(response, "RSP HANDOVER 1 %u %u", ts, ss); + snprintf(response, response_size, "RSP HANDOVER 1 %u %u", ts, ss); } else { mHandover[ts][ss] = true; - sprintf(response, "RSP HANDOVER 0 %u %u", ts, ss); + snprintf(response, response_size, "RSP HANDOVER 0 %u %u", ts, ss); } } else if (match_cmd(command, "NOHANDOVER", &params)) { unsigned ts = 0, ss = 0; sscanf(params, "%u %u", &ts, &ss); if (ts > 7 || ss > 7) { - sprintf(response, "RSP NOHANDOVER 1 %u %u", ts, ss); + snprintf(response, response_size, "RSP NOHANDOVER 1 %u %u", ts, ss); } else { mHandover[ts][ss] = false; - sprintf(response, "RSP NOHANDOVER 0 %u %u", ts, ss); + snprintf(response, response_size, "RSP NOHANDOVER 0 %u %u", ts, ss); } } else if (match_cmd(command, "SETMAXDLY", &params)) { //set expected maximum time-of-arrival for Access Bursts int maxDelay; sscanf(params, "%d", &maxDelay); mMaxExpectedDelayAB = maxDelay; // 1 GSM symbol is approx. 1 km - sprintf(response,"RSP SETMAXDLY 0 %d",maxDelay); + snprintf(response, response_size, "RSP SETMAXDLY 0 %d", maxDelay); } else if (match_cmd(command, "SETMAXDLYNB", &params)) { //set expected maximum time-of-arrival for Normal Bursts int maxDelay; sscanf(params, "%d", &maxDelay); mMaxExpectedDelayNB = maxDelay; // 1 GSM symbol is approx. 1 km - sprintf(response,"RSP SETMAXDLYNB 0 %d",maxDelay); + snprintf(response, response_size, "RSP SETMAXDLYNB 0 %d", maxDelay); } else if (match_cmd(command, "SETRXGAIN", &params)) { int newGain; sscanf(params, "%d", &newGain); newGain = mRadioInterface->setRxGain(newGain, chan); - sprintf(response,"RSP SETRXGAIN 0 %d",newGain); + snprintf(response, response_size, "RSP SETRXGAIN 0 %d", newGain); } else if (match_cmd(command, "NOISELEV", NULL)) { if (mOn) { float lev = mStates[chan].mNoiseLev; - sprintf(response,"RSP NOISELEV 0 %d", + snprintf(response, response_size, "RSP NOISELEV 0 %d", (int) round(20.0 * log10(rxFullScale / lev))); } else { - sprintf(response,"RSP NOISELEV 1 0"); + snprintf(response, response_size, "RSP NOISELEV 1 0"); } } else if (match_cmd(command, "SETPOWER", &params)) { int power; sscanf(params, "%d", &power); power = mRadioInterface->setPowerAttenuation(power, chan); mStates[chan].mPower = power; - sprintf(response, "RSP SETPOWER 0 %d", power); + snprintf(response, response_size, "RSP SETPOWER 0 %d", power); } else if (match_cmd(command, "ADJPOWER", &params)) { int power, step; sscanf(params, "%d", &step); power = mStates[chan].mPower + step; power = mRadioInterface->setPowerAttenuation(power, chan); mStates[chan].mPower = power; - sprintf(response, "RSP ADJPOWER 0 %d", power); -} else if (match_cmd(command, "NOMTXPOWER", NULL)) { + snprintf(response, response_size, "RSP ADJPOWER 0 %d", power); + } else if (match_cmd(command, "NOMTXPOWER", NULL)) { int power = mRadioInterface->getNominalTxPower(chan); - sprintf(response, "RSP NOMTXPOWER 0 %d", power); + snprintf(response, response_size, "RSP NOMTXPOWER 0 %d", power); } else if (match_cmd(command, "RXTUNE", &params)) { // tune receiver int freqKhz; @@ -1007,10 +1008,10 @@ mRxFreq = (freqKhz + cfg->freq_offset_khz) * 1e3; if (!mRadioInterface->tuneRx(mRxFreq, chan)) { LOGCHAN(chan, DTRXCTRL, FATAL) << "RX failed to tune"; - sprintf(response,"RSP RXTUNE 1 %d",freqKhz); + snprintf(response, response_size, "RSP RXTUNE 1 %d", freqKhz); } else - sprintf(response,"RSP RXTUNE 0 %d",freqKhz); + snprintf(response, response_size, "RSP RXTUNE 0 %d", freqKhz); } else if (match_cmd(command, "TXTUNE", &params)) { // tune txmtr int freqKhz; @@ -1018,20 +1019,20 @@ mTxFreq = (freqKhz + cfg->freq_offset_khz) * 1e3; if (!mRadioInterface->tuneTx(mTxFreq, chan)) { LOGCHAN(chan, DTRXCTRL, FATAL) << "TX failed to tune"; - sprintf(response,"RSP TXTUNE 1 %d",freqKhz); + snprintf(response, response_size, "RSP TXTUNE 1 %d", freqKhz); } else - sprintf(response,"RSP TXTUNE 0 %d",freqKhz); + snprintf(response, response_size, "RSP TXTUNE 0 %d", freqKhz); } else if (match_cmd(command, "SETTSC", &params)) { // set TSC unsigned TSC; sscanf(params, "%u", &TSC); if (TSC > 7) { - sprintf(response, "RSP SETTSC 1 %d", TSC); + snprintf(response, response_size, "RSP SETTSC 1 %d", TSC); } else { LOGC(DTRXCTRL, NOTICE) << "Changing TSC from " << mTSC << " to " << TSC; mTSC = TSC; - sprintf(response,"RSP SETTSC 0 %d", TSC); + snprintf(response, response_size, "RSP SETTSC 0 %d", TSC); } } else if (match_cmd(command, "SETSLOT", &params)) { // set slot type @@ -1040,12 +1041,12 @@ sscanf(params, "%d %d", &timeslot, &corrCode); if ((timeslot < 0) || (timeslot > 7)) { LOGCHAN(chan, DTRXCTRL, NOTICE) << "bogus message on control interface"; - sprintf(response,"RSP SETSLOT 1 %d %d",timeslot,corrCode); + snprintf(response, response_size, "RSP SETSLOT 1 %d %d", timeslot, corrCode); return 0; } mStates[chan].chanType[timeslot] = (ChannelCombination) corrCode; setModulus(timeslot, chan); - sprintf(response,"RSP SETSLOT 0 %d %d",timeslot,corrCode); + snprintf(response, response_size, "RSP SETSLOT 0 %d %d", timeslot, corrCode); } else if (match_cmd(command, "SETFORMAT", &params)) { // set TRXD protocol version unsigned version_recv; @@ -1054,28 +1055,28 @@ if (version_recv > TRX_DATA_FORMAT_VER) { LOGCHAN(chan, DTRXCTRL, INFO) << "rejecting TRXD version " << version_recv << " in favor of " << TRX_DATA_FORMAT_VER; - sprintf(response, "RSP SETFORMAT %u %u", TRX_DATA_FORMAT_VER, version_recv); + snprintf(response, response_size, "RSP SETFORMAT %u %u", TRX_DATA_FORMAT_VER, version_recv); } else { LOGCHAN(chan, DTRXCTRL, NOTICE) << "switching to TRXD version " << version_recv; mVersionTRXD[chan] = version_recv; - sprintf(response, "RSP SETFORMAT %u %u", version_recv, version_recv); + snprintf(response, response_size, "RSP SETFORMAT %u %u", version_recv, version_recv); } } else if (match_cmd(command, "RFMUTE", &params)) { // (Un)mute RF TX and RX unsigned mute; sscanf(params, "%u", &mute); mStates[chan].mMuted = mute ? true : false; - sprintf(response, "RSP RFMUTE 0 %u", mute); + snprintf(response, response_size, "RSP RFMUTE 0 %u", mute); } else if (match_cmd(command, "_SETBURSTTODISKMASK", &params)) { // debug command! may change or disappear without notice // set a mask which bursts to dump to disk int mask; sscanf(params, "%d", &mask); mWriteBurstToDiskMask = mask; - sprintf(response,"RSP _SETBURSTTODISKMASK 0 %d",mask); + snprintf(response, response_size, "RSP _SETBURSTTODISKMASK 0 %d", mask); } else { LOGCHAN(chan, DTRXCTRL, NOTICE) << "bogus command " << command << " on control interface."; - sprintf(response,"RSP ERR 1"); + snprintf(response, response_size, "RSP ERR 1"); } LOGCHAN(chan, DTRXCTRL, INFO) << "response is '" << response << "'"; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7b725534c83a759e7b8f72f605dbcc38d778b1f2 Gerrit-Change-Number: 42422 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-trx[master]: transceiver: make control command parsing arguments const
by pespin 17 Mar '26

17 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: transceiver: make control command parsing arguments const ...................................................................... transceiver: make control command parsing arguments const Change-Id: I2f3aa5363c337791451a388f394d7351d3183908 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index f5ddd9b..fa66625 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -828,8 +828,8 @@ * @param params pointer to arguments, or NULL * @return true if command matches, otherwise false */ -static bool match_cmd(char *buf, - const char *cmd, char **params) +static bool match_cmd(const char *buf, + const char *cmd, const char **params) { size_t cmd_len = strlen(cmd); @@ -900,7 +900,7 @@ ctrl_msg cmd_to_send; char *buffer = cmd_received.data; char *response = cmd_to_send.data; - char *command, *params; + const char *command, *params; int msgLen; ctrl_sock_state& s = mCtrlSockets[chan]; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f3aa5363c337791451a388f394d7351d3183908 Gerrit-Change-Number: 42420 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by pespin 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/f7ccd9da_4b9ad501?usp… : PS5, Line 11: - switch response formatting from sprintf() to snprintf() This is no longer part of this patch ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 12:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by pespin 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov, fixeria, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 12:35:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: replace sprintf() with snprintf() in ctrl_sock_handle_rx
by pespin 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42422?usp=email ) Change subject: transceiver: replace sprintf() with snprintf() in ctrl_sock_handle_rx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42422?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7b725534c83a759e7b8f72f605dbcc38d778b1f2 Gerrit-Change-Number: 42422 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 12:35:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status
by Jenkins Builder 17 Mar '26

17 Mar '26

Jenkins Builder has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email ) Change subject: 5gc: Update mobility procedure status ...................................................................... Patch Set 1: (1 comment) File 5gc/C5G_Tests.ttcn: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423/comment/2ed6b033_ab92… : PS1, Line 1029: * - 3GPP TS 23.632 5.3.3 Mobility from EPC to 5GC: Not suppored by open5gs (missing Nhss interface use in UDM) 'suppored' may be misspelled - perhaps 'supported'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff Gerrit-Change-Number: 42423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 17 Mar 2026 12:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status
by pespin 17 Mar '26

17 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email ) Change subject: 5gc: Update mobility procedure status ...................................................................... 5gc: Update mobility procedure status There's no procedure to do direct mobility between GERAN/UTRAN and 5GS according to spec, and IP preservation is not supported either through indirect mobility GERAN/UTRAN<->EUTRAN<->5GS. Regarding 3GPP TS 23.502 Annex G, open5gs-smfd supports Gn interface but only when working against a 4G MME, not through 5GS (PCF and AMF). Related specs: *3GPP TS 23.501: ** 5.17.2.4 Mobility between 5GS and GERAN/UTRAN ** Annex L (normative): Support of GERAN/UTRAN access * 3GPP TS 23.502 4.11.5 Impacts to 5GC Procedures * 3GPP TS 23.632 5.3 5GC-EPC Mobility Scenarios Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff --- M 5gc/C5G_Tests.ttcn 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/42423/1 diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn index 109749a..018f3a2 100644 --- a/5gc/C5G_Tests.ttcn +++ b/5gc/C5G_Tests.ttcn @@ -1025,7 +1025,10 @@ * - 3GPP TS 23.502 4.13.6.1 EPS fallback for IMS voice: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/2534) * - 3GPP TS 23.502 4.13.6.2 Inter RAT Fallback in 5GC for IMS voice: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/2534) * - 3GPP TS 23.502 4.13.6.3 Transfer of PDU session used for IMS voice from non-3GPP access to 5GS: Not supported by open5gs (https://github.com/open5gs/open5gs/issues/2534) - * - 3GPP TS 23.502 Annex G (normative): Support of GERAN/UTRAN access by SMF+PGW-C + * - 3GPP TS 23.632 5.3.2 Mobility from 5GC to EPC: Nudm_UECM_AMFDeregistration not supported by open5gs + * - 3GPP TS 23.632 5.3.3 Mobility from EPC to 5GC: Not suppored by open5gs (missing Nhss interface use in UDM) + * - 3GPP TS 23.632 5.2.3 Vector Generation in UDM/ARPF: Not supported by open5gs (missing Nudm_UEAuthentication_GetHssAv in UDM) + * - 3GPP TS 23.502 Annex G (normative): Support of GERAN/UTRAN access by SMF+PGW-C: Not supported by open5gs (Gn<->N7 (to PCF) in open5gs-smfd) * * - Emergency call (PDU Sess Establish "Request Type"="Emergency Request") * - PDU Session Type IPv6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff Gerrit-Change-Number: 42423 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info
by fixeria 17 Mar '26

17 Mar '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42369?usp=email ) Change subject: doc/manuals: update MmeItem related info ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > both files were added in previous patches in this series that are not merged yet, so it should be sq […] No, it should still be a separate patch because it fixes `63ce2c9`. I noticed this while reading the resulting PDF and decided to submit a fix on top of existing patches. I can work on rebasing: moving this patch back and fixing `doc/osmo-s1gw-cli.md` first, before it's integrated into the manual. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0b8115fe6342a80bf1eb99bd6ad210492a013947 Gerrit-Change-Number: 42369 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 12:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor...
by dexter 17 Mar '26

17 Mar '26

Attention is currently required from: daniel, laforge, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42353?usp=email ) Change subject: docs/put_key: add tutorial that explains how to manage global platform keys ...................................................................... Patch Set 2: (1 comment) File docs/put_key-tutorial.rst: https://gerrit.osmocom.org/c/pysim/+/42353/comment/f00a2814_36ab91c0?usp=em… : PS2, Line 80: pySIM-shell (00:MF/ADF.ISD-R)> We need to check back if this really works. Does the isdp_aid really point to the ISD we set up in the securityDomain PE? In the experiments I have done so far, the select to the ISD-P by the isdp_aid is successful. When I try get_data key_information I get an empty list back. I always thought that was due to the fact that I had no secure channel yet. But apparently the key_information does not require a secure channel. When I look at the profile package. I see that the securityDomain PE specifies an 'instanceAID' field. When I select the AID in that field everything starts to look normal and I can even establish the SCP03 secure channel. This is a bit confusing. I thought the securityDomain PE and the ISD-P were the same thing. I think this is something we should clarify and write down in this tutorial. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e Gerrit-Change-Number: 42353 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 12:06:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint for reading the current configuration
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42416?usp=email ) Change subject: [REST] Add GET /config endpoint for reading the current configuration ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File include/osmo_s1gw.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42416/comment/4a05f464_1663… : PS2, Line 1: %% Copyright (C) 2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ```suggestion %% Copyright (C) 2026 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> ``` -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42416?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic6c9562a541e4a0728257538887537aac6b99b97 Gerrit-Change-Number: 42416 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:40:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log