- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader sends request TPDU with maximum size
by Hoernchen 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42804?usp=email ) Change subject: CCID: Check if reader sends request TPDU with maximum size ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7c1cb52b578c19d6c0ec1493e45f6ed9c43735b4 Gerrit-Change-Number: 42804 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 21:01:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check response of reader with empty SIM carrier
by Hoernchen 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42805?usp=email ) Change subject: CCID: Check response of reader with empty SIM carrier ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifebdcce8f9dd9a51de5a5cb6cf223041d5c38622 Gerrit-Change-Number: 42805 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 21:00:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader handles Abort correctly
by Hoernchen 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email ) Change subject: CCID: Check if reader handles Abort correctly ...................................................................... Patch Set 1: Code-Review-1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f Gerrit-Change-Number: 42806 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 20:56:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: CCID: Check if reader handles Abort correctly
by Hoernchen 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. Hoernchen has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email ) Change subject: CCID: Check if reader handles Abort correctly ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The test is neither complete because it does not even use the ctrl req required by the spec and it does not use the seq as specified, nor does it cover the interesting cases of wrong order/seq of both messages which are not properly specified which is why the firmware does not support it. Kinda pointless even trying to test this, to be honest. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42806?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebe97e73497b8468ebf08faf2c4db700fc76997f Gerrit-Change-Number: 42806 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 20:55:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak
by daniel 08 Jun '26

08 Jun '26

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email ) Change subject: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak ...................................................................... tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a --- M src/tcap_as_loadshare.c 1 file changed, 31 insertions(+), 14 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified daniel: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 6a45d9a..b8941af 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -307,40 +307,49 @@ struct xua_msg *sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); - return -1; + rc = -1; + goto out; } /* TCAP uses only connectionless SCCP messages */ - if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) - return 0; + if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) { + rc = 0; + goto out; + } rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); - return -3; + rc = -3; + goto out; } /* retrieve + decode destination address */ rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); - return -4; + rc = -4; + goto out; } if (!ssn_contains_tcap(called_addr.ssn)) { /* No TCAP */ - return 0; + rc = 0; + goto out; } /* retrieve the SCCP payload (actual encoded TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); - if (!ie_data) - return -6; + if (!ie_data) { + rc = -6; + goto out; + } rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); - return -7; + rc = -7; + goto out; } LOGPAS(as, DLTCAP, LOGL_INFO, "Looking up transaction for type 0x%02x, otid=%u dtid=%u\n", parsed.present, parsed.otid, parsed.dtid); @@ -349,7 +358,8 @@ case TCAP_TCMessage_PR_begin: if (!(rc & OTID_SET)) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } tcap_trans_track_begin(as, asp, &calling_addr, &parsed.otid, &called_addr, NULL); @@ -357,7 +367,8 @@ case TCAP_TCMessage_PR_continue: if (!((rc & OTID_SET) && (rc & DTID_SET))) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } /* only hit/update the transaction tracking */ @@ -367,7 +378,8 @@ case TCAP_TCMessage_PR_end: if (!(rc & DTID_SET)) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } /* only hit/update the transaction tracking */ @@ -377,10 +389,15 @@ case TCAP_TCMessage_PR_NOTHING: default: /* TODO: what to do with those messages? */ - return -9; + rc = -9; + goto out; } - return 0; + rc = 0; + +out: + xua_msg_free(sua); + return rc; } /** Send UDTS to indicate that the originating UDT could not be delivered to its destination -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a Gerrit-Change-Number: 42818 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak
by daniel 08 Jun '26

08 Jun '26

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email ) Change subject: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a Gerrit-Change-Number: 42818 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 15:04:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: fix(ts_51_011): fix lifecycle decoding
by dexter 08 Jun '26

08 Jun '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42773?usp=email ) Change subject: fix(ts_51_011): fix lifecycle decoding ...................................................................... fix(ts_51_011): fix lifecycle decoding - implement proper LCS decoding per TS 102 221 / TS 31.101 - previous implementation misclassified multiple states Related: OS#7018 Change-Id: I8a3bd820b9fbc13c025f8302d1d2eac21686c541 --- M pySim/ts_51_011.py M tests/unittests/test_decode_select_resp.py 2 files changed, 16 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 24cf5c5..af7a433 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1306,12 +1306,23 @@ ret['file_descriptor']['record_len'] = record_len ret['file_descriptor']['num_of_rec'] = ret['file_size'] // record_len ret['access_conditions'] = b2h(resp_bin[8:11]) - if resp_bin[11] & 0x01 == 0: + + # Life cycle status integer, see also ETSI TS 102 221, table 11.7b + lcsi = resp_bin[11] + if lcsi == 0x00: + ret['life_cycle_status_int'] = 'no_information' + elif lcsi == 0x01: + ret['life_cycle_status_int'] = 'creation' + elif lcsi == 0x03: + ret['life_cycle_status_int'] = 'initialization' + elif lcsi & 0xFD == 0x05: ret['life_cycle_status_int'] = 'operational_activated' - elif resp_bin[11] & 0x04: + elif lcsi & 0xFD == 0x04: ret['life_cycle_status_int'] = 'operational_deactivated' + elif lcsi & 0xFC == 0x0C: + ret['life_cycle_status_int'] = 'termination' else: - ret['life_cycle_status_int'] = 'terminated' + ret['life_cycle_status_int'] = lcsi return ret @classmethod diff --git a/tests/unittests/test_decode_select_resp.py b/tests/unittests/test_decode_select_resp.py index 72fb077..4961ec9 100644 --- a/tests/unittests/test_decode_select_resp.py +++ b/tests/unittests/test_decode_select_resp.py @@ -47,10 +47,10 @@ "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'df'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '7f10', 'file_characteristics': '81', 'num_direct_child_df': 0, 'num_direct_child_ef': 13, 'num_chv_unblock_adm_codes': 4}}, # EF.MSISDN {"resp_hex" : "000000346f40040011ffff0102011a", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'creation'}}, # EF.ICCID {"resp_hex" : "0000000a2fe204000cffff01020000", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'creation'}}, ] self.decode_select_response(CardProfileSIM, testcases) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a3bd820b9fbc13c025f8302d1d2eac21686c541 Gerrit-Change-Number: 42773 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: fix(ts_51_011): apply correct access conditions length
by dexter 08 Jun '26

08 Jun '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42772?usp=email ) Change subject: fix(ts_51_011): apply correct access conditions length ...................................................................... fix(ts_51_011): apply correct access conditions length When the access conditions are extracted from resp_bin, the wrong length is used and only 2 bytes instead of 3 are extracted. 3GPP TS 51.011, section 9.2.1, table below "Response parameters/data in case of an EF", clearly states that the length should be 3 bytes (position 9-11) Related: OS#7018 Change-Id: I410fb58c395beafba8de6d5ab4e71452f424cdf2 --- M pySim/ts_51_011.py M tests/unittests/test_decode_select_resp.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 4cad049..24cf5c5 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -1305,7 +1305,7 @@ record_len = resp_bin[14] ret['file_descriptor']['record_len'] = record_len ret['file_descriptor']['num_of_rec'] = ret['file_size'] // record_len - ret['access_conditions'] = b2h(resp_bin[8:10]) + ret['access_conditions'] = b2h(resp_bin[8:11]) if resp_bin[11] & 0x01 == 0: ret['life_cycle_status_int'] = 'operational_activated' elif resp_bin[11] & 0x04: diff --git a/tests/unittests/test_decode_select_resp.py b/tests/unittests/test_decode_select_resp.py index 80dd72b..72fb077 100644 --- a/tests/unittests/test_decode_select_resp.py +++ b/tests/unittests/test_decode_select_resp.py @@ -47,10 +47,10 @@ "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'df'}}, 'proprietary_info': {'available_memory': 0}, 'file_id': '7f10', 'file_characteristics': '81', 'num_direct_child_df': 0, 'num_direct_child_ef': 13, 'num_chv_unblock_adm_codes': 4}}, # EF.MSISDN {"resp_hex" : "000000346f40040011ffff0102011a", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'linear_fixed'}, 'record_len': 26, 'num_of_rec': 2}, 'proprietary_info': {}, 'file_id': '6f40', 'file_size': 52, 'access_conditions': '11ffff', 'life_cycle_status_int': 'terminated'}}, # EF.ICCID {"resp_hex" : "0000000a2fe204000cffff01020000", - "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cff', 'life_cycle_status_int': 'terminated'}}, + "decoded" : {'file_descriptor': {'file_descriptor_byte': {'file_type': 'working_ef', 'structure': 'transparent'}}, 'proprietary_info': {}, 'file_id': '2fe2', 'file_size': 10, 'access_conditions': '0cffff', 'life_cycle_status_int': 'terminated'}}, ] self.decode_select_response(CardProfileSIM, testcases) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I410fb58c395beafba8de6d5ab4e71452f424cdf2 Gerrit-Change-Number: 42772 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: fix(ts_51_011): fix lifecycle decoding
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42773?usp=email ) Change subject: fix(ts_51_011): fix lifecycle decoding ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a3bd820b9fbc13c025f8302d1d2eac21686c541 Gerrit-Change-Number: 42773 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:54:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: fix(ts_51_011): apply correct access conditions length
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42772?usp=email ) Change subject: fix(ts_51_011): apply correct access conditions length ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I410fb58c395beafba8de6d5ab4e71452f424cdf2 Gerrit-Change-Number: 42772 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:54:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log