- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 4 APDU test
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42788?usp=email ) Change subject: CCID: Successful case 4 APDU test ...................................................................... CCID: Successful case 4 APDU test A GET RESPONSE APDU must respond with the exact number of bytes that have been indicated by SW2 of the previous SELECT MF APDU. Change-Id: I88c5ad3285c025f584b1c0296095beb918ab3f4e --- M ccid/CCID_Tests.ttcn 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 3ff9c36..6a8efc9 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -39,6 +39,7 @@ const octetstring c_UICC_SELECT_MF := '00a40004023f00'O; const octetstring c_SIM_SELECT_MF := 'a0a40004023f00'O; +const octetstring c_UICC_GET_RESPONSE_BASE := 'a0c00000'O; /* Table 7 of ISO7816-3 */ type enumerated ISO7816_Fi { @@ -381,6 +382,38 @@ f_start_and_wait(); } +/* GET RESPONSE (Case 4) */ +private function f_TC_successful_case_4() runs on Slot_CT +{ + var octetstring res; + var integer len; + + f_ccid_power_on(); + res := f_ccid_xfr(c_UICC_SELECT_MF, '??'O); + if (res[0] != '61'O) { + setverdict(fail, "Unexpected SW1"); + mtc.stop; + } + len := oct2int(res[1]); + res := f_ccid_xfr(c_UICC_GET_RESPONSE_BASE & int2oct(len, 1), ?) + if (lengthof(res) != len + 2) { + setverdict(fail, "Expected ", len + 2, " octets, but got ", res); + mtc.stop; + } +} +testcase TC_successful_case_4() runs on Test_CT +{ + var integer i; + + f_init(); + + for (i := 0; i < mp_use_slot_count; i := i+1) { + f_start_handler(refers(f_TC_successful_case_4), i); + } + + f_start_and_wait(); +} + /* TODO */ @@ -504,6 +537,7 @@ execute( TC_reset_params() ); } execute( TC_set_params_nochange() ); + execute( TC_successful_case_4() ); /* error handling */ execute( TC_inval_slot() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88c5ad3285c025f584b1c0296095beb918ab3f4e Gerrit-Change-Number: 42788 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Truncated APDU test
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42791?usp=email ) Change subject: CCID: Truncated APDU test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3df2ad9871bccdd03f618a6a457671adb1624590 Gerrit-Change-Number: 42791 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 2 and 3 APDU tests
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42790?usp=email ) Change subject: CCID: Successful case 2 and 3 APDU tests ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110250020c11bc7382b6308a182c09bb79e5e5e Gerrit-Change-Number: 42790 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 1 APDU test
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42789?usp=email ) Change subject: CCID: Successful case 1 APDU test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d5ee9bbd8bb2505a762e3fd80238db658940c16 Gerrit-Change-Number: 42789 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 4 APDU test
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42788?usp=email ) Change subject: CCID: Successful case 4 APDU test ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I88c5ad3285c025f584b1c0296095beb918ab3f4e Gerrit-Change-Number: 42788 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: CCID: Fix “unsupported Secure” test case
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42787?usp=email ) Change subject: CCID: Fix “unsupported Secure” test case ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21517c3e28e0d0e42e8a177b7c668bff15c35aa0 Gerrit-Change-Number: 42787 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if parameters keep unchanged, if set without change.
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42786?usp=email ) Change subject: CCID: Check if parameters keep unchanged, if set without change. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1bf5e58ba910d0633104b3bc3e902ce7d31cb10 Gerrit-Change-Number: 42786 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: jolly. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 9: -Code-Review (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/77fb50cb_c6b2f… : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore]) > I think it's fundamentally wrong to merge this as is since now afaiu make check needs osmo-python or […] Ah, I agree. I didn't understand your earlier comment, which made me think like "why would this have to do anything with the existing vty tests" and not "this is a problem as it requires osmopy during make check". -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in simtrace2[master]: firmware/Makefile: remove -Wredundant-decls
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email ) Change subject: firmware/Makefile: remove -Wredundant-decls ...................................................................... firmware/Makefile: remove -Wredundant-decls picolibc has redundant declarations of free and strdtold, which results in lots of warnings with -Wredundant-decls. Adjust CFLAGS to remove -Wredundant-decls to make the compiler log more readable. /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:147:9: warning: redundant redeclaration of 'free' [-Wredundant-decls] 147 | void free (void *) __nothrow; | ^~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:99:9: note: previous declaration of 'free' with type 'void(void *)' 99 | void free (void *) __nothrow; | ^~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:307:9: warning: redundant redeclaration of 'strtold' [-Wredundant-decls] 307 | strtold (const char *__restrict, char **__restrict); | ^~~~~~~ /usr/lib/picolibc/arm-none-eabi/include/stdlib.h:286:9: note: previous declaration of 'strtold' with type 'long double(const char * restrict, char ** restrict)' 286 | strtold (const char *__restrict __n, char **__restrict __end_PTR); | ^~~~~~~ Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe --- M firmware/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/firmware/Makefile b/firmware/Makefile index 13f6bd2..7692885 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -186,7 +186,7 @@ CFLAGS += -Waggregate-return #-Wsign-compare CFLAGS += -Wmissing-format-attribute -Wno-deprecated-declarations CFLAGS += #-Wpacked -CFLAGS += -Wredundant-decls -Wnested-externs #-Winline -Wlong-long +CFLAGS += -Wnested-externs #-Winline -Wlong-long -Wredundant-decls CFLAGS += -Wunreachable-code #CFLAGS += -Wcast-align #CFLAGS += -std=c11 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe Gerrit-Change-Number: 42769 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... firmware: replace libnewlib with picolibc libnewlib-arm-none-eabi has been removed in debian unstable, build the firmware with picolibc instead. Fixes: OS#7017 Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 --- M debian/control M firmware/Makefile 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: osmith: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/control b/debian/control index 75826be..c0e5a6f 100644 --- a/debian/control +++ b/debian/control @@ -12,7 +12,7 @@ dh-autoreconf, libosmocore-dev (>= 1.11.0), libpcsclite-dev, - libnewlib-arm-none-eabi, + picolibc-arm-none-eabi, libusb-1.0-0-dev, gcc-arm-none-eabi Standards-Version: 3.9.8 diff --git a/firmware/Makefile b/firmware/Makefile index 2f7a370..13f6bd2 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -171,6 +171,7 @@ INCLUDES += -Ilibosmocore/include INCLUDES += -Isrc_simtrace -Iinclude INCLUDES += -Iapps/$(APP) +INCLUDES += -I/usr/lib/picolibc/arm-none-eabi/include ifneq ("$(USE_CLANG)","0") CFLAGS += -Wno-unknown-warning-option -Wno-empty-body -fno-exceptions -fno-unwind-tables --config armv7em_soft_nofp_nosys -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log