- gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: esim/http_json_api.py: support text/plain response Content-Type
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: laforge, neels. fixeria has uploaded a new patch set (#2) to the change originally created by neels. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: esim/http_json_api.py: support text/plain response Content-Type ...................................................................... esim/http_json_api.py: support text/plain response Content-Type Allow returning text/plain Content-Types as 'data' output argument. So far, all the esim/http_json_api functions require a JSON response. However, a specific vendor has a list function where the request is JSON but the response is text/plain CSV data. Allow and return in a dict. Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Jenkins: skip-card-test --- M pySim/esim/http_json_api.py 1 file changed, 8 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/42155/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Gerrit-Change-Number: 42155 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: vty: make CPU scheduling optional based on platform support
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: Timur Davydov, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email ) Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/42653/comment/1ae838a5_c8e6a05e?… : PS1, Line 15: Also change osmo_cpu_sched_vty_init() to return int. > Done, I moved this fix into a separate preceding patch. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:15:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: fix osmo_cpu_sched_vty_init() prototype
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: Timur Davydov. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email ) Change subject: vty: fix osmo_cpu_sched_vty_init() prototype ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 Gerrit-Change-Number: 42709 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:13:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: rsl: don't send legacy Chan Ident IE for Nokia BTS
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email ) Change subject: rsl: don't send legacy Chan Ident IE for Nokia BTS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42717?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibce7a841907ac87ae378ded3ddb174d38b70b7b7 Gerrit-Change-Number: 42717 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:12:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: respond to BTS_COMMISS_TEST_REQ
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email ) Change subject: nokia: respond to BTS_COMMISS_TEST_REQ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42716?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0f2710c3cdb38a9e5b37e40ca5584237a730a902 Gerrit-Change-Number: 42716 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:08:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: nokia bts-reset-timer: raise the maximum to 300 s
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email ) Change subject: nokia bts-reset-timer: raise the maximum to 300 s ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42715?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie5b784c9cce56e27800084471a7fb0b867cc0c69 Gerrit-Change-Number: 42715 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/e2803337_402016f0?usp… : PS1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE Is this parameter Nokia *Site specific? If not, better use `!is_nokia_bts(bts)` here like other VTY commands do. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 20:05:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bsc[master]: nokia vty: change help strings away from "*Site"
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email ) Change subject: nokia vty: change help strings away from "*Site" ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42713/comment/de4f09af_243d12bf?usp… : PS1, Line 395: nokia_site You can also rename `nokia_site` in VTY commands and add `ALIAS` or `ALIAS_DEPRECATED` for backwards compatibility. This would require duplicating command and help strings though. Alternatively, you can change all commands to start with `(nokia|nokia_site) `. Just an idea, not a merge blocker. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c Gerrit-Change-Number: 42713 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 19:57:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by fixeria 28 Apr '26

28 Apr '26

Attention is currently required from: falconia, osmith. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: Code-Review+1 Verified+1 (2 comments) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/cbe3cb95_d351790f?usp… : PS1, Line 512: 256 cosmetic: add define for `256` too, e.g. `NOKIA_OML_MAX_SEGMENT_LEN`? File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/7dd039e3_cdca7d30?usp… : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, > > Avoid multiple line dereference - prefer 'run.static' […] The liner is indeed hallucinating here. Might be something for @osmith@sysmocom.de to check. For now, I am simply removing Jenkins' V-1 vote and adding my V+1. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 19:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by falconia 28 Apr '26

28 Apr '26

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: (2 comments) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/a286c739_416bf42d?usp… : PS1, Line 1778: It is also possible to configure the BTS without a reset, but in this case > please, no spaces at the start of a line In this case I am changing the word content of an existing comment without changing its formatting style. How do we override the overzealous linter in such cases? https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/a9c5f5a2_65188a93?usp… : PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, > Avoid multiple line dereference - prefer 'run.static' What the heck is it complaining about? Functions with long argument lists have those lists split into multiple lines all the time, to keep line length under control, which is all I am doing here. Once again, I need some way to override the overzealous linter. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Apr 2026 17:56:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log