- gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: move general asn debug options into iu_helpers

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: move general asn debug options into iu_helpers ...................................................................... move general asn debug options into iu_helpers In prepration to remove iu_client. Move debug variables asn_debug and asn1_xer_print which are not related to iu_client into common part. Related: OS#5487 Change-Id: If5175c449af13fe81e89488df71fcd8192091659 --- M TODO-RELEASE M include/osmocom/iuh/iu_common.h M include/osmocom/ranap/iu_client.h M src/iu_client.c M src/iu_helpers.c 5 files changed, 14 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/44/40844/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If5175c449af13fe81e89488df71fcd8192091659 Gerrit-Change-Number: 40844 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

6 days, 10 hours

1
0
0 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into tests/test_common.c

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into tests/test_common.c ...................................................................... move talloc_asn1_ctx into tests/test_common.c talloc_asn1_ctx is only used by tests and not connected to iu_client in any way. In preparation to remove iu_client. Related: OS#5487 Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c --- M src/iu_client.c M tests/test_common.c 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/43/40843/1 diff --git a/src/iu_client.c b/src/iu_client.c index 75be457..62ba58f 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -79,7 +79,6 @@ }; void *talloc_iu_ctx; -void *talloc_asn1_ctx; /* Implement the extern asn_debug from libasn1c to indicate whether to print * asn.1 debug messages (see libasn1c). */ diff --git a/tests/test_common.c b/tests/test_common.c index 36d9954..8651852 100644 --- a/tests/test_common.c +++ b/tests/test_common.c @@ -72,6 +72,7 @@ static void *tall_hnb_ctx; void *msgb_ctx; +void *talloc_asn1_ctx; int test_common_init(void) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

6 days, 11 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move general asn debug options into iu_helpers

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email ) Change subject: move general asn debug options into iu_helpers ...................................................................... move general asn debug options into iu_helpers In prepration to remove iu_client. Move debug variables asn_debug and asn1_xer_print which are not related to iu_client into common part. Related: OS#5487 Change-Id: If5175c449af13fe81e89488df71fcd8192091659 --- M include/osmocom/iuh/iu_common.h M include/osmocom/ranap/iu_client.h M src/iu_client.c M src/iu_helpers.c 4 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/44/40844/1 diff --git a/include/osmocom/iuh/iu_common.h b/include/osmocom/iuh/iu_common.h index 11c2a79..766b622 100644 --- a/include/osmocom/iuh/iu_common.h +++ b/include/osmocom/iuh/iu_common.h @@ -21,3 +21,6 @@ uint8_t payload[0]; /* possible further length field + payload */ } __attribute__ ((packed)); +/* Debugging switches from asn1c and osmo-iuh */ +extern int asn_debug; +extern int asn1_xer_print; diff --git a/include/osmocom/ranap/iu_client.h b/include/osmocom/ranap/iu_client.h index 465a17d..a595a97 100644 --- a/include/osmocom/ranap/iu_client.h +++ b/include/osmocom/ranap/iu_client.h @@ -5,6 +5,7 @@ #include <osmocom/core/defs.h> #include <osmocom/core/linuxlist.h> #include <osmocom/gsm/gsm48.h> +#include <osmocom/iuh/iu_common.h> #include <osmocom/sigtran/sccp_sap.h> struct msgb; @@ -15,10 +16,6 @@ struct ranap_iu_rnc; -/* Debugging switches from asn1c and osmo-iuh */ -extern int asn_debug; -extern int asn1_xer_print; - enum ranap_nsap_addr_enc { RANAP_NSAP_ADDR_ENC_X213, RANAP_NSAP_ADDR_ENC_V4RAW, diff --git a/src/iu_client.c b/src/iu_client.c index 62ba58f..b54a0b8 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -80,15 +80,6 @@ void *talloc_iu_ctx; -/* Implement the extern asn_debug from libasn1c to indicate whether to print - * asn.1 debug messages (see libasn1c). */ -int asn_debug = 0; - -/* Implement the extern asn1_xer_print to indicate whether the ASN.1 binary - * code decoded and encoded during Iu communication should be logged to stderr - * (see asn.1 generated code in osmo-iuh). */ -int asn1_xer_print = 0; - ranap_iu_recv_cb_t global_iu_recv_cb = NULL; ranap_iu_event_cb_t global_iu_event_cb = NULL; int iu_log_subsystem = 0; diff --git a/src/iu_helpers.c b/src/iu_helpers.c index 5c7ff31..a89114a 100644 --- a/src/iu_helpers.c +++ b/src/iu_helpers.c @@ -31,6 +31,15 @@ #include <osmocom/ranap/RANAP_TransportLayerAddress.h> #include <osmocom/ranap/RANAP_TransportLayerInformation.h> +/* Implement the extern asn_debug from libasn1c to indicate whether to print + * asn.1 debug messages (see libasn1c). */ +int asn_debug = 0; + +/* Implement the extern asn1_xer_print to indicate whether the ASN.1 binary + * code decoded and encoded during Iu communication should be logged to stderr + * (see asn.1 generated code in osmo-iuh). */ +int asn1_xer_print = 0; + /* decode a BCD-string as used inside ASN.1 encoded Iu interface protocols */ int ranap_bcd_decode(char *out, size_t out_len, const uint8_t *in, size_t in_len) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If5175c449af13fe81e89488df71fcd8192091659 Gerrit-Change-Number: 40844 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

6 days, 11 hours

1
0
0 0

[S] Change in osmo-sgsn[master]: routing area: introduce sgsn_ra_find_or_create()

by lynxis lazus

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email ) Change subject: routing area: introduce sgsn_ra_find_or_create() ...................................................................... Patch Set 4: (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40691/comment/aaff0cc0_9fc53f68?us… : PS2, Line 88: LOGL_ERROR > Not yet fixed in version 3, hence I keep my -1. I was still working on it. Should be resolved now. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 13:06:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

6 days, 12 hours

1
0
0 0

[S] Change in osmo-sgsn[master]: routing area: introduce sgsn_ra_find_or_create()

by lynxis lazus

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: routing area: introduce sgsn_ra_find_or_create() ...................................................................... routing area: introduce sgsn_ra_find_or_create() If the RA is the same, return the RA, but if the ran type is different, return NULL instead of allocating a second RA in the other RAT. Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c M tests/gprs_routing_area/gprs_routing_area_test.c 3 files changed, 28 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/91/40691/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

6 days, 12 hours

1
0
0 0

[XS] Change in osmo-sgsn[master]: routing area: sgsn_ra_geran_page_ra: make argument rai const

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: routing area: sgsn_ra_geran_page_ra: make argument rai const ...................................................................... routing area: sgsn_ra_geran_page_ra: make argument rai const The second argument mmctx can't made const because of the paging info, which uses non-const fields. Change-Id: I21d7e66e433f2b891c94bae91697aa46198fb20c --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/93/40693/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I21d7e66e433f2b891c94bae91697aa46198fb20c Gerrit-Change-Number: 40693 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

6 days, 12 hours

1
0
0 0

[M] Change in osmo-sgsn[master]: BSSGP: reset cells when receiving a Reset on Signal BVC

by lynxis lazus

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40810?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: BSSGP: reset cells when receiving a Reset on Signal BVC ...................................................................... BSSGP: reset cells when receiving a Reset on Signal BVC When a PCU sends a BVC Reset over BSSGP on the Signal BVC, all cells which has been set up previously via PtP BVCs has to be removed. They might be introduced after the Signal BVC reset procedure has finished. Change-Id: I380c8f9ef90d8c7face5c380d923ab5168f5b484 --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_routing_area.c M tests/gprs_routing_area/gprs_routing_area_test.c M tests/gprs_routing_area/gprs_routing_area_test.ok 5 files changed, 90 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/10/40810/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I380c8f9ef90d8c7face5c380d923ab5168f5b484 Gerrit-Change-Number: 40810 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

6 days, 12 hours

1
0
0 0

[M] Change in osmo-sgsn[master]: BSSGP: reset cells when receiving a Reset on Signal BVCI

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40810?usp=email ) Change subject: BSSGP: reset cells when receiving a Reset on Signal BVCI ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40810/comment/29ba0f83_2d6380b6?us… : PS1, Line 10: all cells which has been setuped previously via PtP BVCIs > "set up"? Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40810/comment/5278b148_44cd41dd?us… : PS1, Line 13: They might be introduced after the Signal BVCI is reseted. > "reset"? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I380c8f9ef90d8c7face5c380d923ab5168f5b484 Gerrit-Change-Number: 40810 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:46:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

6 days, 12 hours

1
0
0 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: none of the comments from April addressed so far. File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/40096/comment/8e79fbef_792ad6f9?usp=em… : PS3, Line 33: abstract > if it's abstract, should it be an abc. […] I think the code has moved but the question remains. You describe in a comment that class ParamSource is "abstract", but it is not an abc.ABC. Do you have a different definition of "abstract"? An abstract base class usually has abstract methods which deriving classes must override. If they don't it will raise an exception. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:24:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 days, 12 hours

1
0
0 0

[S] Change in pysim[master]: personalization: set default values

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40094?usp=email ) Change subject: personalization: set default values ...................................................................... Patch Set 4: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/40094/comment/5a0d0620_f6c77562?usp=em… : PS2, Line 11: This is useful for user interaction, to prefill an input field that : indicates a valid input to modify to taste. > I think it looks odd in this patch because i later on separated the patch from the ParamSource patch […] For parameters that actually have a sane default value, I agree it makes sense to have them stored here. But for those that do not, or even worse, where a default would have critical security implications, there should not be a default. If you want to indicate an input format or an example, then that would be an "example content" or "input format" class member, but no a default value. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40094/comment/4485aa83_dbc8ae5a?usp=em… : PS2, Line 278: default_value > that's true, it's a copy paste artifact from the random parameters... […] there is never any use case for an all-zero ICCID. I don't see why we should add that in the code and why it should provide any advantage. If you want to specify length constraints, then that is what max_len and min_len are for. That is the actual "useful indicator for number of digits" as expressed by this class. Any code that wants to use that information in some kind of UI can use that. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03 Gerrit-Change-Number: 40094 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 days, 13 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log