- gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: [5/6] personalization: refactor AlgorithmID, K, Opc

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email ) Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 8: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/184e7b34_c6b81a61?usp=em… : PS8, Line 571: allow_len = int(128/8) # length in bytes (from BinaryParam) actually, the previuos comment is not resolved yet: TUAK allows different key length. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

6 days, 13 hours

1
0
0 0

[M] Change in pysim[master]: [5/6] personalization: refactor AlgorithmID, K, Opc

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39745?usp=email ) Change subject: [5/6] personalization: refactor AlgorithmID, K, Opc ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39745/comment/e4f9b95d_de22b546?usp=em… : PS3, Line 551: allow_len = int(128/8) # length in bytes (from BinaryParam) > I'm sorry, I do not comprehend this code snippet at all... […] the bit lengths are specified in the construct: key length can be 128 or 256 bits -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6296fdcfd5d2ed313c4aade57ff43cc362375848 Gerrit-Change-Number: 39745 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:08:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 days, 13 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/osmo-dev: split get_targets to own func

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email ) Change subject: testenv/osmo-dev: split get_targets to own func ...................................................................... testenv/osmo-dev: split get_targets to own func Split the code for getting osmo-dev targets into a separate function, so this can be reused in the next patch. Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf --- M _testenv/testenv/osmo_dev.py 1 file changed, 16 insertions(+), 11 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index fd5fa4e..8f9667e 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -51,6 +51,21 @@ sys.exit(1) +def get_targets(cfg): + ret = [] + + for section in cfg: + section_data = cfg[section] + if section == "testsuite": + # Gets built with testenv.testsuite.build() + continue + + if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in ret: + ret += [section_data["make"]] + + return ret + + def init(): global init_done @@ -100,17 +115,7 @@ def make(cfg): - targets = [] - - for section in cfg: - section_data = cfg[section] - if section == "testsuite": - # Gets built with testenv.testsuite.build() - continue - - if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in targets: - targets += [section_data["make"]] - + targets = get_targets(cfg) if not targets: logging.debug("No osmo-dev make targets found in testenv.cfg") return -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf Gerrit-Change-Number: 40841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 days, 13 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: osmo_dev: remove unused limit_section arg

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email ) Change subject: testenv: osmo_dev: remove unused limit_section arg ...................................................................... testenv: osmo_dev: remove unused limit_section arg Remove the unused limit_section argument in testenv.osmo_dev.make(). The idea was to use osmo-dev to build programs where no packages are available when using --binary-packages, but this didn't work because when using --binary-packages, we must install all package dependencies from the binary repository (so testing nightly / latest use the expected library versions). Nowadays this use case is handled by podman_install.from_source_* functions without using osmo-dev. Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 --- M _testenv/testenv/osmo_dev.py 1 file changed, 1 insertion(+), 6 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 5852063..fd5fa4e 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -99,7 +99,7 @@ init_done = True -def make(cfg, limit_section=None): +def make(cfg): targets = [] for section in cfg: @@ -107,11 +107,6 @@ if section == "testsuite": # Gets built with testenv.testsuite.build() continue - if limit_section and limit_section != section: - # When called from testenv.podman.install_packages as fallback to - # not having a package available, then we only want to run make - # for the target of one specific config section - continue if "make" in section_data and section_data["make"] != "no" and section_data["make"] not in targets: targets += [section_data["make"]] -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 Gerrit-Change-Number: 40840 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 days, 13 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: pass targets to osmo-dev's gen_makefile

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40842?usp=email ) Change subject: testenv: pass targets to osmo-dev's gen_makefile ...................................................................... testenv: pass targets to osmo-dev's gen_makefile Pass the targets we are about to build to osmo-dev's gen_makefile script. This has two advantages: 1) Check early if a target isn't known by the current osmo-dev version, displaying a useful error to the user instead of just failing during make later on: ERROR: filter_projects_deps_targets: can't find project osmo-new-project in projects_deps! [testenv] gen_makefile.py from osmo-dev failed! [testenv] Your osmo-dev.git clone might be outdated, try: [testenv] $ git -C /home/user/code/osmo-dev pull 2) Parsing the generated Makefile when running "make" after generating it doesn't cause a noticable delay anymore. On my machine (with many Osmocom git repos cloned in osmo-dev's src dir) it went from several seconds to instantly. Depends: osmo-dev I89bb60e94dd03606dbba5a3609d5e1a95993af5b Change-Id: Ib2d8802b305f145d27aab3c1cc3129709b93d93d --- M _testenv/testenv.py M _testenv/testenv/osmo_dev.py 2 files changed, 4 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/_testenv/testenv.py b/_testenv/testenv.py index ebc625e..9e33e37 100755 --- a/_testenv/testenv.py +++ b/_testenv/testenv.py @@ -45,9 +45,6 @@ testenv.podman.start() testenv.podman.check_titan_version() - if not testenv.args.binary_repo: - testenv.osmo_dev.init() - testenv.testsuite.init() testenv.testsuite.build() @@ -55,6 +52,7 @@ if not testenv.args.binary_repo: for cfg_name, cfg in testenv.testenv_cfg.cfgs.items(): testenv.testenv_cfg.set_current(cfg_name) + testenv.osmo_dev.init(cfg) testenv.osmo_dev.make(cfg) # Run the components + testsuite diff --git a/_testenv/testenv/osmo_dev.py b/_testenv/testenv/osmo_dev.py index 8f9667e..0b6bdf0 100644 --- a/_testenv/testenv/osmo_dev.py +++ b/_testenv/testenv/osmo_dev.py @@ -7,8 +7,6 @@ import testenv import testenv.cmd -init_done = False - def get_osmo_dev_dir(): # Users may have used osmo-dev to clone osmo-ttcn3-hacks: @@ -66,12 +64,7 @@ return ret -def init(): - global init_done - - if init_done: - return - +def init(cfg): extra_opts = [] if testenv.args.asan: extra_opts += ["sanitize.opts"] @@ -91,6 +84,8 @@ "--src-dir", testenv.src_dir, "--autoreconf-in-src-copy", + "--targets", + ",".join(get_targets(cfg)), "default.opts", "ccache.opts", "gtp_linux.opts", @@ -111,7 +106,6 @@ logging.critical("Your osmo-dev.git clone might be outdated, try:") logging.critical(f"$ git -C {shlex.quote(cwd)} pull") sys.exit(1) - init_done = True def make(cfg): -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2d8802b305f145d27aab3c1cc3129709b93d93d Gerrit-Change-Number: 40842 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 days, 13 hours

1
0
0 0

[M] Change in pysim[master]: [1/6] personalization: refactor: drop ClassVarMeta use

by laforge

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39741?usp=email ) Change subject: [1/6] personalization: refactor: drop ClassVarMeta use ...................................................................... Patch Set 11: Code-Review-1 (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39741/comment/e4f16f47_c731ac46?usp=em… : PS9, Line 37: class ConfigurableParameter: > There's no point about discussion whether abstract base classes and the python library are useful or […] I continue to see new patch versions with this change without seeing the above adressed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39741?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I60ea8fd11fb438ec90ddb08b17b658cbb789c051 Gerrit-Change-Number: 39741 Gerrit-PatchSet: 11 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

6 days, 13 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: pass targets to osmo-dev's gen_makefile

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40842?usp=email ) Change subject: testenv: pass targets to osmo-dev's gen_makefile ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2d8802b305f145d27aab3c1cc3129709b93d93d Gerrit-Change-Number: 40842 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 11:59:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 13 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv/osmo-dev: split get_targets to own func

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email ) Change subject: testenv/osmo-dev: split get_targets to own func ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40841?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2bd7c05102ca472614289870957cdca335c01eaf Gerrit-Change-Number: 40841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 11:58:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 13 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: osmo_dev: remove unused limit_section arg

by laforge

Attention is currently required from: jolly, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email ) Change subject: testenv: osmo_dev: remove unused limit_section arg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40840?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib09ffd0e269c58acd431bdbb5cc7cdcec2d36359 Gerrit-Change-Number: 40840 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 06 Aug 2025 11:58:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 13 hours

1
0
0 0

[M] Change in osmo-dev[master]: gen_makefile: generate convenience targets

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/40838?usp=email ) Change subject: gen_makefile: generate convenience targets ...................................................................... gen_makefile: generate convenience targets Instead of directly hardcoding the convenience targets as Makefile code, generate them from a dictionary. This allows reusing the information from the dictionary in the next patch for the --targets option. Change-Id: I64cd267cb1accda308585144b154f5f3837bf3e7 --- M gen_makefile.py 1 file changed, 45 insertions(+), 48 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve jolly: Looks good to me, but someone else must approve diff --git a/gen_makefile.py b/gen_makefile.py index c49a27a..5eb28ef 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -58,6 +58,40 @@ all_buildsystems_file = os.path.join(topdir, "all.buildsystems") parser = argparse.ArgumentParser(epilog=__doc__, formatter_class=argparse.RawTextHelpFormatter) +convenience_targets = { + # Whole networks + "cn": [ + "osmo-ggsn", + "osmo-hlr", + "osmo-iuh", + "osmo-mgw", + "osmo-sgsn", + "osmo-sip-connector", + "osmo-smlc", + ], + "cn-bsc": [ + "cn", + "osmo-bsc", + ], + "cn-bsc-nat": [ + "cn", + "mobile", + "osmo-bsc", + "osmo-bsc-nat", + "osmo-bts", + "virtphy", + ], + "usrp": [ + "cn-bsc", + "osmo-bts", + "osmo-trx", + ], + # Components in subdirs of repositories + "mobile": ["osmocom-bb_layer23"], + "trxcon": ["osmocom-bb_trxcon"], + "virtphy": ["osmocom-bb_virtphy"], +} + parser.add_argument('configure_opts_files', help='''Config file containing project name and ./configure options''', @@ -172,6 +206,15 @@ return {} return read_projects_deps(path) +def gen_convenience_targets(): + ret = "" + for short, full in convenience_targets.items(): + if ret: + ret += "\n" + ret += f".PHONY: {short}\n" + ret += f"{short}: {' '.join(full)}\n" + return ret + def gen_makefile_clone(proj, src, src_proj, update_src_copy_cmd): if proj == "osmocom-bb_layer23": return f''' @@ -550,55 +593,9 @@ default: usrp # -# Convenience targets for whole networks +# Convenience targets (whole networks, components in subdirs) # -.PHONY: cn -cn: \\ - osmo-ggsn \\ - osmo-hlr \\ - osmo-iuh \\ - osmo-mgw \\ - osmo-msc \\ - osmo-sgsn \\ - osmo-sip-connector \\ - osmo-smlc \\ - $(NULL) - -.PHONY: cn-bsc -cn-bsc: \\ - cn \\ - osmo-bsc \\ - $(NULL) - -.PHONY: cn-bsc-nat -cn-bsc-nat: \\ - cn \\ - mobile \\ - osmo-bsc \\ - osmo-bsc-nat \\ - osmo-bts \\ - virtphy \\ - $(NULL) - -.PHONY: usrp -usrp: \\ - cn-bsc \\ - osmo-bts \\ - osmo-trx \\ - $(NULL) - -# -# Convenience targets for components in subdirs of repositories -# -.PHONY: mobile -mobile: osmocom-bb_layer23 - -.PHONY: virtphy -virtphy: osmocom-bb_virtphy - -.PHONY: trxcon -trxcon: osmocom-bb_trxcon - +{gen_convenience_targets()} # # Other convenience targets # -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I64cd267cb1accda308585144b154f5f3837bf3e7 Gerrit-Change-Number: 40838 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

6 days, 14 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log