Attention is currently required from: fixeria.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42387?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name
......................................................................
ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name
Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb
---
M pySim/ts_31_102.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/42387/4
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42387?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb
Gerrit-Change-Number: 42387
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email )
Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md
......................................................................
Patch Set 5:
(2 comments)
File doc/manuals/chapters/cli.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/dcfbcd6c_6c1a… :
PS4, Line 34:
> is so much verbosity useful? this all needs to be kept in sync with changes to the program
I see no problem here either. I do not expect the new command line arguments to be added often, and even if we have to, updating the user manual is not a big deal.
File doc/manuals/chapters/rest.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/0ee8031a_ba49… :
PS4, Line 290: === Interactive CLI (`osmo-s1gw-cli`)
> this was just added in the previous patch, not great for code review :\
I am just moving this block into a dedicated file that documents `osmo-s1gw-cli`. Not sure what's wrong here, but I've removed this section from previous patch to avoid confusion.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic2556f6add9c6a24f6da03f4388d7f86dde0c5dc
Gerrit-Change-Number: 42368
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 15:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email )
Change subject: doc/manuals: document the REST interface
......................................................................
Patch Set 5:
(2 comments)
File doc/manuals/chapters/rest.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/01af9436_154c… :
PS4, Line 294: filtering
: (`CMD | grep ...`), and output redirection (`CMD > FILE`).
> piping into grep or redirecting into a file are not features of this program, these are features of […]
(removed this section; it will be added to `cli.adoc` in the next patch)
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/54cb1269_c648… :
PS4, Line 299:
> Here it might also make sense to just refer to `osmo-s1gw-cli -h` instead of duplicating the help in […]
(removed this section; it will be added to `cli.adoc` in the next patch)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I8bc9183fff8f65db71554ee26369db9bdb61b78a
Gerrit-Change-Number: 42367
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 15:53:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email )
Change subject: doc/manuals: document the metrics
......................................................................
Patch Set 5:
(3 comments)
File doc/manuals/chapters/metrics.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/290def47_e202… :
PS4, Line 5: https://github.com/Feuerlabs/exometer_core[exometer_core] library. Two
> "OsmoS1GW exposes internal metrics using the […]
I believe it's important to mention it here, so I've removed the library reference in `configuration.adoc`. I've also mentioned the StatsD reporter plugin here.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/d7c22b20_0ebf… :
PS4, Line 25:
> is this explanation of how the stats are stored internally useful to the user?
Right, this is more relevant for developers.
I've reworked this section explaining the hierarchical nature of the metric names.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/5685d006_8f13… :
PS4, Line 68: | `s1ap.proxy.in_pkt.erab_setup_req` | E-RAB SETUP REQUEST PDUs
> How about: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46
Gerrit-Change-Number: 42365
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 15:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email )
Change subject: doc/manuals: add overview, document running and configuration
......................................................................
Patch Set 5:
(7 comments)
File README.md:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/adb78ef2_930b… :
PS4, Line 131: `make install` deploys a complete ERTS release together with a convenience
> the edits in this line until the end of this section don't seem like improvements to me, it just add […]
Acknowledged
File doc/manuals/chapters/overview.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/d8e5288d_c03c… :
PS4, Line 9: , i.e. radio base stations
> seems unnecessary, people reading this should be familiar with what an eNodeB is, so I suggest to re […]
Acknowledged
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/c1ff35c8_b90a… :
PS4, Line 38: ----
> instead of such ascii art diagrams, we typically use graphviz graphs in manuals: https://gitea. […]
I tend to have problems with graphviz placing the graph elements randomly. I did my best here and (at least in https://dreampuf.github.io/GraphvizOnline/?engine=dot) the new diagram looks good.
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/c4256df6_40d8… :
PS4, Line 32: Useful for testing new features or bug fixes before they are formally released.
> Given that this is project specific documentation, I would remove above block starting with "Two pac […]
Acknowledged
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/7cc5aabd_a480… :
PS4, Line 107: Running `make install` (typically as root, or with `DESTDIR` set for
> This is very verbose. […]
Acknowledged, removed.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/f7ee711a_4629… :
PS4, Line 128: ==== The `osmo-s1gw` Bootstrap Script
> This is also very verbose. […]
I see no problem with explaining what the bootstrap script does and including the help message here. Especially given that osmo-s1gw is currently the only project that installs a release package and brings a bootstrap script (others install a escript instead). And the arguments of `osmo-s1gw.sh` are unlikely to be added/modified often.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/8d6a1432_d189… :
PS4, Line 198: Wireshark and are tagged with the application name `OsmoS1GW`.
> why is this worth mentioning? " and are tagged with the application name `OsmoS1GW`. […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb
Gerrit-Change-Number: 42364
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Mar 2026 15:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: doc/manuals: add overview, document running and configuration
......................................................................
doc/manuals: add overview, document running and configuration
Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb
Related: OS#6671
---
M README.md
A doc/manuals/Makefile
A doc/manuals/chapters/configuration.adoc
A doc/manuals/chapters/overview.adoc
A doc/manuals/chapters/running.adoc
A doc/manuals/osmo-s1gw-usermanual-docinfo.xml
A doc/manuals/osmo-s1gw-usermanual.adoc
7 files changed, 724 insertions(+), 35 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/64/42364/5
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb
Gerrit-Change-Number: 42364
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, osmith, pespin.
Hello Jenkins Builder, osmith, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42366?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: doc/manuals: document GTP-U KPI monitoring
......................................................................
doc/manuals: document GTP-U KPI monitoring
Change-Id: I2709cd545bfd6c8f6e34358caf9d372c02dd5c3e
Related: OS#6671, SYS#7307
---
M doc/manuals/chapters/configuration.adoc
A doc/manuals/chapters/gtpu_kpi.adoc
M doc/manuals/osmo-s1gw-usermanual.adoc
3 files changed, 113 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/66/42366/5
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42366?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I2709cd545bfd6c8f6e34358caf9d372c02dd5c3e
Gerrit-Change-Number: 42366
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: doc/manuals: document the metrics
......................................................................
doc/manuals: document the metrics
Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46
Related: OS#6671, SYS#7065
---
M doc/manuals/chapters/configuration.adoc
A doc/manuals/chapters/metrics.adoc
M doc/manuals/osmo-s1gw-usermanual.adoc
3 files changed, 189 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/65/42365/5
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46
Gerrit-Change-Number: 42365
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>