- gerrit-log - lists.osmocom.org

[XS] Change in simtrace2[master]: firmware/Makefile: remove -Wredundant-decls
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email ) Change subject: firmware/Makefile: remove -Wredundant-decls ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42769?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I32ff78f2a27191d1c6e114429d2e0713674732fe Gerrit-Change-Number: 42769 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:04:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: lynxis lazus, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 10:04:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: replace libnewlib with picolibc
by osmith 08 Jun '26

08 Jun '26

Attention is currently required from: laforge, lynxis lazus. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email ) Change subject: firmware: replace libnewlib with picolibc ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > irrespective of this issue, sysmocom will send you a simtrace2+accessories. I have the simtrace2 now, and verified that `simtrace-trace-dfu.bin` from the binary package built for debian unstable (so using debian unstable dependencies) still works with my two patches. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/42768?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: If136397b71435ea0850002ef6406067962e8d4d7 Gerrit-Change-Number: 42768 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 09:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix podman_extra with multiple cfgs
by osmith 08 Jun '26

08 Jun '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email ) Change subject: testenv: fix podman_extra with multiple cfgs ...................................................................... testenv: fix podman_extra with multiple cfgs Do not reuse the container that gets started to build the testsuite and test components, to also do the the first testsuite run. Restart it after selecting the current testenv*.cfg, and use the podman_extra value from the right config instead. As side-effect, this also makes the container restart logic much simpler. Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 --- M _testenv/testenv.py M _testenv/testenv/podman.py M _testenv/testenv/testenv_cfg.py 3 files changed, 9 insertions(+), 14 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/_testenv/testenv.py b/_testenv/testenv.py index 9450c8f..29bf56e 100755 --- a/_testenv/testenv.py +++ b/_testenv/testenv.py @@ -61,18 +61,13 @@ # Run the components + testsuite loop_count = 0 while loop_continue_cond(loop_count): - # Restart podman container before running again - if testenv.args.podman and loop_count: - testenv.podman.stop(True) - - cfg_count = 0 for cfg_name, cfg in testenv.testenv_cfg.cfgs.items(): - # Restart podman container before running with another config - if testenv.args.podman and cfg_count: - testenv.podman.stop(True) - testenv.testenv_cfg.set_current(cfg_name, loop_count) + # Restart podman container after testenv_cfg.current or loop_count change + if testenv.args.podman: + testenv.podman.stop(True) + if testenv.args.binary_repo: testenv.podman.enable_binary_repo() testenv.podman_install.packages(cfg, cfg_name) @@ -83,7 +78,6 @@ testenv.daemons.stop() testenv.testdir.clean_run_scripts("finished") - cfg_count += 1 testenv.set_log_prefix("[testenv]") loop_count += 1 diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py index 072b20e..dd3c592 100644 --- a/_testenv/testenv/podman.py +++ b/_testenv/testenv/podman.py @@ -267,7 +267,7 @@ dest = os.readlink(testenv.custom_kernel_path) cmd += ["--volume", f"{dest}:{dest}:ro"] - podman_extra = testenv.testenv_cfg.get_podman_extra_first_cfg() + podman_extra = testenv.testenv_cfg.get_podman_extra_current_cfg() if podman_extra: cmd += shlex.split(podman_extra) diff --git a/_testenv/testenv/testenv_cfg.py b/_testenv/testenv/testenv_cfg.py index 3146ae1..93ffa5d 100644 --- a/_testenv/testenv/testenv_cfg.py +++ b/_testenv/testenv/testenv_cfg.py @@ -74,9 +74,10 @@ return host, port -def get_podman_extra_first_cfg(): - _, cfg = next(iter(cfgs.items())) - return cfg["testsuite"].get("podman_extra", None) +def get_podman_extra_current_cfg(): + if current: + return cfgs[current]["testsuite"].get("podman_extra", None) + return None def verify_qemu_cfgs(): -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 Gerrit-Change-Number: 42816 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix podman_extra with multiple cfgs
by fixeria 05 Jun '26

05 Jun '26

Attention is currently required from: jolly, osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email ) Change subject: testenv: fix podman_extra with multiple cfgs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 Gerrit-Change-Number: 42816 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 17:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: fix podman_extra with multiple cfgs
by pespin 05 Jun '26

05 Jun '26

Attention is currently required from: fixeria, jolly, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email ) Change subject: testenv: fix podman_extra with multiple cfgs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42816?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12e187726673e1ca1b1ecfff6b34b1803127be86 Gerrit-Change-Number: 42816 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Jun 2026 15:40:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Add test case to verify proper DSCP settings
by pespin 05 Jun '26

05 Jun '26

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email ) Change subject: Add test case to verify proper DSCP settings ...................................................................... Patch Set 9: (1 comment) File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809/comment/89561bd9_c5e31… : PS7, Line 32: AT_CHECK([python3 -u $abs_top_builddir/tests/vty/vty_test_runner.py -w $abs_top_builddir -p $abs_srcdir -v TestDSCP],, [ignore], [ignore]) > merging this now as-is, we can always change the way we execute a test after it has been merged. I think it's fundamentally wrong to merge this as is since now afaiu make check needs osmo-python or whatever to work properly, which may in turn need more stuff in the system to run them, etc. and which in turn will may people run less make check. This is a uuser-facing feature, and hence afaiu should be tested when using the make target like vty or ext-tests or whatever, not tested during unit test phase. So I still think this needs to be changed as mentioned. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6ac965998433b4d8213cce30fc3fcf8fe485a092 Gerrit-Change-Number: 42809 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 15:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak
by pespin 05 Jun '26

05 Jun '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email ) Change subject: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a Gerrit-Change-Number: 42818 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 15:32:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak
by laforge 05 Jun '26

05 Jun '26

Attention is currently required from: daniel, lynxis lazus, pespin. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email ) Change subject: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a Gerrit-Change-Number: 42818 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 05 Jun 2026 14:36:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak
by lynxis lazus 05 Jun '26

05 Jun '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email ) Change subject: tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak ...................................................................... tcap loadsharing: tcap_as_rx_sccp_asp: Fix memory leak Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a --- M src/tcap_as_loadshare.c 1 file changed, 31 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/18/42818/1 diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 6a45d9a..b8941af 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -307,40 +307,49 @@ struct xua_msg *sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); - return -1; + rc = -1; + goto out; } /* TCAP uses only connectionless SCCP messages */ - if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) - return 0; + if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) { + rc = 0; + goto out; + } rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); - return -3; + rc = -3; + goto out; } /* retrieve + decode destination address */ rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); - return -4; + rc = -4; + goto out; } if (!ssn_contains_tcap(called_addr.ssn)) { /* No TCAP */ - return 0; + rc = 0; + goto out; } /* retrieve the SCCP payload (actual encoded TCAP data) */ ie_data = xua_msg_find_tag(sua, SUA_IEI_DATA); - if (!ie_data) - return -6; + if (!ie_data) { + rc = -6; + goto out; + } rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); - return -7; + rc = -7; + goto out; } LOGPAS(as, DLTCAP, LOGL_INFO, "Looking up transaction for type 0x%02x, otid=%u dtid=%u\n", parsed.present, parsed.otid, parsed.dtid); @@ -349,7 +358,8 @@ case TCAP_TCMessage_PR_begin: if (!(rc & OTID_SET)) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } tcap_trans_track_begin(as, asp, &calling_addr, &parsed.otid, &called_addr, NULL); @@ -357,7 +367,8 @@ case TCAP_TCMessage_PR_continue: if (!((rc & OTID_SET) && (rc & DTID_SET))) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } /* only hit/update the transaction tracking */ @@ -367,7 +378,8 @@ case TCAP_TCMessage_PR_end: if (!(rc & DTID_SET)) { /* FIXME: failure case */ - return -8; + rc = -8; + goto out; } /* only hit/update the transaction tracking */ @@ -377,10 +389,15 @@ case TCAP_TCMessage_PR_NOTHING: default: /* TODO: what to do with those messages? */ - return -9; + rc = -9; + goto out; } - return 0; + rc = 0; + +out: + xua_msg_free(sua); + return rc; } /** Send UDTS to indicate that the originating UDT could not be delivered to its destination -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42818?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id0b21bffcad43d9999f7579d92e5ef2f4a0d9f1a Gerrit-Change-Number: 42818 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log