- gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: lint/checkpatch: ignore MULTILINE_DEREFERENCE
by osmith 29 Apr '26

29 Apr '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/42719?usp=email ) Change subject: lint/checkpatch: ignore MULTILINE_DEREFERENCE ...................................................................... lint/checkpatch: ignore MULTILINE_DEREFERENCE This linting rule gives false positives, e.g. for this snippet: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, uint8_t *l3_msg, unsigned l3_msg_len) It complains with: src/osmo-bsc/bts_nokia_site.c:1785: WARNING:MULTILINE_DEREFERENCE: Avoid multiple line dereference - prefer 'run.static' Related: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/fd3a38ef_a59f616f/ Change-Id: If2a1972fe333f51d534a924fd5ac1c1f7eb65b01 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/42719/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index de14044..c1624e3 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -71,6 +71,7 @@ # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here # * MACRO_WITH_FLOW_CONTROL: not followed # * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars +# * MULTILINE_DEREFERENCE: false positives # * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore # * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in libosmocore # * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data Data passed through...') @@ -110,6 +111,7 @@ --ignore LONG_LINE_STRING \ --ignore MACRO_WITH_FLOW_CONTROL \ --ignore MISSING_SPACE \ + --ignore MULTILINE_DEREFERENCE \ --ignore PREFER_DEFINED_ATTRIBUTE_MACRO \ --ignore PREFER_FALLTHROUGH \ --ignore REPEATED_WORD \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42719?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If2a1972fe333f51d534a924fd5ac1c1f7eb65b01 Gerrit-Change-Number: 42719 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by Jenkins Builder 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria, osmith. Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 2: (5 comments) File src/osmo-bsc/bts_nokia_site.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/2a82c0ba_94532e8f?usp… : PS2, Line 1778: It is also possible to configure the BTS without a reset, but in this case please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/b4927bdb_3b9f02ed?usp… : PS2, Line 1779: the BTS does not accept any changes in configuration - therefore, the mode please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6dc20b80_5f1f37fb?usp… : PS2, Line 1780: of skipping BSC-driven BTS reset is only for use during osmo-bsc development, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/7d417717_b60d8b4e?usp… : PS2, Line 1781: when the developer-operator resets the BTS manually before each test run. please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6b42baee_ecedf0fb?usp… : PS2, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, Avoid multiple line dereference - prefer 'run.static' -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 23:52:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria, osmith. Hello fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by fixeria Change subject: nokia: add support for Flexi Multiradio ...................................................................... nokia: add support for Flexi Multiradio Previous support existed for Nokia MetroSite, UltraSite and InSite models, resulting in BTS model name "nokia_site". However, there exist newer Nokia BTS models that also support E1 Abis and can be supported by OsmoBSC with relatively small changes: Flexi EDGE, Flexi Multiradio and Flexi Multiradio 10. Out of these newer models, American 2G Cooperative (the present patch author's current organization) has only Flexi MR at the present time - hence this model shall be the first "new" Nokia BTS to be supported. The first change required in order to support Flexi MR is ability to receive long OML messages that have been segmented by the BTS: the new BTS sends a much longer BTS_CONF_REQ message, and we have to handle it correctly. Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts_nokia_site.c 2 files changed, 138 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/42712/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia vty: change help strings away from "*Site"
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: nokia vty: change help strings away from "*Site" ...................................................................... nokia vty: change help strings away from "*Site" Support for Nokia BTS in OsmoBSC is being expanded from just *Site family to also include Flexi Multiradio - therefore, help strings and error messages in vty should be changed accordingly. FIXME: names of Nokia-specific vty settings still begin with nokia_site, ditto for the name of the BTS model. TODO: decide on a proper long-term solution. Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c --- M src/osmo-bsc/bts_vty.c 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/13/42713/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c Gerrit-Change-Number: 42713 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: nokia: make Rx diversity configurable ...................................................................... nokia: make Rx diversity configurable The config structure sent to the BTS with BTS_CONF_DATA includes an IE that enables or disables Rx diversity. In the original code this setting was hard-coded to enabled state; make it configurable via vty. Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_nokia_site.c M src/osmo-bsc/bts_vty.c 4 files changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/14/42714/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: nokia skip-reset: make consistent with other vty settings
by falconia 29 Apr '26

29 Apr '26

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email ) Change subject: nokia skip-reset: make consistent with other vty settings ...................................................................... nokia skip-reset: make consistent with other vty settings All other Nokia-specific vty settings use is_nokia_bts() helper function, while the code for skip-reset directly compares bts->type against GSM_BTS_TYPE_NOKIA_SITE. Change to use the helper function: it is consistent with other vty settings, and avoids one more place that erroneously refers to *Site instead of all Nokia BTS. Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 --- M src/osmo-bsc/bts_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/42718/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 54a9fab..cbf00d0 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -399,7 +399,7 @@ { struct gsm_bts *bts = vty->index; - if (bts->type != GSM_BTS_TYPE_NOKIA_SITE) { + if (!is_nokia_bts(bts)) { vty_out(vty, "%% BTS is not of Nokia type%s", VTY_NEWLINE); return CMD_WARNING; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 Gerrit-Change-Number: 42718 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria, osmith. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 1: (1 comment) File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/5848552d_93ef3d31?usp… : PS1, Line 512: 256 > cosmetic: add define for `256` too, e.g. […] Will do as asked, new patch coming shortly. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 23:16:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/90b2e41d_985e8025?usp… : PS1, Line 487: bts->type != GSM_BTS_TYPE_NOKIA_SITE > Is this parameter Nokia *Site specific? It is specific to Nokia BTS family, although not just the Site subfamily. > If not, better use `!is_nokia_bts(bts)` here like other VTY commands do. Argh, I copied the code from `skip-reset` setting, which just happens to use direct comparison while all others use `is_nokia_bts()` as you point out. I will respin this patch, and maybe add one to make `skip-reset` setting consistent with the others. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 23:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia vty: change help strings away from "*Site"
by falconia 29 Apr '26

29 Apr '26

Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email ) Change subject: nokia vty: change help strings away from "*Site" ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42713/comment/50d0fba7_87ad79c4?usp… : PS1, Line 395: nokia_site > You can also rename `nokia_site` in VTY commands and add `ALIAS` or `ALIAS_DEPRECATED` for backwards […] If this grand renaming is indeed desired, perhaps it can be done as its own patch, not in the present critical path? > Just an idea, not a merge blocker. If so, would you be OK with marking this comment as resolved? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c Gerrit-Change-Number: 42713 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 23:07:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: personalization: fix EF_SMSP length, alpha_id padding
by fixeria 28 Apr '26

28 Apr '26

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email ) Change subject: personalization: fix EF_SMSP length, alpha_id padding ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Apr 2026 20:32:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log