- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer
by pespin 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email ) Change subject: libosmo-trx/ep: allow ctrl socket to accept/reply to any peer ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43601?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I97075eb350e4270f4e909d493ba692e6b65be750 Gerrit-Change-Number: 43601 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 08:29:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown
by pespin 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email ) Change subject: libosmo-trx/ep: flush pending TRXC messages on endpoint teardown ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43112/comment/78677a88_4cae36c3?usp… : PS6, Line 581: return !llist_empty(&ep->closing_flushes); > P.S. I am really tired of re-working this patch over and over, and I really wish flushing was implemented in libosmocore. Having to implement this outside of libosmocore feels like a kludge. I think I already clearly mentioned what I thought was needed since the first version of the patch, so it's not like I'm asking different things everytime. Having to implement this outside of libosmocore is imho what's needed here, and implementing it inside libosmocore would be a kludge. This protocol has the specific requirement that one wants to make sure all data is sent before closing the socket, and you want all the other data domain to actually be aware of that and be able to track the state of that at the upper level possible, by making it public that closing is as asynchronous action which may take some time. If the user wants to free everything instantanteously, it can still do so at the expense of not being sure the TRX was stopped. Hiding this fact under several layers is only going to create problems in upper layers. If you disagree fine and do as you wish, but I think it's my duty as a reviewer to point it out specially since I already implemented something relatively similar in osmo-pcap. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43112?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I69e6a3bcf49afc3cfca4a72afdf459625cb91e56 Gerrit-Change-Number: 43112 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 08:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in osmo-trx[master]: libosmo-trx/ep: add TRX endpoint module
by pespin 14 Sep '26

14 Sep '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email ) Change subject: libosmo-trx/ep: add TRX endpoint module ...................................................................... Patch Set 8: Code-Review+1 (1 comment) File libosmo-trx/src/trx_ep.c: https://gerrit.osmocom.org/c/osmo-trx/+/43111/comment/f700db8e_a3072deb?usp… : PS8, Line 675: * For TRXDv2, the PDUs are batched: they get accumulated until this I wonder what's the point in having the breaker case (bi=NULL) included into this same function, instead of having a separate API osmo_trx_ep_send_burst_ind_fin() or similar, which would make code more clearer and avoid extra branching and complexity in this function. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43111?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I767fa43a9ca88be40c385f6dcb9de22891a6afc3 Gerrit-Change-Number: 43111 Gerrit-PatchSet: 8 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 08:18:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-trx[master]: proxy: add TDMA clock generator and basic TRXC handler
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43604?usp=email ) Change subject: proxy: add TDMA clock generator and basic TRXC handler ...................................................................... Patch Set 2: (1 comment) File proxy/include/osmocom/proxy/trx.h: https://gerrit.osmocom.org/c/osmo-trx/+/43604/comment/6104aaec_91c6f2a0?usp… : PS1, Line 43: /*! Change the number of channels; must be called before proxy_trx_open(). */ > You probably want to have these comments in the .c file. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43604?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8c0757f15961bf0574f1305a6a8836853b66afcf Gerrit-Change-Number: 43604 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 08:17:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-trx[master]: osmo-trx-proxy: initial app skeleton
by fixeria 14 Sep '26

14 Sep '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email ) Change subject: osmo-trx-proxy: initial app skeleton ...................................................................... Patch Set 2: (1 comment) File proxy/include/osmocom/proxy/proxy.h: https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/a925f800_4e5a3d53?usp… : PS1, Line 23: struct proxy_ctx *proxy_ctx_alloc(void *talloc_ctx); > No. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id2b12e5e7d053eea53338fbabc48131b9c46c82a Gerrit-Change-Number: 43603 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Sep 2026 07:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: utils/osmo-install-dbg-pkgs: add --open5gs arg
by osmith 14 Sep '26

14 Sep '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/43623?usp=email ) Change subject: utils/osmo-install-dbg-pkgs: add --open5gs arg ...................................................................... utils/osmo-install-dbg-pkgs: add --open5gs arg Extend the script to install open5gs debug packages too when selecting this argument. Change-Id: I8d37e6a00ebf8e48b8240dcee437087988ba7c41 --- M utils/osmo-install-dbg-pkgs.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/utils/osmo-install-dbg-pkgs.py b/utils/osmo-install-dbg-pkgs.py index 9de5af4..e707cfe 100755 --- a/utils/osmo-install-dbg-pkgs.py +++ b/utils/osmo-install-dbg-pkgs.py @@ -20,6 +20,12 @@ description="Install debug packages for all installed Osmocom packages and dependencies" ) parser.add_argument( + "-o", + "--open5gs", + action="store_true", + help="install debug packages for installed Open5GS programs too", + ) + parser.add_argument( "-y", "--yes", action="store_true", @@ -67,6 +73,9 @@ "osmo-*", ] + if args.open5gs: + patterns += ["open5gs-*"] + for line in lines: if not line.startswith("ii "): continue -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8d37e6a00ebf8e48b8240dcee437087988ba7c41 Gerrit-Change-Number: 43623 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: SMS: fix bogus error for SMS over SG from MME
by osmith 14 Sep '26

14 Sep '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email ) Change subject: SMS: fix bogus error for SMS over SG from MME ...................................................................... SMS: fix bogus error for SMS over SG from MME OsmoMSC accepts SMS over the SG interface from the MME and can successfully send them. Fix that the following error gets logged along with every SMS from SG: MO SMS without prior CM Service Request (gsm_04_11.c:1127) Fixes: OS#6207 Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 --- M src/libmsc/gsm_04_11.c 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_11.c b/src/libmsc/gsm_04_11.c index 530ef17..fb04b45 100644 --- a/src/libmsc/gsm_04_11.c +++ b/src/libmsc/gsm_04_11.c @@ -1123,10 +1123,15 @@ osmo_fsm_inst_dispatch(msc_a->c.fi, MSC_A_EV_TRANSACTION_ACCEPTED, trans); if (mo) { - if (!osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SMS)) - LOG_TRANS(trans, LOGL_ERROR, "MO SMS without prior CM Service Request\n"); - else + if (!osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SMS)) { + if (vsub->attached_via_ran == OSMO_RAT_EUTRAN_SGS) { + /* SMS over the SG interface from MME (OS#6207) */ + } else { + LOG_TRANS(trans, LOGL_ERROR, "MO SMS without prior CM Service Request\n"); + } + } else { msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SMS); + } } /* If we're re-using the existing LU connection, drop the LU token. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id3f9c6c20e6d4d4275ca16fb17b0822a7d70e0a0 Gerrit-Change-Number: 43625 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-trx[master]: osmo-trx-proxy: initial app skeleton
by fixeria 13 Sep '26

13 Sep '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email ) Change subject: osmo-trx-proxy: initial app skeleton ...................................................................... Patch Set 2: (2 comments) File proxy/include/osmocom/proxy/proxy.h: https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/a9d8a2df_3b1a8017?usp… : PS1, Line 23: struct proxy_ctx *proxy_ctx_alloc(void *talloc_ctx); > no _free()? No. We do allocate only one instance of this struct and never free() it while the program is running. I could add the _free() counterpart for the sake of completeness, but at the moment it's not really needed. File proxy/src/proxy.c: https://gerrit.osmocom.org/c/osmo-trx/+/43603/comment/32f42b79_68fe329d?usp… : PS1, Line 56: bool proxy_ctx_add_defaults_if_empty(struct proxy_ctx *proxy) > weird returning a bool here instead of return code. Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43603?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Id2b12e5e7d053eea53338fbabc48131b9c46c82a Gerrit-Change-Number: 43603 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Sep 2026 19:28:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: expect TC_data_rtp_tchh{48,24} to fail
by pespin 13 Sep '26

13 Sep '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43626?usp=email ) Change subject: bts: expect TC_data_rtp_tchh{48,24} to fail ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib8116689817798187f4f6b96bd5cb8b6dff7a6b1 Gerrit-Change-Number: 43626 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 13 Sep 2026 19:19:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proxy: queue BURST.req and dispatch per TDMA frame tick
by fixeria 13 Sep '26

13 Sep '26

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email ) Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File proxy/src/burst_fwd.c: https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/75a77745_1be6113a?usp… : PS1, Line 138: > basically it's a trade-off whether we want more computationally expensive enqueue or dequeue. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ib147983e97638d2a2e487ccf76184912caf0941d Gerrit-Change-Number: 43612 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 13 Sep 2026 19:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log