- gerrit-log - lists.osmocom.org

[M] Change in osmo-ccid-firmware[master]: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email ) Change subject: libosmo_emb: type-safe tearfree_u64_t wrapper for LDRD/STRD access ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42784?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I458bfaf53e27c51882c7a8c1326e51d12943b0bb Gerrit-Change-Number: 42784 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:54:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: ICC_MUTE instead of CMD_NOT_SUPPORTED on XfrBlock to unpowered ...
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42783?usp=email ) Change subject: ccid: ICC_MUTE instead of CMD_NOT_SUPPORTED on XfrBlock to unpowered slot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I7f64475b023bd2b6fd1c4263850e56dd84d20b3e Gerrit-Change-Number: 42783 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: fail PPS on invalid first byte in PPS_S_WAIT_PPSX
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42780?usp=email ) Change subject: 7816fsm: fail PPS on invalid first byte in PPS_S_WAIT_PPSX ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I5b74b8443a98224c0c95a664a886066495d8b64a Gerrit-Change-Number: 42780 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:53:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: 7816fsm: reset stale cuart state on FSM RESET entry
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email ) Change subject: 7816fsm: reset stale cuart state on FSM RESET entry ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42779?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iac8bd7f4f0eecccc9acce149277a4f5016fec7c1 Gerrit-Change-Number: 42779 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:53:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: reject invalid bClockCommand
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42778?usp=email ) Change subject: ccid: reject invalid bClockCommand ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42778?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I34dedcaaaf3cd67e22b207016f08e745736dd625 Gerrit-Change-Number: 42778 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:53:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: cuart: Fix waiting time to be per-byte instead of total timeout
by laforge 08 Jun '26

08 Jun '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42777?usp=email ) Change subject: cuart: Fix waiting time to be per-byte instead of total timeout ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42777?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ic00040b88e1b204db3f4f3edad09878aa28d35a1 Gerrit-Change-Number: 42777 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 08 Jun 2026 11:53:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 1 APDU test
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42789?usp=email ) Change subject: CCID: Successful case 1 APDU test ...................................................................... CCID: Successful case 1 APDU test A MANAGE CHANNEL APDU has no data and must respond without any data, just the status words. Change-Id: I7d5ee9bbd8bb2505a762e3fd80238db658940c16 --- M ccid/CCID_Tests.ttcn 1 file changed, 27 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 6a8efc9..346cacd 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -39,6 +39,7 @@ const octetstring c_UICC_SELECT_MF := '00a40004023f00'O; const octetstring c_SIM_SELECT_MF := 'a0a40004023f00'O; +const octetstring c_UICC_MANAGE_CHANNEL := '0070800100'O; const octetstring c_UICC_GET_RESPONSE_BASE := 'a0c00000'O; /* Table 7 of ISO7816-3 */ @@ -382,6 +383,31 @@ f_start_and_wait(); } +/* manage channel (Case 1) */ +private function f_TC_successful_case_1() runs on Slot_CT +{ + var octetstring res; + + f_ccid_power_on(); + res := f_ccid_xfr(c_UICC_MANAGE_CHANNEL, '??'O); + if (res != '6200'O) { + setverdict(fail, "Unexpected SW1/SW2"); + mtc.stop; + } +} +testcase TC_successful_case_1() runs on Test_CT +{ + var integer i; + + f_init(); + + for (i := 0; i < mp_use_slot_count; i := i+1) { + f_start_handler(refers(f_TC_successful_case_1), i); + } + + f_start_and_wait(); +} + /* GET RESPONSE (Case 4) */ private function f_TC_successful_case_4() runs on Slot_CT { @@ -538,6 +564,7 @@ } execute( TC_set_params_nochange() ); execute( TC_successful_case_4() ); + execute( TC_successful_case_1() ); /* error handling */ execute( TC_inval_slot() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7d5ee9bbd8bb2505a762e3fd80238db658940c16 Gerrit-Change-Number: 42789 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Successful case 2 and 3 APDU tests
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42790?usp=email ) Change subject: CCID: Successful case 2 and 3 APDU tests ...................................................................... CCID: Successful case 2 and 3 APDU tests A SELECT APDU has data and must respond without any data, just the status words. A READ BINARY APDU has no data, but it must respond with data, followed by the status words. Change-Id: I9110250020c11bc7382b6308a182c09bb79e5e5e --- M ccid/CCID_Tests.ttcn 1 file changed, 33 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 346cacd..f5dae50 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -40,6 +40,8 @@ const octetstring c_UICC_SELECT_MF := '00a40004023f00'O; const octetstring c_SIM_SELECT_MF := 'a0a40004023f00'O; const octetstring c_UICC_MANAGE_CHANNEL := '0070800100'O; +const octetstring c_SIM_SELECT_EF_ICCID := '00A4000C022FE2'O; +const octetstring c_SIM_READ_BINARY := '00B000000A'O; const octetstring c_UICC_GET_RESPONSE_BASE := 'a0c00000'O; /* Table 7 of ISO7816-3 */ @@ -408,6 +410,36 @@ f_start_and_wait(); } +/* read binary (Case 3 + 2) */ +private function f_TC_successful_case_2_3() runs on Slot_CT +{ + var octetstring res; + + f_ccid_power_on(); + res := f_ccid_xfr(c_SIM_SELECT_EF_ICCID, '??'O); + if (res != '9000'O) { + setverdict(fail, "Unexpected SW1/SW2"); + mtc.stop; + } + res := f_ccid_xfr(c_SIM_READ_BINARY, ?); + if (substr(res, 10,2) != '9000'O) { + setverdict(fail, "Unexpected SW1/SW2"); + mtc.stop; + } +} +testcase TC_successful_case_2_3() runs on Test_CT +{ + var integer i; + + f_init(); + + for (i := 0; i < mp_use_slot_count; i := i+1) { + f_start_handler(refers(f_TC_successful_case_2_3), i); + } + + f_start_and_wait(); +} + /* GET RESPONSE (Case 4) */ private function f_TC_successful_case_4() runs on Slot_CT { @@ -565,6 +597,7 @@ execute( TC_set_params_nochange() ); execute( TC_successful_case_4() ); execute( TC_successful_case_1() ); + execute( TC_successful_case_2_3() ); /* error handling */ execute( TC_inval_slot() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9110250020c11bc7382b6308a182c09bb79e5e5e Gerrit-Change-Number: 42790 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: CCID: Fix “unsupported Secure” test case
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42787?usp=email ) Change subject: CCID: Fix “unsupported Secure” test case ...................................................................... CCID: Fix “unsupported Secure” test case Expect SlotStatus or DataBlock. The specification states that DataBlock response is used to indicate, if Secure command is not suppported. Existing implementation, such as Omnikey Cardman 3121 or osmo-ccid-firmware respond with SlotStatus instead. Change-Id: I21517c3e28e0d0e42e8a177b7c668bff15c35aa0 --- M ccid/CCID_Tests.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index 566cb3e..3ff9c36 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -461,6 +461,9 @@ [] CCID.receive(tr_CCID_DataBlock(hdr_in := tr_CCID_HeaderIN_FAIL(CCID_ERR_CMD_NOT_SUPPORTED))) { setverdict(pass); } + [] CCID.receive(tr_CCID_SlotStatus(hdr_in := tr_CCID_HeaderIN_FAIL(CCID_ERR_CMD_NOT_SUPPORTED))) { + setverdict(pass); + } [] as_ccid_any(); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I21517c3e28e0d0e42e8a177b7c668bff15c35aa0 Gerrit-Change-Number: 42787 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: CCID: Check if parameters keep unchanged, if set without change.
by laforge 08 Jun '26

08 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42786?usp=email ) Change subject: CCID: Check if parameters keep unchanged, if set without change. ...................................................................... CCID: Check if parameters keep unchanged, if set without change. Using SetParameters with the current set of parameter must not cause them to change. Change-Id: Id1bf5e58ba910d0633104b3bc3e902ce7d31cb10 --- M ccid/CCID_Tests.ttcn 1 file changed, 32 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/ccid/CCID_Tests.ttcn b/ccid/CCID_Tests.ttcn index d158f64..566cb3e 100644 --- a/ccid/CCID_Tests.ttcn +++ b/ccid/CCID_Tests.ttcn @@ -350,6 +350,37 @@ f_start_and_wait(); } +/* SetParameters: verify acceptance of unchanged setting */ +private function f_TC_set_params_nochange() runs on Slot_CT +{ + var CCID_PDU set_par, get_par; + f_ccid_power_on(); + + /* get current parameters */ + set_par := f_ccid_get_par(); + + /* send unmodified */ + get_par := f_ccid_set_par(set_par.u.Parameters.abProtocolData); + + /* check if they still match */ + if (match(set_par.u.Parameters.abProtocolData, get_par.u.Parameters.abProtocolData)) { + setverdict(pass); + } else { + setverdict(fail, "SetParameters changed parameters unexpected"); + } +} +testcase TC_set_params_nochange() runs on Test_CT +{ + var integer i; + + f_init(); + + for (i := 0; i < mp_use_slot_count; i := i+1) { + f_start_handler(refers(f_TC_set_params_nochange), i); + } + f_start_and_wait(); +} + /* TODO */ @@ -469,6 +500,7 @@ execute( TC_set_params() ); execute( TC_reset_params() ); } + execute( TC_set_params_nochange() ); /* error handling */ execute( TC_inval_slot() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1bf5e58ba910d0633104b3bc3e902ce7d31cb10 Gerrit-Change-Number: 42786 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log