Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email )
Change subject: IPAd: Check for memory leaks after each test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43622?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifd5390ac230b48614585d2820b9133daebd8c321
Gerrit-Change-Number: 43622
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:57:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email )
Change subject: IPAd: Add test case for multple eIM packages
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1:
To me this looks good, just two suggestions regarding the rounds parameter.
File ipad/IPAd_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/4903035c_33dd… :
PS1, Line 1170: var integer i, rounds := 5;
maybe have the rounds parameter as a module parameter? (mp_tc_multi_package_rounds)?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620/comment/410bb9bc_8f0e… :
PS1, Line 1209: f_init(id, 300.0);
maybe write t_guard := 300.0, than its more obvious what the number means. You could also interoperate the rounds parameter. t_guard := rounds * 6.0 ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43620?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I74bba77cc391ed243729e99a5aeaefb9dbde2922
Gerrit-Change-Number: 43620
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:42:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email )
Change subject: IPAd: Split f_terminate_poll_cycle()
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
To me this looks good. When I understand everything correctly, then the functionality should not be changed by this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43619?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4e278f74ce3bb9bbd666f13c2a72ed90eba34af7
Gerrit-Change-Number: 43619
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Mon, 14 Sep 2026 14:24:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/43637?usp=email
to look at the new patch set (#3).
Change subject: pySim-shell: use verify_adm command for commandline ADM auth
......................................................................
pySim-shell: use verify_adm command for commandline ADM auth
since the very early days, pySim-shell.py has a commandline option
where the user may supply an ADM pin as commandline parameter.
(-a / --pin-adm and -A --pin-adm-hex) This was introduced to simplify
the usage of pySim-shell.py with shellscripts.
Unfortunately the code that handles those commandline options
duplicates the code of the verify_adm commmand. Fortunately it is
very easy to call pySim-shell commands directly using the CMD2
onecmd_plus_hooks method, so we can just call the verify_adm and
replace the duplicated code with that.
So far we are only able to use ADM1 pins from the commandline, since
we now practically use the verify_adm commnad, we can add another
parameter to allow the verification of ADM as well.
Related: SYS#8239
Change-Id: I7164fad757048774aa7186a84041febde75c351c
---
M pySim-shell.py
1 file changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/43637/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43637?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7164fad757048774aa7186a84041febde75c351c
Gerrit-Change-Number: 43637
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/43634?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: doc/examples: add a config file for osmo-trx-proxy
......................................................................
doc/examples: add a config file for osmo-trx-proxy
Change-Id: I401753bd1977057c3de481e7bf074d1f92f84499
Related: OS#6672
---
M doc/examples/Makefile.am
A doc/examples/osmo-trx-proxy/osmo-trx-proxy.cfg
2 files changed, 39 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/34/43634/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43634?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I401753bd1977057c3de481e7bf074d1f92f84499
Gerrit-Change-Number: 43634
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/43635?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: debian: add packaging for osmo-trx-proxy
......................................................................
debian: add packaging for osmo-trx-proxy
Ship the osmo-trx-proxy binary and its default/example VTY config
(doc/examples/osmo-trx-proxy/osmo-trx-proxy.cfg), following the same
layout as the osmo-trx-ipc package.
Change-Id: I995b44bf9a884cf5ba6db8333e6f08c9604a58a5
Related: OS#6672
---
M debian/control
A debian/osmo-trx-proxy.install
2 files changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/35/43635/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/43635?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I995b44bf9a884cf5ba6db8333e6f08c9604a58a5
Gerrit-Change-Number: 43635
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>