- gerrit-log - lists.osmocom.org

[S] Change in onomondo-eim[master]: config/sys.config: fix certificate paths
by fixeria 16 Jun '26

16 Jun '26

Attention is currently required from: dexter, jolly. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email ) Change subject: config/sys.config: fix certificate paths ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Usually all misc files go to the `priv` directory - this is a standard place for auxiliary files in OTP applications. Its path can be obtained at run-time via `code:priv_dir/1`: ``` -spec get_priv(Name) -> Path when Name :: file:filename_all(), Path :: file:filename_all(). get_priv(Name) -> PrivDir = code:priv_dir(?ENV_APP_NAME), filename:join(PrivDir, Name). %% example Path = get_priv("sample_ssl_cert.crt"). ``` The proposed patch looks wrong to me. The configuration should definitely not contain relative paths. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e Gerrit-Change-Number: 42830 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jun 2026 07:14:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by neels 15 Jun '26

15 Jun '26

Attention is currently required from: fixeria, laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42829/comment/600bae53_b8a5f9b9?usp=em… : PS4, Line 1737: So, when SUCI-CalcInfo for USIM in DF.SAIP contains both key types, : # then no profile-A or B services need to be requested explicitly. > I'm not sure you can go about it that way. […] I've looked it up specifically to solve the problem of requiring BOTH even though only one of them is strictly necessary like discussed in SYS#8096. quoting SAIP spec (and SYS#8096) SAIP 2.3.1, 8.2 Profile Header: [...] • get-identity: support of the GET IDENTITY as defined in ETSI [102 221] and the associated interface for SUCI derivation defined in 3GPP [31.130]. __*At least one implementation of the ECIES profile A or profile B*__ as described in 3GPP [33.501] shall be supported by the eUICC when this function is supported. The Null-scheme shall be supported in addition of the ECIES scheme. This service shall be set in the Profile if services n°124 and n°125 are "available" in EF UST • profile-a-x25519: implementation of the ECIES Profile A as described in 3GPP [33.501] • profile-b-p256: implementation of the ECIES Profile B as described in 3GPP [33.501] The point here is that get-identity implies: "one of A or B in addition to Null-key support" Please confirm and mark resolved, thx -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2026 14:45:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in onomondo-eim[master]: certificates: add checks to make sure cert and key files are readable
by dexter 15 Jun '26

15 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42833?usp=email ) Change subject: certificates: add checks to make sure cert and key files are readable ...................................................................... certificates: add checks to make sure cert and key files are readable In cas a certificate or key file is not reachable, the failure symptoms may not be immediately obvious. Let's add checks to make sure all certificate and key files are readable. Change-Id: Icaea4aae6188bcdecbc44558aefd2609706be56f Related: SYS#7093 --- M src/crypto_utils.erl M src/onomondo_eim_app.erl 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/33/42833/1 diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl index 9d0cd0f..1bba9ab 100644 --- a/src/crypto_utils.erl +++ b/src/crypto_utils.erl @@ -211,7 +211,12 @@ error; get_root_cert(EumCertificate, RootCiCertPaths) -> [RootCiCertPath | RootCiCertPathsTail] = RootCiCertPaths, - {ok, RootCiCertPem} = file:read_file(RootCiCertPath), + RootCiCertPem = case file:read_file(RootCiCertPath) of + {ok, FileContent} -> + FileContent; + _ -> + throw({"CI certificate file not readable", RootCiCertPath}) + end, [{'Certificate', RootCiCertBer, not_encrypted}] = public_key:pem_decode(RootCiCertPem), {ok, EumCertificateBer} = 'PKIX1Explicit88':encode('Certificate', EumCertificate), case public_key:pkix_is_issuer(EumCertificateBer, RootCiCertBer) of diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index ffdc68b..960d9f1 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -30,6 +30,21 @@ "Starting ESipa HTTPs server at ~p:~p...~ncertificate: ~p~nkey: ~p~n", [Ip, Port, Cert, Key] ), + + case filelib:is_file(Cert) of + true -> + ok; + _ -> + throw({"SSL certificate file not readable", Cert}) + end, + + case filelib:is_file(Key) of + true -> + ok; + _ -> + throw({"SSL private key file not readable", Key}) + end, + cowboy:start_tls( https_listener_esipa, [ -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42833?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Icaea4aae6188bcdecbc44558aefd2609706be56f Gerrit-Change-Number: 42833 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: onomondo_eim_app/cosmetic: add a space between version and the versio...
by dexter 15 Jun '26

15 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email ) Change subject: onomondo_eim_app/cosmetic: add a space between version and the version number ...................................................................... onomondo_eim_app/cosmetic: add a space between version and the version number Change-Id: Ib6b215b0ae5157150b541b34803135cbf0733695 Related: SYS#7093 --- M src/onomondo_eim_app.erl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/31/42831/1 diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index 498e36a..5394ef5 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -94,7 +94,7 @@ start(_Type, _Args) -> {ok, Vsn} = application:get_key(onomondo_eim, vsn), - logger:notice("eIM! version:~s~n", [Vsn]), + logger:notice("eIM! version: ~s~n", [Vsn]), % Startup database ok = mnesia_db:init(), -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ib6b215b0ae5157150b541b34803135cbf0733695 Gerrit-Change-Number: 42831 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: onomondo_eim_app: display current working directory
by dexter 15 Jun '26

15 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email ) Change subject: onomondo_eim_app: display current working directory ...................................................................... onomondo_eim_app: display current working directory It may be useful to know the current working directory, in particular when debugging problems with the certificate paths Change-Id: I89d46bac2ff7022b5c5929252e0090a6d77af733 Related: SYS#7093 --- M src/onomondo_eim_app.erl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/32/42832/1 diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index 5394ef5..ffdc68b 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -96,6 +96,9 @@ {ok, Vsn} = application:get_key(onomondo_eim, vsn), logger:notice("eIM! version: ~s~n", [Vsn]), + {ok, Cwd} = file:get_cwd(), + logger:notice("working directory: ~s~n", [Cwd]), + % Startup database ok = mnesia_db:init(), -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42832?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I89d46bac2ff7022b5c5929252e0090a6d77af733 Gerrit-Change-Number: 42832 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: config/sys.config: fix certificate paths
by dexter 15 Jun '26

15 Jun '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email ) Change subject: config/sys.config: fix certificate paths ...................................................................... config/sys.config: fix certificate paths The path of the certificates in the example sys.config do not match when the eIM is ran locally from the root directory of the git. let's align the paths so that they match when the eIM is started like this: ./_build/default/rel/onomondo_eim_release/bin/onomondo_eim_release console Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e Related: SYS#7093 --- M config/sys.config 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/30/42830/1 diff --git a/config/sys.config b/config/sys.config index 990a442..c3f83d1 100644 --- a/config/sys.config +++ b/config/sys.config @@ -3,24 +3,24 @@ {esipa_ip, {127, 0, 0, 1}}, {esipa_port, 8000}, {esipa_ssl_disable, false}, - {esipa_ssl_cert, "config/sample_ssl_cert.crt"}, - {esipa_ssl_key, "config/sample_ssl_cert.key"}, + {esipa_ssl_cert, "../../../../config/sample_ssl_cert.crt"}, + {esipa_ssl_key, "../../../../config/sample_ssl_cert.key"}, {rest_ip, {127, 0, 0, 1}}, {rest_port, 8080}, {eim_id, "eIM"}, {es9p_ssl_disable, false}, - {eim_cert, "config/sample_eim_cert_nist.crt"}, - {eim_key, "config/sample_eim_cert_nist.key"}, + {eim_cert, "../../../../config/sample_eim_cert_nist.crt"}, + {eim_key, "../../../../config/sample_eim_cert_nist.key"}, {counter_value, 1}, {consumer_euicc, true}, {rest_timeout_stuck, 300}, {rest_timeout_noshow, 1800}, {rest_timeout_expired, 86400}, {root_ci_certs, [ - "config/sgp26_gsma_root_ci_cert_nist_symantec.crt", - "config/sgp26_gsma_root_ci_cert_nist_oiste.crt", - "config/sgp26_test_root_ci_cert_nist.crt", - "config/sgp26_test_root_ci_cert_brainpool.crt" + "../../../../config/sgp26_gsma_root_ci_cert_nist_symantec.crt", + "../../../../config/sgp26_gsma_root_ci_cert_nist_oiste.crt", + "../../../../config/sgp26_test_root_ci_cert_nist.crt", + "../../../../config/sgp26_test_root_ci_cert_brainpool.crt" ]} ]} ]. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie09d746a6e28ac6fee3e00dfa32cb01f8a7b947e Gerrit-Change-Number: 42830 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by laforge 14 Jun '26

14 Jun '26

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... Patch Set 4: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42829/comment/79f18a9d_d6723364?usp=em… : PS4, Line 1737: So, when SUCI-CalcInfo for USIM in DF.SAIP contains both key types, : # then no profile-A or B services need to be requested explicitly. I'm not sure you can go about it that way. AFAIR, the network will tell (broadcast?) which of the keys (by key ID) is currently to be used by the UE[s], and it doesn't know anything about the eUICC capabilities. So I think if the EF.SUCI_Calc_Info contains A and B, then we need to make both A+B mandatory. Please ignore my comment if your conclusion of 5G spec review has resulted in a different outcome. Not sure if I remember it right. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Jun 2026 20:12:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by neels 12 Jun '26

12 Jun '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email to look at the new patch set (#4). Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 Related: SYS#8096 SYS#8037 Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Jenkins: skip-card-test --- M pySim/esim/saip/__init__.py 1 file changed, 50 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/42829/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by neels 12 Jun '26

12 Jun '26

neels has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 Related: SYS#8096 SYS#8037 Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 --- M pySim/esim/saip/__init__.py 1 file changed, 50 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/42829/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

[M] Change in pysim[master]: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a...
by neels 12 Jun '26

12 Jun '26

neels has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/pysim/+/42829?usp=email ) Change subject: saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 ...................................................................... saip.PES.rebuild_mandatory_services(): set 5G get-identity, profile-a-x25519, profile-b-p256 Related: SYS#8096 SYS#8037 Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 --- M pySim/esim/saip/__init__.py 1 file changed, 51 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/42829/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ibc29c6437c5c92e2b14938b733156536863465c1 Gerrit-Change-Number: 42829 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder

1 0

2026

2025

2024

2023

2022

gerrit-log