- gerrit-log - lists.osmocom.org

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email ) Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Patch Set 6: (1 comment) File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/c/osmo-iuh/+/40847/comment/79f75642_bcd7b638?usp… : PS1, Line 8: direct > directly "instead" -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 12:59:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 day, 20 hours

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enb_uptime: track eNB uptime

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email ) Change subject: enb_uptime: track eNB uptime ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie8a06fafa2ce3e7a5aec1eb8e71af3053599cf24 Gerrit-Change-Number: 40831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 11:07:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 day, 22 hours

1
0
0 0

[S] Change in osmo-iuh[master]: iu_client: fix linter issues

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email ) Change subject: iu_client: fix linter issues ...................................................................... Patch Set 3: (1 comment) File src/iu_client.c: https://gerrit.osmocom.org/c/osmo-iuh/+/40848/comment/f8d17fab_c021eae6?usp… : PS3, Line 659: } else > I'd argue that the else should use braces here as well. I agree! But I don't care enough about this code base. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ia8b3405701ed62eac39b9510d34da4ba1987146c Gerrit-Change-Number: 40848 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 10:57:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

1 day, 22 hours

1
0
0 0

[XS] Change in osmo-msc[master]: transaction: Fix potenial use after free of members

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email ) Change subject: transaction: Fix potenial use after free of members ...................................................................... transaction: Fix potenial use after free of members Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf --- M src/libmsc/transaction.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/53/40853/1 diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index 19ffcb9..92af621 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -239,6 +239,8 @@ { const char *usage_token; struct msc_a *msc_a; + struct paging_request *pr; + struct vlr_subscr *vsub; LOG_TRANS(trans, LOGL_DEBUG, "Freeing transaction\n"); @@ -273,13 +275,15 @@ } if (trans->paging_request) { - paging_request_remove(trans->paging_request); + pr = trans->paging_request; trans->paging_request = NULL; + paging_request_remove(pr); } if (trans->vsub) { - vlr_subscr_put(trans->vsub, trans_vsub_use(trans->type)); + vsub = trans->vsub; trans->vsub = NULL; + vlr_subscr_put(vsub, trans_vsub_use(trans->type)); } msc_a = trans->msc_a; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40853?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I177959fb298ae04c4e8df877582fc9a1bd4dc2cf Gerrit-Change-Number: 40853 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com>

1 day, 23 hours

1
0
0 0

[XS] Change in osmo-msc[master]: silent_call: Fix use after free of paging request

by matanp

matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email ) Change subject: silent_call: Fix use after free of paging request ...................................................................... silent_call: Fix use after free of paging request Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 --- M src/libmsc/silent_call.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/52/40852/1 diff --git a/src/libmsc/silent_call.c b/src/libmsc/silent_call.c index a59e3af..c450fdc 100644 --- a/src/libmsc/silent_call.c +++ b/src/libmsc/silent_call.c @@ -152,8 +152,9 @@ } trans->silent_call.from_vty = vty; - if (!paging_request_start(vsub, PAGING_CAUSE_CALL_BACKGROUND, paging_cb_silent, trans, - "establish silent call")) { + trans->paging_request = paging_request_start(vsub, PAGING_CAUSE_CALL_BACKGROUND, paging_cb_silent, trans, + "establish silent call"); + if (!trans->paging_request) { trans_free(trans); return -ENODEV; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40852?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I93913d189800d71f82c013b6e946bd63db362f65 Gerrit-Change-Number: 40852 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com>

1 day, 23 hours

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enb_uptime: track eNB uptime

by jolly

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email ) Change subject: enb_uptime: track eNB uptime ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie8a06fafa2ce3e7a5aec1eb8e71af3053599cf24 Gerrit-Change-Number: 40831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 09:20:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enb_uptime: track eNB uptime

by jolly

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email ) Change subject: enb_uptime: track eNB uptime ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie8a06fafa2ce3e7a5aec1eb8e71af3053599cf24 Gerrit-Change-Number: 40831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 09:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days

1
0
0 0

[M] Change in ...osmo-s1gw[master]: enb_uptime: track eNB uptime

by jolly

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email ) Change subject: enb_uptime: track eNB uptime ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40831?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie8a06fafa2ce3e7a5aec1eb8e71af3053599cf24 Gerrit-Change-Number: 40831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 07 Aug 2025 09:19:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days

1
0
0 0

[S] Change in osmo-iuh[master]: move vty functions into own vty.h

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email ) Change subject: move vty functions into own vty.h ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40846?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I8d393d17aa5f004dc4aa4e916bee68f44339e138 Gerrit-Change-Number: 40846 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 07 Aug 2025 06:46:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 days, 2 hours

1
0
0 0

[XL] Change in osmo-iuh[master]: Drop iu_client - adopted by osmo-sgsn

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email ) Change subject: Drop iu_client - adopted by osmo-sgsn ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File include/osmocom/ranap/iu_client.h: https://gerrit.osmocom.org/c/osmo-iuh/+/40847/comment/60f5a21b_17f64279?usp… : PS1, Line 8: direct directly -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I95a5aeccc314ffdeaa04cc93f4e5947f715dd5de Gerrit-Change-Number: 40847 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 07 Aug 2025 06:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

2 days, 2 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log