Attention is currently required from: keith, pespin.
fixeria has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email )
Change subject: sqlite optimisation: Avoid unneeded database operation
......................................................................
Patch Set 5:
(2 comments)
File src/libmsc/db.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/80b7de71_ed68cf76?usp… :
PS4, Line 302: id = $id LIMIT 1
> I consider it standard practice to add a LIMIT 1 to a query that is only intended to ever delete max […]
Not sure if this really a standard practice, given that not all database bacnends support the `LIMIT` statement in `DELETE FROM` queries. I am not strictly against this as it does not hurt, but it looks redundant to me. The uniqueness of `id` (primary key) must be guaranteed by the database engine, so either you have exactly one record matching your query or none.
https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/d55a8767_86c83c79?usp… :
PS4, Line 303: DB_STMT_SMS_DEL_EXPIRED
I believe this was already brought up here by other reviewers: we now have two identical queries in the array. One of them should be removed to avoid duplication (can be done in a separate patch).
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: keith <keith(a)rhizomatica.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 07:44:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email )
Change subject: testenv: add --install-package
......................................................................
testenv: add --install-package
Add an option to quickly install packages in the container. This is
useful when making a new SUT run with osmo-ttcn3-hacks and figuring out
which packages need to be installed to make the build pass (without
rebuilding the whole container for each missing dependency). It can also
be used to quickly install additional debugging tools (strace, valgrind,
etc.). A cache for the deb files is already getting mounted inside the
container.
Change-Id: Ie54817e6c0334a224a612521beb378537c10d39d
---
M _testenv/testenv/__init__.py
M _testenv/testenv/podman.py
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py
index 44259c2..8a3b728 100644
--- a/_testenv/testenv/__init__.py
+++ b/_testenv/testenv/__init__.py
@@ -210,6 +210,14 @@
action="store_true",
help="run an interactive shell before stopping daemons/container",
)
+ group.add_argument(
+ "-I",
+ "--install-package",
+ dest="install_packages",
+ action="append",
+ metavar="PACKAGE",
+ help="temporarily install a debian package in the container",
+ )
group = sub_run.add_argument_group("output options")
group.add_argument(
@@ -272,6 +280,9 @@
if args.kernel == "debian" and not args.podman:
raise NoTraceException("--kernel-debian requires --podman")
+ if args.install_packages and not args.podman:
+ raise NoTraceException("--install-packages requires --podman")
+
if args.kernel == "custom" and not os.path.exists(custom_kernel_path):
logging.critical(
"See _testenv/README.md for more information on downloading a pre-built kernel or building your own kernel."
diff --git a/_testenv/testenv/podman.py b/_testenv/testenv/podman.py
index 678a0c1..2013699 100644
--- a/_testenv/testenv/podman.py
+++ b/_testenv/testenv/podman.py
@@ -285,6 +285,9 @@
if not os.path.exists(pkgcache):
exec_cmd(["apt-get", "-q", "update"])
+ if testenv.args.install_packages:
+ exec_cmd(["apt-get", "install", "-y", "--no-install-recommends"] + testenv.args.install_packages)
+
def check_titan_version():
version, _ = testenv.testenv_cfg.get_titan_version_first_cfg()
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie54817e6c0334a224a612521beb378537c10d39d
Gerrit-Change-Number: 41215
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/41212?usp=email )
Change subject: gen_makefile: erlang: fix missing clone and deps
......................................................................
gen_makefile: erlang: fix missing clone and deps
Add a dummy configure target for erlang that ensures the git clone and
building of dependencies is done before attempting to build erlang
projects. A dummy target is used to make the logic consistent with
autotools and meson.
This is in preparation for building python libraries for pyhss, which
will work similarly.
Change-Id: I627e78f9317d99755cfad5d5c8526c3b7f1b3a27
---
M gen_makefile.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/gen_makefile.py b/gen_makefile.py
index 3885e10..e5f07ab 100755
--- a/gen_makefile.py
+++ b/gen_makefile.py
@@ -382,7 +382,10 @@
touch $@
'''
elif buildsystem == "erlang":
- return ""
+ return f'''
+.make.{proj}.configure: .make.{proj}.clone {deps_installed}
+ touch $@
+ '''
else:
assert False, f"unknown buildsystem: {buildsystem}"
@@ -414,7 +417,7 @@
'''
elif buildsystem == "erlang":
return f'''
-.make.{proj}.build: $({proj}_files)
+.make.{proj}.build: .make.{proj}.configure $({proj}_files)
@echo "\\n\\n\\n===== $@\\n"
set -x && \\
export REBAR_BASE_DIR="$$PWD/{build_proj}" && \\
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/41212?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I627e78f9317d99755cfad5d5c8526c3b7f1b3a27
Gerrit-Change-Number: 41212
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: falconia.
osmith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41209?usp=email )
Change subject: osmo_trau_frame_encode(): reduce space requirement in common case
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41209?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I9f3541b0618ebef26e53b69041e5b74abefd3b85
Gerrit-Change-Number: 41209
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Mon, 13 Oct 2025 07:32:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes