- gerrit-log - lists.osmocom.org

[XS] Change in libosmo-abis[master]: lapd_sap_stop(): fix use of uninitialized stack memory
by falconia 01 May '26

01 May '26

falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email ) Change subject: lapd_sap_stop(): fix use of uninitialized stack memory ...................................................................... lapd_sap_stop(): fix use of uninitialized stack memory DL-RELEASE in lapd_core can be done in two ways: by sending DISC and waiting for UA, or a purely local clearing of state. The selection between these two modes is communicated via an extended field in struct osmo_dlsap_prim that extends beyond the standard struct osmo_prim_hdr. lapd_sap_stop() is a wrapper function that sends DL-RELEASE to lapd_core; its only current users are the vendor-specific E1 BTS handlers for Ericsson and Nokia in OsmoBSC, and both of those need local release handling. This wrapper function does allocate correctly-sized struct osmo_dlsap_prim on the stack, but until now it failed to initialize the extended field - hence the actual behavior was subject to laws of chance, depending on uninitialized content of stack memory. Change-Id: Ic1469698ee8edf9b6fb55df8f79cc062be711f61 --- M src/input/lapd.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve falconia: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/input/lapd.c b/src/input/lapd.c index 88cc26f..b335923 100644 --- a/src/input/lapd.c +++ b/src/input/lapd.c @@ -550,6 +550,13 @@ msg->l3h = msg->data; osmo_prim_init(&dp.oph, 0, PRIM_DL_REL, PRIM_OP_REQUEST, msg); + /* DL-RELEASE can be done in two ways: by sending DISC and waiting + * for UA, or a purely local clearing of state. The only current + * users of this lapd_sap_stop() API are vendor-specific E1 BTS + * handlers for Ericsson and Nokia in OsmoBSC, and both of them + * need local release handling. */ + dp.u.rel_req.mode = 1; + /* send to L2 */ return lapd_recv_dlsap(&dp, &sap->dl.lctx); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic1469698ee8edf9b6fb55df8f79cc062be711f61 Gerrit-Change-Number: 42680 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-abis[master]: lapd_sap_stop(): fix use of uninitialized stack memory
by falconia 01 May '26

01 May '26

Attention is currently required from: laforge. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email ) Change subject: lapd_sap_stop(): fix use of uninitialized stack memory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic1469698ee8edf9b6fb55df8f79cc062be711f61 Gerrit-Change-Number: 42680 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 01 May 2026 15:21:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/a61aa9b7_4172f… : PS2, Line 555: tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); > just to make sure: do you need to call tcap_trans_track_continue() again once finally the asp is sel […] IMO no. The function sets otid/dtid if not already known, updates the timestamp and returns the asp. We already have the asp and just created a complete entry as otid/dtid are already known from the continue. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 18:28:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/ff26c2bb_067bc… : PS2, Line 555: tcap_trans_track_entry_create(as, asp, &called_addr, &parsed.dtid, &calling_addr, &parsed.otid); just to make sure: do you need to call tcap_trans_track_continue() again once finally the asp is selected? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:58:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:56:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email ) Change subject: bts: guard AMR RTP decoder stub with HAVE_LIBOSMOCODEC_STATIC ...................................................................... Patch Set 6: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-bts/+/42701/comment/e5c91bd0_7f21a2f1?usp… : PS6, Line 350: if test -n "$osmocodec_libdir" && test -f "$osmocodec_libdir/libosmocodec.a" ; then AFAIU the fact that an static library exists doesn't mean you are statically linking against that library? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie19ae2013893575a2f74a87af2151034abf57870 Gerrit-Change-Number: 42701 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:55:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: abis: add helper to update BTS identity
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: Timur Davydov, fixeria. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email ) Change subject: abis: add helper to update BTS identity ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: This function in osmo-bts should only be added/merged once there's a patch using it. Do you mind providing a link to the path here so it becomes clearer? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibafd66a1e1dc42ad0063c412087bee10d212fe33 Gerrit-Change-Number: 42699 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails Related: SYS#5423 Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 --- M src/tcap_as_loadshare.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/42686/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684/comment/ae02ae5e_1e549… : PS1, Line 11: otid/dtid. > Could you explain the problem more in detail please? (asymmetric MTP paths and it was a "hack" anywa […] I added a note about asymmetric MTP paths, is that enough? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/1c3a9e26_483b2… : PS1, Line 551: if (!asp) { > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:52:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log