- gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: Correctly calculate size iofd_msgb_alloc2()

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email ) Change subject: Correctly calculate size iofd_msgb_alloc2() ...................................................................... Patch Set 2: Code-Review-1 (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/41138/comment/42e0bfdf_55a2a702?… : PS2, Line 193: return msgb_alloc_headroom_c(iofd, size + headroom, headroom, "osmo_io_msgb"); static inline struct msgb *msgb_alloc_headroom_c(const void *ctx, uint16_t size, uint16_t headroom, const char *name) See uint16_t size above, this is broken anyway when passing "size+headroom". -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41138?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16c1e08fb64a1fafaeee1844fd8c00ecc2861d12 Gerrit-Change-Number: 41138 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Sat, 11 Oct 2025 19:51:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 days, 8 hours

1
0
0 0

[M] Change in osmo-msc[master]: SMS UX optimisation: Deliver rx'd SMS right away

by keith

keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email ) Change subject: SMS UX optimisation: Deliver rx'd SMS right away ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 19:40:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 days, 8 hours

1
0
0 0

[XS] Change in osmo-msc[master]: sqlite optimisation: add debug logging

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/41222?usp=email ) Change subject: sqlite optimisation: add debug logging ...................................................................... sqlite optimisation: add debug logging Change-Id: I43fc4d0e8c4de1f3d353a6bc886b4c3761dcef2a --- M src/libmsc/sms_queue.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/22/41222/1 diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c index 4ef4601..86a0e39 100644 --- a/src/libmsc/sms_queue.c +++ b/src/libmsc/sms_queue.c @@ -301,11 +301,13 @@ while (wrapped < 2 && (--sanity)) { /* If we wrapped around and passed the first msisdn, we're * through the entire SMS DB; end it. */ - if (wrapped && strcmp(last_msisdn, started_with_msisdn) >= 0) + if (wrapped && strcmp(last_msisdn, started_with_msisdn) >= 0) { + DEBUGP(DLSMS, "SMS queue: Reached end of DB.\n"); break; - + } sms = db_sms_get_next_unsent_rr_msisdn(net, last_msisdn, 9); if (!sms) { + DEBUGP(DLSMS, "SMS queue: Got no next unsent SMS\n"); last_msisdn[0] = '\0'; wrapped++; continue; @@ -324,7 +326,7 @@ return sms; } - DEBUGP(DLSMS, "SMS queue: no SMS to be sent\n"); + DEBUGP(DLSMS, "SMS queue: no SMS to be sent, tried %d times.\n", sanity+100); return NULL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41222?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I43fc4d0e8c4de1f3d353a6bc886b4c3761dcef2a Gerrit-Change-Number: 41222 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org>

3 days, 8 hours

1
0
0 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation

by keith

Attention is currently required from: fixeria, pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 4: (1 comment) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/ce8942e1_460cd2a1?usp… : PS4, Line 302: id = $id LIMIT 1 > Why are you adding `LIMIT 1`? Can there really be more than one entry with `id = $id`? I consider it standard practice to add a LIMIT 1 to a query that is only intended to ever delete maximum of 1 row. I can't say off the top of my head where I learned this, but I have surely seen it. I don't know if there's any performance benefit. Maybe it's just one more of those oh so many things that programmers do to convey intention to other programmers but that one could always argue are not really necessary, because X or Y will "never" happen. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 18:10:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 days, 9 hours

1
0
0 0

[M] Change in libosmo-abis[master]: trau_frame: add support for config frames of 3GPP Rel5+

by keith

Attention is currently required from: falconia. keith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email ) Change subject: trau_frame: add support for config frames of 3GPP Rel5+ ...................................................................... Patch Set 1: (1 comment) File src/trau/trau_frame.c: https://gerrit.osmocom.org/c/libosmo-abis/+/41210/comment/d2b2d256_6339ba88… : PS1, Line 1371: * exception of newly added OSMO_TRAU16_FT_CONFIG, and for OSMO_TRAU8_SPEECH > The last time 3GPP defined a new frame type for GSM Abis was Release 5 (2002); the newly added frame […] No, nothing to do with what you write. I'm just being a pedant about "new"-ness A couple of years ago, I pulled a fairly beaten up looking POE adapter out of a dusty box, wondering if it might have been operational. - and wiping off the encrusted mud revealed some sticky gungy masking tape with the word "NEW" written on it. Every so grateful to whoever stuck that on there... :-) Anyway, this patch is RTG :) BTW, oxford dic has: "newly, adj. (very) recently or lately" -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifbde07e4a3fb80e4faa0b6a6b32938ed98371c5b Gerrit-Change-Number: 41210 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 11 Oct 2025 18:02:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

3 days, 10 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hlr: add MSC to ccm_pars.name

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41219?usp=email ) Change subject: hlr: add MSC to ccm_pars.name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1813e49ec286892c1a637deb99908903613696aa Gerrit-Change-Number: 41219 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:49:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 20 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: don't test OsmoHLR-only features with PyHSS

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41218?usp=email ) Change subject: hlr: don't test OsmoHLR-only features with PyHSS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c4905dd3f73abfe9f7cc77fc045368b9499aade Gerrit-Change-Number: 41218 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:47:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 20 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: add HLR_IMPL_PYHSS

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41217?usp=email ) Change subject: hlr: add HLR_IMPL_PYHSS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0989374d777aabf5afaf224faeb0cb2ff4e603e6 Gerrit-Change-Number: 41217 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:46:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 20 hours

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: set PYTHONUNBUFFERED=1

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41216?usp=email ) Change subject: testenv: set PYTHONUNBUFFERED=1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I155f7c7bd9b985094e36fee6c6a2acfe556f580d Gerrit-Change-Number: 41216 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:45:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 20 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: add --install-packages

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email ) Change subject: testenv: add --install-packages ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File _testenv/testenv/__init__.py: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215/comment/c5be7266_2cbf… : PS1, Line 215: packages Nitpick: package(s) suggests that you can specify more than one package, like `--install-packages "foo bar zoo"`, but the `metavar` is `PACKAGE`. Maybe call it `--install-package` (without the 's') to avoid confusion? Alternatively, maybe change to use `type=str` and then do `testenv.args.install_packages.split(' ')`? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41215?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie54817e6c0334a224a612521beb378537c10d39d Gerrit-Change-Number: 41215 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

3 days, 20 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log