- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Add ts_SIP_Response_Trying

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SIP_Templates: Add ts_SIP_Response_Trying ...................................................................... SIP_Templates: Add ts_SIP_Response_Trying Similar to ts_SIP_Response_Ringing. We also have the counterpart tr_* for both Trying and Ringing. This is needed in a follow-up patch. Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb --- M library/SIP_Templates.ttcn 1 file changed, 28 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/94/36794/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb Gerrit-Change-Number: 36794 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

4 days, 5 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SIP_Templates: Allow passing Server field ...................................................................... SIP_Templates: Allow passing Server field This field is used by an IMS core. Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc --- M library/SIP_Templates.ttcn 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/36797/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

4 days, 5 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Always set Content-Length

by pespin

Attention is currently required from: jolly, pespin. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: SIP_Templates: Always set Content-Length ...................................................................... SIP_Templates: Always set Content-Length According to RFC3261 7.4.2, 7.5, 20.14 Content-Length SHOULD be set over any transport, and MUST be set over TCP. Hence, make sure we set it in all cases. This allows Asterisk being able to decode SIP messages sent to it over a TCP connection, since it uses the Content-Length field to look up for message boundaries over the TCP stream. Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf --- M library/SIP_Templates.ttcn 1 file changed, 68 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/36814/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf Gerrit-Change-Number: 36814 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

4 days, 5 hours

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Initial IMS registration

by pespin

Attention is currently required from: jolly, laforge, osmith, pespin. Hello Jenkins Builder, jolly, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: asterisk: Initial IMS registration ...................................................................... asterisk: Initial IMS registration This patch is a step towards testing IMS. So far only the code infrstrastructure to handle the 1st REGISTER (outside IPSEC) is provided. It can already be seen how Asterisk sends the second REGISTER over IPSEC, but there's no means to test it yet in TTCN-3. This will be done in a follow-up patch, which may take some work. Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M library/SIP_Templates.ttcn 3 files changed, 432 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/59/36759/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 Gerrit-Change-Number: 36759 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

4 days, 5 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Security_server field

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email ) Change subject: SIP_Templates: Allow passing Security_server field ...................................................................... SIP_Templates: Allow passing Security_server field Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 --- M library/SIP_Templates.ttcn 1 file changed, 24 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/SIP_Templates.ttcn b/library/SIP_Templates.ttcn index 7e33b3b..d35813e 100644 --- a/library/SIP_Templates.ttcn +++ b/library/SIP_Templates.ttcn @@ -476,6 +476,17 @@ sec_mechanism_list := sec_mechanism_list } +template (present) Security_server +tr_Security_server(template (present) Security_mechanism_list sec_mechanism_list := ?) := { + fieldName := SECURITY_SERVER_E, + sec_mechanism_list := sec_mechanism_list +} +template (value) Security_server +ts_Security_server(template (value) Security_mechanism_list sec_mechanism_list) := { + fieldName := SECURITY_SERVER_E, + sec_mechanism_list := sec_mechanism_list +} + template (present) Security_mechanism tr_Security_mechanism(template (present) charstring name := ?, template SemicolonParam_List params := *) := { @@ -504,6 +515,7 @@ template (omit) Expires expires := omit, template (omit) Require require := omit, template (omit) Security_client security_client := omit, + template (omit) Security_server security_server := omit, template (omit) Supported supported := omit, template (omit) WwwAuthenticate wwwAuthenticate := omit ) modifies ts_SIP_msgHeader_empty := { @@ -531,6 +543,7 @@ }, require := require, security_client := security_client, + security_server := security_server, supported := supported, toField := { fieldName := TO_E, @@ -575,6 +588,7 @@ template Expires expires := *, template Require require := *, template Security_client security_client := *, + template Security_server security_server := *, template Supported supported := *, template WwwAuthenticate wwwAuthenticate := * ) modifies t_SIP_msgHeader_any := { @@ -598,6 +612,7 @@ }, require := require, security_client := security_client, + security_server := security_server, supported := supported, toField := { fieldName := TO_E, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 Gerrit-Change-Number: 36792 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 5 hours

1
0
0 0

[S] Change in libosmo-sccp[master]: debian/postinst: add checks, be verbose

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a --- M debian/osmo-stp.postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/debian/osmo-stp.postinst b/debian/osmo-stp.postinst index bfcc1dc..3dbfd43 100755 --- a/debian/osmo-stp.postinst +++ b/debian/osmo-stp.postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-stp.cfg - chmod 0660 /etc/osmocom/osmo-stp.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.9.0"; then + if [ -e /etc/osmocom/osmo-stp.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-stp.cfg + chmod -v 0660 /etc/osmocom/osmo-stp.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a Gerrit-Change-Number: 36800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 5 hours

1
0
0 0

[S] Change in osmo-msc[master]: debian/postinst: add checks, be verbose

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index 80821c4..46cd851 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-msc.cfg - chmod 0660 /etc/osmocom/osmo-msc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.12.0"; then + if [ -e /etc/osmocom/osmo-msc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-msc.cfg + chmod -v 0660 /etc/osmocom/osmo-msc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36807 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 5 hours

1
0
0 0

[S] Change in osmo-smlc[master]: debian/postinst: add checks, be verbose

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I8994759df644d6edd8f937051b95690537b749be --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index faecd26..6c99b1f 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-smlc.cfg - chmod 0660 /etc/osmocom/osmo-smlc.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.3.0"; then + if [ -e /etc/osmocom/osmo-smlc.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-smlc.cfg + chmod -v 0660 /etc/osmocom/osmo-smlc.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36810 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 5 hours

1
0
0 0

[S] Change in libosmo-sccp[master]: debian/postinst: add checks, be verbose

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/36800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I853097a13e27b2ebd0b940117c8f5f4b3ea49b9a Gerrit-Change-Number: 36800 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[S] Change in osmo-hlr[master]: debian/postinst: add checks, be verbose

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/postinst b/debian/postinst index 5dedec4..34fb79d 100755 --- a/debian/postinst +++ b/debian/postinst @@ -21,12 +21,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-hlr.cfg - chmod 0660 /etc/osmocom/osmo-hlr.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "1.8.0"; then + if [ -e /etc/osmocom/osmo-hlr.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-hlr.cfg + chmod -v 0660 /etc/osmocom/osmo-hlr.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f Gerrit-Change-Number: 36804 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 5 hours

1
0
0 0

[S] Change in osmo-msc[master]: debian/postinst: add checks, be verbose

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/36807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2b01a7625cf66fbb7d203f939ddcc1cbab43cf33 Gerrit-Change-Number: 36807 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[S] Change in osmo-smlc[master]: debian/postinst: add checks, be verbose

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/36810?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36810 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[S] Change in osmo-hlr[master]: debian/postinst: add checks, be verbose

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/36804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I1bcbe414fd18101e4d875a16539deab7baf9cb5f Gerrit-Change-Number: 36804 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:47:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[S] Change in osmo-mgw[master]: doc: example configs: fix deprecation warnings

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36785?usp=email ) Change subject: doc: example configs: fix deprecation warnings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I62a4fd119de48039c3c450d5323d8f9b7de8120f Gerrit-Change-Number: 36785 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:26:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[M] Change in osmo-trx[master]: contrib/systemd: run as osmocom user

by fixeria

Attention is currently required from: msuraev, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3e0e5978992dac0a0c76c6f0e859576aa3eb72eb Gerrit-Change-Number: 30131 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 11:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 5 hours

1
0
0 0

[S] Change in libosmocore[master]: core: fix LOGPIO(): add missing space after 'iofd(...)'

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email ) Change subject: core: fix LOGPIO(): add missing space after 'iofd(...)' ...................................................................... core: fix LOGPIO(): add missing space after 'iofd(...)' Without a space the logging looks like this: iofd(virt-rnc0-0)Cancelling read Change-Id: I84d305ce6cfc69352a64cb9e42229f88f09893c0 --- M include/osmocom/core/osmo_io.h 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/29/36829/1 diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index 6f4dfa8..fa1f9c3 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -55,7 +55,7 @@ * \param[in] args arguments to the format string */ #define LOGPIO(iofd, level, fmt, args...) \ - LOGP(DLIO, level, "iofd(%s)" fmt, iofd->name, ## args) + LOGP(DLIO, level, "iofd(%s) " fmt, iofd->name, ## args) struct osmo_io_fd; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84d305ce6cfc69352a64cb9e42229f88f09893c0 Gerrit-Change-Number: 36829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

4 days, 6 hours

1
0
0 0

[M] Change in osmo-trx[master]: contrib/systemd: run as osmocom user

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30131?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I3e0e5978992dac0a0c76c6f0e859576aa3eb72eb Gerrit-Change-Number: 30131 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 10:52:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 days, 6 hours

1
0
0 0

[M] Change in osmo-bts[master]: contrib/systemd: run as osmocom user

by fixeria

Attention is currently required from: msuraev, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30133?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37be0dd4df012047a495235195912bd06ad2423d Gerrit-Change-Number: 30133 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 09:37:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 7 hours

1
0
0 0

[M] Change in osmo-pcu[master]: contrib/systemd: run as osmocom user

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/systemd/osmo-pcu.service: https://gerrit.osmocom.org/c/osmo-pcu/+/36828/comment/aff5a129_05a7e8e7 PS1, Line 17: CPUSchedulingPolicy=rr > Are you sure this is going to work when running as non-root? I am running all Osmocom services as a […] Oh, I see your explanation in the COMMIT_MSG now. Nevermind :D -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I362a9e55309033c42b16f12321f8d1aa27da7b59 Gerrit-Change-Number: 36828 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 09:35:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

4 days, 7 hours

1
0
0 0

[M] Change in osmo-pcu[master]: contrib/systemd: run as osmocom user

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 1: (1 comment) File contrib/systemd/osmo-pcu.service: https://gerrit.osmocom.org/c/osmo-pcu/+/36828/comment/89048e8d_7fc16586 PS1, Line 17: CPUSchedulingPolicy=rr Are you sure this is going to work when running as non-root? I am running all Osmocom services as a regular user on my system, and AFAIR I had to create the following file: ``` $ cat /etc/security/limits.d/osmocom.conf @osmocom - rtprio 99 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I362a9e55309033c42b16f12321f8d1aa27da7b59 Gerrit-Change-Number: 36828 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 09:33:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() Ensure the expected default UEA configuration, which is always reset properly even if one of the testcases aborts due to a DTE. Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: lynxis lazus: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index f6a4243..5f1bb55 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -14,6 +14,9 @@ private function f_init() runs on test_CT { g_ranap_enable := true; SGSN_Tests.f_init(); + + /* default VTY configuration */ + f_vty_config(SGSNVTY, "sgsn", "encryption uea 0"); } private function f_TC_iu_attach(charstring id) runs on BSSGP_ConnHdlr { @@ -59,7 +62,6 @@ f_sleep(1.0); vc_conn := f_start_handler(refers(f_TC_iu_attach), testcasename(), g_gb, 1001, expect_ciph := true); vc_conn.done; - f_vty_config(SGSNVTY, "sgsn", "encryption uea 0"); f_cleanup(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: add Iu specific, module local f_init()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36823?usp=email ) Change subject: sgsn: add Iu specific, module local f_init() ...................................................................... sgsn: add Iu specific, module local f_init() Change-Id: Iea23b847b363da518a8dc121405522df9e4e0f77 --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 13 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 236a6a7..53aa032 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -11,6 +11,10 @@ import from RANAP_PDU_Descriptions all; import from RANAP_IEs all; +private function f_init() runs on test_CT { + g_ranap_enable := true; + SGSN_Tests.f_init(); +} private function f_TC_iu_attach(charstring id) runs on BSSGP_ConnHdlr { var PdpActPars apars := valueof(t_PdpActPars(mp_ggsn_ip)); @@ -29,7 +33,6 @@ * MS -> SGSN: Attach Complete */ var BSSGP_ConnHdlr vc_conn; - g_ranap_enable := true; f_init(); f_sleep(1.0); vc_conn := f_start_handler(refers(f_TC_iu_attach), testcasename(), g_gb, 1001); @@ -50,7 +53,6 @@ * MS -> SGSN: Attach Complete */ var BSSGP_ConnHdlr vc_conn; - g_ranap_enable := true; f_init(); f_vty_config(SGSNVTY, "sgsn", "encryption uea 1 2"); f_sleep(1.0); @@ -75,7 +77,6 @@ * MS <-> SGSN: Routing Area Update over Geran */ var BSSGP_ConnHdlr vc_conn; - g_ranap_enable := true; f_init(); f_sleep(1.0); vc_conn := f_start_handler(refers(f_TC_iu_attach_geran_rau), testcasename(), g_gb, 1002); @@ -99,7 +100,6 @@ * MS <-> SGSN: Routing Area Update over Iu */ var BSSGP_ConnHdlr vc_conn; - g_ranap_enable := true; f_init(); f_sleep(1.0); vc_conn := f_start_handler(refers(f_TC_geran_attach_iu_rau), testcasename(), g_gb, 1003); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea23b847b363da518a8dc121405522df9e4e0f77 Gerrit-Change-Number: 36823 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix TC_iu_attach failing for recent -master

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36824?usp=email ) Change subject: sgsn: fix TC_iu_attach failing for recent -master ...................................................................... sgsn: fix TC_iu_attach failing for recent -master Since recently, osmo-sgsn is requesting encryption (UEA1 + UEA2) in RANAP Security Mode Command by default [1]. The testcase TC_iu_attach is assuming no encryption (UEA0) and thus failing. Fix this by explicitly setting UEA0 via the VTY, similarly to what testcase TC_iu_attach_encr does. Change-Id: Ibaf83db1ab0f82f7e934e89ae3f6c19d014be197 Related: [1] osmo-sgsn.git I4eb9451b4267fc1436ed90a55ff200cf36f16bf6 --- M sgsn/SGSN_Tests_Iu.ttcn 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 53aa032..f6a4243 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -35,6 +35,7 @@ var BSSGP_ConnHdlr vc_conn; f_init(); f_sleep(1.0); + f_vty_config(SGSNVTY, "sgsn", "encryption uea 0"); vc_conn := f_start_handler(refers(f_TC_iu_attach), testcasename(), g_gb, 1001); vc_conn.done; f_cleanup(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf83db1ab0f82f7e934e89ae3f6c19d014be197 Gerrit-Change-Number: 36824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email ) Change subject: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI ...................................................................... sgsn: fix TC_iu_attach_geran_rau: register the new TLLI We're getting a new TLLI assigned during the attach procedure (see Allocated P-TMSI in the GMM Attach Accept message), which needs to be registered in order to receive BSSGP PDUs from BSSGP_Emulation. Change-Id: Idafcbd7e44a523a26dc34dc72e38ff879782148e --- M sgsn/SGSN_Tests_Iu.ttcn M sgsn/expected-results.xml 2 files changed, 19 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/sgsn/SGSN_Tests_Iu.ttcn b/sgsn/SGSN_Tests_Iu.ttcn index 5f1bb55..0a589b9 100644 --- a/sgsn/SGSN_Tests_Iu.ttcn +++ b/sgsn/SGSN_Tests_Iu.ttcn @@ -4,6 +4,7 @@ import from Osmocom_VTY_Functions all; import from SGSN_Tests all; +import from BSSGP_Emulation all; import from RAN_Adapter all; import from RAN_Emulation all; @@ -71,6 +72,10 @@ /* first perform regular attach */ f_gmm_attach(umts_aka_challenge := true, force_gsm_sres := false, ran_index := 3); + /* we got a new TLLI, register it */ + f_bssgp_client_unregister(g_pars.imsi); + f_bssgp_client_register(g_pars.imsi, g_pars.tlli); + /* do a routing area update */ f_routing_area_update(g_pars.ra); } diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index bef13dc..2351ace 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -88,12 +88,7 @@  <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_encr' time='MASKED'/> - <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_geran_rau' time='MASKED'> - <failure type='fail-verdict'>"BSSGP_Emulation.ttcnpp:830 : Couldn't find Component for TLLI 'E918E6AA'O" - SGSN_Tests_Iu.ttcn:MASKED SGSN_Tests_Iu control part - SGSN_Tests_Iu.ttcn:MASKED TC_iu_attach_geran_rau testcase - </failure> - </testcase> + <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_geran_rau' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_geran_attach_iu_rau' time='MASKED'/>  <testcase classname='SGSN_Tests_NS' name='TC_SNS_size' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idafcbd7e44a523a26dc34dc72e38ff879782148e Gerrit-Change-Number: 36826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email ) Change subject: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS ...................................................................... sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS Change-Id: Ic499bcd036ef02d4e3ac7a94ccc3ff141df9b17b --- M sgsn/SGSN_Tests.ttcn 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 0371e29..9c73834 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -614,6 +614,7 @@ lAC := '1234'O, iE_Extensions := omit }; + var RANAP_IEs.RAC rac := '00'O; var SAI sai := { pLMNidentity := lai.pLMNidentity, lAC := lai.lAC, @@ -626,7 +627,7 @@ rNC_ID := 2342 /* FIXME */ }; - ranap := valueof(ts_RANAP_initialUE_CS(lai, sai, l3_enc, sigc_id, grnc_id)); + ranap := valueof(ts_RANAP_initialUE_PS(lai, rac, sai, l3_enc, sigc_id, grnc_id)); BSSAP.send(ts_RANAP_Conn_Req(g_pars.sccp_addr_peer, g_pars.sccp_addr_local, ranap)); alt { [] BSSAP.receive(RAN_Conn_Prim:MSC_CONN_PRIM_CONF_IND) {} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic499bcd036ef02d4e3ac7a94ccc3ff141df9b17b Gerrit-Change-Number: 36827 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 May 2024 09:28:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 7 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... Patch Set 1: (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825/comment/190c1fee_4df5… PS1, Line 19: f_vty_config(SGSNVTY, "sgsn", "encryption uea 0"); > I would also prefer using encryption by default in our test cases. […] Feel free to submit a separate patch enabling the encryption by default, it would only be a matter of changing one line thanks to this patch. As I said, I am just moving stuff to the common init function and not changing the default UEA configuration here. Marking this thread as resolved. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 May 2024 09:28:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

4 days, 7 hours

1
0
0 0

[M] Change in osmo-bts[master]: contrib/systemd: run as osmocom user

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30133?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I37be0dd4df012047a495235195912bd06ad2423d Gerrit-Change-Number: 30133 Gerrit-PatchSet: 3 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 09:11:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email ) Change subject: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idafcbd7e44a523a26dc34dc72e38ff879782148e Gerrit-Change-Number: 36826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:34:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email ) Change subject: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic499bcd036ef02d4e3ac7a94ccc3ff141df9b17b Gerrit-Change-Number: 36827 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:34:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email ) Change subject: sgsn: fix f_send_l3_initial_ue(): indicate PS domain, not CS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36827?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic499bcd036ef02d4e3ac7a94ccc3ff141df9b17b Gerrit-Change-Number: 36827 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:33:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email ) Change subject: sgsn: fix TC_iu_attach_geran_rau: register the new TLLI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36826?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idafcbd7e44a523a26dc34dc72e38ff879782148e Gerrit-Change-Number: 36826 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:33:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by lynxis lazus

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825/comment/ca0f594e_6cfb… PS1, Line 19: f_vty_config(SGSNVTY, "sgsn", "encryption uea 0"); > Whether we want to run all tests with encryption or not is a separate question. […] I would also prefer using encryption by default in our test cases. For Iu it shouldn't matter as much, because encryption is done by the hnodeb. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:32:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: fix TC_iu_attach failing for recent -master

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36824?usp=email ) Change subject: sgsn: fix TC_iu_attach failing for recent -master ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36824?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibaf83db1ab0f82f7e934e89ae3f6c19d014be197 Gerrit-Change-Number: 36824 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:30:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: add Iu specific, module local f_init()

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36823?usp=email ) Change subject: sgsn: add Iu specific, module local f_init() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36823?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iea23b847b363da518a8dc121405522df9e4e0f77 Gerrit-Change-Number: 36823 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:29:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... Patch Set 1: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:27:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config()

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email ) Change subject: sgsn: reset encryption in SGSN_Tests_Iu.f_vty_config() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36825?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic2c5a11e86e4349796fa7508076ac27ef22815cd Gerrit-Change-Number: 36825 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 08:26:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 8 hours

1
0
0 0

[M] Change in osmo-pcu[master]: contrib/systemd: run as osmocom user

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... contrib/systemd: run as osmocom user I have verified that with AmbientCapabilities=CAP_SYS_NICE, setting scheduling policy as described in the manual still works as expected. Related: OS#4107 Change-Id: I362a9e55309033c42b16f12321f8d1aa27da7b59 --- M contrib/systemd/osmo-pcu.service A debian/postinst 2 files changed, 55 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/28/36828/1 diff --git a/contrib/systemd/osmo-pcu.service b/contrib/systemd/osmo-pcu.service index 521f6fc..8c0fd69 100644 --- a/contrib/systemd/osmo-pcu.service +++ b/contrib/systemd/osmo-pcu.service @@ -9,7 +9,10 @@ StateDirectory=osmocom WorkingDirectory=%S/osmocom Restart=always +User=osmocom +Group=osmocom RestartSec=2 +AmbientCapabilities=CAP_SYS_NICE # CPU scheduling policy: CPUSchedulingPolicy=rr # For real-time scheduling policies an integer between 1 (lowest priority) and 99 (highest priority): diff --git a/debian/postinst b/debian/postinst new file mode 100755 index 0000000..cfd72a2 --- /dev/null +++ b/debian/postinst @@ -0,0 +1,39 @@ +#!/bin/sh -e +case "$1" in + configure) + # Create the osmocom group and user (if it doesn't exist yet) + if ! getent group osmocom >/dev/null; then + groupadd --system osmocom + fi + if ! getent passwd osmocom >/dev/null; then + useradd \ + --system \ + --gid osmocom \ + --home-dir /var/lib/osmocom \ + --shell /sbin/nologin \ + --comment "Open Source Mobile Communications" \ + osmocom + fi + + # Fix permissions of previous (root-owned) install (OS#4107) + if dpkg --compare-versions "$2" le "1.5.0"; then + if [ -e /etc/osmocom/osmo-pcu.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-pcu.cfg + chmod -v 0660 /etc/osmocom/osmo-pcu.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi + ;; +esac + +# dh_installdeb(1) will replace this with shell code automatically +# generated by other debhelper scripts. +#DEBHELPER# + -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I362a9e55309033c42b16f12321f8d1aa27da7b59 Gerrit-Change-Number: 36828 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

4 days, 8 hours

1
0
0 0

[M] Change in ...osmo-epdg[master]: docs: add chapter operating

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36822?usp=email ) Change subject: docs: add chapter operating ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File docs/manuals/chapters/operating.adoc: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36822/comment/62cd4b62_16ca… PS1, Line 17: can't changed can't be changed -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36822?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: If4546fd98c470bcb29523bebae0ffa6bcf7f6cde Gerrit-Change-Number: 36822 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 May 2024 07:38:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 9 hours

1
0
0 0

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email ) Change subject: docs: add basic manual of the osmo-epdg ...................................................................... Patch Set 7: (1 comment) File docs/manuals/chapters/epcrequirements.adoc: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/c619ddaa_f410… PS7, Line 1: [[epcrequirements]] This file does not get included, and gets deleted in the next commit? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b Gerrit-Change-Number: 36783 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 May 2024 07:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 days, 9 hours

1
0
0 0

[L] Change in ...osmo-epdg[master]: docs: add basic manual of the osmo-epdg

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email ) Change subject: docs: add basic manual of the osmo-epdg ...................................................................... Patch Set 7: Code-Review+1 (6 comments) Patchset: PS7: Very nice manual! File docs/manuals/chapters/epcrequirements.adoc: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/ae7c94e6_941f… PS7, Line 15: THe The File docs/manuals/chapters/osmo-epdg.adoc: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/e15d00ea_67cc… PS7, Line 16: distribution osmocom distributions, Osmocom File docs/manuals/chapters/strongswan.adoc: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/0cb554bd_6cab… PS7, Line 9: at https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/ca83c707_c10b… PS7, Line 32: ) ). File docs/manuals/osmoepdg-usermanual-docinfo.xml: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783/comment/9007eb7b_4ab5… PS7, Line 4: 2014 2024? :) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I596b6a351b7356aefa7e69f95521bc4012b9264b Gerrit-Change-Number: 36783 Gerrit-PatchSet: 7 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 15 May 2024 07:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 9 hours

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: asterisk: Initial IMS registration

by osmith

Attention is currently required from: jolly, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email ) Change subject: asterisk: Initial IMS registration ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File library/SIP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759/comment/b16030cc_9fd4… PS4, Line 904: Unauthozied Unauthorized -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb3b19ccd82cad25948106b2c72aa424d7f79cd8 Gerrit-Change-Number: 36759 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Always set Content-Length

by osmith

Attention is currently required from: jolly, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email ) Change subject: SIP_Templates: Always set Content-Length ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26e444fe466b4742d74ef5a6e371ce8488a5afcf Gerrit-Change-Number: 36814 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:13:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Server field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email ) Change subject: SIP_Templates: Allow passing Server field ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36797?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7816eb4565fb027a2902c60c600a75b96dc293bc Gerrit-Change-Number: 36797 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:08:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing UserAgent field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email ) Change subject: SIP_Templates: Allow passing UserAgent field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib1e3e66b8fe46ad2626b07193dfcaa594f26352e Gerrit-Change-Number: 36796 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:07:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Add ts_SIP_Response_Trying

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email ) Change subject: SIP_Templates: Add ts_SIP_Response_Trying ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I05d8be9ce8860c610c509670392e14f1096fdddb Gerrit-Change-Number: 36794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:05:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email ) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:02:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing 'Allow' field

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email ) Change subject: SIP_Templates: Allow passing 'Allow' field ...................................................................... Patch Set 1: (1 comment) File library/SIP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793/comment/4d8c1849_78c5… PS1, Line 78: function tr_AllowMethods(template Method_List allow_methods) return template Allow { this is now unused, even in https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36759/4. is it worth keeping? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36793?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10dd36d8c0ef8dbcbb58016c9684d877a0455b03 Gerrit-Change-Number: 36793 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 07:01:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: SIP_Templates: Allow passing Security_server field

by osmith

Attention is currently required from: jolly, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email ) Change subject: SIP_Templates: Allow passing Security_server field ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36792?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7ee3d6dace39c784b0ec900d58a55421ac967269 Gerrit-Change-Number: 36792 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 May 2024 06:57:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

4 days, 10 hours

1
0
0 0

[S] Change in osmo-upf[master]: debian/postinst: add checks, be verbose

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email ) Change subject: debian/postinst: add checks, be verbose ...................................................................... debian/postinst: add checks, be verbose Do not attempt to change permissions/ownership if the package gets upgraded from a version higher than the next release. Do not fail if the user deleted the config file. Be verbose when changing permissions. Related: OS#4107 Change-Id: I8994759df644d6edd8f937051b95690537b749be --- M debian/postinst 1 file changed, 31 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/postinst b/debian/postinst index 4310e7e..3298043 100755 --- a/debian/postinst +++ b/debian/postinst @@ -16,12 +16,20 @@ fi # Fix permissions of previous (root-owned) install (OS#4107) - chown osmocom:osmocom /etc/osmocom/osmo-upf.cfg - chmod 0660 /etc/osmocom/osmo-upf.cfg - chown root:osmocom /etc/osmocom - chmod 2775 /etc/osmocom - mkdir -p /var/lib/osmocom - chown -R osmocom:osmocom /var/lib/osmocom + if dpkg --compare-versions "$2" le "0.2.0"; then + if [ -e /etc/osmocom/osmo-upf.cfg ]; then + chown -v osmocom:osmocom /etc/osmocom/osmo-upf.cfg + chmod -v 0660 /etc/osmocom/osmo-upf.cfg + fi + + if [ -d /etc/osmocom ]; then + chown -v root:osmocom /etc/osmocom + chmod -v 2775 /etc/osmocom + fi + + mkdir -p /var/lib/osmocom + chown -R -v osmocom:osmocom /var/lib/osmocom + fi ;; esac -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/36811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I8994759df644d6edd8f937051b95690537b749be Gerrit-Change-Number: 36811 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

4 days, 10 hours

1
0
0 0

2024

2023

2022

gerrit-log