- gerrit-log - lists.osmocom.org

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by Jenkins Builder 28 Apr '26

28 Apr '26

Attention is currently required from: Hoernchen, osmith. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email ) Change subject: fw source: force reformat once and for all ...................................................................... Patch Set 3: (3 comments) File sysmoOCTSIM/dfu_descriptors.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/6bfdb332_fd… : PS3, Line 30: #define DFURT_IF_DESCRIPTOR_STRUCT \ macros should not use a trailing semicolon File sysmoOCTSIM/talloc.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/1997cc8b_eb… : PS3, Line 880: void *talloc_pooled_object(const void *ctx, #type, unsigned num_subobjects, size_t total_subobjects_size); function definition argument 'type' should also have an identifier name File sysmoOCTSIM/talloc.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/80be2045_f5… : PS3, Line 251: #define TC_UNDEFINE_GROW_CHUNK(_tc, _new_size) \ Single statement macros should not use a do {} while (0) loop -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 16:54:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in osmo-ccid-firmware[master]: formatting: update .clang-format
by Hoernchen 28 Apr '26

28 Apr '26

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42355?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: formatting: update .clang-format ...................................................................... formatting: update .clang-format Updates the formatting rules derived from linux kernel 098b6e44cbaa2d526d06af90c862d13fb414a0ec At the same time tell clang-format to keep the bespoke formatting used for the fsm and usb descs. Change-Id: I1fd4d38897946693b5495fa4d0b61925eb9d07f7 --- M .clang-format M ccid_common/iso7816_3.c M ccid_common/iso7816_fsm.c M sysmoOCTSIM/usb_descriptors.c 4 files changed, 366 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/55/42355/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42355?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1fd4d38897946693b5495fa4d0b61925eb9d07f7 Gerrit-Change-Number: 42355 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: fw: add git blame ignore file
by Hoernchen 28 Apr '26

28 Apr '26

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42331?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: fw: add git blame ignore file ...................................................................... fw: add git blame ignore file Reformatting should not pollute blame, so ignore those revs. Change-Id: I35b86f52d491c9e28ab0af9e3e3d4fd5f6dbd119 --- A .git-blame-ignore-revs 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/31/42331/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42331?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I35b86f52d491c9e28ab0af9e3e3d4fd5f6dbd119 Gerrit-Change-Number: 42331 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XL] Change in osmo-ccid-firmware[master]: fw source: force reformat once and for all
by Hoernchen 28 Apr '26

28 Apr '26

Attention is currently required from: Hoernchen, osmith. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: fw source: force reformat once and for all ...................................................................... fw source: force reformat once and for all This commit applies the rules to all files that matter (obv excluding asf4 code) since it is impossible to modify code because the code never used the code style enforced by the linter/clang-format and 1) changing code 2) reformatting code 3) extracting the reformatting changes for the modified lines as a separate commit 4) commiting standalone reformatting changes 4) commiting the actual code change on top is a workflow that takes forever and is completely ridiculous because the whole point of formatter rules is to apply them. This needs a second commit with .git-blame-ignore-revs to not pollute blame. Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f --- M ccid_common/ccid_device.c M ccid_common/ccid_device.h M ccid_common/ccid_proto.c M ccid_common/ccid_proto.h M ccid_common/ccid_slot_fsm.c M ccid_common/cuart.c M ccid_common/cuart.h M ccid_common/iso7816_3.c M ccid_common/iso7816_fsm.c M ccid_common/iso7816_fsm.h M ccid_host/ccid_main_functionfs.c M ccid_host/ccid_slot_sim.c M ccid_host/cuart_driver_tty.c M ccid_host/cuart_fsm_test.c M ccid_host/cuart_test.c M ccid_host/hub_main_functionfs.c M ccid_host/logging.c M ccid_host/utils_ringbuffer.c M ccid_host/utils_ringbuffer.h M sysmoOCTSIM/command.c M sysmoOCTSIM/command.h M sysmoOCTSIM/cuart_driver_asf4_usart_async.c M sysmoOCTSIM/dfu_descriptors.h M sysmoOCTSIM/driver_init.c M sysmoOCTSIM/driver_init.h M sysmoOCTSIM/i2c_bitbang.c M sysmoOCTSIM/i2c_bitbang.h M sysmoOCTSIM/libosmo_emb.c M sysmoOCTSIM/libosmo_emb.h M sysmoOCTSIM/linuxlist_atomic.h M sysmoOCTSIM/main.c M sysmoOCTSIM/ncn8025.c M sysmoOCTSIM/ncn8025.h M sysmoOCTSIM/octsim_i2c.c M sysmoOCTSIM/replace.h M sysmoOCTSIM/talloc.c M sysmoOCTSIM/talloc.h M sysmoOCTSIM/usb_descriptors.c M sysmoOCTSIM/usb_descriptors.h M sysmoOCTSIM/usb_dfu.h M sysmoOCTSIM/usb_start.c M sysmoOCTSIM/usb_start.h 42 files changed, 1,856 insertions(+), 2,078 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/30/42330/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iacc086bb566551225e7a21b639a1ad2ec257484f Gerrit-Change-Number: 42330 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-e1d[master]: HDLC timeslots: fix Rx of maximum-sized frames
by tnt 28 Apr '26

28 Apr '26

tnt has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email ) Change subject: HDLC timeslots: fix Rx of maximum-sized frames ...................................................................... HDLC timeslots: fix Rx of maximum-sized frames E1D protocol sets the maximum permitted size of an HDLC frame to 264 bytes of useful payload, not counting the 2 bytes of FCS. This limit is fair enough, as it matches GSM TS 08.56, the primary intended application. However, osmo_isdnhdlc engine used internally by the daemon requires an Rx buffer 2 bytes larger than the maximum payload length, for temporary storage of FCS bytes: by the nature of HDLC, a receiver has no way of identifying FCS bytes as such until after they have been received and stored in the Rx buffer. This bug was caught when bringing up OsmoBSC with Nokia Flexi Multiradio BTS. This BTS emits some long OML messages that get broken into segments, with each not-last segment traveling over HDLC as a maximum-sized frame - and these frames then get dropped by osmo-e1d, causing further breakage downstream. Change-Id: I479e8fe5118c8eb7d4e6b16b49047a3278bc9808 --- M src/e1d.h 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified tnt: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/e1d.h b/src/e1d.h index 5015761..7d2d4c6 100644 --- a/src/e1d.h +++ b/src/e1d.h @@ -101,7 +101,8 @@ struct osmo_isdnhdlc_vars tx; struct osmo_isdnhdlc_vars rx; - uint8_t rx_buf[E1DP_MAX_SIZE_HDLC]; + /* extra 2 bytes needed for FCS */ + uint8_t rx_buf[E1DP_MAX_SIZE_HDLC + 2]; uint8_t tx_buf[E1DP_MAX_SIZE_HDLC]; int tx_ofs; int tx_len; -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I479e8fe5118c8eb7d4e6b16b49047a3278bc9808 Gerrit-Change-Number: 42681 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-e1d[master]: HDLC timeslots: fix Rx of maximum-sized frames
by tnt 28 Apr '26

28 Apr '26

Attention is currently required from: falconia, laforge. tnt has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email ) Change subject: HDLC timeslots: fix Rx of maximum-sized frames ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/42681?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I479e8fe5118c8eb7d4e6b16b49047a3278bc9808 Gerrit-Change-Number: 42681 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Apr 2026 16:10:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by Timur Davydov 28 Apr '26

28 Apr '26

Attention is currently required from: Hoernchen, laforge, pespin, tnt. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email ) Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... Patch Set 16: (1 comment) File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42248/comment/45422ddc_0d36d272?usp… : PS15, Line 776: return (burst_lut_prepared) ? modulateBurstLaurentLutInt(bits) : modulateBurstLaurent(bits); > The feature is either enabled using the ifdef and there is a lut or it's not enabled and there is no […] Agreed. Removed runtime checks — LUT is now strictly controlled by the ifdef. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 16 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Apr 2026 15:48:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by Timur Davydov 28 Apr '26

28 Apr '26

Attention is currently required from: Timur Davydov, laforge, pespin, tnt. Hello Hoernchen, Jenkins Builder, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... transceiver: add optional Laurent burst LUT modulation (int16) Introduce an optional Burst LUT optimization for Laurent-based burst modulation, enabled via --with-burst-lut. - Add precomputed Laurent LUT tables (float and int16 I/Q variants) - Generate LUT at initialization (prepareBurstLUT) - Use LUT-based modulation for sps=4 when enabled - Add configure.ac option and USE_BURST_LUT define This reduces runtime computation by replacing per-burst Laurent processing with memcpy-based LUT lookups. Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 --- M Transceiver52M/sigProcLib.cpp M configure.ac 2 files changed, 167 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/42248/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 16 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by Hoernchen 28 Apr '26

28 Apr '26

Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by Hoernchen 28 Apr '26

28 Apr '26

Attention is currently required from: laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I agree it would have been nice (and actually I would have expected within more than one month of st […] This requires far more work redesigning the whole memory allocation handling and is very low on the list of important things, patching pcscd if there ever is a problem is much quicker and for the past year there was no issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 28 Apr 2026 15:07:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log