laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email )
Change subject: Fix: Only run pcscd with "--diable-polkit" if supported
......................................................................
Fix: Only run pcscd with "--diable-polkit" if supported
For example, if bankd tests run on Debian Bookwork, pcscd does not have
the "--disable-polkit" option. This option is not required, because it
does not support Polit anyway.
Only add "--disable-polkit" to the command line if supported by pcscd.
Change-Id: Ib2cdf7fcd698c33810ebfbb1db2fa666b9d7dbb3
---
M remsim/testenv_bankd.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
osmith: Looks good to me, approved
diff --git a/remsim/testenv_bankd.cfg b/remsim/testenv_bankd.cfg
index 62df381..1cda9b0 100644
--- a/remsim/testenv_bankd.cfg
+++ b/remsim/testenv_bankd.cfg
@@ -5,7 +5,7 @@
[pcscd]
prepare=require_vsmartcard_vpcd.sh
-program=pcscd -f -d --disable-polkit
+program=pcscd -f -d $(pcscd --help 2>&1 | grep -q -- --disable-polkit && echo "--disable-polkit")
make=no
package=pcscd
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2cdf7fcd698c33810ebfbb1db2fa666b9d7dbb3
Gerrit-Change-Number: 42711
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email )
Change subject: Fix: Only run pcscd with "--diable-polkit" if supported
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2cdf7fcd698c33810ebfbb1db2fa666b9d7dbb3
Gerrit-Change-Number: 42711
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 28 Apr 2026 14:11:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Ping @ewild@sysmocom.deIt would be great to get this patch into master.
I agree it would have been nice (and actually I would have expected within more than one month of stalling here) to see a commit that only contains functional changes and no cosmetic changes.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70
Gerrit-Change-Number: 42306
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Apr 2026 14:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages
......................................................................
Patch Set 3:
(1 comment)
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/e71c3ffc_c1… :
PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
> yes, really interesting, i wonder why that is? interestingly I rarely see any other developer even s […]
I've seen quite a number of cases where cosmetich changes were submitted separately from functional changes.
of course you won't find instances of someone running some automatic formatting tool in one cosmetic commit and then submitting another functional commit on top of that, as we do not have any tradition of using automatic formatting tools in Osmocom. I thought with osmo-ccid-firmware we can give you a shot at trying that approach, but what I've seen so far here is doing anything but convince me that this is something we want to do or possibly even expand to other repositories. I'm willing to let the experiment run for some more time and would actually like to see it succeed.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70
Gerrit-Change-Number: 42306
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Apr 2026 14:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, laforge.
lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Ping @ewild@sysmocom.deIt would be great to get this patch into master.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70
Gerrit-Change-Number: 42306
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 28 Apr 2026 13:12:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email )
Change subject: jenkins.sh: pin libosmocore version to current version v1.14
......................................................................
jenkins.sh: pin libosmocore version to current version v1.14
osmo-ccid-firmware isn't using much of libosmocore.
Use a specific version instead of the current master.
This also improve reproducible builds, because the jenkins would otherwise
use the current master commit to build it.
Related: OS#6987
Change-Id: I678957099348e067d62a4abd04cbdac822463cf4
---
M contrib/jenkins.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
osmith: Looks good to me, approved
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index bd90e45..ec361fa 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -18,7 +18,7 @@
echo
echo "=============== libosmocore host build ==========="
-osmo-build-dep.sh libosmocore "" --disable-doxygen
+osmo-build-dep.sh libosmocore "1.14.0" --disable-doxygen
export PKG_CONFIG_PATH="$inst/lib/pkgconfig:$PKG_CONFIG_PATH"
export LD_LIBRARY_PATH="$inst/lib"
export PATH="$inst/bin:$PATH"
@@ -36,7 +36,7 @@
echo "=============== libosmocore cross-build ==========="
mkdir -p "$deps"
cd "$deps"
-osmo-deps.sh libosmocore master
+osmo-deps.sh libosmocore 1.14.0
cd libosmocore
CFLAGS="-Os -g3 -ffunction-sections -fdata-sections -nostartfiles -nodefaultlibs"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I678957099348e067d62a4abd04cbdac822463cf4
Gerrit-Change-Number: 42676
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42710?usp=email )
Change subject: jobs/ttcn3-testsuites-testenv: fix rm apt partial
......................................................................
jobs/ttcn3-testsuites-testenv: fix rm apt partial
Fix that testenv jobs may fail to remove the cache at the beginning:
rm: cannot remove '_cache/podman/var-lib-apt-debian-trixie/lists/partial': Permission denied
This happens when the partial directory still exists:
$ ls -lah ~/jenkins/workspace/ttcn3-bsc-test-sccplite/_cache/podman/var-lib-apt-debian-trixie/lists
total 12K
drwxr-xr-x 3 osmocom-build osmocom-build 4.0K Apr 27 08:48 .
drwxr-xr-x 3 osmocom-build osmocom-build 4.0K Apr 26 08:48 ..
drwx------ 2 100041 osmocom-build 4.0K Apr 26 08:48 partial
Which in turn is the result of "apt update" failing to download files in
an earlier job:
E: Failed to fetch https://downloads.osmocom.org/packages/osmocom:/nightly/Debian_13/./Package… File has unexpected size (210767 != 210491). Mirror sync in progress? [IP: 148.251.236.141 443]
Hashes of expected file:
- Filesize:210491 [weak]
- SHA256:a0cdea838b724880f455d68eb433f6331a7d4113c2eb677ca2f7f6dbdf9a72e1
- SHA1:71780896257ca550e51b95e77fee4c63fcc9980c [weak]
- MD5Sum:531a2d49d4e9f3ff121ca6aa5be602fc [weak]
Release file created at: Sun, 26 Apr 2026 08:48:04 +0000
E: Some index files failed to download. They have been ignored, or old ones used instead.
Change-Id: I35b9e42b754805b42f0a868a5d0c20c1f1c01731
---
M jobs/ttcn3-testsuites-testenv.yml
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
osmith: Looks good to me, approved; Verified
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
jolly: Looks good to me, but someone else must approve
diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml
index 144377e..944a92c 100644
--- a/jobs/ttcn3-testsuites-testenv.yml
+++ b/jobs/ttcn3-testsuites-testenv.yml
@@ -643,6 +643,19 @@
podman pull registry.osmocom.org/osmocom-build/debian-"$debver"-osmo-ttcn3-testenv
done
+ # Clean up leftover apt partial directories, which the host system
+ # user can't remove directly
+ for i in _cache/podman/var-lib-apt-debian-*/lists/partial; do
+ if [ -e "$i" ]; then
+ podman run \
+ --rm \
+ -v "$PWD:/build" \
+ -w /build \
+ osmocom-build/debian-trixie-osmo-ttcn3-testenv \
+ rm -rvf "$i"
+ fi
+ done
+
rm -rf logs _cache .linux
if [ "$KERNEL" != "none" ]; then
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42710?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I35b9e42b754805b42f0a868a5d0c20c1f1c01731
Gerrit-Change-Number: 42710
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
osmith has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email )
Change subject: Fix: Only run pcscd with "--diable-polkit" if supported
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42711?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2cdf7fcd698c33810ebfbb1db2fa666b9d7dbb3
Gerrit-Change-Number: 42711
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Tue, 28 Apr 2026 10:37:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes