- gerrit-log - lists.osmocom.org

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into iu_helpers

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into iu_helpers ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 07 Aug 2025 06:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

6 days, 10 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move general asn debug options into iu_helpers

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email ) Change subject: move general asn debug options into iu_helpers ...................................................................... Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40844?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: If5175c449af13fe81e89488df71fcd8192091659 Gerrit-Change-Number: 40844 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 06 Aug 2025 19:17:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

6 days, 21 hours

1
0
0 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into iu_helpers

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into iu_helpers ...................................................................... Patch Set 3: -Code-Review (1 comment) Patchset: PS3: should be fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Aug 2025 19:17:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 days, 21 hours

1
0
0 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into iu_helpers

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: move talloc_asn1_ctx into iu_helpers ...................................................................... move talloc_asn1_ctx into iu_helpers In preparation to remove iu_client. Related: OS#5487 Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c --- M src/iu_client.c M src/iu_helpers.c 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/43/40843/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

6 days, 21 hours

1
0
0 0

[XL] Change in osmo-sgsn[master]: Adopt iu_client from osmo-iuh

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Adopt iu_client from osmo-iuh ...................................................................... Adopt iu_client from osmo-iuh iu_client was original written to have an abstraction for Iu. However the MSC stopped using iu_client a long time ago because the abstraption didn't fit well. There was never time to rewrite SGSN to direct talk RANAP using the primitives. Adopt iu_client for now, but with the plan to rewrite it in a similar way as osmo-msc is doing IuCS. Adopted from osmo-iuh: 1631c8ac5a2f ("iu_client: fix linter issues") Related: OS#5487 Change-Id: I9c0d9667ddcb57b52eae34da942acfc1688c1418 --- M include/osmocom/sgsn/Makefile.am A include/osmocom/sgsn/iu_client.h M src/sgsn/Makefile.am A src/sgsn/iu_client.c M tests/gprs_routing_area/Makefile.am M tests/sgsn/Makefile.am 6 files changed, 1,383 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/12/40812/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9c0d9667ddcb57b52eae34da942acfc1688c1418 Gerrit-Change-Number: 40812 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

6 days, 22 hours

1
0
0 0

[XS] Change in osmo-sgsn[master]: iu_client: hide symbols to prevent clashs

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40850?usp=email ) Change subject: iu_client: hide symbols to prevent clashs ...................................................................... iu_client: hide symbols to prevent clashs Change-Id: Ide2f7767b90501790a5d609222185918da66336b --- M src/sgsn/iu_client.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/50/40850/1 diff --git a/src/sgsn/iu_client.c b/src/sgsn/iu_client.c index 0536e8c..1736163 100644 --- a/src/sgsn/iu_client.c +++ b/src/sgsn/iu_client.c @@ -79,11 +79,11 @@ struct llist_head lac_rac_list; }; -void *talloc_iu_ctx; +static void *talloc_iu_ctx; -ranap_iu_recv_cb_t global_iu_recv_cb = NULL; -ranap_iu_event_cb_t global_iu_event_cb = NULL; -int iu_log_subsystem = 0; +static ranap_iu_recv_cb_t global_iu_recv_cb = NULL; +static ranap_iu_event_cb_t global_iu_event_cb = NULL; +static int iu_log_subsystem = 0; #define LOGPIU(level, fmt, args...) \ LOGP(iu_log_subsystem, level, fmt, ## args) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ide2f7767b90501790a5d609222185918da66336b Gerrit-Change-Number: 40850 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

6 days, 22 hours

1
0
0 0

[S] Change in osmo-sgsn[master]: iu_client: start using adopted iu_client

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40851?usp=email ) Change subject: iu_client: start using adopted iu_client ...................................................................... iu_client: start using adopted iu_client Use internal headers. Use renamed event names/types. Change-Id: I7c99ad0498c6f885361562c54fcf0ebdc086616b --- M include/osmocom/sgsn/gprs_ranap.h M include/osmocom/sgsn/sgsn.h M src/sgsn/gprs_ranap.c M src/sgsn/sgsn_main.c M src/sgsn/sgsn_vty.c 5 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/51/40851/1 diff --git a/include/osmocom/sgsn/gprs_ranap.h b/include/osmocom/sgsn/gprs_ranap.h index 68f9115..6dcb63a 100644 --- a/include/osmocom/sgsn/gprs_ranap.h +++ b/include/osmocom/sgsn/gprs_ranap.h @@ -5,7 +5,7 @@ #ifdef BUILD_IU #include <osmocom/ranap/ranap_ies_defs.h> #include <osmocom/ranap/ranap_msg_factory.h> -#include <osmocom/ranap/iu_client.h> +#include <osmocom/sgsn/iu_client.h> struct sgsn_mm_ctx; struct sgsn_pdp_ctx; diff --git a/include/osmocom/sgsn/sgsn.h b/include/osmocom/sgsn/sgsn.h index 9190a61..09eb22c 100644 --- a/include/osmocom/sgsn/sgsn.h +++ b/include/osmocom/sgsn/sgsn.h @@ -17,7 +17,7 @@ #include "../../config.h" #if BUILD_IU -#include <osmocom/ranap/iu_client.h> +#include <osmocom/sgsn/iu_client.h> #endif #include <ares.h> diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index 3252ee6..3e2c891 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -144,14 +144,14 @@ if (!ctx) { LOGIUP(ctx, LOGL_ERROR, "NULL ctx given for IU event %s\n", - ranap_iu_event_type_str(type)); + iu_client_event_type_str(type)); return rc; } mm = sgsn_mm_ctx_by_ue_ctx(ctx); if (!mm) { LOGIUP(ctx, LOGL_NOTICE, "Cannot find mm ctx for IU event %s\n", - ranap_iu_event_type_str(type)); + iu_client_event_type_str(type)); ranap_iu_free_ue(ctx); return rc; } @@ -164,7 +164,7 @@ /* fall thru */ case RANAP_IU_EVENT_LINK_INVALIDATED: /* Clean up ranap_ue_conn_ctx here */ - LOGMMCTXP(LOGL_INFO, mm, "IU release (cause=%s)\n", ranap_iu_event_type_str(type)); + LOGMMCTXP(LOGL_INFO, mm, "IU release (cause=%s)\n", iu_client_event_type_str(type)); rc = osmo_fsm_inst_dispatch(mm->iu.mm_state_fsm, E_PMM_PS_CONN_RELEASE, NULL); if (rc < 0) sgsn_ranap_iu_free(mm); diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c index 320842d..bebb7ae 100644 --- a/src/sgsn/sgsn_main.c +++ b/src/sgsn/sgsn_main.c @@ -77,7 +77,7 @@ #if BUILD_IU #include <osmocom/sigtran/osmo_ss7.h> #include <osmocom/sigtran/protocol/m3ua.h> -#include <osmocom/ranap/iu_client.h> +#include <osmocom/sgsn/iu_client.h> #endif #define _GNU_SOURCE diff --git a/src/sgsn/sgsn_vty.c b/src/sgsn/sgsn_vty.c index 7279167..9721ee1 100644 --- a/src/sgsn/sgsn_vty.c +++ b/src/sgsn/sgsn_vty.c @@ -63,7 +63,7 @@ #include "../../config.h" #ifdef BUILD_IU -#include <osmocom/ranap/iu_client.h> +#include <osmocom/sgsn/iu_client.h> #endif static struct sgsn_config *g_cfg = NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I7c99ad0498c6f885361562c54fcf0ebdc086616b Gerrit-Change-Number: 40851 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

6 days, 22 hours

1
0
0 0

[S] Change in osmo-sgsn[master]: iu_client: rename symbols to prevent clashes with libosmo-ranap

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40849?usp=email ) Change subject: iu_client: rename symbols to prevent clashes with libosmo-ranap ...................................................................... iu_client: rename symbols to prevent clashes with libosmo-ranap While moving the iu_client into osmoSGSN, it's not allowed to have the same global symbols in the library as in osmoSGSN. Change-Id: I2af29b38f110b80f69ef598c8e2700ff323a9d7c --- M include/osmocom/sgsn/iu_client.h M src/sgsn/iu_client.c 2 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/49/40849/1 diff --git a/include/osmocom/sgsn/iu_client.h b/include/osmocom/sgsn/iu_client.h index 7b5c1b4..8277886 100644 --- a/include/osmocom/sgsn/iu_client.h +++ b/include/osmocom/sgsn/iu_client.h @@ -54,10 +54,10 @@ RANAP_IU_EVENT_NEW_AREA, /* Either a new LAC/RAC has been detected */ }; -extern const struct value_string ranap_iu_event_type_names[]; -static inline const char *ranap_iu_event_type_str(enum ranap_iu_event_type e) +extern const struct value_string iu_client_event_type_names[]; +static inline const char *iu_client_event_type_str(enum ranap_iu_event_type e) { - return get_value_string(ranap_iu_event_type_names, e); + return get_value_string(iu_client_event_type_names, e); } /* Implementations of iu_recv_cb_t shall find the ranap_ue_conn_ctx in msg->dst. */ diff --git a/src/sgsn/iu_client.c b/src/sgsn/iu_client.c index 8d20602..0536e8c 100644 --- a/src/sgsn/iu_client.c +++ b/src/sgsn/iu_client.c @@ -102,7 +102,7 @@ /* This rac will be used internally. RAC with 0xff will be rejected */ #define OSMO_RESERVED_RAC 0xff -const struct value_string ranap_iu_event_type_names[] = { +const struct value_string iu_client_event_type_names[] = { OSMO_VALUE_STRING(RANAP_IU_EVENT_RAB_ASSIGN), OSMO_VALUE_STRING(RANAP_IU_EVENT_SECURITY_MODE_COMPLETE), OSMO_VALUE_STRING(RANAP_IU_EVENT_IU_RELEASE), @@ -121,7 +121,7 @@ if (ue_ctx && !ue_ctx->notification) return 0; - LOGPIU(LOGL_DEBUG, "Submit Iu event to upper layer: %s\n", ranap_iu_event_type_str(type)); + LOGPIU(LOGL_DEBUG, "Submit Iu event to upper layer: %s\n", iu_client_event_type_str(type)); return global_iu_event_cb(ue_ctx, type, data); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2af29b38f110b80f69ef598c8e2700ff323a9d7c Gerrit-Change-Number: 40849 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

6 days, 22 hours

1
0
0 0

[XS] Change in osmo-iuh[master]: move talloc_asn1_ctx into tests/test_common.c

by lynxis lazus

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email ) Change subject: move talloc_asn1_ctx into tests/test_common.c ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: Even it looks, talloc_asn1_ctx is only used by tests, it's actually used by libasn1c. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40843?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I79fe6d3e3ac92df70ec536d85d9cf1434252ba8c Gerrit-Change-Number: 40843 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 06 Aug 2025 17:52:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

6 days, 23 hours

1
0
0 0

[S] Change in osmo-iuh[master]: move enum ranap_nsap_addr_enc into ranap_common.h

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: move enum ranap_nsap_addr_enc into ranap_common.h ...................................................................... move enum ranap_nsap_addr_enc into ranap_common.h The enum defines how an IP address in a RAB assignment is encoded. This is part of RANAP. Related: OS#5487 Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 --- M TODO-RELEASE M include/osmocom/ranap/iu_client.h M include/osmocom/ranap/ranap_common.h M src/iu_client_vty.c 4 files changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/45/40845/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ie281bcf6b03d4cc431902cb0f6b0d5f722c80c74 Gerrit-Change-Number: 40845 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

6 days, 23 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log