- gerrit-log - lists.osmocom.org

[XS] Change in osmo-remsim[master]: asn1: ber_decoder: disable stack size check on ctx = NULL
by laforge 27 Apr '26

27 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email ) Change subject: asn1: ber_decoder: disable stack size check on ctx = NULL ...................................................................... asn1: ber_decoder: disable stack size check on ctx = NULL The stack size check is triggering when using asan or when compile with -O1. It is unclear why this is problematic. This is a not a leak. Related: OS#7002 Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 --- M src/rspro/ber_decoder.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve diff --git a/src/rspro/ber_decoder.c b/src/rspro/ber_decoder.c index 0f99400..1e150ac 100644 --- a/src/rspro/ber_decoder.c +++ b/src/rspro/ber_decoder.c @@ -44,7 +44,9 @@ } else { /* If context is not given, be security-conscious anyway */ memset(&s_codec_ctx, 0, sizeof(s_codec_ctx)); - s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX; + /* TODO: disable stack check until the root cause can be debugged. See OS#7002 + s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX; */ + s_codec_ctx.max_stack_size = 0; opt_codec_ctx = &s_codec_ctx; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 Gerrit-Change-Number: 42706 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asn_debug = 0
by laforge 27 Apr '26

27 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asn_debug = 0 ...................................................................... Remove unconditional assignment of asn_debug = 0 It is now the default and there is no code to set it. Remove the assignment Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a --- M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 3 files changed, 0 insertions(+), 5 deletions(-) Approvals: laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 7698541..9ef05a4 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -82,8 +82,6 @@ log_set_print_tid(osmo_stderr_target, 1); log_enable_multithread(); - asn_debug = 0; - /* initialize members of 'bankd' */ bankd->slotmaps = slotmap_init(bankd); INIT_LLIST_HEAD(&bankd->workers); diff --git a/src/bankd/main.c b/src/bankd/main.c index 54aac61..21f3a50 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -37,7 +37,6 @@ int main(int argc, char **argv) { - asn_debug = 0; g_ctx = talloc_named_const(NULL, 0, "main"); talloc_asn1_ctx = talloc_named_const(g_ctx, 0, "asn1_context"); card_readers_probe(g_ctx); diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index f9af5d0..ff89478 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -216,7 +216,5 @@ exit(1); } - asn_debug = 0; - client_user_main(g_client); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-remsim[master]: asn1: ber_decoder: disable stack size check on ctx = NULL
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email ) Change subject: asn1: ber_decoder: disable stack size check on ctx = NULL ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 Gerrit-Change-Number: 42706 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:24:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asn_debug = 0
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asn_debug = 0 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-remsim[master]: asn1: move asn_debug into librspro
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email ) Change subject: asn1: move asn_debug into librspro ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce Gerrit-Change-Number: 42707 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:24:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: asn1: ber_decoder: disable stack size check on ctx = NULL
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email ) Change subject: asn1: ber_decoder: disable stack size check on ctx = NULL ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 Gerrit-Change-Number: 42706 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:23:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by laforge 27 Apr '26

27 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... rspro_util: asn1 decode: fix memleak when decoding fails Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 --- M src/rspro_util.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified jolly: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/rspro_util.c b/src/rspro_util.c index 23bb839..b4b473e 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -86,6 +86,8 @@ LOGP(DRSPRO, LOGL_DEBUG, "decoding %s\n", msgb_hexdump(msg)); rval = ber_decode(NULL, &asn_DEF_RsproPDU, (void **) &pdu, msgb_l2(msg), msgb_l2len(msg)); if (rval.code != RC_OK) { + if (pdu) + ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); LOGP(DRSPRO, LOGL_ERROR, "Failed to decode: %d. Consumed %zu of %u bytes\n", rval.code, rval.consumed, msgb_length(msg)); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:22:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: jenkins.sh: pin libosmocore version to current version v1.14
by laforge 27 Apr '26

27 Apr '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email ) Change subject: jenkins.sh: pin libosmocore version to current version v1.14 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I678957099348e067d62a4abd04cbdac822463cf4 Gerrit-Change-Number: 42676 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 23:22:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by laforge 27 Apr '26

27 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email ) Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Fix: Prevent bankd from exiting upon SIGPIPE If a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf --- M src/bankd/bankd_main.c 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index fc8f480..5d46f97 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -55,6 +55,7 @@ #define SIGMAPADD SIGRTMIN+2 static void handle_sig_usr1(int sig); +static void handle_sig_pipe(int sig); static void handle_sig_mapdel(int sig); static void handle_sig_mapadd(int sig); @@ -439,6 +440,7 @@ g_bankd->main = pthread_self(); signal(SIGMAPDEL, handle_sig_mapdel); signal(SIGMAPADD, handle_sig_mapadd); + signal(SIGPIPE, handle_sig_pipe); signal(SIGUSR1, handle_sig_usr1); LOGP(DMAIN, LOGL_INFO, "Reading PCSC slots...\n"); @@ -557,6 +559,13 @@ /* do nothing */ } +/* signal handler for receiving SIGPIPE from worker thread */ +static void handle_sig_pipe(int sig) +{ + /* DO NOT LOG ANYTHING HERE, IT WILL DEADLOCK WITH THE osmo_log_tgt_mutex */ + /* do nothing */ +} + static void handle_sig_usr1(int sig) { OSMO_ASSERT(sig == SIGUSR1); -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log