- gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: vty: make CPU scheduling optional based on platform support
by Timur Davydov 27 Apr '26

27 Apr '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email ) Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/42653/comment/8a819372_fb9e9c00?… : PS1, Line 15: Also change osmo_cpu_sched_vty_init() to return int. > Ok, then please fix it in a previous separate patch, it's unrelated to making the implementation con […] Done, I moved this fix into a separate preceding patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Apr 2026 20:47:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in libosmocore[master]: vty: fix osmo_cpu_sched_vty_init() prototype
by Timur Davydov 27 Apr '26

27 Apr '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email ) Change subject: vty: fix osmo_cpu_sched_vty_init() prototype ...................................................................... vty: fix osmo_cpu_sched_vty_init() prototype Change return type of osmo_cpu_sched_vty_init() from void to int to match its implementation. This fixes a prototype mismatch rejected by stricter compilers (e.g. Emscripten). Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 --- M include/osmocom/vty/cpu_sched_vty.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/42709/1 diff --git a/include/osmocom/vty/cpu_sched_vty.h b/include/osmocom/vty/cpu_sched_vty.h index 171f168..b04ee34 100644 --- a/include/osmocom/vty/cpu_sched_vty.h +++ b/include/osmocom/vty/cpu_sched_vty.h @@ -31,7 +31,7 @@ * \file cpu_sched_vty.h */ -void osmo_cpu_sched_vty_init(void *tall_ctx); +int osmo_cpu_sched_vty_init(void *tall_ctx); int osmo_cpu_sched_vty_apply_localthread(void); /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia86e8063178ad82de098c2ff693cfbcd7e9f2192 Gerrit-Change-Number: 42709 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in libosmocore[master]: vty: make CPU scheduling optional based on platform support
by Timur Davydov 27 Apr '26

27 Apr '26

Attention is currently required from: Timur Davydov, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: vty: make CPU scheduling optional based on platform support ...................................................................... vty: make CPU scheduling optional based on platform support Add configure checks for sched_* APIs and guard their usage in cpu_sched_vty with HAVE_SCHED_* macros. If scheduler functions are not available, return -ENOTSUP instead of failing at build time. This improves portability on platforms lacking full sched support (e.g. non-Linux or restricted environments). Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 --- M configure.ac M src/vty/cpu_sched_vty.c 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/53/42653/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic5b7e39fac16531d370cb81f769ba87fef18cb81 Gerrit-Change-Number: 42653 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 16:24:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Test TCAP routing with a different called address answering
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email ) Change subject: stp: Test TCAP routing with a different called address answering ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/b12ab977_e549… : PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1) > I think using `-1` is fine here. […] numberings for all PC, routes etc. is already quite complex in these testsuites, adding more magic numbers like -1 here just makes it even harder. This is clearly imho an optional parameter, and making it omit seems like the more obvious way to specify it. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb Gerrit-Change-Number: 42682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 16:18:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by jolly, Verified+1 by Jenkins Builder Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... rspro_util: asn1 decode: fix memleak when decoding fails Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 --- M src/rspro_util.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/05/42705/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: jenkins.sh: pin libosmocore version to current version v1.14
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: Hoernchen, laforge. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email to look at the new patch set (#2). Change subject: jenkins.sh: pin libosmocore version to current version v1.14 ...................................................................... jenkins.sh: pin libosmocore version to current version v1.14 osmo-ccid-firmware isn't using much of libosmocore. Use a specific version instead of the current master. This also improve reproducible builds, because the jenkins would otherwise use the current master commit to build it. Related: OS#6987 Change-Id: I678957099348e067d62a4abd04cbdac822463cf4 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/76/42676/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I678957099348e067d62a4abd04cbdac822463cf4 Gerrit-Change-Number: 42676 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: (1 comment) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/0b5f1f93_7611eb8f?… : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); > Acknowledged For another commit: I would move the ownership into the function and not only for the success cases. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 16:08:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge, lynxis lazus. jolly has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: (1 comment) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/4091f75b_50654fbe?… : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); > No this is different, as it returns NULL. Ack. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:59:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... Patch Set 1: (2 comments) File src/rspro_util.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/a22eedfa_54138a91?… : PS1, Line 70: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); > You decided to free pdu here in case of encoding failure. […] Acknowledged https://gerrit.osmocom.org/c/osmo-remsim/+/42705/comment/be903414_8bb96dc5?… : PS1, Line 92: ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); > Same issue here. This casues a double free. No this is different, as it returns NULL. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log