- gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: tests/vty: Run ss7_asp_test.vty
by fixeria 09 Dec '25

09 Dec '25

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email ) Change subject: tests/vty: Run ss7_asp_test.vty ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb0c589e6bdf692fa82361deedeb82169c09270 Gerrit-Change-Number: 41635 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:50:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: tcap: Fix wrong msgb ownership documentation
by pespin 09 Dec '25

09 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41636?usp=email ) Change subject: cosmetic: tcap: Fix wrong msgb ownership documentation ...................................................................... cosmetic: tcap: Fix wrong msgb ownership documentation Caller of the function, ipa_rx_msg(), already specifies the ownesrship is kept by its callers, ss7_asp_ipa_srv_conn_rx_cb() and ipa_cli_read_cb(). Change-Id: Idfda2c2eda8a8490d8306a364eccf96ebc15b7a4 --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index c5016cc..28d8175 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -701,7 +701,7 @@ /** Entrypoint for IPA TCAP Routing messages, parses and handles those * * @param asp - * @param msg the message buffer. Callee takes ownership! + * @param msg the message buffer. It is kept owned by the caller. * @return 0 on success */ int ipa_rx_msg_osmo_ext_tcap_routing(struct osmo_ss7_asp *asp, struct msgb *msg) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41636?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idfda2c2eda8a8490d8306a364eccf96ebc15b7a4 Gerrit-Change-Number: 41636 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: vty: Forbid deleting ASP currently configured in an AS
by pespin 09 Dec '25

09 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41634?usp=email ) Change subject: vty: Forbid deleting ASP currently configured in an AS ...................................................................... vty: Forbid deleting ASP currently configured in an AS Make the user first remove the ASP from the AS manually. Change-Id: I3eed65b4a33b786e7dde6e86774c56655523aea2 --- M src/ss7_asp_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 16 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_asp_vty.c b/src/ss7_asp_vty.c index 49177a1..d54eb01 100644 --- a/src/ss7_asp_vty.c +++ b/src/ss7_asp_vty.c @@ -232,12 +232,23 @@ struct osmo_ss7_instance *inst = vty->index; const char *name = argv[0]; struct osmo_ss7_asp *asp; + struct osmo_ss7_as *as; asp = osmo_ss7_asp_find_by_name(inst, name); if (!asp) { vty_out(vty, "No ASP named '%s' found%s", name, VTY_NEWLINE); return CMD_WARNING; } + + llist_for_each_entry(as, &inst->as_list, list) { + if (osmo_ss7_as_has_asp(as, asp)) { + vty_out(vty, "%% ASP '%s' currently configured in AS '%s'. " + "You must first remove the ASP from the AS configuration%s", + name, as->cfg.name, VTY_NEWLINE); + return CMD_WARNING; + } + } + osmo_ss7_asp_destroy(asp); return CMD_SUCCESS; } diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index bf2db65..1114a2c 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -657,6 +657,11 @@ No ASP named 'unknown-asp' found OsmoSTP(config-cs7)# no asp my-asp +% ASP 'my-asp' currently configured in AS 'my-ass'. You must first remove the ASP from the AS configuration +OsmoSTP(config-cs7)# as my-ass m3ua +OsmoSTP(config-cs7-as)# no asp my-asp +OsmoSTP(config-cs7-as)# exit +OsmoSTP(config-cs7)# no asp my-asp OsmoSTP(config-cs7)# do show cs7 instance 0 asp ASP Name AS Name State Type Role SCTP Role Local Addresses Remote Addresses -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eed65b4a33b786e7dde6e86774c56655523aea2 Gerrit-Change-Number: 41634 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Forbid tcap-routing in ASP mode
by pespin 09 Dec '25

09 Dec '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email ) Change subject: tcap: Forbid tcap-routing in ASP mode ...................................................................... tcap: Forbid tcap-routing in ASP mode The tcap-routing feature is only expected to be used so far by osmo-stp, which runs in SG role. Disable it for programs running under ASP role. Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34 --- M src/ss7_as_vty.c M src/tcap_as_loadshare.c 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index f7f3cfe..92e16bb 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -709,8 +709,10 @@ install_lib_element(L_CS7_AS_NODE, &as_no_traf_mode_cmd); install_lib_element(L_CS7_AS_NODE, &as_sls_shift_cmd); #ifdef WITH_TCAP_LOADSHARING - install_lib_element(L_CS7_AS_NODE, &as_tcap_routing_cmd); - install_lib_element(L_CS7_AS_NODE, &as_no_tcap_routing_cmd); + if (cs7_role == CS7_ROLE_SG) { + install_lib_element(L_CS7_AS_NODE, &as_tcap_routing_cmd); + install_lib_element(L_CS7_AS_NODE, &as_no_tcap_routing_cmd); + } #endif /* WITH_TCAP_LOADSHARING */ install_lib_element(L_CS7_AS_NODE, &as_bindingtable_reset_cmd); install_lib_element(L_CS7_AS_NODE, &as_recov_tout_cmd); diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 28d8175..623bd3b 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -46,6 +46,7 @@ #include "sccp_internal.h" #include "ss7_asp.h" #include "ss7_internal.h" +#include "ss7_vty.h" #include "tcap_as_loadshare.h" #include "tcap_trans_tracking.h" #include "xua_internal.h" @@ -707,10 +708,18 @@ int ipa_rx_msg_osmo_ext_tcap_routing(struct osmo_ss7_asp *asp, struct msgb *msg) { int rc = 0; - struct osmo_ss7_as *as = ipa_find_as_for_asp(asp); + struct osmo_ss7_as *as; struct ipa_tcap_routing_hdr *hdr; enum ipa_tcap_routing_msg_types routing_msg; + if (cs7_role != CS7_ROLE_SG) { + LOGPASP(asp, DLTCAP, LOGL_ERROR, + "Rx unexpected OSMO IPA EXT TCAP ROUTING msg in role != CS7_ROLE_SG!\n"); + rc = -ENOENT; + goto out; + } + + as = ipa_find_as_for_asp(asp); if (!as) { LOGPASP(asp, DLTCAP, LOGL_ERROR, "Rx message for IPA ASP without AS?!\n"); rc = -ENOENT; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34 Gerrit-Change-Number: 41637 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tests/vty: Run ss7_asp_test.vty
by osmith 09 Dec '25

09 Dec '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email ) Change subject: tests/vty: Run ss7_asp_test.vty ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > looks like the tests need to be adjusted more to have it pass? […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb0c589e6bdf692fa82361deedeb82169c09270 Gerrit-Change-Number: 41635 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tests/vty: Run ss7_asp_test.vty
by osmith 09 Dec '25

09 Dec '25

Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email ) Change subject: tests/vty: Run ss7_asp_test.vty ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41635?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibcb0c589e6bdf692fa82361deedeb82169c09270 Gerrit-Change-Number: 41635 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Forbid tcap-routing in ASP mode
by fixeria 09 Dec '25

09 Dec '25

Attention is currently required from: daniel, lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email ) Change subject: tcap: Forbid tcap-routing in ASP mode ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34 Gerrit-Change-Number: 41637 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: vty: Forbid deleting ASP currently configured in an AS
by fixeria 09 Dec '25

09 Dec '25

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41634?usp=email ) Change subject: vty: Forbid deleting ASP currently configured in an AS ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41634?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3eed65b4a33b786e7dde6e86774c56655523aea2 Gerrit-Change-Number: 41634 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:48:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Forbid tcap-routing in ASP mode
by osmith 09 Dec '25

09 Dec '25

Attention is currently required from: daniel, lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email ) Change subject: tcap: Forbid tcap-routing in ASP mode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34 Gerrit-Change-Number: 41637 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:47:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap: Forbid tcap-routing in ASP mode
by fixeria 09 Dec '25

09 Dec '25

Attention is currently required from: daniel, lynxis lazus, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email ) Change subject: tcap: Forbid tcap-routing in ASP mode ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41637?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4ccfa9ae06c756dd6626045a8e9f14ae79bcfa34 Gerrit-Change-Number: 41637 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 09 Dec 2025 12:47:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log