- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: stp: Test TCAP routing with a different called address answering
by fixeria 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email ) Change subject: stp: Test TCAP routing with a different called address answering ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/218548b0_d4f1… : PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1) > Can we use template (omit) alt_asp_idx := omit here please? […] I think using `-1` is fine here. Using a template here brings unnecessary complexity like having to use `isvalue()` and `valueof()`. But I am fine with either approach. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb Gerrit-Change-Number: 42682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Make TCAP tests more realistic
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email ) Change subject: stp: Make TCAP tests more realistic ...................................................................... Patch Set 1: (1 comment) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683/comment/4fa7e710_59be… : PS1, Line 341: /* TCAP Being: O -> T */ Begin -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia807c2b26e5188b700365650311cabc0f9095674 Gerrit-Change-Number: 42683 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:13:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Test TCAP routing with a different called address answering
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email ) Change subject: stp: Test TCAP routing with a different called address answering ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: +1 from me once stuff mentioned here (and expected-results-xml) are fixed. File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/0b7c1d2d_9462… : PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1) Can we use template (omit) alt_asp_idx := omit here please? And then: if (isvalue(alt_asp_idx)) ... https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/e446ab9f_c6d6… : PS1, Line 385: The answer is sent from a different point code than the request dpc */ "is sent" here is a bit ambiguous. Sent from who to where? I'd better describe it: "is sent by the STP peer to the STP". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb Gerrit-Change-Number: 42682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:10:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-remsim[master]: Fix: Prevent bankd from exiting upon SIGPIPE
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: fixeria, jolly, laforge, lynxis lazus. Hello Jenkins Builder, fixeria, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: Fix: Prevent bankd from exiting upon SIGPIPE ...................................................................... Fix: Prevent bankd from exiting upon SIGPIPE If a client disconnects from a worker thread while the worker is responding to a to a request from that client, the socket is closed and SIGPIPE is sent to the worker, causing the application to exit. To prevent this, all workers have a dummy handler to prevent this. Now the worker can handle the closing of the socket. Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf --- M src/bankd/bankd_main.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/65/42665/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I13d6e9da48d12f93c00bd2d021789bde71aca7cf Gerrit-Change-Number: 42665 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-abis[master]: lapd_sap_stop(): fix use of uninitialized stack memory
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: falconia, laforge. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email ) Change subject: lapd_sap_stop(): fix use of uninitialized stack memory ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ic1469698ee8edf9b6fb55df8f79cc062be711f61 Gerrit-Change-Number: 42680 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:04:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: cosmetic: fix white space in lapd_sap_{start,stop}()
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/42679?usp=email ) Change subject: cosmetic: fix white space in lapd_sap_{start,stop}() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/42679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iadf8629bc3bdf18260b1b83290ce95483d8aac2c Gerrit-Change-Number: 42679 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:02:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Clarify name of tcap asp selection function
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email ) Change subject: tcap_as_loadshare: Clarify name of tcap asp selection function ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42687?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I327ad282d2689be2bcf7d3da23026717923c9325 Gerrit-Change-Number: 42687 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email ) Change subject: tcap_as_loadshare: Route msg based on TCAP route if cache lookup fails ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686/comment/bd062c24_21b4a… : PS1, Line 551: if (!asp) { > You should also create the session tracking entry otherwise you will always look it up. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2fd9068be8a0a512b17c8bd2365aa87c266e5669 Gerrit-Change-Number: 42686 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Apr 2026 15:00:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email ) Change subject: tcap_as_loadshare: Use tcap_trans_track_begin instead of *_entry_create ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: This may also explain some "mem leak" spotted somewhere when using tcap iirc. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42685?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icbaab976ed8207843129291494176679db574304 Gerrit-Change-Number: 42685 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:59:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: Don't fill in PC from M3UA
by pespin 27 Apr '26

27 Apr '26

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email ) Change subject: tcap_as_loadshare: Don't fill in PC from M3UA ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Ack, description needs to be improved to explain the scenario. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42684?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4f99fc87cd33ee3f2aad531710cc39a9b9c7e6d9 Gerrit-Change-Number: 42684 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 27 Apr 2026 14:57:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log