Attention is currently required from: Timur Davydov.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email )
Change subject: trx, bts: add optional WebSDR backend (callback-based transport)
......................................................................
Patch Set 5:
(1 comment)
File src/osmo-bts-trx/osmo-bts-trx-websdr.c:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-bts/+/42703/comment/5d4bf6e2_d1bbcfd3?usp… :
PS5, Line 90: const char *params[] = {
char * array declaration might be better as static const
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9
Gerrit-Change-Number: 42703
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email )
Change subject: abis: add helper to update BTS identity
......................................................................
Patch Set 3:
(1 comment)
File src/common/abis.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42699/comment/7cf14d10_70b475e6?usp… :
PS2, Line 555: abis_update
> This symbol name is too generic. Update what? […]
Ack, agreed. Renamed to abis_update_bts_info().
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibafd66a1e1dc42ad0063c412087bee10d212fe33
Gerrit-Change-Number: 42699
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email )
Change subject: trx: factor out clock indication handling into helper
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/42693/comment/ddafaf1d_e34f60ab?usp… :
PS2, Line 12: This separates core FN processing from socket-specific code
: an
> I guess the idea here is that this new function will be called from somewhere else, bypassing the UD […]
Yes, exactly.
The intention is to make the FN/clock indication handling reusable from a non-socket clock source. In the WebSDR/WASM build, the clock indication can be delivered directly from the JS/WebUSB side via an in-memory callback, without going through the UDP socket path.
So this patch only factors out the common handling from `trx_clk_read_cb()`. The existing UDP behavior remains unchanged, while a later patch can call the same helper from the WebSDR-specific clock path.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0e6b3e25da14ada4d0ef86fd4c4e6bbc12e447d2
Gerrit-Change-Number: 42693
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:38:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email )
Change subject: trx: factor out FN timer processing into common helper
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42692/comment/fd8facd9_33e3e4e7?usp… :
PS2, Line 476: reason
> Well, there is a functional change here: `reason` is always NULL now. […]
Good catch, you are right.
I will keep the existing behavior and pass `&reason` to `trx_fn_timer_process()`
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia28cce57afb3dc97c8655e855ebd5ace7e096648
Gerrit-Change-Number: 42692
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:38:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email )
Change subject: build: make timerfd usage optional
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bts-trx/scheduler_trx.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42689/comment/519db8d6_29fc2ce5?usp… :
PS2, Line 31: #ifdef HAVE_SYS_TIMERFD_H
: #include <sys/timerfd.h>
: #e
> I believe this should be done after including `btsconfig. […]
Yes, it makes sense. I moved this check after including btsconfig.h, so it follows the same pattern as the surrounding code
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: build: make timerfd usage optional
......................................................................
build: make timerfd usage optional
Check for sys/timerfd.h in configure and guard its usage
with HAVE_SYS_TIMERFD_H.
This avoids build failures on platforms where timerfd is
not available.
Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
---
M configure.ac
M src/osmo-bts-trx/scheduler_trx.c
2 files changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/42689/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42689?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id5a700c865f984e8f99199a1e365bb7f1462030a
Gerrit-Change-Number: 42689
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: trx: factor out clock indication handling into helper
......................................................................
trx: factor out clock indication handling into helper
Extract clock indication handling logic into trx_clk_phy()
and reuse it from trx_clk_read_cb()
This separates core FN processing from socket-specific code
and prepares for alternative clock sources (e.g. non-UDP /
in-memory callbacks used in WebSDR/WASM builds).
No functional changes intended
Change-Id: I0e6b3e25da14ada4d0ef86fd4c4e6bbc12e447d2
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 22 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/93/42693/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42693?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I0e6b3e25da14ada4d0ef86fd4c4e6bbc12e447d2
Gerrit-Change-Number: 42693
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov, fixeria.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by fixeria, Verified+1 by Jenkins Builder
Change subject: trx: factor out FN timer processing into common helper
......................................................................
trx: factor out FN timer processing into common helper
Extract core FN timer handling logic into trx_fn_timer_process()
to decouple it from timerfd-specific code.
This allows reusing the same scheduling logic for alternative
timer backends (e.g. WebSDR) while keeping timerfd integration
as a thin wrapper.
No functional changes intended.
Change-Id: Ia28cce57afb3dc97c8655e855ebd5ace7e096648
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 38 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/92/42692/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42692?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia28cce57afb3dc97c8655e855ebd5ace7e096648
Gerrit-Change-Number: 42692
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: abis: add helper to update BTS identity
......................................................................
abis: add helper to update BTS identity
Introduce abis_update_bts_info() to update site_id and bts_id in
bts_dev_info at runtime
This allows adjusting BTS identity after initialization,
e.g. from external control interfaces
Change-Id: Ibafd66a1e1dc42ad0063c412087bee10d212fe33
---
M include/osmo-bts/abis.h
M src/common/abis.c
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/99/42699/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42699?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibafd66a1e1dc42ad0063c412087bee10d212fe33
Gerrit-Change-Number: 42699
Gerrit-PatchSet: 3
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: trx, bts: add optional WebSDR backend (callback-based transport)
......................................................................
trx, bts: add optional WebSDR backend (callback-based transport)
Introduce WebSDR backend enabled via ENABLE_WEBSDR,
adding an alternative callback-based transport alongside
existing socket-based TRX/OSMUX I/O
Implement:
- TRX control via osmotrxlib_process_command()
- TRXD data via apitrx_tx_call()/trx_data_read()
- clock handling via apibts_clock_ind() and external timers
- Osmux integration via ws_osmux_* helpers
Adapt scheduler to support API-based burst submission and
external timer callbacks in WebSDR mode
Disable signal handling, stats and socket I/O when building
with ENABLE_WEBSDR
Add WebSDR API entrypoint, Emscripten build target and
example configuration
Enables running BTS/TRX stack in WebAssembly environments
Change-Id: Idebd588f33afd85021813ad5821391781db683a9
---
M .gitignore
A doc/examples/trx/osmo-bts-trx-websdr.cfg
M src/common/main.c
M src/common/osmux.c
M src/osmo-bts-trx/Makefile.am
M src/osmo-bts-trx/main.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.c
A src/osmo-bts-trx/osmo-bts-trx-websdr.h
M src/osmo-bts-trx/scheduler_trx.c
M src/osmo-bts-trx/trx_if.c
M src/osmo-bts-trx/trx_vty.c
11 files changed, 715 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/42703/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9
Gerrit-Change-Number: 42703
Gerrit-PatchSet: 5
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>