- gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/NAS_EPS_Templates: Add Emergency Number List templates
by jolly 02 Oct '25

02 Oct '25

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41203?usp=email ) Change subject: library/NAS_EPS_Templates: Add Emergency Number List templates ...................................................................... library/NAS_EPS_Templates: Add Emergency Number List templates Change-Id: Ied3d8f56f84302617edc1cf3017a2866c6dbbd96 --- M library/NAS_EPS_Templates.ttcn 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/41203/1 diff --git a/library/NAS_EPS_Templates.ttcn b/library/NAS_EPS_Templates.ttcn index 706bcf2..20b2913 100644 --- a/library/NAS_EPS_Templates.ttcn +++ b/library/NAS_EPS_Templates.ttcn @@ -274,6 +274,38 @@ uENetworkCapabilityLV := ts_UENetworkCapabilityLV(ue_net_cap) } +/* 9.9.3.37 Emergency Number List */ +template (value) EmergencyNumber +ts_EmergencyNumber(template (value) LIN1 lengthOfEmergencyNumber, + template (value) BIT5 emergencyServiceCategoryValue, + template (value) octetstring emergencyNumberDigits) := { + lengthOfEmergencyNumber := lengthOfEmergencyNumber, + emergencyServiceCategoryValue:= emergencyServiceCategoryValue, + spare := '000'B, + emergencyNumberDigits := emergencyNumberDigits +} +template (value) EmergencyNumberListTLV +ts_EmergencyNumberListTLV(template (value) EmergencyNumberList list) := { + elementIdentifier := '34'O, + lengthIndicator := 0, /* overwritten */ + emergencyNumberList := list +} +template (present) EmergencyNumber +tr_EmergencyNumber(template (present) LIN1 lengthOfEmergencyNumber := ?, + template (present) BIT5 emergencyServiceCategoryValue := ?, + template (present) octetstring emergencyNumberDigits := ?) := { + lengthOfEmergencyNumber := lengthOfEmergencyNumber, + emergencyServiceCategoryValue:= emergencyServiceCategoryValue, + spare := ?, + emergencyNumberDigits := emergencyNumberDigits +} +template (present) EmergencyNumberListTLV +tr_EmergencyNumberListTLV(template (present) EmergencyNumberList list := ?) := { + elementIdentifier := '34'O, + lengthIndicator := ?, + emergencyNumberList := list +} + /* 9.9.3.45 GUTI Type */ const BIT1 GUTI_TYPE_NATIVE := '0'B; const BIT1 GUTI_TYPE_MAPPED := '1'B; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ied3d8f56f84302617edc1cf3017a2866c6dbbd96 Gerrit-Change-Number: 41203 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME-Tests: Add test for emergency bearer setup
by jolly 02 Oct '25

02 Oct '25

Attention is currently required from: jolly. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: MME-Tests: Add test for emergency bearer setup ...................................................................... MME-Tests: Add test for emergency bearer setup When the UE makes an emergency call, it requests emergency bearer to be established. The configured emergency bearer will be established. The test checks if the emergency bearer is established and the APN name matches the configured APN name. Related: SYS#7635 Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 --- M mme/ConnHdlr.ttcn M mme/MME_Tests_emergency.ttcn M mme/expected-results.xml 3 files changed, 83 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/41189/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 Gerrit-Change-Number: 41189 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[S] Change in osmo-ci[master]: jobs/gerrit,master: use debian-trixie-build
by fixeria 02 Oct '25

02 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41202?usp=email ) Change subject: jobs/gerrit,master: use debian-trixie-build ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id65b7f9045e13bed38c1de514cdd537fac88f60f Gerrit-Change-Number: 41202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:14:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: scripts/osmo-ci-docker-rebuild: switch to trixie
by fixeria 02 Oct '25

02 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41201?usp=email ) Change subject: scripts/osmo-ci-docker-rebuild: switch to trixie ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41201?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1497f14e57f9d7b0867368b923c8f8919c72cd76 Gerrit-Change-Number: 41201 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:12:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds: rtl-sdr: add jenkins-notifications
by fixeria 02 Oct '25

02 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41200?usp=email ) Change subject: jobs/master-builds: rtl-sdr: add jenkins-notifications ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9b783181a467a76bc2d11149baf433581c91bd06 Gerrit-Change-Number: 41200 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:12:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: Fix build with debian 13
by fixeria 02 Oct '25

02 Oct '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email ) Change subject: Fix build with debian 13 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0831e448692713c488c0590a86bdc99b37160f47 Gerrit-Change-Number: 41197 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:11:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: MME-Tests: Add test for emergency bearer setup
by fixeria 02 Oct '25

02 Oct '25

Attention is currently required from: jolly. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email ) Change subject: MME-Tests: Add test for emergency bearer setup ...................................................................... Patch Set 2: (1 comment) File mme/ConnHdlr.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189/comment/455f59ac_7cad… : PS2, Line 955: .start > You're re-using a timer that may already be running. […] Nevermind. According to ETSI ES 201 873-1 V4.16.1, section 23.2 The Start timer operation: ... "The start operation may be applied to a running timer, in which case the timer is stopped and re-started". -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2a81defc96bcebdf1a4ec765278ca502800cbe46 Gerrit-Change-Number: 41189 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Thu, 02 Oct 2025 13:09:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XL] Change in osmo-ttcn3-hacks[master]: smdpp: es9p testsuite
by dexter 02 Oct '25

02 Oct '25

Attention is currently required from: Hoernchen, laforge. dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email ) Change subject: smdpp: es9p testsuite ...................................................................... Patch Set 7: Verified+1 (1 comment) Patchset: PS7: Compilation is now fine - thanks for fixing this! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3ba163d9155a3b019214dbccc3c8031dfd7deb6b Gerrit-Change-Number: 41119 Gerrit-PatchSet: 7 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Oct 2025 12:41:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-msc[master]: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of ...
by lynxis lazus 02 Oct '25

02 Oct '25

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email ) Change subject: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of umts_aka ...................................................................... vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of umts_aka Simplifies code when re-transmitting Ciphering Mode Command when using it also for PS. Change-Id: Ia556bc33d1cf30ef17fed2828908aa0b6b6dc8be --- M include/osmocom/vlr/vlr.h M src/libvlr/vlr.c M src/libvlr/vlr_access_req_fsm.c M src/libvlr/vlr_lu_fsm.c 4 files changed, 24 insertions(+), 16 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/vlr/vlr.h b/include/osmocom/vlr/vlr.h index b1994d0..9b49ff2 100644 --- a/include/osmocom/vlr/vlr.h +++ b/include/osmocom/vlr/vlr.h @@ -488,7 +488,7 @@ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool umts_aka, + enum vlr_subscr_security_context sec_ctx, bool retrieve_imeisv); bool vlr_use_umts_aka(struct osmo_auth_vector *vec, bool is_r99); diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index c7b7e63..c9055dc 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -1664,19 +1664,35 @@ /* Internal evaluation of requested ciphering mode. * Send set_ciph_mode() to MSC depending on the ciph_mode argument. - * \param[in] vlr VLR instance. - * \param[in] fi Calling FSM instance, for logging. - * \param[in] msc_conn_ref MSC conn to send to. - * \param[in] ciph_mode Ciphering config, to decide whether to do ciphering. + * \param[in] vlr VLR instance. + * \param[in] fi Calling FSM instance, for logging. + * \param[in] msc_conn_ref MSC conn to send to. + * \param[in] sec_ctx the security context to be established. + * \param[in] retrieve_imeisv request the IMEI in the ciphering mode command. * \returns 0 if no ciphering is needed or message was sent successfully, * or a negative value if ciph_mode is invalid or sending failed. */ int vlr_set_ciph_mode(struct vlr_instance *vlr, struct osmo_fsm_inst *fi, void *msc_conn_ref, - bool umts_aka, + enum vlr_subscr_security_context sec_ctx, bool retrieve_imeisv) { + bool umts_aka; + + switch (sec_ctx) { + case VLR_SEC_CTX_GSM: + umts_aka = false; + break; + case VLR_SEC_CTX_UMTS: + umts_aka = true; + break; + case VLR_SEC_CTX_NONE: + return 0; + default: + return -EINVAL; + } + LOGPFSML(fi, LOGL_DEBUG, "Set Ciphering Mode\n"); return vlr->ops.set_ciph_mode(msc_conn_ref, umts_aka, retrieve_imeisv); } diff --git a/src/libvlr/vlr_access_req_fsm.c b/src/libvlr/vlr_access_req_fsm.c index 516f53d..91ff06e 100644 --- a/src/libvlr/vlr_access_req_fsm.c +++ b/src/libvlr/vlr_access_req_fsm.c @@ -297,7 +297,6 @@ { struct proc_arq_priv *par = fi->priv; struct vlr_subscr *vsub = par->vsub; - bool umts_aka; LOGPFSM(fi, "%s()\n", __func__); @@ -311,10 +310,7 @@ switch (vsub->sec_ctx) { case VLR_SEC_CTX_GSM: - umts_aka = false; - break; case VLR_SEC_CTX_UMTS: - umts_aka = true; break; default: LOGPFSML(fi, LOGL_ERROR, "Cannot start ciphering, security context is not established\n"); @@ -323,7 +319,7 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, par->msc_conn_ref, - umts_aka, + vsub->sec_ctx, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, "Failed to send Ciphering Mode Command\n"); diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c index 5b2e96b..ec459a1 100644 --- a/src/libvlr/vlr_lu_fsm.c +++ b/src/libvlr/vlr_lu_fsm.c @@ -892,7 +892,6 @@ { struct lu_fsm_priv *lfp = lu_fsm_fi_priv(fi); struct vlr_subscr *vsub = lfp->vsub; - bool umts_aka; LOGPFSM(fi, "%s()\n", __func__); @@ -914,10 +913,7 @@ switch (vsub->sec_ctx) { case VLR_SEC_CTX_GSM: - umts_aka = false; - break; case VLR_SEC_CTX_UMTS: - umts_aka = true; break; default: LOGPFSML(fi, LOGL_ERROR, "Cannot start ciphering, security context is not established\n"); @@ -926,7 +922,7 @@ } if (vlr_set_ciph_mode(vsub->vlr, fi, lfp->msc_conn_ref, - umts_aka, + vsub->sec_ctx, vsub->vlr->cfg.retrieve_imeisv_ciphered)) { LOGPFSML(fi, LOGL_ERROR, "Failed to send Ciphering Mode Command\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia556bc33d1cf30ef17fed2828908aa0b6b6dc8be Gerrit-Change-Number: 41168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of ...
by lynxis lazus 02 Oct '25

02 Oct '25

Attention is currently required from: neels. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email ) Change subject: vlr: vlr_set_ciph_mode(): use vlr_subscr_security_context instead of umts_aka ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia556bc33d1cf30ef17fed2828908aa0b6b6dc8be Gerrit-Change-Number: 41168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Oct 2025 10:30:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log