- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by pespin 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 4: (2 comments) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/d5639cae_a7a1d474?usp… : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); > Fixed indentation. Done File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/9cda1e77_3d495c9f?usp… : PS4, Line 913: snprintf(response, response_size, "RSP POWEROFF 0"); This change to snprintf is welcome but it is definetly a different patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 08:05:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-trx[master]: transceiver: make control command parsing arguments const
by pespin 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email ) Change subject: transceiver: make control command parsing arguments const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f3aa5363c337791451a388f394d7351d3183908 Gerrit-Change-Number: 42420 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 17 Mar 2026 08:02:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by Timur Davydov 17 Mar '26

17 Mar '26

Attention is currently required from: Hoernchen, laforge, pespin, tnt. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email ) Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... Patch Set 15: (1 comment) Patchset: PS13: > @dtv.comp@gmail. […] This optimization was originally added for the WebSDR path to improve performance, but it's independent from the WebSDR changes. I've moved it to a separate branch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 15 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 18:26:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-trx[master]: device/websdr: add WebSDR transceiver backend and build target
by Timur Davydov 17 Mar '26

17 Mar '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: device/websdr: add WebSDR transceiver backend and build target ...................................................................... Patch Set 4: (1 comment) File Transceiver52M/device/websdr/TransceiverWebSdr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/dc3abae4_430d8b5a?usp… : PS3, Line 50: : Transceiver(cfg, wTransmitLatency, wRadioInterface) > Thanks for the feedback. […] I've moved the implementation into `Transceiver52` instead of placing it under `device/`. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 17:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 17 Mar '26

17 Mar '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 4: (4 comments) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/1c5ee6e8_752d670d?usp… : PS3, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); > It's fine if CI fails in this file, we wan overwrite it manually. Fixed indentation. File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/c601bc4a_e9677bee?usp… : PS3, Line 831: static bool match_cmd(const char *buf, > This can be done in a previous separate commit. I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42420 https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/ee89e3f1_ada61c16?usp… : PS3, Line 1026: return -EINVAL; > My point is that I don't see why do you decided to move the "return EINVAL here instead of 0 and dec […] I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421 https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/34518f1f_307609fb?usp… : PS3, Line 1091: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > The logic is preserved here. […] I've added a separate patch for this - https://gerrit.osmocom.org/c/osmo-trx/+/42421 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Mar 2026 17:05:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Jenkins Builder 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 4: (1 comment) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/aaac0572_a5e924e7?usp… : PS4, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 16 Mar 2026 17:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility
by pespin 17 Mar '26

17 Mar '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility ...................................................................... 5gc: Introduce test TC_ran_initiated_qos_flow_mobility Change-Id: I1a1df29fa254496990d3d9099b3072433468ecb1 --- M 5gc/C5G_Tests.ttcn M 5gc/ConnHdlr.ttcn M 5gc/expected-results.xml M library/ngap/NGAP_EncDec.cc M library/ngap/NGAP_Types.ttcn 5 files changed, 86 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/42417/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a1df29fa254496990d3d9099b3072433468ecb1 Gerrit-Change-Number: 42417 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT and preserve original...
by Timur Davydov 17 Mar '26

17 Mar '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT and preserve original behavior ...................................................................... transceiver: return -EINVAL for invalid SETSLOT and preserve original behavior Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/21/42421/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index cc60491..28e1d39 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -1022,7 +1022,7 @@ if ((timeslot < 0) || (timeslot > 7)) { LOGCHAN(chan, DTRXCTRL, NOTICE) << "bogus message on control interface"; snprintf(response, response_size, "RSP SETSLOT 1 %d %d", timeslot, corrCode); - return 0; + return -EINVAL; } mStates[chan].chanType[timeslot] = (ChannelCombination) corrCode; setModulus(timeslot, chan); @@ -1087,7 +1087,7 @@ rc = ctrl_cmd_handle(chan, buffer, response, response_size); if (rc < 0) - return rc; + return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ LOGCHAN(chan, DTRXCTRL, INFO) << "response is '" << response << "'"; transceiver->ctrl_sock_send(cmd_to_send, chan); -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 17 Mar '26

17 Mar '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: transceiver: split control command handling from socket I/O ...................................................................... transceiver: split control command handling from socket I/O - move control command parsing/response generation into ctrl_cmd_handle() - keep ctrl_sock_handle_rx() focused on socket read/write - switch response formatting from sprintf() to snprintf() Change-Id: I5413aa511e951522270c75635e89448395fc429e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 62 insertions(+), 50 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-trx[master]: transceiver: make control command parsing arguments const
by Timur Davydov 17 Mar '26

17 Mar '26

Timur Davydov has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email ) Change subject: transceiver: make control command parsing arguments const ...................................................................... transceiver: make control command parsing arguments const Change-Id: I2f3aa5363c337791451a388f394d7351d3183908 --- M Transceiver52M/Transceiver.cpp 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/20/42420/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index f5ddd9b..fa66625 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -828,8 +828,8 @@ * @param params pointer to arguments, or NULL * @return true if command matches, otherwise false */ -static bool match_cmd(char *buf, - const char *cmd, char **params) +static bool match_cmd(const char *buf, + const char *cmd, const char **params) { size_t cmd_len = strlen(cmd); @@ -900,7 +900,7 @@ ctrl_msg cmd_to_send; char *buffer = cmd_received.data; char *response = cmd_to_send.data; - char *command, *params; + const char *command, *params; int msgLen; ctrl_sock_state& s = mCtrlSockets[chan]; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42420?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2f3aa5363c337791451a388f394d7351d3183908 Gerrit-Change-Number: 42420 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log