- gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by fixeria 05 Dec '25

05 Dec '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 09:27:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-mgw[master]: mgcp_client: add support for VND.THEMWI.CCSD codec
by osmith 05 Dec '25

05 Dec '25

osmith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email ) Change subject: mgcp_client: add support for VND.THEMWI.CCSD codec ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Fix for the linter: https://gerrit.osmocom.org/c/osmo-ci/+/41592 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/41529?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e4e15b5b3d20036aae8472bd94bc878b718ddd4 Gerrit-Change-Number: 41529 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:44:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ci[master]: lint: run clang-format only on specific projects
by osmith 05 Dec '25

05 Dec '25

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email ) Change subject: lint: run clang-format only on specific projects ...................................................................... lint: run clang-format only on specific projects For most C projects, running checkpatch works best with the coding style we use. Run clang-format only in specific projects that seem to be fully formatted with that tool. Related: https://gerrit.osmocom.org/c/osmo-mgw/+/41529 Related: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39470 Related: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39471 Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de --- M lint/lint_diff.sh 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/92/41592/1 diff --git a/lint/lint_diff.sh b/lint/lint_diff.sh index d76d951..e37de17 100755 --- a/lint/lint_diff.sh +++ b/lint/lint_diff.sh @@ -61,10 +61,28 @@ } test_clang_format() { + local check_projects=" + osmo-asf4-dfu + osmo-ccid-firmware + " + local skip=true + local i + if ! [ -e ".clang-format" ] || ! command -v clang-format >/dev/null; then return fi + for i in $check_projects; do + if [ "$i" = "$PROJECT" ]; then + skip=false + break + fi + done + + if $skip; then + return + fi + echo "Running clang-format on 'git diff $COMMIT'..." echo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41592?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2c07b30f9254b54027b721b77ab6f35249b5e2de Gerrit-Change-Number: 41592 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email ) Change subject: scripts: Add libosmo-asn1-tcap to OSMO_RELEASE_REPOS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I76703ed5c648eb50574166f8459fd0bde1720902 Gerrit-Change-Number: 41587 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/3c447f23_d1e6e60c?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" > ```suggestion […] actually this is better ("$@" would expand to multiple additional printf arguments whereas we only have one %s): ```suggestion printf "${GREEN}OK:${RESET} %s\n" "$1" ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 08:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: osmo-release.sh: Fix coloring output under bash
by osmith 05 Dec '25

05 Dec '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email ) Change subject: osmo-release.sh: Fix coloring output under bash ...................................................................... Patch Set 2: (1 comment) File osmo-release.sh: https://gerrit.osmocom.org/c/libosmocore/+/41547/comment/00c17890_f56f4097?… : PS2, Line 39: printf "${GREEN}OK:${RESET} $@\n" ```suggestion printf "${GREEN}OK:${RESET} %s\n" "$@" ``` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41547?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib9e33ec8650ad8bc2e4b1893d9a7195c041c52dc Gerrit-Change-Number: 41547 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Dec 2025 07:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in ...osmo-epdg[master]: s2b: when socket opening fails, stop the S2b module
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: s2b: when socket opening fails, stop the S2b module ...................................................................... s2b: when socket opening fails, stop the S2b module Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd --- M src/epdg_gtpc_s2b.erl 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/01/37901/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/37901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I49a6a1ec0c938aa70444c19c0b7b644f2e42f1fd Gerrit-Change-Number: 37901 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... s2b: allow to set the restart counter/recovery field The restart counter is a 8 bit value, used to detect if a component has been restarted because GTPv2 is only using UDP. Use system_time by millisecond mod 256 as default. Further allow the supervisor to set it to a specific value. Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 --- M src/epdg_gtpc_s2b.erl M src/osmo_epdg_sup.erl 2 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/88/41588/4 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by lynxis lazus 04 Dec '25

04 Dec '25

Attention is currently required from: laforge. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 3: (3 comments) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/8e639807_1613… : PS2, Line 9: counter a 8 bit value > **is** a 8 bit value Done File src/epdg_gtpc_s2b.erl: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/59ba705a_c5fd… : PS2, Line 112: monotonic timer could be to reproducible on systems > What do you mean here? This comment is confusing... maybe it's better now. https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/866d405b_f06f… : PS2, Line 115: UserConfig > This argument has two different names: `Options` in `start_link()` and `UserConfig` here. […] The other values are mandatory. This one is an optional one. I would like to keep it for this commit. If changes are necessary, this should go into another commit. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: s2b: allow to set the restart counter/recovery field
by fixeria 04 Dec '25

04 Dec '25

Attention is currently required from: laforge, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email ) Change subject: s2b: allow to set the restart counter/recovery field ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588/comment/052d9be3_029d… : PS2, Line 9: counter a 8 bit value > **is** a 8 bit value ah, it should actually be "an" because "an eight ..." -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/41588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e894a2c54dd180c0bc3a6f78d0bb7dd455cad81 Gerrit-Change-Number: 41588 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log