- gerrit-log - lists.osmocom.org

[S] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by lynxis lazus 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. lynxis lazus has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email ) Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 13:53:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asn_debug = 0
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asn_debug = 0 ...................................................................... Remove unconditional assignment of asn_debug = 0 It is now the default and there is no code to set it. Remove the assignment Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a --- M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 3 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/08/42708/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: Remove unconditional assignment of asb_debug = 0
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email ) Change subject: Remove unconditional assignment of asb_debug = 0 ...................................................................... Remove unconditional assignment of asb_debug = 0 It is now the default and there is no code to set it. Remove the assignment Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a --- M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 3 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/08/42708/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index ae3ed26..47be44b 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -81,8 +81,6 @@ log_set_print_tid(osmo_stderr_target, 1); log_enable_multithread(); - asn_debug = 0; - /* initialize members of 'bankd' */ bankd->slotmaps = slotmap_init(bankd); INIT_LLIST_HEAD(&bankd->workers); diff --git a/src/bankd/main.c b/src/bankd/main.c index 54aac61..21f3a50 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -37,7 +37,6 @@ int main(int argc, char **argv) { - asn_debug = 0; g_ctx = talloc_named_const(NULL, 0, "main"); talloc_asn1_ctx = talloc_named_const(g_ctx, 0, "asn1_context"); card_readers_probe(g_ctx); diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index a2f7cd1..f327204 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -215,7 +215,5 @@ exit(1); } - asn_debug = 0; - client_user_main(g_client); } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I114e9773a1d0aa3c16990a946cf91c69b9c2498a Gerrit-Change-Number: 42708 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-remsim[master]: asn1: move asn_debug into librspro
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email ) Change subject: asn1: move asn_debug into librspro ...................................................................... asn1: move asn_debug into librspro To allow compiling the asn code with `-DEMIT_ASN_DEBUG=1`. Otherwise it will fail with an unresolved symbol because librspro is compiled as shared-object. Further initialize it as disable (0). Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce --- M src/asn1c_helpers.c M src/asn1c_helpers.h M src/bankd/bankd_main.c M src/bankd/main.c M src/client/remsim_client_main.c 5 files changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/07/42707/1 diff --git a/src/asn1c_helpers.c b/src/asn1c_helpers.c index ea3f5a6..5a2416a 100644 --- a/src/asn1c_helpers.c +++ b/src/asn1c_helpers.c @@ -7,6 +7,8 @@ #include "asn1c_helpers.h" +int asn_debug = 0; + const char *asn_type_name(const asn_TYPE_descriptor_t *td) { return td->name; diff --git a/src/asn1c_helpers.h b/src/asn1c_helpers.h index ac34a8f..75a68d7 100644 --- a/src/asn1c_helpers.h +++ b/src/asn1c_helpers.h @@ -1,6 +1,9 @@ #pragma once #include <asn_application.h> + +extern int asn_debug; + struct asn_TYPE_descriptor_t; const char *asn_type_name(const asn_TYPE_descriptor_t *td); diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index 5e33b41..ae3ed26 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -44,6 +44,7 @@ #include <asn_application.h> #include <osmocom/rspro/RsproPDU.h> +#include "asn1c_helpers.h" #include "bankd.h" #include "rspro_client_fsm.h" #include "debug.h" @@ -69,8 +70,6 @@ * bankd core / main thread ***********************************************************************/ -int asn_debug; - static void bankd_init(struct bankd *bankd) { g_tall_ctx = talloc_named_const(NULL, 0, "global"); diff --git a/src/bankd/main.c b/src/bankd/main.c index f4601ae..54aac61 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -30,10 +30,10 @@ #include <winscard.h> #include "internal.h" +#include "asn1c_helpers.h" static void *g_ctx; __thread void *talloc_asn1_ctx; -int asn_debug; int main(int argc, char **argv) { diff --git a/src/client/remsim_client_main.c b/src/client/remsim_client_main.c index 2f9b8e0..a2f7cd1 100644 --- a/src/client/remsim_client_main.c +++ b/src/client/remsim_client_main.c @@ -14,7 +14,6 @@ static void *g_tall_ctx; void __thread *talloc_asn1_ctx; -int asn_debug; static void handle_sig_usr1(int signal) { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icb03e8905f3b38ecebfcf294727a01f994511cce Gerrit-Change-Number: 42707 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: asn1: ber_decoder: disable stack size check on ctx = NULL
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email ) Change subject: asn1: ber_decoder: disable stack size check on ctx = NULL ...................................................................... asn1: ber_decoder: disable stack size check on ctx = NULL The stack size check is triggering when using asan or when compile with -O1. It is unclear why this is problematic. This is a not a leak. Related: OS#7002 Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 --- M src/rspro/ber_decoder.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/06/42706/1 diff --git a/src/rspro/ber_decoder.c b/src/rspro/ber_decoder.c index 0f99400..1e150ac 100644 --- a/src/rspro/ber_decoder.c +++ b/src/rspro/ber_decoder.c @@ -44,7 +44,9 @@ } else { /* If context is not given, be security-conscious anyway */ memset(&s_codec_ctx, 0, sizeof(s_codec_ctx)); - s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX; + /* TODO: disable stack check until the root cause can be debugged. See OS#7002 + s_codec_ctx.max_stack_size = _ASN_DEFAULT_STACK_MAX; */ + s_codec_ctx.max_stack_size = 0; opt_codec_ctx = &s_codec_ctx; } -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Id99531f62ccdf73497bb08483ca6adbabe1a7cd7 Gerrit-Change-Number: 42706 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: rspro_util: asn1 decode: fix memleak when decoding fails
by lynxis lazus 27 Apr '26

27 Apr '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email ) Change subject: rspro_util: asn1 decode: fix memleak when decoding fails ...................................................................... rspro_util: asn1 decode: fix memleak when decoding fails Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 --- M src/rspro_util.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/05/42705/1 diff --git a/src/rspro_util.c b/src/rspro_util.c index 23bb839..5e4ab17 100644 --- a/src/rspro_util.c +++ b/src/rspro_util.c @@ -66,6 +66,8 @@ msg->l2h = msg->data; rval = der_encode_to_buffer(&asn_DEF_RsproPDU, pdu, msgb_data(msg), msgb_tailroom(msg)); if (rval.encoded < 0) { + if (pdu) + ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); LOGP(DRSPRO, LOGL_ERROR, "Failed to encode %s\n", rval.failed_type->name); msgb_free(msg); return NULL; @@ -86,6 +88,8 @@ LOGP(DRSPRO, LOGL_DEBUG, "decoding %s\n", msgb_hexdump(msg)); rval = ber_decode(NULL, &asn_DEF_RsproPDU, (void **) &pdu, msgb_l2(msg), msgb_l2len(msg)); if (rval.code != RC_OK) { + if (pdu) + ASN_STRUCT_FREE(asn_DEF_RsproPDU, pdu); LOGP(DRSPRO, LOGL_ERROR, "Failed to decode: %d. Consumed %zu of %u bytes\n", rval.code, rval.consumed, msgb_length(msg)); return NULL; -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42705?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I071343d0134dbffb1bb71ea26a5b514be1b5bb27 Gerrit-Change-Number: 42705 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email to look at the new patch set (#4). Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Fix: Prevent race conditions when accessing slotmap in bankd If a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. To prevent this, the worker locks the slot map and calls the new function slotmap_by_client_nolock(). After it has finished working with the returned pointer, it unlocks the slot map again. A possible delete by the main thread would be delayed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 --- M src/bankd/bankd_main.c M src/slotmap.c M src/slotmap.h 3 files changed, 21 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/64/42664/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-remsim[master]: Fix: Remove slot mapping at bankd when client disconnects
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: laforge. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email ) Change subject: Fix: Remove slot mapping at bankd when client disconnects ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > I think this is fundamentally wrong. […] Actually the slotmap can persist. The change of the state and the removal mapping in the worker ist what is required to fix that issue. I removed slotmap_del and it works fine. (See commit message) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42645/comment/8a846d17_7bfdaa2b?… : PS1, Line 1109: > I thnink the slotmap_del is the conceptually wrong part. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 Gerrit-Change-Number: 42645 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2026 13:19:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-remsim[master]: Fix: Remove slot mapping at bankd when client disconnects
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: Fix: Remove slot mapping at bankd when client disconnects ...................................................................... Fix: Remove slot mapping at bankd when client disconnects If a client disconnects before removing the slot mapping, the worker must undefine its 'bank_id' and 'slot_nr' and must change its state to 'UNMAPPED'. send_signal_to_worker() searches for a worker that has a given bank and slot. If a client re-connects to a different worker and if the bank and slot would be still assigned to the old worker, the old worker could receive signals when assigning or removing slot mapping. The new worker would not be mapped. Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 --- M src/bankd/bankd_main.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/45/42645/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2fd03490e2506c55104309a0ef952389119023b8 Gerrit-Change-Number: 42645 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-remsim[master]: Fix: Prevent race conditions when accessing slotmap in bankd
by jolly 27 Apr '26

27 Apr '26

Attention is currently required from: jolly, laforge, lynxis lazus. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: Fix: Prevent race conditions when accessing slotmap in bankd ...................................................................... Fix: Prevent race conditions when accessing slotmap in bankd All threads (main and workers) can use slotmap_by_bank() and slotmap_by_client() to get a mapping entry from the slot map. While working with this entry (reading values), it could be deleted by a different thread. For example, if a client connects to a worker, the worker will check if there is an existing mapping between a reader and this client. If it exists, slotmap_by_client() will return a pointer. If the mapping is deleted at this time by the server, the worker uses a pointer to a mapping entry that has just been freed. Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 --- M src/bankd/bankd_main.c M src/slotmap.c M src/slotmap.h 3 files changed, 21 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/64/42664/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42664?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3464726f37beb7c47b4e1f00c018ffa4f3948906 Gerrit-Change-Number: 42664 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log