October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL
by pespin 31 Oct '23

31 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL ...................................................................... GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL open5gs 125740727e558c7604897eda711d4d40f2906239 changed behavior and is no longer sending the Used-Service-Unit AVP during INITIAL_REQUEST, which makes sense since those values should be only initialized and spec seems to more or less expect it that way, though receiving it at INITIAL time should be accepted too AFAICT. Related: https://github.com/open5gs/open5gs/pull/2721 Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e --- M ggsn_tests/GGSN_Tests.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/34929/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 5b1f7a1..d6a0403 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -534,7 +534,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 182147d..bafabdf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -363,7 +363,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0
by pespin 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 31 Oct 2023 13:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package
by pespin 31 Oct '23

31 Oct '23

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: > I think the proper solution would be to migrate (copy?) the values to libosmo-sigtran. […] I see other osmocom projects depending on it liek osmo-msc and osmo-smlc iirc, but ok, I will mark this one as WIP. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Oct 2023 13:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds
by pespin 31 Oct '23

31 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email ) Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Increase default X31 val from 5 to 15 seconds It was spotted that in some deploys with satellite links and heavy load, the roundtrip times for CR and CC can go slightly over 12 seconds, so better increase the default value to 15 seconds to be on a safer place and avoid operation problems with default configuration. Related: SYS#6602, SYS#6616 Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 --- M src/osmo-hnbgw/tdefs.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/tdefs.c b/src/osmo-hnbgw/tdefs.c index 601f704..cae9405 100644 --- a/src/osmo-hnbgw/tdefs.c +++ b/src/osmo-hnbgw/tdefs.c @@ -34,7 +34,7 @@ struct osmo_tdef hnbgw_T_defs[] = { {.T = 3113, .default_val = 15, .desc = "Time to keep Paging record, for CN pools with more than one link" }, {.T = 4, .default_val = 5, .desc = "Timeout to receive RANAP RESET ACKNOWLEDGE from an MSC/SGSN" }, - {.T = -31, .default_val = 5, .desc = "Timeout for discarding a partially released context map (RUA <-> SCCP)" }, + {.T = -31, .default_val = 15, .desc = "Timeout for discarding a partially released context map (RUA <-> SCCP)" }, {.T = -1002, .default_val = 10, .desc = "Timeout for the HNB to respond to PS RAB Assignment Request" }, { } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0
by osmith 31 Oct '23

31 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Bump version: 0.2.0 Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf --- M debian/changelog 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/28/34928/1 diff --git a/debian/changelog b/debian/changelog index 488f3d7..dfc8fb6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,39 @@ +osmo-diameter2gsup (0.2.0) unstable; urgency=medium + + [ Alexander Couzens ] + * contrib/generate_build_dep.sh: remove erlang bytecode from checkouts + * docs: add a simple example to use configuration file + + [ Oliver Smith ] + * debian: set compat level to 10 + * systemd: depend on networking-online.target + + [ Alexander Couzens ] + * Use GSUP APN as Service-Selection field + + [ Pau Espin Pedrol ] + * rebar3.lock: Update epcap dep to v1.1.1 to fix compilation error + * README.md: Document how to run escript with config file + + [ Oliver Smith ] + * README.md: update + + [ Pau Espin Pedrol ] + * cosmetic: Fix typo in comment + * gsup: Log connect failures + * gsup: Attempt reconnecting if connect fails + * Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names + * Translate GSUP Auth Info Answer error Cause in Diamater AIA + + [ Alexander Couzens ] + * server_cb: use a define for the VENDOR_3GPP code + * gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY + + [ Oliver Smith ] + * debian/rules: extract build_dep.tar.gz first + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 31 Oct 2023 12:59:24 +0100 + osmo-diameter2gsup (0.1.2) unstable; urgency=medium [ Matt Johnson ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think the proper solution would be to migrate (copy?) the values to libosmo-sigtran. libosmo-sccp is super legacy and should be abandoned completely as there are no active users for probably close to 10 years by now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:55:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email ) Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds
by pespin 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, laforge, neels. Hello Jenkins Builder, daniel, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Increase default X31 val from 5 to 15 seconds It was spotted that in some deploys with satellite links and heavy load, the roundtrip times for CR and CC can go slightly over 12 seconds, so better increase the default value to 15 seconds to be on a safer place and avoid operation problems with default configuration. Related: SYS#6602, SYS#6616 Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 --- M src/osmo-hnbgw/tdefs.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/22/34922/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value
by osmith 31 Oct '23

31 Oct '23

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:24:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0