March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: cbch_scheduler: cosmetic: s/bts_cbch_timer/bts_cbch_timer_cb/

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27617 ) Change subject: cbch_scheduler: cosmetic: s/bts_cbch_timer/bts_cbch_timer_cb/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibff3045d8066b644b437e46330848ebadfb373fd Gerrit-Change-Number: 27617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Mar 2022 12:07:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: cbch_scheduler: cosmetic: s/bts_cbch_timer/bts_cbch_timer_cb/

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27617 ) Change subject: cbch_scheduler: cosmetic: s/bts_cbch_timer/bts_cbch_timer_cb/ ...................................................................... cbch_scheduler: cosmetic: s/bts_cbch_timer/bts_cbch_timer_cb/ Change-Id: Ibff3045d8066b644b437e46330848ebadfb373fd --- M src/osmo-bsc/cbch_scheduler.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/17/27617/1 diff --git a/src/osmo-bsc/cbch_scheduler.c b/src/osmo-bsc/cbch_scheduler.c index 1bdf5e7..c66f743 100644 --- a/src/osmo-bsc/cbch_scheduler.c +++ b/src/osmo-bsc/cbch_scheduler.c @@ -246,7 +246,7 @@ bts_smscb_page_done(cstate, page); } -static void bts_cbch_timer(void *data) +static void bts_cbch_timer_cb(void *data) { struct gsm_bts *bts = (struct gsm_bts *)data; @@ -259,7 +259,7 @@ /* There is one SMSCB message (page) per eight 51-multiframes, i.e. 1.882 seconds */ void bts_cbch_timer_schedule(struct gsm_bts *bts) { - osmo_timer_setup(&bts->cbch_timer, &bts_cbch_timer, bts); + osmo_timer_setup(&bts->cbch_timer, &bts_cbch_timer_cb, bts); osmo_timer_schedule(&bts->cbch_timer, 1, 882920); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibff3045d8066b644b437e46330848ebadfb373fd Gerrit-Change-Number: 27617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: cosmetic: use VTY_IPV46_CMD in the command string

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27615 ) Change subject: VTY: cosmetic: use VTY_IPV46_CMD in the command string ...................................................................... VTY: cosmetic: use VTY_IPV46_CMD in the command string Change-Id: I3088aed936b936d36a550f766031328143481064 --- M src/cbc_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 9a36aa4..24ca1a9 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -347,7 +347,7 @@ } DEFUN(cfg_cbsp_local_ip, cfg_cbsp_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for CBSP\n" "Local IPv6 address for CBSP\n") { @@ -383,7 +383,7 @@ } DEFUN(cfg_ecbe_local_ip, cfg_ecbe_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for ECBE REST Interface\n" "Local IPv6 address for ECBE REST Interface\n") @@ -469,7 +469,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, - "remote-ip (A.B.C.D|X:X::X:X)", + "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" "Remote IP address of peer\n") { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3088aed936b936d36a550f766031328143481064 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: fix incomplete 'remote-ip' command description

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27616 ) Change subject: VTY: fix incomplete 'remote-ip' command description ...................................................................... VTY: fix incomplete 'remote-ip' command description Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f --- M src/cbc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 24ca1a9..f0c34d6 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -471,7 +471,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" - "Remote IP address of peer\n") + "IPv4 address of peer\n" "IPv6 address of peer\n") { struct cbc_peer *peer = (struct cbc_peer *) vty->index; osmo_talloc_replace_string(peer, &peer->remote_host, argv[0]); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: doc/examples: make osmo-cbc.cfg file more informative

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27614 ) Change subject: doc/examples: make osmo-cbc.cfg file more informative ...................................................................... doc/examples: make osmo-cbc.cfg file more informative This example is not any better than just using '-c /dev/null'. Add some default parameters taken from 'show running-config'. Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index dae31e3..0b66996 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,3 +1,11 @@ log stderr logging level cbsp debug +cbc + unknown-peers reject + cbsp + local-ip 127.0.0.1 + local-port 48049 + ecbe + local-ip 127.0.0.1 + local-port 12345 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: fix incomplete 'remote-ip' command description

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27616 ) Change subject: VTY: fix incomplete 'remote-ip' command description ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:57:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: cosmetic: use VTY_IPV46_CMD in the command string

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27615 ) Change subject: VTY: cosmetic: use VTY_IPV46_CMD in the command string ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3088aed936b936d36a550f766031328143481064 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:56:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: doc/examples: make osmo-cbc.cfg file more informative

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27614 ) Change subject: doc/examples: make osmo-cbc.cfg file more informative ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:56:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Fix assert hit if connecting to SGSN fails """ DLBSSGP ERROR gprs_bssgp_pcu.c:1278 Failed to connect! DL1IF ERROR pcu_l1_if.cpp:827 No NSVC available to connect to the SGSN! DRLCMAC INFO pdch.cpp:185 PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => disabled Assert failed m_is_enabled == 1 pdch.cpp:186 """ Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b --- M src/pcu_l1_if.cpp 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index d5672e5..d0698d9 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -731,7 +731,8 @@ for (trx_nr = 0; trx_nr < ARRAY_SIZE(bts->trx); trx_nr++) { bts->trx[trx_nr].arfcn = info_ind->trx[trx_nr].arfcn; for (ts_nr = 0; ts_nr < ARRAY_SIZE(bts->trx[0].pdch); ts_nr++) - bts->trx[trx_nr].pdch[ts_nr].disable(); + if (bts->trx[trx_nr].pdch[ts_nr].is_enabled()) + bts->trx[trx_nr].pdch[ts_nr].disable(); } gprs_bssgp_destroy(bts); exit(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:55:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: cosmetic: use VTY_IPV46_CMD in the command string

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27615 ) Change subject: VTY: cosmetic: use VTY_IPV46_CMD in the command string ...................................................................... VTY: cosmetic: use VTY_IPV46_CMD in the command string Change-Id: I3088aed936b936d36a550f766031328143481064 --- M src/cbc_vty.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/15/27615/1 diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 9a36aa4..24ca1a9 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -347,7 +347,7 @@ } DEFUN(cfg_cbsp_local_ip, cfg_cbsp_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for CBSP\n" "Local IPv6 address for CBSP\n") { @@ -383,7 +383,7 @@ } DEFUN(cfg_ecbe_local_ip, cfg_ecbe_local_ip_cmd, - "local-ip (A.B.C.D|X:X::X:X)", + "local-ip " VTY_IPV46_CMD, "Local IP address for CBSP\n" "Local IPv4 address for ECBE REST Interface\n" "Local IPv6 address for ECBE REST Interface\n") @@ -469,7 +469,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, - "remote-ip (A.B.C.D|X:X::X:X)", + "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" "Remote IP address of peer\n") { -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27615 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I3088aed936b936d36a550f766031328143481064 Gerrit-Change-Number: 27615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: VTY: fix incomplete 'remote-ip' command description

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27616 ) Change subject: VTY: fix incomplete 'remote-ip' command description ...................................................................... VTY: fix incomplete 'remote-ip' command description Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f --- M src/cbc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/16/27616/1 diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 24ca1a9..f0c34d6 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -471,7 +471,7 @@ DEFUN(cfg_peer_remote_ip, cfg_peer_remote_ip_cmd, "remote-ip " VTY_IPV46_CMD, "Configure remote IP of peer\n" - "Remote IP address of peer\n") + "IPv4 address of peer\n" "IPv6 address of peer\n") { struct cbc_peer *peer = (struct cbc_peer *) vty->index; osmo_talloc_replace_string(peer, &peer->remote_host, argv[0]); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27616 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I2f98285bda4a482ac1af04f71eafa19daee5137f Gerrit-Change-Number: 27616 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-cbc[master]: doc/examples: make osmo-cbc.cfg file more informative

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/27614 ) Change subject: doc/examples: make osmo-cbc.cfg file more informative ...................................................................... doc/examples: make osmo-cbc.cfg file more informative This example is not any better than just using '-c /dev/null'. Add some default parameters taken from 'show running-config'. Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e --- M doc/examples/osmo-cbc/osmo-cbc.cfg 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/14/27614/1 diff --git a/doc/examples/osmo-cbc/osmo-cbc.cfg b/doc/examples/osmo-cbc/osmo-cbc.cfg index dae31e3..0b66996 100644 --- a/doc/examples/osmo-cbc/osmo-cbc.cfg +++ b/doc/examples/osmo-cbc/osmo-cbc.cfg @@ -1,3 +1,11 @@ log stderr logging level cbsp debug +cbc + unknown-peers reject + cbsp + local-ip 127.0.0.1 + local-port 48049 + ecbe + local-ip 127.0.0.1 + local-port 12345 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/27614 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I6dca38a2220c32fad96237d7522a300f12b4469e Gerrit-Change-Number: 27614 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 20:12:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-pcu[master]: Fix assert hit if connecting to SGSN fails

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27613 ) Change subject: Fix assert hit if connecting to SGSN fails ...................................................................... Fix assert hit if connecting to SGSN fails """ DLBSSGP ERROR gprs_bssgp_pcu.c:1278 Failed to connect! DL1IF ERROR pcu_l1_if.cpp:827 No NSVC available to connect to the SGSN! DRLCMAC INFO pdch.cpp:185 PDCH(bts=0,trx=0,ts=0) PDCH state: disabled => disabled Assert failed m_is_enabled == 1 pdch.cpp:186 """ Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b --- M src/pcu_l1_if.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/13/27613/1 diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index d5672e5..d0698d9 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -731,7 +731,8 @@ for (trx_nr = 0; trx_nr < ARRAY_SIZE(bts->trx); trx_nr++) { bts->trx[trx_nr].arfcn = info_ind->trx[trx_nr].arfcn; for (ts_nr = 0; ts_nr < ARRAY_SIZE(bts->trx[0].pdch); ts_nr++) - bts->trx[trx_nr].pdch[ts_nr].disable(); + if (bts->trx[trx_nr].pdch[ts_nr].is_enabled()) + bts->trx[trx_nr].pdch[ts_nr].disable(); } gprs_bssgp_destroy(bts); exit(0); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27613 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I36dc64fa807091bf2b565417c1185c4cb399932b Gerrit-Change-Number: 27613 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Add missing osmo-pcu to sanitize.opts Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c --- M sanitize.opts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/sanitize.opts b/sanitize.opts index 5f42da8..94bb855 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -13,6 +13,7 @@ osmo-sgsn --enable-sanitize openbsc --enable-sanitize osmo-sip-connector --enable-sanitize +osmo-pcu --enable-sanitize osmo-bts --enable-sanitize osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27612 ) Change subject: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts ...................................................................... Add missing osmo-cbc to all.deps and {sanitize,werror}.opts Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved; Verified diff --git a/all.deps b/all.deps index 75c2b96..988d1ee 100644 --- a/all.deps +++ b/all.deps @@ -26,6 +26,7 @@ osmo-bsc-nat libosmo-sccp libgtpnl osmo-upf libosmocore libgtpnl +osmo-cbc libosmo-netif # can only clone these docker-playground diff --git a/sanitize.opts b/sanitize.opts index 94bb855..34f27af 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -18,3 +18,4 @@ osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize osmo-upf --enable-sanitize +osmo-cbc --enable-sanitize diff --git a/werror.opts b/werror.opts index 7f2ee6c..c5daa23 100644 --- a/werror.opts +++ b/werror.opts @@ -14,3 +14,4 @@ osmo-bts --enable-werror osmo-bsc-nat --enable-werror osmo-upf --enable-werror +osmo-cbc --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 Gerrit-Change-Number: 27612 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27612 ) Change subject: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 Gerrit-Change-Number: 27612 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 19:47:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 19:42:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/27612 ) Change subject: Add missing osmo-cbc to all.deps and {sanitize,werror}.opts ...................................................................... Add missing osmo-cbc to all.deps and {sanitize,werror}.opts Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 --- M all.deps M sanitize.opts M werror.opts 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/12/27612/1 diff --git a/all.deps b/all.deps index 75c2b96..988d1ee 100644 --- a/all.deps +++ b/all.deps @@ -26,6 +26,7 @@ osmo-bsc-nat libosmo-sccp libgtpnl osmo-upf libosmocore libgtpnl +osmo-cbc libosmo-netif # can only clone these docker-playground diff --git a/sanitize.opts b/sanitize.opts index 94bb855..34f27af 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -18,3 +18,4 @@ osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize osmo-upf --enable-sanitize +osmo-cbc --enable-sanitize diff --git a/werror.opts b/werror.opts index 7f2ee6c..c5daa23 100644 --- a/werror.opts +++ b/werror.opts @@ -14,3 +14,4 @@ osmo-bts --enable-werror osmo-bsc-nat --enable-werror osmo-upf --enable-werror +osmo-cbc --enable-werror -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27612 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I39e2067f5d93e648e05ee0f949145d31af43e6d7 Gerrit-Change-Number: 27612 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 18:44:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-dev[master]: Add missing osmo-pcu to sanitize.opts

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/27611 ) Change subject: Add missing osmo-pcu to sanitize.opts ...................................................................... Add missing osmo-pcu to sanitize.opts Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c --- M sanitize.opts 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/11/27611/1 diff --git a/sanitize.opts b/sanitize.opts index 5f42da8..94bb855 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -13,6 +13,7 @@ osmo-sgsn --enable-sanitize openbsc --enable-sanitize osmo-sip-connector --enable-sanitize +osmo-pcu --enable-sanitize osmo-bts --enable-sanitize osmo-smlc --enable-sanitize osmo-pcu --enable-sanitize -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27611 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I8afe1a5fdcbd6d356d104cb7be3b9be4b508a97c Gerrit-Change-Number: 27611 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:48:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... common: gb-ns2: add chapter Gb/NS maintenance Add chapter to describe common maintenance Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f --- A common/chapters/gb-ns2-maintenance.adoc A common/chapters/gb-ns2-nsvc-states-alive.dot A common/chapters/gb-ns2-nsvc-states-reset-block.dot 3 files changed, 130 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved diff --git a/common/chapters/gb-ns2-maintenance.adoc b/common/chapters/gb-ns2-maintenance.adoc new file mode 100644 index 0000000..ea99532 --- /dev/null +++ b/common/chapters/gb-ns2-maintenance.adoc @@ -0,0 +1,115 @@ +=== Gb/NS maintenance + +This section describes common maintenance procedures. + +[[ns2-nse-states]] +==== NSE states + +A NSE can have the following states: + +.NSE states +* ALIVE +* DEAD + +For FR, IPA: The NSE is ALIVE if there is at least one NSVC in state UNBLOCKED. +For IP-SNS/UDP: The NSE is ALIVE if there is at least one NSVC ALIVE and the sum of all ALIVE NSVCs signalling weights > 0 and data weights > 0. + +The state of the NSE is shown by vty. + +.show ns +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> NSE state + +==== NSVC states + +A NSVC can have the following states: + +.nsvc states +[options="header"] +|========================================================= +| State | transport UNITDATA | Description + +| DISABLED | No | Either the transport layer is unavailable (FR) or this NSVC is currently used by IP-SNS dynamic configuration. +| RESET | No | Sending out RESET PDU and awaiting data. +| BLOCKED | No* | The NSVC has been BLOCKED. * see 3GPP TS 48.016 § 7.2 exception +| UNBLOCKED/ALIVE | Yes | The NSVC transport UNITDATA. +| RECOVERING | No | The NSVC test procedure timed out. NSVC type is a IP-SNS which don't use RESET/BLOCK/UNBLOCK. + +|========================================================= + +[[fig-nsvc-states-reset-block]] +.Simplified state diagram for RESET BLOCK UNBLOCK NSVCs +[graphviz] +---- +include::gb-ns2-nsvc-states-reset-block.dot[] +---- + +[[fig-nsvc-states-alive]] +.Simplified state diagram for IP-SNS/UDP +[graphviz] +---- +include::gb-ns2-nsvc-states-alive.dot[] +---- + +==== Show information of a specific NSE + +The NSE 1234 has been configured for as BSS with IP-SNS configuration. + +.show ns on a dynamic configured IP-SNS NSE +---- +GbProxy# show ns nsei 1234 +NSEI 01234: UDP, DEAD <1> + FSM Instance Name: 'GPRS-NS2-SNS-BSS(NSE01234-SNS)[0x6120000012a0]', ID: 'NSE01234-SNS' + Log-Level: 'DEBUG', State: 'BSS_SIZE' <2> + Timer: 1 + Maximum number of remote NS-VCs: 8192, IPv4 Endpoints: 8192, IPv6 Endpoints: 8192 + 1 NS-VC: + NSVCI none: DISABLED DYNAMIC data_weight=1 sig_weight=1 udp)[127.0.0.1]:23000<>[127.0.0.1]:22000 +---- +<1> A UDP NSE. A NSE can be ALIVE or DEAD +<2> The SNS state. CONFIGURED and LOCAL_PROCEDURE are ALIVE states + +For description of NSE states see <<ns2-nse-states>>. + +.show ns on a frame relay NSE +---- +OsmoNSdummy# show ns nsei 02001 +NSEI 02001: FR, ALIVE <1> + 4 NS-VC: + NSVCI 00001: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet1 dlci: 16 <2> + NSVCI 00002: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet2 dlci: 17 <3> + NSVCI 00003: DISABLED PERSIST <4> data_weight=1 sig_weight=1 fr)netif: hdlcnet3 dlci: 18 + NSVCI 00004: DISABLED PERSIST data_weight=1 sig_weight=1 fr)netif: hdlcnet4 dlci: 19 +---- +<1> A FR NSE. A NSE can be ALIVE or DEAD +<2> An unblocked NS-VC will be used for data and signalling. data and signalling weight are only relevant for UDP NSVC. +<3> NSVC is still blocked. +<4> A PERSIST NSVC is a configured via VTY. + +==== Blocking a NSVC + +.how to block a single NSVC +---- +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 41m 6s + 2 NS-VC: + NSVCI 01234: UNBLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 ALIVE since 0d 0h 2m 36s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 41m 6s + +OsmoNSdummy# nsvc 1234 block +The NS-VC 01234 will be blocked. +OsmoNSdummy# show ns nsei 01234 +NSEI 01234: UDP, ALIVE since 0d 0h 42m 7s + 2 NS-VC: + NSVCI 01234: BLOCKED PERSIST udp)[127.0.0.1]:23000\<1234>[127.0.0.1]:22000 DEAD since 0d 0h 3m 37s + NSVCI 01235: UNBLOCKED PERSIST udp)[127.0.0.1]:23001\<1235>[127.0.0.1]:22001 ALIVE since 0d 0h 42m 7s +---- diff --git a/common/chapters/gb-ns2-nsvc-states-alive.dot b/common/chapters/gb-ns2-nsvc-states-alive.dot new file mode 100644 index 0000000..7e919c1 --- /dev/null +++ b/common/chapters/gb-ns2-nsvc-states-alive.dot @@ -0,0 +1,6 @@ + +digraph G { + DISABLED -> ALIVE; + ALIVE -> RECOVERING [label="test procedure timeout"]; + RECOVERING -> ALIVE [label="test procedure success"]; +} diff --git a/common/chapters/gb-ns2-nsvc-states-reset-block.dot b/common/chapters/gb-ns2-nsvc-states-reset-block.dot new file mode 100644 index 0000000..b1825d5 --- /dev/null +++ b/common/chapters/gb-ns2-nsvc-states-reset-block.dot @@ -0,0 +1,9 @@ +digraph G { + DISABLED -> RESET [label="transport layer available"]; + RESET -> BLOCKED [label="reset ack"]; + BLOCKED -> UNBLOCKED [label="unblock"]; + UNBLOCKED -> BLOCKED [label="block"]; + BLOCKED -> RESET [label="test procedure timeout"]; + UNBLOCKED -> RESET [label="test procedure timeout"]; +} + -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-gsm-manuals[master]: common: gb-ns2: add chapter Gb/NS maintenance

by lynxis lazus

lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 ) Change subject: common: gb-ns2: add chapter Gb/NS maintenance ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: 1+1=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/24687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5571001a127c933397a4bc26e85410288d50fc2f Gerrit-Change-Number: 24687 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:29:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: hodec2: add penalty-time low-rxqual-ho

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27596 ) Change subject: hodec2: add penalty-time low-rxqual-ho ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27596 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I057b156604a104a26a7ce45d1c7adadbf452c932 Gerrit-Change-Number: 27596 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:20:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Add ss7 instances to osmo_ss7_instances in creation order Otherwise when configuring ss7 instances in numerical order in the VTY and then printing the VTY configuration they end up ordered this way: cs7 instance 2 cs7 instance 1 cs7 instance 0 Related: SYS#5912 Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c --- M src/osmo_ss7.c M tests/vty/ss7_asp_test.vty 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified neels: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index 99536d3..a4af727 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -399,7 +399,7 @@ inst->cfg.pc_fmt.component_len[1] = 8; inst->cfg.pc_fmt.component_len[2] = 3; - llist_add(&inst->list, &osmo_ss7_instances); + llist_add_tail(&inst->list, &osmo_ss7_instances); INIT_LLIST_HEAD(&inst->cfg.sccp_address_book); diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index bfbb77e..09be45b 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -337,10 +337,6 @@ ss7_asp_vty_test(config)# show running-config ... -cs7 instance 1 - sccp-address bar - routing-indicator PC - point-code 1.2.3 cs7 instance 0 asp my-asp 12345 54321 m3ua local-ip 127.0.0.100 @@ -351,6 +347,10 @@ sccp-address foo routing-indicator PC point-code 1.2.3 +cs7 instance 1 + sccp-address bar + routing-indicator PC + point-code 1.2.3 end ss7_asp_vty_test(config)# do show cs7 instance 0 users -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:20:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 ) Change subject: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num ...................................................................... BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Related: SYS#5905 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 25f00d8..0d8fb38 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -696,6 +696,61 @@ setverdict(pass); } +/* Verify handling of the Repetition Period and the Number of Broadcasts */ +testcase TC_cbsp_write_rep_period_num() runs on cbsp_test_CT { + var CBSP_IE page := f_gen_page(); + const integer rep_period := 2; /* units of 1.883s */ + const integer rep_number := 5; + var integer msg_count := 0; + var float last_time := 0.0; + timer T; + + g_pars := valueof(ts_CBSP_Pars_default(false, 9001, 9501)); + f_init(guard_timeout := 60.0); + + f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, + cell_list := ts_BSSMAP_CIL_LAC_CI({bssmap_lac_ci(mp_cgi_bts0)}), + rep_period := rep_period, num_bcast_req := rep_number, + content := { page }, success_list := ?, fail_list := omit); + + /* Count SMSCB messages during N=rep_number+2 repetition periods */ + T.start(int2float(rep_period * (rep_number + 2)) * 1.883); + alt { + [] IPA_RSL[0].receive(tr_ASP_RSL_UD(f_page2rsl(page, g_cbsp_msg_id, g_cbsp_ser_no))) { + var float exp_period := int2float(rep_period) * 1.883; + var float calc_period := T.read - last_time; + + log("Rx SMSCB message: count := ", msg_count + 1, ", ", + "elapsed := ", T.read, "s, diff := ", calc_period, "s"); + + if (msg_count > 0) { + /* Check the actual repetition period (+/- 0.5s) */ + var template float tr_exp_period := (exp_period - 0.5 .. exp_period + 0.5); + if (not match(calc_period, tr_exp_period)) { + setverdict(fail, "Repetition period mismatch: ", + "calculated := ", calc_period, "s vs ", + "expected := ", tr_exp_period, "s"); + } + } + + msg_count := msg_count + 1; + last_time := T.read; + repeat; + } + [] T.timeout { + log("Received ", msg_count, " messages during ", last_time, "s"); + } + } + + if (msg_count != rep_number) { + setverdict(fail, "Received ", msg_count, " messages, ", + "while we expected ", rep_number); + } + + f_sleep(1.0); + setverdict(pass); +} + /* Replace a message that doesn't exist: failure */ testcase TC_cbsp_replace_nonexist() runs on cbsp_test_CT { var CBSP_IEs pages := {f_gen_page()}; @@ -945,6 +1000,7 @@ execute( TC_cbsp_write_lac() ); execute( TC_cbsp_write_then_replace() ); + execute( TC_cbsp_write_rep_period_num() ); execute( TC_cbsp_replace_nonexist() ); execute( TC_cbsp_write_too_many() ); execute( TC_cbsp_kill_nonexist() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Gerrit-Change-Number: 27605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 ) Change subject: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Gerrit-Change-Number: 27605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:19:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ran emulation: allow multiple reset attempts

by laforge

Attention is currently required from: Hoernchen. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 ) Change subject: ran emulation: allow multiple reset attempts ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928 Gerrit-Change-Number: 27602 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:19:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by laforge

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:18:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 ) Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... mgcp_network: do not try to convert RTCP packets Make sure that RTCP packets do not enter the code path where AMR OA and BWE is converted. The conversion will fail and the RTCP packet will be dropped. Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Related: SYS#5902 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 0ea8c25..8ade27d 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1518,6 +1518,7 @@ return rc; } +/* Note: This function is able to handle RTP and RTCP */ static int rx_rtp(struct msgb *msg) { struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg); @@ -1534,7 +1535,8 @@ * framing mode (octet-aligned vs. bandwith-efficient is explicitly * define, then we check if the incoming payload matches that * expectation. */ - if (amr_oa_bwe_convert_indicated(conn_src->end.codec)) { + if (mc->proto == MGCP_PROTO_RTP && + amr_oa_bwe_convert_indicated(conn_src->end.codec)) { int oa = amr_oa_check((char*)msgb_data(msg), msgb_length(msg)); if (oa < 0) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: fix typo RTPC -> RTCP

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27607 ) Change subject: mgcp_network: fix typo RTPC -> RTCP ...................................................................... mgcp_network: fix typo RTPC -> RTCP Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 8ade27d..bcc6652 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1471,7 +1471,7 @@ msgb_put(msg, ret); LOG_CONN_RTP(conn_src, LOGL_DEBUG, "%s: rx %u bytes from %s:%u\n", - proto == MGCP_PROTO_RTP ? "RTP" : "RTPC", + proto == MGCP_PROTO_RTP ? "RTP" : "RTCP", msgb_length(msg), osmo_sockaddr_ntop(&addr.u.sa, ipbuf), osmo_sockaddr_port(&addr.u.sa)); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a Gerrit-Change-Number: 27607 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 ) Change subject: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC ...................................................................... gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC Related: SYS#5908 Depends-on: If240dd13f0f674693018c93390386b2c8afb97af (libosmocore.git) Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 --- M TODO-RELEASE M src/gb_proxy.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 1c5d61f..f17d4ce 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1 +1,2 @@ #component what description / commit summary line +configure.ac libosmocore depend on next released libosmocore after 1.6.0 with (struct bssgp_bvc_fsm_ops)->reset_ack_notification diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 298e132..b4a53bc 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -848,6 +848,7 @@ const struct bssgp_bvc_fsm_ops sgsn_sig_bvc_fsm_ops = { .reset_notification = sgsn_sig_bvc_reset_notif, + .reset_ack_notification = sgsn_sig_bvc_reset_notif, }; /*********************************************************************** -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 Gerrit-Change-Number: 27610 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: fix typo RTPC -> RTCP

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27607 ) Change subject: mgcp_network: fix typo RTPC -> RTCP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27607 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3274441a1bf6f4f015f01017ef03451b7f79310a Gerrit-Change-Number: 27607 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:16:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets

by laforge

Attention is currently required from: pespin, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 ) Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 ) Change subject: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 Gerrit-Change-Number: 27610 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:07:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in libosmocore[master]: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27609 ) Change subject: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged ...................................................................... bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged There are cases where we want to be notified of a successful BVC reset, e.g. for a signalling because we can then start resetting the PtP-BVCs. With this hook it's now possible to do that. Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Related: SYS#5908 --- M TODO-RELEASE M include/osmocom/gprs/bssgp_bvc_fsm.h M src/gb/bssgp_bvc_fsm.c 3 files changed, 7 insertions(+), 0 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 8902371..a6d16d2 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -9,3 +9,4 @@ #library what description / commit summary line libosmogsm ABI BREAKAGE CELL_IDENT_WHOLE_GLOBAL_PS changed enum number libosmogsm add struct member Add codec_list_bss_supported to gsm0808_handover_request_ack (more_items flag ensures ABI compat) +libosmogb ABI BREAKAGE Add reset_ack_notification function pointer to struct bssgp_bvc_fsm_ops diff --git a/include/osmocom/gprs/bssgp_bvc_fsm.h b/include/osmocom/gprs/bssgp_bvc_fsm.h index 446dda8..9d3a620 100644 --- a/include/osmocom/gprs/bssgp_bvc_fsm.h +++ b/include/osmocom/gprs/bssgp_bvc_fsm.h @@ -40,6 +40,8 @@ void (*reset_notification)(uint16_t nsei, uint16_t bvci, const struct gprs_ra_id *ra_id, uint16_t cell_id, uint8_t cause, void *priv); void (*rx_fc_bvc)(uint16_t nsei, uint16_t bvci, const struct bssgp2_flow_ctrl *fc, void *priv); + void (*reset_ack_notification)(uint16_t nsei, uint16_t bvci, const struct gprs_ra_id *ra_id, + uint16_t cell_id, uint8_t cause, void *priv); }; struct osmo_fsm_inst * diff --git a/src/gb/bssgp_bvc_fsm.c b/src/gb/bssgp_bvc_fsm.c index 664ad09..3a36c7d 100644 --- a/src/gb/bssgp_bvc_fsm.c +++ b/src/gb/bssgp_bvc_fsm.c @@ -375,6 +375,7 @@ struct bvc_fsm_priv *bfp = fi->priv; const struct tlv_parsed *tp = NULL; struct msgb *rx = NULL, *tx; + uint8_t cause; switch (event) { case BSSGP_BVCFSM_E_RX_RESET: @@ -385,6 +386,7 @@ /* fall-through */ case BSSGP_BVCFSM_E_RX_RESET_ACK: rx = data; + cause = bfp->last_reset_cause; tp = (const struct tlv_parsed *) msgb_bcid(rx); if (bfp->bvci == 0) update_negotiated_features(fi, tp); @@ -398,6 +400,8 @@ osmo_fsm_inst_state_chg(fi, BSSGP_BVCFSM_S_BLOCKED, T1_SECS, T1); } else osmo_fsm_inst_state_chg(fi, BSSGP_BVCFSM_S_UNBLOCKED, 0, 0); + if (bfp->ops && bfp->ops->reset_ack_notification) + bfp->ops->reset_ack_notification(bfp->nsei, bfp->bvci, &bfp->ra_id, bfp->cell_id, cause, bfp->ops_priv); break; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Gerrit-Change-Number: 27609 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 1 month

1
0
0 0

Change in libosmocore[master]: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27609 ) Change subject: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Adding +1s from before -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Gerrit-Change-Number: 27609 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:04:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in libosmocore[master]: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged

by daniel

Attention is currently required from: daniel. Hello Jenkins Builder, pespin, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/27609 to look at the new patch set (#2). Change subject: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged ...................................................................... bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged There are cases where we want to be notified of a successful BVC reset, e.g. for a signalling because we can then start resetting the PtP-BVCs. With this hook it's now possible to do that. Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Related: SYS#5908 --- M TODO-RELEASE M include/osmocom/gprs/bssgp_bvc_fsm.h M src/gb/bssgp_bvc_fsm.c 3 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/27609/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Gerrit-Change-Number: 27609 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 ) Change subject: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: maybe improve the commit message to add more context. -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 Gerrit-Change-Number: 27610 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:00:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in libosmocore[master]: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27609 ) Change subject: bssgp_bvc_fsm: Add a hook to notify when a reset was acknowledged ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: maybe improve the commit message to add more context. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27609 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If240dd13f0f674693018c93390386b2c8afb97af Gerrit-Change-Number: 27609 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 16:00:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 ) Change subject: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 Gerrit-Change-Number: 27610 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 15:59:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 3: (1 comment) File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604/comment/1c31db9a_2b55… PS1, Line 48: getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e cap_net_raw > Oh pcap here is "process capability". […] It doesn't matter, but this appears to lead to discussions, so I'll pretend that it does matter and use 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 15:28:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 to look at the new patch set (#3). Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... tcpdump capture script: check permissions to fix running in a netns Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d --- M ttcn3-tcpdump-start.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/27604/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27606 ) Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/27606/comment/464db906_1e03cd9e PS2, Line 1521: static int rx_rtp(struct msgb *msg) > It would be great if you can submit a new commit adding a comment here on top explaining that this f […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 15:07:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: do not try to convert RTCP packets

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 to look at the new patch set (#3). Change subject: mgcp_network: do not try to convert RTCP packets ...................................................................... mgcp_network: do not try to convert RTCP packets Make sure that RTCP packets do not enter the code path where AMR OA and BWE is converted. The conversion will fail and the RTCP packet will be dropped. Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Related: SYS#5902 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/06/27606/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic850344d8b5f7710d12e4553a4033b733dced52b Gerrit-Change-Number: 27606 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ran emulation: allow multiple reset attempts

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 ) Change subject: ran emulation: allow multiple reset attempts ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928 Gerrit-Change-Number: 27602 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:47:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC

by pespin

Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 ) Change subject: gbproxy: Ensure PtP-BVCs are reset when we reset the SGSN SIG-BVC ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I6560d8ce1ee6a0d7d42d625b76f6dd637dedb6c0 Gerrit-Change-Number: 27610 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:46:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 1 month

1
0
0 0

2024

2023

2022

gerrit-log March 2022