Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/27627 )
Change subject: WIP: llc: schedule frames to MS based on SAPI priority
......................................................................
Patch Set 1:
(3 comments)
File src/llc.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/6d6517e7_94c95273
PS1, Line 37: union
This line as well as the address field can be moved out of the conditional block to avoid
duplication.
File src/llc.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/82fc5a97_ecf7b419
PS1, Line 99: int i
For the sake of consistency with llc_queue_clear(), it should be unsigned.
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/4f82228a_f118a575
PS1, Line 112:
Unusual formatting.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/27627
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e
Gerrit-Change-Number: 27627
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Mar 2022 18:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment