laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35735?usp=email )
Change subject: pySim.esim.saip: More type annotations
......................................................................
pySim.esim.saip: More type annotations
Change-Id: Ib549817ee137bab610aea9c89a5ab86c2a7592ea
---
M pySim/esim/saip/__init__.py
1 file changed, 20 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/35/35735/1
diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py
index 251395f..7bb2172 100644
--- a/pySim/esim/saip/__init__.py
+++ b/pySim/esim/saip/__init__.py
@@ -16,7 +16,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
import abc
-from typing import Tuple, List, Optional, Dict
+from typing import Tuple, List, Optional, Dict, Union
import asn1tools
@@ -26,7 +26,7 @@
asn1 = compile_asn1_subdir('saip')
class ProfileElement:
- def _fixup_sqnInit_dec(self):
+ def _fixup_sqnInit_dec(self) -> None:
"""asn1tools has a bug when working with SEQUENCE OF that have DEFAULT values. Let's work around
this."""
if self.type != 'akaParameter':
@@ -39,7 +39,7 @@
# SEQUENCE (SIZE (32)) OF OCTET STRING (SIZE (6))
self.decoded['sqnInit'] = [b'\x00'*6] * 32
- def _fixup_sqnInit_enc(self):
+ def _fixup_sqnInit_enc(self) -> None:
"""asn1tools has a bug when working with SEQUENCE OF that have DEFAULT values. Let's work around
this."""
if self.type != 'akaParameter':
@@ -53,7 +53,7 @@
# none of the fields were initialized with a non-default (non-zero) value, so we can skip it
del self.decoded['sqnInit']
- def parse_der(self, der: bytes):
+ def parse_der(self, der: bytes) -> None:
"""Parse a sequence of PE and store the result in instance attributes."""
self.type, self.decoded = asn1.decode('ProfileElement', der)
# work around asn1tools bug regarding DEFAULT for a SEQUENCE OF
@@ -72,7 +72,7 @@
self._fixup_sqnInit_enc()
return asn1.encode('ProfileElement', (self.type, self.decoded))
- def __str__(self):
+ def __str__(self) -> str:
return self.type
@@ -102,7 +102,7 @@
assert len(l) == 1
return l[0]
- def parse_der(self, der: bytes):
+ def parse_der(self, der: bytes) -> None:
"""Parse a sequence of PE and store the result in self.pe_list."""
self.pe_list = []
remainder = der
@@ -111,11 +111,11 @@
self.pe_list.append(ProfileElement.from_der(first_tlv))
self._process_pelist()
- def _process_pelist(self):
+ def _process_pelist(self) -> None:
self._rebuild_pe_by_type()
self._rebuild_pes_by_naa()
- def _rebuild_pe_by_type(self):
+ def _rebuild_pe_by_type(self) -> None:
self.pe_by_type = {}
# build a dict {pe_type: [pe, pe, pe]}
for pe in self.pe_list:
@@ -124,7 +124,7 @@
else:
self.pe_by_type[pe.type] = [pe]
- def _rebuild_pes_by_naa(self):
+ def _rebuild_pes_by_naa(self) -> None:
"""rebuild the self.pes_by_naa dict {naa: [ [pe, pe, pe], [pe, pe] ]} form,
which basically means for every NAA there's a lsit of instances, and each consists
of a list of a list of PEs."""
@@ -165,8 +165,8 @@
out += pe.to_der()
return out
- def __repr__(self):
+ def __repr__(self) -> str:
return "PESequence(%s)" % ', '.join([str(x) for x in self.pe_list])
- def __iter__(self):
+ def __iter__(self) -> str:
yield from self.pe_list
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35735?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib549817ee137bab610aea9c89a5ab86c2a7592ea
Gerrit-Change-Number: 35735
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/35731?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: add SAIP template handling + v3.1 definitions
......................................................................
add SAIP template handling + v3.1 definitions
This adds classes for describing profile templates as well
as derived classes defining the profile templates of the
"Profile Interoperability Technical Specification", specifically
it's "ANNEX A (Normative): File Structure Templates Definition"
We need a machine-readable definition of those templates, so
we can fully interpret an unprotected profile package (UPP),
as the UPP usually only contains the increment/difference to
a given teplate.
Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8
---
A pySim/esim/saip/templates.py
1 file changed, 694 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/35731/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8
Gerrit-Change-Number: 35731
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
saip.personalization: Also drop any fillFileOffset
When replacing a file's contents, we must not just remove any
fillFileContent tuples, but also the fillFileOffset.
Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
---
M pySim/esim/saip/personalization.py
1 file changed, 15 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index 32a53e6..bde7ce6 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -20,13 +20,13 @@
from pySim.esim.saip import ProfileElement, ProfileElementSequence
-def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_key:str) -> List[Tuple]:
+def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_keys: List[str]) -> List[Tuple]:
"""In a list of tuples, remove all tuples whose first part equals 'unwanted_key'."""
- return list(filter(lambda x: x[0] != unwanted_key, l))
+ return list(filter(lambda x: x[0] not in unwanted_keys, l))
def file_replace_content(file: List[Tuple], new_content: bytes):
"""Completely replace all fillFileContent of a decoded 'File' with the new_content."""
- file = remove_unwanted_tuples_from_list(file, 'fillFileContent')
+ file = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset'])
file.append(('fillFileContent', new_content))
return file
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35732?usp=email )
Change subject: requirements.txt: Switch to osmocom fork of asn1tools
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35732?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675
Gerrit-Change-Number: 35732
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:24:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35731?usp=email )
Change subject: add SAIP template handling + v3.1 definitions
......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/35731/comment/6ad8d394_7faa632d
PS1, Line 23: __init__
cosmetic: too many params, may of which are optional. I would go for `**kw` here:
```
def __init__(self, fid:int, name:str, ftype: str, **kw):
# ...
self.foo = kw.get('foo') # defaults to None
self.bar = kw.get('bar', True) # defaults to True
```
https://gerrit.osmocom.org/c/pysim/+/35731/comment/f66bf293_989183cf
PS1, Line 531: FilesUsimDf5GSv2
duplicate definition
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8
Gerrit-Change-Number: 35731
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:13:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35732?usp=email )
Change subject: requirements.txt: Switch to osmocom fork of asn1tools
......................................................................
requirements.txt: Switch to osmocom fork of asn1tools
This is sadly required as the Interoperable Profile format must process
elements of an ASN.1 sequence in order, which doesn't work if the parser
puts the elements in a python dict.
The osmocom fork of asn1tools hence uses OrderedDict to work around
this problem.
Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675
---
M requirements.txt
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/35732/1
diff --git a/requirements.txt b/requirements.txt
index 5b735f0..c12daf8 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -11,6 +11,6 @@
colorlog
pycryptodomex
cryptography
-asn1tools
+git+https://github.com/osmocom/asn1tools
packaging
git+https://github.com/hologram-io/smpp.pdu
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35732?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Id28fcf060f491bb3d76aa6d8026aa76058edb675
Gerrit-Change-Number: 35732
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sun, 28 Jan 2024 21:05:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35729?usp=email )
Change subject: saip.personalization: Also drop any fillFileOffset
......................................................................
saip.personalization: Also drop any fillFileOffset
When replacing a file's contents, we must not just remove any
fillFileContent tuples, but also the fillFileOffset.
Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
---
M pySim/esim/saip/personalization.py
1 file changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/29/35729/1
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index 32a53e6..bde7ce6 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -20,13 +20,13 @@
from pySim.esim.saip import ProfileElement, ProfileElementSequence
-def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_key:str) -> List[Tuple]:
+def remove_unwanted_tuples_from_list(l: List[Tuple], unwanted_keys: List[str]) -> List[Tuple]:
"""In a list of tuples, remove all tuples whose first part equals 'unwanted_key'."""
- return list(filter(lambda x: x[0] != unwanted_key, l))
+ return list(filter(lambda x: x[0] not in unwanted_keys, l))
def file_replace_content(file: List[Tuple], new_content: bytes):
"""Completely replace all fillFileContent of a decoded 'File' with the new_content."""
- file = remove_unwanted_tuples_from_list(file, 'fillFileContent')
+ file = remove_unwanted_tuples_from_list(file, ['fillFileContent', 'fillFileOffset'])
file.append(('fillFileContent', new_content))
return file
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35729?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3e4d97ae9de8a78f7bc0165ece5954481568b800
Gerrit-Change-Number: 35729
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email )
Change subject: tests/Makefile.am: do not add files to EXTRA_DIST conditionally
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35728?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8f530d6157b00907dd1b438100bb0fb300dfcd22
Gerrit-Change-Number: 35728
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Jan 2024 19:42:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email )
Change subject: osmo-release.sh: make it a bit more user friendly
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File osmo-release.sh:
https://gerrit.osmocom.org/c/libosmocore/+/35725/comment/0e55e4aa_8ce0df92
PS1, Line 240: echo "After making changes, add modified file(s) to the index using git-add."
"using git-add and try again"?
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8574cb00de820ab477eb5c4abd05d8e546ca89cc
Gerrit-Change-Number: 35725
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Jan 2024 19:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email )
Change subject: osmo-release.sh: make it a bit more user friendly
......................................................................
osmo-release.sh: make it a bit more user friendly
Change-Id: I8574cb00de820ab477eb5c4abd05d8e546ca89cc
---
M osmo-release.sh
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/35725/1
diff --git a/osmo-release.sh b/osmo-release.sh
index 5f31c5f..e947fe4 100755
--- a/osmo-release.sh
+++ b/osmo-release.sh
@@ -235,7 +235,9 @@
if [ "z$LIBVERS" != "z" ]; then
if [ "z$MAKEMOD" = "z" ] && [ "z$ALLOW_NO_LIBVERSION_CHANGE" = "z0" ]; then
- echo "ERROR: Before releasing, please modify some of the libversions: $LIBVERS"
+ echo "ERROR: Before releasing, please modify some of the libversions:"
+ for l in $LIBVERS; do echo " $l"; done
+ echo "After making changes, add modified file(s) to the index using git-add."
echo "You should NOT be doing this unless you've read and understood following article:"
echo "https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info…"
exit 1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35725?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8574cb00de820ab477eb5c4abd05d8e546ca89cc
Gerrit-Change-Number: 35725
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email )
Change subject: Bump version: 1.5.0.5-aa34 → 1.5.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Please, read https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning. […]
(The link you shared describes the versioning scheme, but does not define the rules. I found them here: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info…).
Even though the library interfaces have not been changed so far, we still need to increment the `revision` according to 7.3 4) "If the library source code has changed at all since the last update ...". I will update the patch.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I88b987d714a88728b62f74a60c44d9c3532b5686
Gerrit-Change-Number: 35720
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 28 Jan 2024 10:42:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email )
Change subject: Bump version: 1.5.0.5-aa34 → 1.5.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> AFAICT, we did not add/modify API since the last release. […]
Please, read https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.ht…, you still need to update the revision field.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I88b987d714a88728b62f74a60c44d9c3532b5686
Gerrit-Change-Number: 35720
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Jan 2024 22:11:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35721?usp=email )
Change subject: ara_m: Permit encoding of empty AID (--aid '') in ARA-M rules
......................................................................
ara_m: Permit encoding of empty AID (--aid '') in ARA-M rules
Encoding an empty AID-REF-DO (4F) is neccessary to achieve the meaning
described in "Secure Element Access Control - Public Release v1.0"
Table 6-1: "Empty: Indicates that the rules to be stored or retrieved
are associated with all SE applications not covered by a specific rule".
Change-Id: Iac6c3d78bc9ce36bac47589e5f7a0cc78e2efc38
---
M pySim/ara_m.py
1 file changed, 15 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index 68244d1..f05109b 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -348,7 +348,7 @@
"""Perform STORE DATA [Command-Store-REF-AR-DO] to store a (new) access rule."""
# REF
ref_do_content = []
- if opts.aid:
+ if opts.aid != None:
ref_do_content += [{'aid_ref_do': opts.aid}]
elif opts.aid_empty:
ref_do_content += [{'aid_ref_empty_do': None}]
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35721?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iac6c3d78bc9ce36bac47589e5f7a0cc78e2efc38
Gerrit-Change-Number: 35721
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35722?usp=email )
Change subject: ara_m: Use GlobalPlatform SELECT decoding
......................................................................
ara_m: Use GlobalPlatform SELECT decoding
As the ARA-M applet is a GlobalPlatform applet, its SELECT response
decoding should be used, not the ETSI EUICC TS 102 221 fall-back.
Change-Id: I1a30b88a385f6de663aa837483dd32c0d104856f
---
M pySim/ara_m.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index f05109b..a2eaa33 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -31,6 +31,7 @@
from pySim.construct import *
from pySim.filesystem import *
from pySim.tlv import *
+import pySim.global_platform
# various BER-TLV encoded Data Objects (DOs)
@@ -259,6 +260,9 @@
files = []
self.add_files(files)
+ def decode_select_response(self, data_hex):
+ return pySim.global_platform.decode_select_response(data_hex)
+
@staticmethod
def xceive_apdu_tlv(tp, hdr: Hexstr, cmd_do, resp_cls, exp_sw='9000'):
"""Transceive an APDU with the card, transparently encoding the command data from TLV
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35722?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1a30b88a385f6de663aa837483dd32c0d104856f
Gerrit-Change-Number: 35722
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35723?usp=email )
Change subject: runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
......................................................................
runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
In case SELECT doesn't return any response data, we must reset
the lchan.selected_file_fcp* members to None to prevent pySim-shell
preventing stale data from the previously selected file.
Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
---
M pySim/runtime.py
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/runtime.py b/pySim/runtime.py
index f836ec8..3aeaab1 100644
--- a/pySim/runtime.py
+++ b/pySim/runtime.py
@@ -304,6 +304,9 @@
if select_resp_data:
self.selected_file_fcp_hex = select_resp_data
self.selected_file_fcp = self.selected_file.decode_select_response(select_resp_data)
+ else:
+ self.selected_file_fcp_hex = None
+ self.selected_file_fcp = None
# register commands of new file
if cmd_app and self.selected_file.shell_commands:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
Gerrit-Change-Number: 35723
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35724?usp=email )
Change subject: [cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
......................................................................
[cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
PERM-AR-DO actually originates in a different spec than all other parts
of the ara_m.py, so let's explicitly mention that.
Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
---
M pySim/ara_m.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index a2eaa33..d137dcf 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -116,6 +116,7 @@
class PermArDO(BER_TLV_IE, tag=0xdb):
# Android UICC Carrier Privileges specific extension, see https://source.android.com/devices/tech/config/uicc
+ # based on Table 6-8 of GlobalPlatform Device API Access Control v1.0
_construct = Struct('permissions'/HexAdapter(Bytes(8)))
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
Gerrit-Change-Number: 35724
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35723?usp=email )
Change subject: runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
Gerrit-Change-Number: 35723
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 27 Jan 2024 20:50:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35721?usp=email )
Change subject: ara_m: Permit encoding of empty AID (--aid '') in ARA-M rules
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35721?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iac6c3d78bc9ce36bac47589e5f7a0cc78e2efc38
Gerrit-Change-Number: 35721
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 27 Jan 2024 20:50:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35724?usp=email )
Change subject: [cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
Gerrit-Change-Number: 35724
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Sat, 27 Jan 2024 20:50:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35721?usp=email )
Change subject: ara_m: Permit encoding of empty AID (--aid '') in ARA-M rules
......................................................................
ara_m: Permit encoding of empty AID (--aid '') in ARA-M rules
Encoding an empty AID-REF-DO (4F) is neccessary to achieve the meaning
described in "Secure Element Access Control - Public Release v1.0"
Table 6-1: "Empty: Indicates that the rules to be stored or retrieved
are associated with all SE applications not covered by a specific rule".
Change-Id: Iac6c3d78bc9ce36bac47589e5f7a0cc78e2efc38
---
M pySim/ara_m.py
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/35721/1
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index 68244d1..f05109b 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -348,7 +348,7 @@
"""Perform STORE DATA [Command-Store-REF-AR-DO] to store a (new) access rule."""
# REF
ref_do_content = []
- if opts.aid:
+ if opts.aid != None:
ref_do_content += [{'aid_ref_do': opts.aid}]
elif opts.aid_empty:
ref_do_content += [{'aid_ref_empty_do': None}]
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35721?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iac6c3d78bc9ce36bac47589e5f7a0cc78e2efc38
Gerrit-Change-Number: 35721
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35722?usp=email )
Change subject: ara_m: Use GlobalPlatform SELECT decoding
......................................................................
ara_m: Use GlobalPlatform SELECT decoding
As the ARA-M applet is a GlobalPlatform applet, its SELECT response
decoding should be used, not the ETSI EUICC TS 102 221 fall-back.
Change-Id: I1a30b88a385f6de663aa837483dd32c0d104856f
---
M pySim/ara_m.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/35722/1
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index f05109b..a2eaa33 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -31,6 +31,7 @@
from pySim.construct import *
from pySim.filesystem import *
from pySim.tlv import *
+import pySim.global_platform
# various BER-TLV encoded Data Objects (DOs)
@@ -259,6 +260,9 @@
files = []
self.add_files(files)
+ def decode_select_response(self, data_hex):
+ return pySim.global_platform.decode_select_response(data_hex)
+
@staticmethod
def xceive_apdu_tlv(tp, hdr: Hexstr, cmd_do, resp_cls, exp_sw='9000'):
"""Transceive an APDU with the card, transparently encoding the command data from TLV
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35722?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I1a30b88a385f6de663aa837483dd32c0d104856f
Gerrit-Change-Number: 35722
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35724?usp=email )
Change subject: [cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
......................................................................
[cosmetic] ara_m: Give a spec reference for the PERM-AR-DO
PERM-AR-DO actually originates in a different spec than all other parts
of the ara_m.py, so let's explicitly mention that.
Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
---
M pySim/ara_m.py
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/35724/1
diff --git a/pySim/ara_m.py b/pySim/ara_m.py
index a2eaa33..7631d07 100644
--- a/pySim/ara_m.py
+++ b/pySim/ara_m.py
@@ -116,6 +116,7 @@
class PermArDO(BER_TLV_IE, tag=0xdb):
# Android UICC Carrier Privileges specific extension, see https://source.android.com/devices/tech/config/uicc
+ # based on Table 6-8 of GlobalPlatfomr Device API Access Control v1.0
_construct = Struct('permissions'/HexAdapter(Bytes(8)))
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35724?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6e0014c323f605860d0f70cd0c04d7e461e8a9de
Gerrit-Change-Number: 35724
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35723?usp=email )
Change subject: runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
......................................................................
runtime: Reset selected_file_fcp[_hex] if SELECT returns no data
In case SELECT doesn't return any response data, we must reset
the lchan.selected_file_fcp* members to None to prevent pySim-shell
preventing stale data from the previously selected file.
Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
---
M pySim/runtime.py
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/35723/1
diff --git a/pySim/runtime.py b/pySim/runtime.py
index f836ec8..3aeaab1 100644
--- a/pySim/runtime.py
+++ b/pySim/runtime.py
@@ -304,6 +304,9 @@
if select_resp_data:
self.selected_file_fcp_hex = select_resp_data
self.selected_file_fcp = self.selected_file.decode_select_response(select_resp_data)
+ else:
+ self.selected_file_fcp_hex = None
+ self.selected_file_fcp = None
# register commands of new file
if cmd_app and self.selected_file.shell_commands:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35723?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia04b8634e328e604e8df7e8d59b7fd532242d2ca
Gerrit-Change-Number: 35723
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email )
Change subject: Bump version: 1.5.0.5-aa34 → 1.5.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> You are missing updating the revision (middle field) in LIBVERSION for both libraries: […]
AFAICT, we did not add/modify API since the last release. Shall I still bump those?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/35720?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I88b987d714a88728b62f74a60c44d9c3532b5686
Gerrit-Change-Number: 35720
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Jan 2024 18:43:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/a504d852_2cafe0c9
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> I am certainly not an expert in English grammar, but I think it should be `an` because `M` in `MGCP` […]
Ack, I remember discussuing and looking at it previously with Daniel and it seems the sound is the one actually marking whether it's "an" or "n", not the letter.
since MGCP is pronunced EM... hence a vowel sound, it should use "an".
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 27 Jan 2024 18:32:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(1 comment)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/03384690_72d38d42
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> I intentionally switched all 'an' to 'a' since M is not a vowel?
I am certainly not an expert in English grammar, but I think it should be `an` because `M` in `MGCP` acronym, while being not a vowel, is a _vowel sound_ `em`. This is not the case if you automatically expand the acronyms when reading them ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 21:21:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: daniel, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email )
Change subject: Convert README to README.md and expand like in other projects
......................................................................
Patch Set 2:
(2 comments)
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/909b843e_b6f569d5
PS1, Line 9: The OsmoMGW program exposes an MGCP interface towards a MGPC call agent
> AFAICS, not addressed: `s/a/an/`.
I intentionally switched all 'an' to 'a' since M is not a vowel?
File README.md:
https://gerrit.osmocom.org/c/osmo-mgw/+/35718/comment/40f58cba_01f92034
PS2, Line 9: MGPC
> wait, it's MGCP, right?
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35718?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id9a78ccc0d10f0e3a9d832ac4c4988cfbb8ddb3c
Gerrit-Change-Number: 35718
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 26 Jan 2024 21:07:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment