Attention is currently required from: pespin, daniel.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/34224 )
Change subject: stream tests: Eliminate timestamps from output
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Simply and plain for me: I just submitted a test patch
based on libosmo-netif master and it's passin […]
This doesn't prove that
the problem is local or related to my patch.
The problems have been that for two patches (see above text, "Add ... support for
IPA", for the server side patch I found a workaround by using a different local
port), timestamps all of a sudden stopped being predictable and hence tests failed with
these patches (.ok-output not matching).
The test code itself has not been changed and you can read above what commits are causing
this deviation in timestamps (I haven't yet busied myself with identifying the exact
reason or commit, my guess is it doesn't matter in the end).
If you were to rebase
https://gerrit.osmocom.org/c/libosmo-netif/+/33198/19 on
libosmo-netif master - I gave the then-HEAD commit hash for reference - , you should be
able see what I'm talking about (the lastest revision - 20 - was uploaded together
with this change and doesn't use timestamps, so it would fail for other discrepancies
in stdout output).
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/34224
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c
Gerrit-Change-Number: 34224
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment