- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: sane embedded builds without host talloc
by Hoernchen 11 Mar '26

11 Mar '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email ) Change subject: sane embedded builds without host talloc ...................................................................... sane embedded builds without host talloc So far host talloc was always required. This fixes this up to only build a subset of stuff that actually works for embedded targets while using the pseudotalloc header file, and the actual firmware can supply its own talloc, without involving some random build system supplied talloc headers. Unfortunately static symbols can't really be weak, so just going for always-on weak pseudotalloc does not work. Change-Id: Ibb309a01ac6cad827b33ac18be408be1ac2cf7e0 --- M configure.ac M libosmocore.pc.in M src/Makefile.am M src/core/Makefile.am M src/core/backtrace.c M src/core/panic.c 6 files changed, 55 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/08/42308/1 diff --git a/configure.ac b/configure.ac index b5f858f..3eaf0ad 100644 --- a/configure.ac +++ b/configure.ac @@ -217,8 +217,6 @@ dnl Don't require a newer version than 3.4, we build poky 201705 on debian 8 AM_PATH_PYTHON([3.4]) -PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) - ENABLE_URING_DEFAULT="yes" ENABLE_PCSC_DEFAULT="yes" ENABLE_LIBUSB_DEFAULT="yes" @@ -503,6 +501,19 @@ AC_DEFINE([ENABLE_PSEUDOTALLOC], [1], [Enable building pseudotalloc library]) ]) +dnl In embedded mode, talloc is provided externally (e.g. by the firmware project) +dnl or via pseudotalloc. Only check for system talloc in non-embedded, non-pseudotalloc builds. +AS_IF([test "x$enable_pseudotalloc" != "xyes" && test "x$embedded" != "xyes"], [ + PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) + AC_SUBST(TALLOC_PC, [talloc]) +], [ + TALLOC_CFLAGS="" + TALLOC_LIBS="" + AC_SUBST(TALLOC_PC, []) +]) +AC_SUBST(TALLOC_CFLAGS) +AC_SUBST(TALLOC_LIBS) + AC_ARG_ENABLE(log_macros, [AS_HELP_STRING( [--disable-log-macros], diff --git a/libosmocore.pc.in b/libosmocore.pc.in index 6479221..d2928fd 100644 --- a/libosmocore.pc.in +++ b/libosmocore.pc.in @@ -6,7 +6,7 @@ Name: Osmocom Core Library Description: C Utility Library Version: @VERSION@ -Requires: talloc @LIBMNL_PC@ +Requires: @TALLOC_PC@ @LIBMNL_PC@ Requires.private: @LIBSCTP_PC@ Libs: -L${libdir} -losmocore Libs.private: @PTHREAD_LIBS@ @LIBSCTP_LIBS@ diff --git a/src/Makefile.am b/src/Makefile.am index 8606646..57e897f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,5 +1,10 @@ SUBDIRS = \ core \ + pseudotalloc \ + $(NULL) + +if !EMBEDDED +SUBDIRS += \ vty \ isdn \ codec \ @@ -7,7 +12,7 @@ coding \ gb \ ctrl \ - pseudotalloc \ sim \ usb \ - $(NULL) \ No newline at end of file + $(NULL) +endif \ No newline at end of file diff --git a/src/core/Makefile.am b/src/core/Makefile.am index b89cb70..bfe3050 100644 --- a/src/core/Makefile.am +++ b/src/core/Makefile.am @@ -8,6 +8,10 @@ if ENABLE_PSEUDOTALLOC AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc +else +if EMBEDDED +AM_CPPFLAGS += -I$(top_srcdir)/src/pseudotalloc +endif endif lib_LTLIBRARIES = libosmocore.la @@ -22,44 +26,54 @@ $(NULL) libosmocore_la_SOURCES = \ - application.c \ backtrace.c \ base64.c \ bits.c \ - bitvec.c \ bitcomp.c \ - context.c \ conv.c \ conv_acc.c \ conv_acc_generic.c \ - counter.c \ crc16.c \ crc8gen.c \ crc16gen.c \ crc32gen.c \ crc64gen.c \ - exec.c \ fsm.c \ - gsmtap_util.c \ isdnhdlc.c \ - it_q.c \ logging.c \ + loggingrb.c \ + msgb.c \ + panic.c \ + prbs.c \ + rbtree.c \ + sercomm.c \ + tdef.c \ + timer.c \ + timer_gettimeofday.c \ + timer_clockgettime.c \ + utils.c \ + probes.d \ + $(NULL) + +if !EMBEDDED +libosmocore_la_SOURCES += \ + application.c \ + bitvec.c \ + context.c \ + counter.c \ + exec.c \ + gsmtap_util.c \ + it_q.c \ logging_file.c \ logging_gsmtap.c \ - loggingrb.c \ macaddr.c \ - msgb.c \ netdev.c \ netns.c \ osmo_io.c \ osmo_io_poll.c \ - panic.c \ - prbs.c \ prim.c \ rate_ctr.c \ - rbtree.c \ select.c \ - sercomm.c \ signal.c \ sockaddr_str.c \ socket.c \ @@ -69,18 +83,13 @@ stats_statsd.c \ stats_tcp.c \ strrb.c \ - tdef.c \ thread.c \ time_cc.c \ - timer.c \ - timer_gettimeofday.c \ - timer_clockgettime.c \ tun.c \ use_count.c \ - utils.c \ write_queue.c \ - probes.d \ $(NULL) +endif if HAVE_EMSCRIPTEN libosmocore_la_SOURCES += logging_emscripten.c diff --git a/src/core/backtrace.c b/src/core/backtrace.c index 60bd238..5930cb7 100644 --- a/src/core/backtrace.c +++ b/src/core/backtrace.c @@ -22,9 +22,9 @@ #include <stdio.h> #include <stdlib.h> +#include "config.h" #include <osmocom/core/utils.h> #include <osmocom/core/logging.h> -#include "config.h" #ifdef HAVE_EXECINFO_H #include <execinfo.h> diff --git a/src/core/panic.c b/src/core/panic.c index bbf6d08..f8efd00 100644 --- a/src/core/panic.c +++ b/src/core/panic.c @@ -100,4 +100,9 @@ osmo_panic_handler = h; } +#ifdef EMBEDDED +/* thread.c is excluded from the embedded build (requires POSIX pid_t/getpid) */ +int osmo_gettid(void) { return 0; } +#endif + /*! @} */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb309a01ac6cad827b33ac18be408be1ac2cf7e0 Gerrit-Change-Number: 42308 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ccid: properly emit wait time ext messages ...................................................................... ccid: properly emit wait time ext messages The CCID message that tells the host that the card asked for a wait time extension was missing. This is a bit weird, because it breaks the 1:1 relationship between messages and responses that usually exists, nor does it consume a bSeq, so we just count and emit WT msgs as appropriate. Closes: OS#6458 Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 --- M ccid_common/ccid_device.h M ccid_common/ccid_slot_fsm.c M ccid_common/iso7816_fsm.c M ccid_common/iso7816_fsm.h 4 files changed, 99 insertions(+), 82 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/06/42306/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: firmware: enable watchdog timer
by Hoernchen 11 Mar '26

11 Mar '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42307?usp=email ) Change subject: firmware: enable watchdog timer ...................................................................... firmware: enable watchdog timer 2s is plenty, and while not perfect it should at least ensure that hangs that require manual intervention happen rarely if at all. At least from a custimer POV having resets in case something breaks is better than ending up with non working devices that are stuck. Change-Id: I1ef1fc70d33492efe0171a7879c1a23f16957195 --- M sysmoOCTSIM/main.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/07/42307/1 diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c index 74de4bf..75fb4ad 100644 --- a/sysmoOCTSIM/main.c +++ b/sysmoOCTSIM/main.c @@ -685,6 +685,17 @@ printf("Chip ID: %s\r\n", sernr_buf); printf("Reset cause: %s\r\n", rstcause_buf); + /* Configure and enable WDT with ~2s timeout (2048 cycles @ 1.024 kHz) */ + while (WDT->SYNCBUSY.reg) + ; + WDT->CONFIG.reg = WDT_CONFIG_PER_CYC2048; + while (WDT->SYNCBUSY.reg) + ; + WDT->CTRLA.reg = WDT_CTRLA_ENABLE; + while (WDT->SYNCBUSY.reg) + ; + printf("Watchdog enabled (2s timeout)\r\n"); + talloc_enable_null_tracking(); g_tall_ctx = talloc_named_const(NULL, 0, "global"); printf("g_tall_ctx=%p\r\n", g_tall_ctx); @@ -737,6 +748,9 @@ } feed_ccid(); osmo_timers_update(); + + /* Pet the watchdog */ + WDT->CLEAR.reg = WDT_CLEAR_CLEAR_KEY; int qs = llist_count_at(&g_ccid_s.free_q); if (qs > NUM_OUT_BUF) for (int i = 0; i < qs - NUM_OUT_BUF; i++) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1ef1fc70d33492efe0171a7879c1a23f16957195 Gerrit-Change-Number: 42307 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by Hoernchen 11 Mar '26

11 Mar '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... ccid: properly emit wait time ext messages The CCID message that tells the host that the card asked for a wait time extension was missing. This is a bit weird, because it breaks the 1:1 relationship between messages and responses that usually exists, nor does it consume a bSeq, so we just count and emit WT msgs as appropriate. Closes: OS#6458 Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 --- M ccid_common/ccid_device.h M ccid_common/ccid_slot_fsm.c M ccid_common/iso7816_fsm.c M ccid_common/iso7816_fsm.h 4 files changed, 46 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/06/42306/1 diff --git a/ccid_common/ccid_device.h b/ccid_common/ccid_device.h index 97d6212..ee2b5e2 100644 --- a/ccid_common/ccid_device.h +++ b/ccid_common/ccid_device.h @@ -78,6 +78,8 @@ const struct ccid_pars_decoded *default_pars; volatile uint32_t event; volatile void* event_data; + /* count of pending Wait Time Extension notifications to send to host */ + volatile uint32_t wtime_ext; }; /* CCID operations provided by USB transport layer */ diff --git a/ccid_common/ccid_slot_fsm.c b/ccid_common/ccid_slot_fsm.c index c34ad72..307c50f 100644 --- a/ccid_common/ccid_slot_fsm.c +++ b/ccid_common/ccid_slot_fsm.c @@ -102,6 +102,7 @@ card_uart_ctrl(ss->cuart, CUART_CTL_POWER_5V0, false); cs->icc_powered = false; cs->cmd_busy = false; + cs->wtime_ext = 0; } } @@ -175,6 +176,10 @@ case ISO7816_E_HW_ERR_IND: card_uart_ctrl(ss->cuart, CUART_CTL_NO_RXTX, true); break; + case ISO7816_E_WTIME_EXT_IND: + /* card sent NULL byte (0x60); notify host via intermediate TimeExtension response */ + cs->wtime_ext++; + break; case ISO7816_E_ATR_ERR_IND: case ISO7816_E_TPDU_FAILED_IND: case ISO7816_E_PPS_FAILED_IND: @@ -206,6 +211,27 @@ volatile uint32_t event = cs->event; volatile void * volatile data = cs->event_data; + /* send pending Wait Time Extension notifications to host. + * wtime_ext is incremented from ISR context (UART RX -> FSM -> user_cb), + * so we must atomically read-and-clear to avoid losing increments. */ + if (cs->wtime_ext) { + uint32_t wt_pending; +#ifdef OCTSIMFWBUILD + CRITICAL_SECTION_ENTER(); +#endif + wt_pending = cs->wtime_ext; + cs->wtime_ext = 0; +#ifdef OCTSIMFWBUILD + CRITICAL_SECTION_LEAVE(); +#endif + for (uint32_t i = 0; i < wt_pending; i++) { + LOGPCS(cs, LOGL_DEBUG, "Sending Wait Time Extension to host\n"); + resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_TIME_EXT, 1, NULL, 0); + /* this does neither consume the bSeq nor unbusy the slot! */ + ccid_slot_send(cs, resp); + } + } + if (!event) return 0; // if(event && !data) @@ -224,6 +250,7 @@ resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_FAILED, CCID_ERR_ICC_MUTE, 0, 0); ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case ISO7816_E_ATR_DONE_IND: tpdu = data; @@ -239,6 +266,7 @@ resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_OK, 0, msgb_data(tpdu), msgb_length(tpdu)); ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case ISO7816_E_ATR_ERR_IND: tpdu = data; @@ -252,6 +280,7 @@ resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_FAILED, CCID_ERR_ICC_MUTE, msgb_data(tpdu), msgb_length(tpdu)); ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; break; case ISO7816_E_TPDU_DONE_IND: @@ -261,6 +290,7 @@ resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_OK, 0, msgb_l4(tpdu), msgb_l4len(tpdu)); ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case ISO7816_E_TPDU_FAILED_IND: tpdu = data; @@ -275,6 +305,7 @@ resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_FAILED, CCID_ERR_ICC_MUTE, msgb_l2(tpdu), 0); ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case ISO7816_E_PPS_DONE_IND: tpdu = data; @@ -310,6 +341,7 @@ ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case ISO7816_E_PPS_UNSUPPORTED_IND: /* unsupported means no response, failed means request/response mismatch @@ -331,6 +363,7 @@ ccid_slot_send_unbusy(cs, resp); cs->event = 0; + cs->wtime_ext = 0; break; case 0: break; diff --git a/ccid_common/iso7816_fsm.c b/ccid_common/iso7816_fsm.c index a035148..c59bc7d 100644 --- a/ccid_common/iso7816_fsm.c +++ b/ccid_common/iso7816_fsm.c @@ -228,6 +228,7 @@ { ISO7816_E_ATR_DONE_IND, "ATR_DONE_IND" }, { ISO7816_E_ATR_ERR_IND, "ATR_ERR_IND" }, { ISO7816_E_TPDU_DONE_IND, "TPDU_DONE_IND" }, + { ISO7816_E_WTIME_EXT_IND, "WTIME_EXT_IND" }, { ISO7816_E_XCEIVE_TPDU_CMD, "XCEIVE_TPDU_CMD" }, /* allstate events */ { ISO7816_E_WTIME_EXP, "WAIT_TIME_EXP" }, @@ -432,6 +433,10 @@ /* hand finished TPDU to user */ ip->user_cb(fi, event, 0, apdu); break; + case ISO7816_E_WTIME_EXT_IND: + /* notify user of wait time extension; TPDU still in progress! */ + ip->user_cb(fi, event, 0, NULL); + break; default: OSMO_ASSERT(0); } @@ -588,7 +593,8 @@ S(ISO7816_E_TX_COMPL) | S(ISO7816_E_RX_ERR_IND) | S(ISO7816_E_TX_ERR_IND) | - S(ISO7816_E_TPDU_DONE_IND), + S(ISO7816_E_TPDU_DONE_IND) | + S(ISO7816_E_WTIME_EXT_IND), .out_state_mask = S(ISO7816_S_RESET) | S(ISO7816_S_WAIT_TPDU) | S(ISO7816_S_IN_TPDU), @@ -1319,6 +1325,7 @@ LOGPFSML(fi, LOGL_DEBUG, "Received 0x%02x from UART\n", byte); if (byte == 0x60) { /* NULL: wait for another procedure byte */ + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_WTIME_EXT_IND, NULL); card_uart_set_rx_threshold(ip->uart, 1); card_uart_ctrl(ip->uart, CUART_CTL_RX_TIMER_HINT, 1); osmo_fsm_inst_state_chg(fi, TPDU_S_PROCEDURE, 0, 0); @@ -1490,6 +1497,7 @@ LOGPFSML(fi, LOGL_DEBUG, "Received 0x%02x from UART\n", byte); if (byte == 0x60) { /* NULL: wait for actual SW1 */ + osmo_fsm_inst_dispatch(fi->proc.parent, ISO7816_E_WTIME_EXT_IND, NULL); card_uart_set_rx_threshold(ip->uart, 1); card_uart_ctrl(ip->uart, CUART_CTL_RX_TIMER_HINT, 1); osmo_fsm_inst_state_chg(fi, TPDU_S_SW1, 0, 0); diff --git a/ccid_common/iso7816_fsm.h b/ccid_common/iso7816_fsm.h index fb37396..542880a 100644 --- a/ccid_common/iso7816_fsm.h +++ b/ccid_common/iso7816_fsm.h @@ -47,6 +47,8 @@ /* TODO: Rx FIFO overrun */ /* TODO: Rx buffer overrun */ + ISO7816_E_WTIME_EXT_IND, /*!< Wait Time Extension (NULL byte 0x60) from card */ + /* internal events between FSMs in this file */ ISO7816_E_ATR_DONE_IND, /*!< ATR Done indication from ATR child FSM */ ISO7816_E_ATR_ERR_IND, /*!< ATR Error indication from ATR child FSM */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[M] Change in pysim[master]: pySim/transport: fix GET RESPONSE behaviour
by laforge 10 Mar '26

10 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email ) Change subject: pySim/transport: fix GET RESPONSE behaviour ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Patchset: PS4: it would be good to introduce some testing of this new fixed handling e.g.by checking the number of remaining PIN attempts which was failing in the OS#6970. Said test could be introduced together with this patch so we can immediately see it now works? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26f0566af0cdd61dcc97f5f502479dc76adc37cc Gerrit-Change-Number: 42301 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:26:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim/transport: fix GET RESPONSE behaviour
by laforge 10 Mar '26

10 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email ) Change subject: pySim/transport: fix GET RESPONSE behaviour ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I would argue actual bugfixes have higher priority and should hence be at the start of a patch series, and not at the end where they're blocked by more cosmetic changes in front of them -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26f0566af0cdd61dcc97f5f502479dc76adc37cc Gerrit-Change-Number: 42301 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by laforge 10 Mar '26

10 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42305?usp=email ) Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... Patch Set 1: (1 comment) File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/42305/comment/701fab1c_99ad18f2?usp=em… : PS1, Line 84: # Setup logger : PySimLogger.setup(print, {logging.WARN: "\033[33m"}) : if (opts.verbose): : PySimLogger.set_verbose(True) : PySimLogger.set_level(logging.DEBUG) : else: : PySimLogger.set_verbose(False) : PySimLogger.set_level(logging.INFO) it looks like this should go in some generic helper function that we call from all the programs, simply passing a "verbose:bool = False" argument into the function? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:23:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: contrib/csv-to_pgsl: explicitly set log level to INFO in non verbose ...
by laforge 10 Mar '26

10 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42304?usp=email ) Change subject: contrib/csv-to_pgsl: explicitly set log level to INFO in non verbose mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 Gerrit-Change-Number: 42304 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:22:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: build: install common/GSM/transceiver libraries for emscripten and ad...
by Timur Davydov 10 Mar '26

10 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 4: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/63a71d84_2e62190b?usp… : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f) > How is for instance […] It isn't — and it doesn't need to be. `Channelizer`/`Synthesis` are compiled into object files inside the static library `libtransceiver_common.a`, but no code in the Emscripten binary actually references them. They are only ever instantiated by `RadioInterfaceMulti` (in `radioInterfaceMulti.cpp`), which is not part of the Emscripten link target. With static libraries, the linker only pulls in object files that resolve symbols actually referenced by the binary. Since nothing calls `Channelizer`/`Synthesis`, their objects are never pulled from the archive, and the unresolved `cxvec_fft()` symbol is never encountered. It simply stays unused inside the .a file. Btw, I'm currently reworking this commit. My plan is to introduce a separate `web` target in `devices` that will produce a static library `osmo-trx-web.a` containing everything needed to build `osmo-bts` with Emscripten. It will only be built when the `--with-web` configure flag is enabled. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 12:02:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in pysim[master]: contrib/csv-to_pgsl: explicitly set log level to INFO in non verbose ...
by dexter 10 Mar '26

10 Mar '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42304?usp=email ) Change subject: contrib/csv-to_pgsl: explicitly set log level to INFO in non verbose mode ...................................................................... contrib/csv-to_pgsl: explicitly set log level to INFO in non verbose mode The current log level for PySimLogger currently is DEBUG. (The default for verbose is False). Since those defaults may change over time, we should conciously set what we want in verbose and non verbose mode, like we already do in pySim-shell. Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 --- M contrib/csv-to-pgsql.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/42304/1 diff --git a/contrib/csv-to-pgsql.py b/contrib/csv-to-pgsql.py index 416d870..c3c480f 100755 --- a/contrib/csv-to-pgsql.py +++ b/contrib/csv-to-pgsql.py @@ -289,6 +289,9 @@ if (opts.verbose): PySimLogger.set_verbose(True) PySimLogger.set_level(logging.DEBUG) + else + PySimLogger.set_verbose(False) + PySimLogger.set_level(logging.INFO) # Open CSV file cr = open_csv(opts) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 Gerrit-Change-Number: 42304 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log