[M] Change in osmo-msc[master]: add configurable DTMF support via RTP or SIP
Attention is currently required from: lynxis lazus. falconia has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email ) Change subject: add configurable DTMF support via RTP or SIP ...................................................................... Patch Set 1: (3 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/79156a9d_0e810196?usp=... : PS1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */
Acknowledged I second the request to change the naming from SIP to MNCC. In Osmocom+ThemWi hybrid networks like the one being built by American 2G Cooperative, the MNCC system connected to osmo-msc is absolutely not SIP - while we do have SIP-I deeper in the CN, there is no osmo-sip-connector and no SIP directly coupled to osmo-msc.
https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/d6eeae28_3f508394?usp=... : PS1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */
Acknowledged, I when I read "DTMF via RTP" i was immediately thinking of in-line tones being injecte […] In the network being built by A2GC, we are in fact injecting actual DTMF waveforms into the G.711 PCM sample stream generated by our transcoding MGW! Hence I vote for a name like MGCP_RQNT (out of @pespin@sysmocom.de's suggestions), as opposed to something that refers specifically to RFC 4733 to the exclusion of the in-band option.
File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/44024/comment/040517f3_6cf48084?usp=... : PS1, Line 691: rtp|sip Can we please make it `(mgw|mncc)` instead? This way it will cover alternative possibilities of MNCC being non-SIP and the MGW being a transcoder that can do either RFC 4733 or in-band. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44024?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Icd33a0b412f39a56046e57038551332776be2ba1 Gerrit-Change-Number: 44024 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: falconia <falcon@freecalypso.org> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Sat, 07 Nov 2026 09:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de>
participants (1)
-
falconia