Attention is currently required from: lynxis lazus.
3 comments:
File include/osmocom/msc/gsm_data.h:
Patch Set #1, Line 149: DTMF_MODE_SIP = 0, /* forward via MNCC to SIP connector (default) */
Acknowledged
I second the request to change the naming from SIP to MNCC. In Osmocom+ThemWi hybrid networks like the one being built by American 2G Cooperative, the MNCC system connected to osmo-msc is absolutely not SIP - while we do have SIP-I deeper in the CN, there is no osmo-sip-connector and no SIP directly coupled to osmo-msc.
Patch Set #1, Line 150: DTMF_MODE_RTP, /* RFC 4733 telephone-event via MGCP RQNT */
Acknowledged, I when I read "DTMF via RTP" i was immediately thinking of in-line tones being injecte […]
In the network being built by A2GC, we are in fact injecting actual DTMF waveforms into the G.711 PCM sample stream generated by our transcoding MGW! Hence I vote for a name like MGCP_RQNT (out of @pespin@sysmocom.de's suggestions), as opposed to something that refers specifically to RFC 4733 to the exclusion of the in-band option.
File src/libmsc/msc_vty.c:
Patch Set #1, Line 691: rtp|sip
Can we please make it `(mgw|mncc)` instead? This way it will cover alternative possibilities of MNCC being non-SIP and the MGW being a transcoder that can do either RFC 4733 or in-band.
To view, visit change 44024. To unsubscribe, or for help writing mail filters, visit settings.