Attention is currently required from: fixeria, laforge, pespin.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email )
Change subject: core: fix config.h
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
> I did fully understand the proposal by @fixeria and I would be fine if we did that. […]
now with a masterfully crafted jenkins hook
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2026 16:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Hoernchen, laforge, pespin.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by pespin, Verified-1 by Jenkins Builder
Change subject: core: fix config.h
......................................................................
core: fix config.h
While exploring why logging is disabled but still shows up in the binaries
I kind of wondered how all the config.h HAVE_XX checks we have everwhere work.
Apparently they do not work at all, due to missing or misplaced include of config.h.
This affects tons of other checks as well.
The jenkins hook ensures the include order is checked to ensure config.h
does not get misplaced or lost in the future.
Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
---
M contrib/jenkins_common.sh
M src/core/application.c
M src/core/backtrace.c
M src/core/base64.c
M src/core/bitcomp.c
M src/core/bits.c
M src/core/bitvec.c
M src/core/context.c
M src/core/conv_acc_generic.c
M src/core/counter.c
M src/core/crc16.c
M src/core/crcXXgen.c.tpl
M src/core/fsm.c
M src/core/isdnhdlc.c
M src/core/logging_emscripten.c
M src/core/logging_systemd.c
M src/core/loggingrb.c
M src/core/mnl.c
M src/core/msgb.c
M src/core/msgfile.c
M src/core/panic.c
M src/core/prbs.c
M src/core/prim.c
M src/core/rate_ctr.c
M src/core/rbtree.c
M src/core/select.c
M src/core/serial.c
M src/core/signal.c
M src/core/soft_uart.c
M src/core/stat_item.c
M src/core/strrb.c
M src/core/tdef.c
M src/core/timer.c
M src/core/timer_gettimeofday.c
M src/core/use_count.c
M src/core/utils.c
M src/core/write_queue.c
37 files changed, 65 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/42205/5
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000
Gerrit-Change-Number: 42205
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
......................................................................
ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
As per CCID 1.1 ch 6.2.3 a reader that does not support
these commands can reject them, which we now do, instead of
pretending to accept the params.
This requires https://gitlab.com/wireshark/wireshark/-/issues/20107 to
be properly decoded in wireshark >= 4.4.8 .
As a bonus this fixes the error response in gen_err_resp which so far had superfluous param data attached to it.
Closes: OS#5380
Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24
---
M ccid_common/ccid_device.c
1 file changed, 9 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/12/42312/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24
Gerrit-Change-Number: 42312
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email
to look at the new patch set (#2).
Change subject: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
......................................................................
ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
As per CCID 1.1 ch 6.2.3 a reader that does not support
these commands can reject them, which we now do, instead of
pretending to accept the params.
This requires https://gitlab.com/wireshark/wireshark/-/issues/20107 to
be properly decoded in wireshark >= 4.4.8 .
As a bonus this fixes the error response in gen_err_resp which so far had superfluous param data attached to it.
Closes: OS#5380
Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24
---
M ccid_common/ccid_device.c
1 file changed, 9 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/12/42312/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24
Gerrit-Change-Number: 42312
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: dexter, laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/42305?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
......................................................................
pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
pySim-prog and pySim-read do not integrate the pySimLogger yet. As we
may add more debug output that should not be visible on normal use, we
should ensure that the pySimLogger is correctly set up.
Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74
---
M pySim-prog.py
M pySim-read.py
M tests/pySim-prog_test/Fairwaves-SIM.ok
M tests/pySim-prog_test/Wavemobile-SIM.ok
M tests/pySim-prog_test/fakemagicsim.ok
M tests/pySim-prog_test/sysmoISIM-SJA2.ok
M tests/pySim-prog_test/sysmoISIM-SJA5.ok
M tests/pySim-prog_test/sysmoUSIM-SJS1.ok
M tests/pySim-prog_test/sysmosim-gr1.ok
9 files changed, 26 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/05/42305/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74
Gerrit-Change-Number: 42305
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: lynxis lazus, pespin.
Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email )
Change subject: dfu: rewrite firmware downloading
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
honestly I can't quite see the improvement because now we have dfu_flash_done and usb_dfu_status on top of the already existing dfu_state and dfu_status ... a rewrite should make it less confusing instead of even more contrived.
The patch mostly changes "things" but I'm not aware of any actual issues that are being solved here, we only have one repeatable apparently hardware related flash write issue as far as I am aware, and I'd rather not start touching a bootloader that (at least until now) did a fairly good job.
File usb/class/dfu/device/dfudf.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/2c98ad5f_910421b… :
PS4, Line 175: dfu_state = USB_DFU_STATE_DFU_DNBUSY;
at least move that assignment to case USB_DFU_STATE_DFU_DNLOAD_SYNC and don't just drop old comments..
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/3282a248_c776b2d… :
PS4, Line 272: break;
why do we suddenly need superfluous break statements within else if chains?
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef
Gerrit-Change-Number: 42174
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 10 Mar 2026 15:35:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 4:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/42caabb4_7fd4c8ba?usp… :
PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f)
> So IMHO what this patch would need to do instead is to add a new --disable-multi-arfcn configure fla […]
Yes, that makes sense. I'll rework the patch to introduce a `--disable-multi-arfcn` configure flag and avoid compiling `RadioInterfaceMulti` and its dependencies.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2026 15:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>