- gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntoleran...
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus, pespin. Hello Hoernchen, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed In theory a device which is manifestintolerant and completed the manifestation should not reach MANIFEST_SYNC again. Remove the state transistion to WAIT-RESET and stay in the current state and wait for the main loop to change the state is safer. Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d --- M usb/class/dfu/device/dfudf.c 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/75/42175/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-asf4-dfu[master]: Replace snprintf() to free 4 kb
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: lynxis lazus. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42275?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Replace snprintf() to free 4 kb ...................................................................... Replace snprintf() to free 4 kb Change-Id: Ide644648bda86d4ae77a6713d1e140a4b78ba835 --- M usb_flash_main.c 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/75/42275/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42275?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: Ide644648bda86d4ae77a6713d1e140a4b78ba835 Gerrit-Change-Number: 42275 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu-download: flash the first block in manifest phase
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Hoernchen, Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: dfu-download: flash the first block in manifest phase ...................................................................... dfu-download: flash the first block in manifest phase To prevent half flashed applications, erase the first page when dfu downloading starts and save the first block for later. In manifest stage, flash the first block. If the first 4 byte are 0xffffffff, the board won't boot into application and go into the dfu bootloader. Change-Id: I894f3ee71587ccb287e92d7025039954991c631f --- M usb/class/dfu/device/dfudf.c M usb/class/dfu/device/dfudf.h M usb_start.c 3 files changed, 50 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/73/42273/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I894f3ee71587ccb287e92d7025039954991c631f Gerrit-Change-Number: 42273 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in pysim[master]: pySim/transport: fix GET RESPONSE behaviour
by dexter 11 Mar '26

11 Mar '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email ) Change subject: pySim/transport: fix GET RESPONSE behaviour ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > it would be good to introduce some testing of this new fixed handling e.g. […] We could integrate a testcase into the already existing APDU tests by trying if apdu 0020000A00 returns 63c3 properly. That would cover the changes. Without this patch we would get 6f00. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42301?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I26f0566af0cdd61dcc97f5f502479dc76adc37cc Gerrit-Change-Number: 42301 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:04:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE no...
by pespin 11 Mar '26

11 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email ) Change subject: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended ...................................................................... NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/42313/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 6626cc1..e36245d 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -3852,6 +3852,11 @@ id := id_PDUSessionResourceListHORqd, criticality := reject, value_ := { PDUSessionResourceListHORqd := p_pDUSessionResourceListHORqd } + }, + { + id := id_SourceToTarget_TransparentContainer, + criticality := reject, + value_ := { SourceToTarget_TransparentContainer := p_SourceToTarget_TransparentContainer } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435 Gerrit-Change-Number: 42313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong id in HandoverReq template IE
by pespin 11 Mar '26

11 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email ) Change subject: NGAP_Templates: Fix wrong id in HandoverReq template IE ...................................................................... NGAP_Templates: Fix wrong id in HandoverReq template IE Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/42314/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index e36245d..465f577 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4151,7 +4151,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4246,7 +4246,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4427,7 +4427,7 @@ value_ := { SecurityContext := p_securityContext } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, @@ -4542,7 +4542,7 @@ value_ := { NAS_PDU := p_nAS_PDU } }, { - id := id_PDUSessionResourceListHORqd, + id := id_PDUSessionResourceSetupListHOReq, criticality := reject, value_ := { PDUSessionResourceSetupListHOReq := p_pDUSessionResourceSetupListHOReq } }, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79 Gerrit-Change-Number: 42314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Expect optional IEs in HandoverRequest templates
by pespin 11 Mar '26

11 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42315?usp=email ) Change subject: NGAP_Templates: Expect optional IEs in HandoverRequest templates ...................................................................... NGAP_Templates: Expect optional IEs in HandoverRequest templates Change-Id: I227d67a589127ccfc5f44950daa3c0d95e425437 --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/42315/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index 465f577..e5752ce 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4426,6 +4426,7 @@ criticality := reject, value_ := { SecurityContext := p_securityContext } }, + *, { id := id_PDUSessionResourceSetupListHOReq, criticality := reject, @@ -4436,11 +4437,13 @@ criticality := reject, value_ := { AllowedNSSAI := p_allowedNSSAI } }, + *, { id := id_SourceToTarget_TransparentContainer, criticality := reject, value_ := { SourceToTarget_TransparentContainer := p_SourceToTarget_TransparentContainer } }, + *, { id := id_GUAMI, criticality := reject, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42315?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I227d67a589127ccfc5f44950daa3c0d95e425437 Gerrit-Change-Number: 42315 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to...
by pespin 11 Mar '26

11 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42316?usp=email ) Change subject: NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverRequestAcknowledge ...................................................................... NGAP_Templates: Add missing IE TargetToSource_TransparentContainer to HandoverRequestAcknowledge Change-Id: I19b0b718021326a64fe3bf1b3508a769a453557d --- M library/ngap/NGAP_Templates.ttcn 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/42316/1 diff --git a/library/ngap/NGAP_Templates.ttcn b/library/ngap/NGAP_Templates.ttcn index e5752ce..46e55bf 100644 --- a/library/ngap/NGAP_Templates.ttcn +++ b/library/ngap/NGAP_Templates.ttcn @@ -4733,7 +4733,8 @@ template (value) SuccessfulOutcome m_n2_HandoverRequestAcknowledge( in template (value) AMF_UE_NGAP_ID p_amfUeNgapID := PX_AMF_UE_NGAP_ID, in template (value) RAN_UE_NGAP_ID p_ranUeNgapID := PX_RAN_UE_NGAP_ID, - in template (value) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList + in template (value) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList, + in template (value) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer ) := { procedureCode := id_HandoverResourceAllocation, criticality := reject, @@ -4754,6 +4755,11 @@ id := id_PDUSessionResourceAdmittedList, criticality := ignore, value_ := { PDUSessionResourceAdmittedList := p_pDUSessionResourceAdmittedList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } @@ -4770,7 +4776,8 @@ template (present) SuccessfulOutcome mw_n2_HandoverRequestAcknowledge( template (present) AMF_UE_NGAP_ID p_amfUeNgapID := ?, template (present) RAN_UE_NGAP_ID p_ranUeNgapID := ?, - template (present) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList := ? + template (present) PDUSessionResourceAdmittedList p_pDUSessionResourceAdmittedList := ?, + template (present) TargetToSource_TransparentContainer p_TargetToSource_TransparentContainer := ? ) := { procedureCode := id_HandoverResourceAllocation, criticality := reject, @@ -4791,6 +4798,11 @@ id := id_PDUSessionResourceAdmittedList, criticality := ignore, value_ := { PDUSessionResourceAdmittedList := p_pDUSessionResourceAdmittedList } + }, + { + id := id_TargetToSource_TransparentContainer, + criticality := reject, + value_ := { TargetToSource_TransparentContainer := p_TargetToSource_TransparentContainer } } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42316?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19b0b718021326a64fe3bf1b3508a769a453557d Gerrit-Change-Number: 42316 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.File: Support pinStatusTemplateDO + lcsi
by laforge 11 Mar '26

11 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42122?usp=email ) Change subject: pySim.esim.saip.File: Support pinStatusTemplateDO + lcsi ...................................................................... pySim.esim.saip.File: Support pinStatusTemplateDO + lcsi The tuples defining a DF or ADF in an eSIM template must contain a pinStatusTemplateDO. When parsing tuples into a File() instance, we must save it, and re-create it at the time we re-encode that file. Same applies to the lcsi (life cycle state indicator), which may optionally exist for any file. Change-Id: I073aa4374f2cd664d07fa0224bf0d4c809cdf4aa Closes: OS#6955 --- M pySim/esim/saip/__init__.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index a50e86f..bdbbccf 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -151,6 +151,8 @@ self.df_name = None self.fill_pattern = None self.fill_pattern_repeat = False + self.pstdo = None # pinStatusTemplateDO, mandatory for DF/ADF + self.lcsi = None # optional life cycle status indicator # apply some defaults from profile if self.template: self.from_template(self.template) @@ -278,6 +280,8 @@ elif self.file_type in ['MF', 'DF', 'ADF']: fdb_dec['file_type'] = 'df' fdb_dec['structure'] = 'no_info_given' + # pinStatusTemplateDO is mandatory for DF/ADF + fileDescriptor['pinStatusTemplateDO'] = self.pstdo # build file descriptor based on above input data fd_dict = {} if len(fdb_dec): @@ -304,6 +308,8 @@ # desired fill or repeat pattern in the "proprietaryEFInfo" element for the EF in Profiles # downloaded to a V2.2 or earlier eUICC. fileDescriptor['proprietaryEFInfo'] = pefi + if self.lcsi: + fileDescriptor['lcsi'] = self.lcsi logger.debug("%s: to_fileDescriptor(%s)" % (self, fileDescriptor)) return fileDescriptor @@ -323,6 +329,8 @@ if efFileSize: self._file_size = self._decode_file_size(efFileSize) + self.pstdo = fileDescriptor.get('pinStatusTemplateDO', None) + self.lcsi = fileDescriptor.get('lcsi', None) pefi = fileDescriptor.get('proprietaryEFInfo', {}) securityAttributesReferenced = fileDescriptor.get('securityAttributesReferenced', None) if securityAttributesReferenced: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I073aa4374f2cd664d07fa0224bf0d4c809cdf4aa Gerrit-Change-Number: 42122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmocore[master]: sane embedded builds without host talloc
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email ) Change subject: sane embedded builds without host talloc ...................................................................... Patch Set 1: (1 comment) File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/42308/comment/38bc10bc_286f0e5a?… : PS1, Line 62: context does this change the featureset of embedded builds? IT looks a bit like it for stuff like bitvec.c? If so, then we have to *at least* mention this in the commit log, ideally put it into a separate patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb309a01ac6cad827b33ac18be408be1ac2cf7e0 Gerrit-Change-Number: 42308 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log