- gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: core: fix config.h
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, fixeria, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:35:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Patch Set 2: Code-Review-1 (4 comments) File ccid_common/ccid_slot_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/f38a6c35_b2… : PS2, Line 229: resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_TIME_EXT, 1, NULL, 0); can we be sure that we can allocate sufficient waitign time extension messages? what a about a card that DoSs us with an infinite sequence of rapid 0x60 messages? IMHO it would be safer to decrement the wtime_ext counter only individually for each message we sent to the host, and in case of allocation failures (resp == NULL?) simply keep the count at non-zero until the next turn. File ccid_common/iso7816_fsm.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/b977e403_b2… : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */ this cosmetic re-formatting or code does not belong to the patch. I guess you're not using 'git add -p' before committing? File ccid_common/iso7816_fsm.c: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/b9d69422_6d… : PS2, Line 227: { ISO7816_E_TX_ERR_IND, "TX_ERR_IND" }, same as above https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/8d291570_56… : PS2, Line 555: S(ISO7816_E_POWER_UP_IND), and more cosmetic changes -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:33:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmocore[master]: core: fix config.h
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: fixeria, laforge, pespin. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 6: (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/42205/comment/c70b681a_3065c11a?… : PS6, Line 206: const char *m_dump __attribute__((unused)); > This looks unrelated to this patch? […] no it is not because the log macro expands to nothing and thanks to werror it breakds the build. of course we can special case this var with defines or come up with 10 different more contrived ways to just make it work... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:27:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmocore[master]: sane embedded builds without host talloc
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email ) Change subject: sane embedded builds without host talloc ...................................................................... Patch Set 1: (1 comment) File src/core/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/42308/comment/17ca78a6_21d8446e?… : PS1, Line 62: context > does this change the featureset of embedded builds? IT looks a bit like it for stuff like bitvec. […] how many firmware users do we have? do we have firmware that wants random talloc allocation in bitvec or somewhere else? I'm not aware of any of that, but who knows.. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibb309a01ac6cad827b33ac18be408be1ac2cf7e0 Gerrit-Change-Number: 42308 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:26:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: jolly, laforge, lynxis lazus. Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I don't think more testing is required, the spec is clear that the limit is 260, dwMaxCCIDMessageLength-10 is 262 in our case so "enough" to cover this. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:24:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, jolly, laforge, lynxis lazus. Hoernchen has uploaded a new patch set (#3) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Hoernchen The change is no longer submittable: Code-Review is unsatisfied now. Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes The CCID v1.1 ch 6.1.4 specification states a T=0 TPDU must not exceed 260 bytes, so let's properly handle this error case. Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/93/42193/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: jolly, laforge, lynxis lazus. Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:22:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, jolly, laforge, lynxis lazus. Hoernchen has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by lynxis lazus Change subject: ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes ...................................................................... ccid_slot_fsm.c: Reject T=0 TPDU > 260 bytes The CCID v1.1 ch 6.1.5 specification states a T=0 TPDU must not exceed 260 bytes, so let's properly handle this error case. Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 --- M ccid_common/ccid_slot_fsm.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/93/42193/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Iceb0013adf448fe56c909fd8ccf14a021d8b7331 Gerrit-Change-Number: 42193 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email ) Change subject: dfu: rewrite firmware downloading ...................................................................... Patch Set 5: (3 comments) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/10305403_7482ee5… : PS2, Line 246: if (!(usb_dfu_func_desc->bmAttributes & USB_REQ_DFU_DNLOAD)) { // download is not enabled > this whole to_return should be also replaced. Reverted the break back because of adding the else again. File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/ac2174af_8da2d60… : PS4, Line 175: dfu_state = USB_DFU_STATE_DFU_DNBUSY; > at least move that assignment to case USB_DFU_STATE_DFU_DNLOAD_SYNC and don't just drop old comments […] I've reverted the removal of the comment "// switch to busy state". I've added additional comments. The code path for DNLOAD_SYNC and DNBUSY can be merged into one code path and don't need different handling. The main loop doesn't change anymore the dfu_state while flashing, so the state changes here and the comment "// download has not completed" doesn't describe the state of the device anymore. https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174/comment/10c26509_f2f2924… : PS4, Line 272: break; > why do we suddenly need superfluous break statements within else if chains? Ack. I've reverted the else to keep the code more minimal in this change. -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 17:18:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-asf4-dfu[master]: dfu: rewrite firmware downloading
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: lynxis lazus, pespin. Hello Hoernchen, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: dfu: rewrite firmware downloading ...................................................................... dfu: rewrite firmware downloading Improve handling of dfu_state by moving more state changing towards the IRQ handler. Having both the main loop and IRQ changes dfu_state within the same state could lead to races. The main loop is now only a simple worker which reports back via dfu_flash_done & dfu_flash_status. Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef --- M usb/class/dfu/device/dfudf.c M usb/class/dfu/device/dfudf.h M usb_start.c 3 files changed, 66 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/74/42174/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42174?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I345d5948455b25cd8a2efb1abfd9d0986ebd8cef Gerrit-Change-Number: 42174 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log