Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42304?usp=email )
Change subject: PySimLogger: add parameter to set initial log-level/verbosity
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8
Gerrit-Change-Number: 42304
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2026 17:42:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email )
Change subject: NGAP_Templates: Fix wrong id in HandoverReq template IE
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42314?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I160a319543c32187bc4f2f3f4cf0baa667758f79
Gerrit-Change-Number: 42314
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2026 17:41:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email )
Change subject: sane embedded builds without host talloc
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File src/core/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/42308/comment/ccc5f8e7_37b3b50c?… :
PS1, Line 62: context
> how many firmware users do we have? do we have firmware that wants random talloc allocation in bitve […]
the point is not whether or not that change may make sense. The point is that you are sneaking it into a patch without documenting it clearly in the changelog. And as a secondary point, that it is a logically distinct change that would preced the current change.
That's basically exactly what I was trying to convey with my previous review comment. Maybe this time I can manage to express myself more clearly.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42308?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ibb309a01ac6cad827b33ac18be408be1ac2cf7e0
Gerrit-Change-Number: 42308
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2026 17:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>