- gerrit-log - lists.osmocom.org

[M] Change in osmo-asf4-dfu[master]: dfu-download: flash the first block in manifest phase
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email ) Change subject: dfu-download: flash the first block in manifest phase ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I894f3ee71587ccb287e92d7025039954991c631f Gerrit-Change-Number: 42273 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Mar 2026 10:47:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE no...
by osmith 11 Mar '26

11 Mar '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email ) Change subject: NGAP_Templates: Fix missing SourceToTarget_TransparentContainer IE not appended ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cff63f3d662fa168b57abe4ef95f347ab74435 Gerrit-Change-Number: 42313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Mar 2026 10:44:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: laforge. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Patch Set 3: (1 comment) File ccid_common/iso7816_fsm.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/838f5a13_8b… : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */ > In that case either the linter rules need to be changed, or there needs to be a separate patch for a […] And how is reformatting changed code in a patch preceding the patch changing the code supposed to work? A linter time travel hook that does this by looking at changed lines and emitting a second preceding commit and rebasing, maybe? Is the linter now suddenly holding my patch hostage here, again? No matter what I do I get dragged into code formatting discussions, even if we have a linter, even if we have a .clang-format style used by the linter that is supposed to be used to reformat the code so we finally stop discussing formatting. The so called linting has been a nuisance and massive drag on anything with tons of legacy code and no clear coding style for years with zero discernible benefit and the issues appear to get more contrived every year. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Mar 2026 10:44:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-trx[master]: build: add --disable-multi-arfcn configure option
by pespin 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: add --disable-multi-arfcn configure option ...................................................................... Patch Set 6: (3 comments) File Transceiver52M/arch/common/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/79153ce1_5209049a?usp… : PS6, Line 9: mult.h fyi, you can usually do this to avoid touching too many lines with each patch: mult.h \ $(NULL) File Transceiver52M/radioInterface.h: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/9d3dbe0f_13f1a221?usp… : PS6, Line 165: #ifdef ENABLE_MULTI_ARFCN What about splitting this subclass into a separate header instead in a previous commit? File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/13268275_548b0081?usp… : PS6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN]) Please indent these 2 lines. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:57:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: Handle the TPDU-length = 4 case according to CCID spec
by laforge 11 Mar '26

11 Mar '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42317?usp=email ) Change subject: ccid: Handle the TPDU-length = 4 case according to CCID spec ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: this needs testing first. I tried to tst via pySim, but even with firmware prior to this change, it seems like my version of pcsc-lite is patching the 4byte TPDU already, so we need a lowl-level CCID test case to actually verify this. But then eclipse-titan for debian unstable is currently not instlalable anymore, so I'm blocked by that. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42317?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ia27962bda526af3373b36d637e2b548aa01a3346 Gerrit-Change-Number: 42317 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:51:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: firmware: fix msgb/list mixed irq access handling
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, lynxis lazus. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email ) Change subject: firmware: fix msgb/list mixed irq access handling ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42319?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I9212bfa7688cb4d3161ba963b854225744128632 Gerrit-Change-Number: 42319 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:48:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: generate proper error for short messages
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email ) Change subject: ccid: generate proper error for short messages ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I3bf0bebd361666a2f3d0341444415a6f25d2b4bf Gerrit-Change-Number: 42318 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:47:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly emit wait time ext messages
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email ) Change subject: ccid: properly emit wait time ext messages ...................................................................... Patch Set 3: (1 comment) File ccid_common/iso7816_fsm.h: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/c1ccc735_80… : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */ > Just unhide the build failure here and you can see that the linter prevents building this without re […] In that case either the linter rules need to be changed, or there needs to be a separate patch for all the cosmetic changes preceeding the functional change. It has been forever that we never mix cosmetic + functional changes in one patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70 Gerrit-Change-Number: 42306 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:46:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-trx[master]: build: add --disable-multi-arfcn configure option
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, osmith, pespin. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: add --disable-multi-arfcn configure option ...................................................................... Patch Set 6: Code-Review+1 (4 comments) File Transceiver52M/arch/common/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/7c96afc0_07c184e0?usp… : PS1, Line 16: NOT_HAVE_EMSCRIPTEN > Agreed, thanks. I now use HAVE_EMSCRIPTEN directly and removed NOT_HAVE_EMSCRIPTEN. Done File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c5c511f2_715a7743?usp… : PS3, Line 82: AC_DISABLE_SHARED dnl don't build shared libraries (emscripten) > Sounds good. Once this is merged, I'll rebase my branch accordingly. Done https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/e380fd41_7a698f65?usp… : PS3, Line 306: PKG_CHECK_MODULES(LIBUSB, libusb-1.0) > Sounds good. Once this is merged, I'll rebase my branch accordingly. Done https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/39c692fa_c7673805?usp… : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f) > Yes, that makes sense. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 6 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:44:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: add optional Laurent burst LUT modulation (int16)
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, tnt. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email ) Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ...................................................................... Patch Set 5: (1 comment) File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42248/comment/d7578b07_a37b8842?usp… : PS5, Line 706: unsigned modulateBits(uint8_t *bits, unsigned bitlen, int16_t *outbuf) a read-only input paramter "bits" should be marked as "const" -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2 Gerrit-Change-Number: 42248 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 11 Mar 2026 09:42:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log