[M] Change in osmo-remsim[master]: Introduce osmo-remsim-client-socket
Attention is currently required from: jolly, laforge, lynxis lazus. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email ) Change subject: Introduce osmo-remsim-client-socket ...................................................................... Patch Set 5: (3 comments) Patchset: PS5: I don't see the SOCKET_SUPPORT being defined anywhere in the build system? eg. having a configure flag. File src/client/Makefile.am: https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/736ce405_d48bc109?u... : PS5, Line 24: bin_PROGRAMS += osmo-remsim-client-socket if SOCKET_SUPPORT ? We probably want to update the jenkins jobs to be matrix ones where we test with and without configure flag here. File src/client/client.h: https://gerrit.osmocom.org/c/osmo-remsim/+/43742/comment/c8a4b305_d3c26d20?u... : PS5, Line 96: /* only valid for socket client */ #ifdef SOCKET_SUPPORT ? -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I9eddb60e4e7c3191ca2b340690416b53005f714f Gerrit-Change-Number: 43742 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 11 Nov 2026 10:35:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
pespin