Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: add --disable-multi-arfcn configure option
......................................................................
Patch Set 7:
(3 comments)
File Transceiver52M/arch/common/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/fb9e9c46_e48ef71f?usp… :
PS6, Line 9: mult.h
> fyi, you can usually do this to avoid touching too many lines with each patch: […]
Thanks for the tip — I've applied that in the current patch.
File Transceiver52M/radioInterface.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/4a95ccbd_699461d1?usp… :
PS6, Line 165: #ifdef ENABLE_MULTI_ARFCN
> What about splitting this subclass into a separate header instead in a previous commit?
Good point — I've moved the subclass into a separate header. I also added include guards in `radioInterface.h` and `radioBuffer.h` I didn't use `#pragma once`, since the codebase mostly uses traditional `#ifndef`/`#define` guards.
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/223f009a_e94ccf0c?usp… :
PS6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN])
> Please indent these 2 lines.
Thanks, fixed the indentation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Mar 2026 11:08:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.
Hello Hoernchen, Jenkins Builder, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Verified+1 by Jenkins Builder
Change subject: build: add --disable-multi-arfcn configure option
......................................................................
build: add --disable-multi-arfcn configure option
- add configure flag to disable Multi ARFCN support
- compile Channelizer, Synthesis, RadioInterfaceMulti and fft.c only when enabled
- guard Multi ARFCN-specific code with ENABLE_MULTI_ARFCN
- avoid requiring fftw3f when Multi ARFCN support is disabled
Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
---
M Transceiver52M/Makefile.am
M Transceiver52M/arch/common/Makefile.am
M Transceiver52M/osmo-trx.cpp
M Transceiver52M/radioBuffer.h
M Transceiver52M/radioInterface.h
M Transceiver52M/radioInterfaceMulti.cpp
A Transceiver52M/radioInterfaceMulti.h
M configure.ac
8 files changed, 98 insertions(+), 45 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/43/42243/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Hoernchen, Timur Davydov, tnt.
Hello Hoernchen, Jenkins Builder, tnt,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: transceiver: add optional Laurent burst LUT modulation (int16)
......................................................................
transceiver: add optional Laurent burst LUT modulation (int16)
Introduce an optional Burst LUT optimization for Laurent-based burst
modulation, enabled via --with-burst-lut.
- Add precomputed Laurent LUT tables (float and int16 I/Q variants)
- Generate LUT at initialization (prepareBurstLUT)
- Use LUT-based modulation for sps=4 when enabled
- Keep original modulateBurstLaurent() as fallback
- Add configure.ac option and USE_BURST_LUT define
This reduces runtime computation by replacing per-burst Laurent
processing with memcpy-based LUT lookups.
Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2
---
M Transceiver52M/sigProcLib.cpp
M configure.ac
2 files changed, 186 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/48/42248/6
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2
Gerrit-Change-Number: 42248
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages
......................................................................
Patch Set 3:
(1 comment)
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/86bdc1ab_fb… :
PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
> And how is reformatting changed code in a patch preceding the patch changing the code supposed to wo […]
I don't understant why it's so hard to first reformat the code, and then add your changes on top of it? We can debate all day long how annoying the situation is, and I'm open for whatever solutions there might be, just as long as we keep our commit history clean and never mix unrelated formatting changes with actual functional code changes. That shouldn't be any surprise at all, and interestingly we rarely see any other developer even submitting something like that for review in the first place.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ib69483d453a0e5ebb1bc1885a8f78790a0f10d70
Gerrit-Change-Number: 42306
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Mar 2026 10:56:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>