[M] Change in osmo-msc[master]: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX
Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email ) Change subject: mgw: add "X-Side: CN" / "X-Side: RAN" to emitted CRCX ...................................................................... Patch Set 3: (1 comment) File src/libmsc/rtp_stream.c: https://gerrit.osmocom.org/c/osmo-msc/+/44001/comment/c5a9a540_26d2fb5a?usp=... : PS3, Line 66: void rtp_stream_init_gsmnet(struct gsm_network *net)
This looks a bit ugly imho, It be a lot simpler having a global variable when initializing the point […] It is very silly business indeed, but all existing OsmoMSC code passes the global gsm_network pointer around in ways just like this. `call_leg_init()` was already there before my changes, and it takes this global pointer. I have an idea for how to make my addition a little bit cleaner in the next version of this patch.
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/44001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie26ece9035ee579f2af84a13d71a553f98817592 Gerrit-Change-Number: 44001 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 09 Nov 2026 12:03:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>
participants (1)
-
falconia