March 2026 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: pfcp_peer: detect UPF restart via RTS mismatch in Heartbeat Response
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42490?usp=email ) Change subject: pfcp_peer: detect UPF restart via RTS mismatch in Heartbeat Response ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42490/comment/38429b82_4e97… : PS1, Line 10: the value stored during Association Setup (`rem_rts`). A mismatch AFAIR the newer PFCP specs explicitly state the RTS in Association Setup shall be ignored. Instead, you need to record the RTS in the first HB Response, and match against that on every subsequent HB Responses. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I00a8384db1ea9c38d0ad9ff90b3d45ad86c3a020 Gerrit-Change-Number: 42490 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 10:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: add configurable heartbeat miss count + association reset
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: pfcp_peer: add configurable heartbeat miss count + association reset ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/pfcp_peer.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489/comment/e8e309b1_8368… : PS1, Line 115: hb_missed :: non_neg_integer() unanswered would probably be a better naming. BTW I'd say usually this is implemented as actually a "retrans" variable counting downwards. This allows knowing immediatelly how many tries remain without needing to look at the process config. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8cb0fb23468aba4dead9865a90d893c78c6ae074 Gerrit-Change-Number: 42489 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 10:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: tune Heartbeat Request/Response logging
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42488?usp=email ) Change subject: pfcp_peer: tune Heartbeat Request/Response logging ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I6435cdf64fd86fa5358d57ea4d56dcad8eb9e69e Gerrit-Change-Number: 42488 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 10:09:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: implement periodic PFCP heartbeat
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42487?usp=email ) Change subject: pfcp_peer: implement periodic PFCP heartbeat ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmo_s1gw.hrl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42487/comment/a1f64df7_b1cc… : PS1, Line 46: -define(ENV_DEFAULT_PFCP_HEARTBEAT_INTERVAL, 0). %% disabled imho this should be enabled by default, afair it's the only way for a pfcp node to detect the peer restart. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42487?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I306324f8eca325202a3fa23125854db9d5eaab38 Gerrit-Change-Number: 42487 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 10:08:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: make assoc_setup and heartbeat_req timeouts configurable
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42486?usp=email ) Change subject: pfcp_peer: make assoc_setup and heartbeat_req timeouts configurable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42486?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I58a472a3bbbbad029a2f0246b084428ab3b1905c Gerrit-Change-Number: 42486 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:59:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: global_platform: refactor gen_install_parameters()
by dexter 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria, laforge, osmith. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42378?usp=email ) Change subject: global_platform: refactor gen_install_parameters() ...................................................................... Patch Set 4: Code-Review+2 Verified+1 (4 comments) Patchset: PS4: I have now looked at this again. I think the code is 100% correct now. I also re-tested the applet installation and it still works. I think we can merge this now. File pySim/global_platform/install_param.py: https://gerrit.osmocom.org/c/pysim/+/42378/comment/7d353d7d_0e6225af?usp=em… : PS3, Line 60: > this looks correct, but I would add some comments to make the code easier to understand: […] Done https://gerrit.osmocom.org/c/pysim/+/42378/comment/fdb01422_854d156b?usp=em… : PS3, Line 67: system_specific_params.append({'stk_parameter': stk_parameter}) > Well, this is literally what the code does: […] I am not sure. This was only a suggestion. If you think this is too much verbosity, than this is fine with me. File tests/unittests/test_globalplatform.py: https://gerrit.osmocom.org/c/pysim/+/42378/comment/5e3dfa33_3bc54d60?usp=em… : PS3, Line 298: load_parameters = gen_install_parameters() > Not sure what you mean where, but let me explain why I am changing this line. […] Thanks. I now understand. This worked before because of the bug in install_param.py, which is now fixed. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f Gerrit-Change-Number: 42378 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:57:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: gtpu_kpi: use ?ENV_DEFAULT_GTPU_KPI_{TABLE_NAME,INTERVAL}
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42484?usp=email ) Change subject: gtpu_kpi: use ?ENV_DEFAULT_GTPU_KPI_{TABLE_NAME,INTERVAL} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia8194966b20da1adc26c02f416b8ec0508191d98 Gerrit-Change-Number: 42484 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:57:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: config/sys.config: group pfcp_peer params into a map
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42485?usp=email ) Change subject: config/sys.config: group pfcp_peer params into a map ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iba954746fe20e6b9eeaec3196e1f83e3fc3e7fc2 Gerrit-Change-Number: 42485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:57:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: [REST] PfcpAssocState: field 'lrts' is required
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42483?usp=email ) Change subject: [REST] PfcpAssocState: field 'lrts' is required ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic766ebc56ce1810fc27cb49ddcac50bc94e539d9 Gerrit-Change-Number: 42483 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:54:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: pfcp_peer: add configurable heartbeat miss count + association reset
by pespin 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email ) Change subject: pfcp_peer: add configurable heartbeat miss count + association reset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8cb0fb23468aba4dead9865a90d893c78c6ae074 Gerrit-Change-Number: 42489 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:54:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026