March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-netif[master]: ip_checksum: Add SPDX license identifier
by pespin 24 Mar '26

24 Mar '26

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42477?usp=email ) Change subject: ip_checksum: Add SPDX license identifier ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic40d01771e8d01461ed81d1a60d9e91a48fdc8d0 Gerrit-Change-Number: 42477 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Mar 2026 20:45:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: icmpv6: Re-license code under GPL-v2-or-later
by pespin 24 Mar '26

24 Mar '26

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email ) Change subject: icmpv6: Re-license code under GPL-v2-or-later ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5a4fa18ef64c2f228e21fa2c067e55eaa4080508 Gerrit-Change-Number: 42476 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 23 Mar 2026 20:45:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: transport: change APDU format paradigm
by laforge 24 Mar '26

24 Mar '26

Attention is currently required from: daniel, dexter, fixeria, neels. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42441?usp=email ) Change subject: transport: change APDU format paradigm ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > For the apdu command in pySim-shell. […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9a531a825def318b28bf58291d811cf119003fab Gerrit-Change-Number: 42441 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Mar 2026 19:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport: change APDU format paradigm
by laforge 24 Mar '26

24 Mar '26

Attention is currently required from: daniel, dexter, fixeria, neels. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42441?usp=email ) Change subject: transport: change APDU format paradigm ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42441?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9a531a825def318b28bf58291d811cf119003fab Gerrit-Change-Number: 42441 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Mar 2026 19:18:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: icmpv6: Re-license code under GPL-v2-or-later
by laforge 24 Mar '26

24 Mar '26

laforge has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email ) Change subject: icmpv6: Re-license code under GPL-v2-or-later ...................................................................... icmpv6: Re-license code under GPL-v2-or-later The original statement in my code from osmo-ggsn commit d46bcd236e93432c894a939f4e5810dc5e9b4974 in 2017 was worded GPLv2-only, which was due to the fact that the original OpenGGSN code is v2-only. All subsequent modifications to this code were done by either me or Pau Espin, who was doing the work under contract with sysmocom, of which I'm the managing director. Therefore, I have legal authority to re-license this file to v2-or-later. Change-Id: I5a4fa18ef64c2f228e21fa2c067e55eaa4080508 --- M src/icmpv6.c 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/76/42476/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5a4fa18ef64c2f228e21fa2c067e55eaa4080508 Gerrit-Change-Number: 42476 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder

1 0

[L] Change in libosmo-netif[master]: Introduce API osmo_icmpv6
by laforge 24 Mar '26

24 Mar '26

laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42464?usp=email ) Change subject: Introduce API osmo_icmpv6 ...................................................................... Patch Set 2: (1 comment) File src/icmpv6.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42464/comment/215ea1f1_4f5d2dc… : PS2, Line 6: The contents of this file may be used under the terms of the GNU : * General Public License Version 2, provided that the above copyright : * notice and this permission notice is included in all copies or : * substantial portions of the software. > ok, this looks like I want to relicense it unter GPL-v2-or-later like the rest of the library code. […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42464?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I78ec7270c717af0a1b8ffd9398cd69ea7a0dbee2 Gerrit-Change-Number: 42464 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Mar 2026 19:15:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmo-netif[master]: icmpv6: Re-license code under GPL-v2-or-later
by laforge 24 Mar '26

24 Mar '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email ) Change subject: icmpv6: Re-license code under GPL-v2-or-later ...................................................................... icmpv6: Re-license code under GPL-v2-or-later The original statement in my code from osmo-ggsn commit d46bcd236e93432c894a939f4e5810dc5e9b4974 in 2017 was worded GPLv2-only, which was most likely an oversight. All subsequent modifications to this code were done by either me or Pau Espin, who was doing the work under contract with sysmocom, of which I'm the managing director. Therefore, I have legal authority to re-license this file to v2-or-later. Change-Id: I5a4fa18ef64c2f228e21fa2c067e55eaa4080508 --- M src/icmpv6.c 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/76/42476/1 diff --git a/src/icmpv6.c b/src/icmpv6.c index b0f29a8..c0d5710 100644 --- a/src/icmpv6.c +++ b/src/icmpv6.c @@ -2,13 +2,24 @@ * relevant 3GPP specs for a GGSN with IPv6 PDP contexts */ /* (C) 2017 by Harald Welte <laforge(a)gnumonks.org> + * All Rights Reserved. * - * The contents of this file may be used under the terms of the GNU - * General Public License Version 2, provided that the above copyright - * notice and this permission notice is included in all copies or - * substantial portions of the software. + * SPDX-License-Identifier: GPL-2.0+ + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * */ - #include <stdint.h> #include <stdbool.h> #include <string.h> -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42476?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5a4fa18ef64c2f228e21fa2c067e55eaa4080508 Gerrit-Change-Number: 42476 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in libosmo-netif[master]: ip_checksum: Add SPDX license identifier
by laforge 24 Mar '26

24 Mar '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42477?usp=email ) Change subject: ip_checksum: Add SPDX license identifier ...................................................................... ip_checksum: Add SPDX license identifier Let's make sure the newly-created/imported file has a machine-readable SPDX identifier. Change-Id: Ic40d01771e8d01461ed81d1a60d9e91a48fdc8d0 --- M src/ip_checksum.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/77/42477/1 diff --git a/src/ip_checksum.c b/src/ip_checksum.c index 1fa6f42..ec715e2 100644 --- a/src/ip_checksum.c +++ b/src/ip_checksum.c @@ -27,6 +27,8 @@ * modify it under the terms of the GNU General Public License * as published by the Free Software Foundation; either version * 2 of the License, or (at your option) any later version. + * + * SPDX-License-Identifier: GPL-2.0+ */ /* Revised by Kenneth Albanowski for m68knommu. Basic problem: unaligned access -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42477?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic40d01771e8d01461ed81d1a60d9e91a48fdc8d0 Gerrit-Change-Number: 42477 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-dev[master]: all.deps: osmo-ggsn now depends on libosmo-netif
by pespin 24 Mar '26

24 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/42466?usp=email ) Change subject: all.deps: osmo-ggsn now depends on libosmo-netif ...................................................................... all.deps: osmo-ggsn now depends on libosmo-netif Since osmo-ggsn.git Change-Id I8d8fae362f302d48afaed28a9c664f76ca4a2739, osmo-ggsn depends on libosmo-netif. Change-Id: I4d10fff6a6994c428c572fc10249ad95b0d7e8db --- M all.deps 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/all.deps b/all.deps index f0e99a1..f5148ca 100644 --- a/all.deps +++ b/all.deps @@ -7,7 +7,7 @@ libosmo-sigtran libosmo-netif libosmo-asn1-tcap libsmpp34 libasn1c -osmo-ggsn libosmocore libgtpnl +osmo-ggsn libosmocore libosmo-netif libgtpnl osmo-iuh libosmo-sigtran libasn1c osmo-hlr libosmo-abis osmo-mgw libosmo-netif libosmo-abis -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I4d10fff6a6994c428c572fc10249ad95b0d7e8db Gerrit-Change-Number: 42466 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: General_types.ttcn: Introduce type OCT4_20n
by pespin 24 Mar '26

24 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42471?usp=email ) Change subject: General_types.ttcn: Introduce type OCT4_20n ...................................................................... General_types.ttcn: Introduce type OCT4_20n This is useful to store EUAs of type v4,v6 or v4v6. Change-Id: I00a35c444e3fb498712fbb4b9c310375c527052f --- M library/General_Types.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/library/General_Types.ttcn b/library/General_Types.ttcn index dca4ea2..1b9a732 100644 --- a/library/General_Types.ttcn +++ b/library/General_Types.ttcn @@ -155,6 +155,7 @@ type octetstring OCT3_17n length(3..17) with { variant "" }; type octetstring OCT4_8n length(4..8) with { variant "" }; type octetstring OCT4_16n length(4..16) with { variant "" }; + type octetstring OCT4_20n length(4..20) with { variant "" }; //**************************************************** -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42471?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I00a35c444e3fb498712fbb4b9c310375c527052f Gerrit-Change-Number: 42471 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026