gerrit-log March 2026

gerrit-log@lists.osmocom.org

1 participants
1933 discussions

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by fixeria 01 Mar '26

01 Mar '26

Attention is currently required from: Thorkell Thorkelsson, falconia, pespin. fixeria has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bts-sysmo/tch.c: https://gerrit.osmocom.org/c/osmo-bts/+/42244/comment/eb5c5f1e_5a3fda38?usp… : PS2, Line 601: FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented I believe this comment is still valid: `GsmL1_TchPlType_Amr_SidBad` is not handled in the switch statement. Could you please explain why are you removing it? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 01 Mar 2026 15:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 01 Mar '26

01 Mar '26

Thorkell Thorkelsson has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 2 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-CC: Jenkins Builder

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by Thorkell Thorkelsson 01 Mar '26

01 Mar '26

Thorkell Thorkelsson has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... tch: fix RTP clock not ticking for unhandled payload types When the payload type from the DSP is not handled by the switch in l1if_tch_rx(), rmsg stays NULL and we return 0 without calling add_l1sap_header(), silently dropping a 20ms RTP tick. Always allocate an empty RTP frame when rmsg is NULL so the RTP clock keeps ticking. Related: OS#5974 Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Signed-off-by: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> --- M src/osmo-bts-sysmo/tch.c 1 file changed, 14 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/44/42244/1 diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c index b5bf04b..bbf05c1 100644 --- a/src/osmo-bts-sysmo/tch.c +++ b/src/osmo-bts-sysmo/tch.c @@ -598,18 +598,23 @@ case GsmL1_TchPlType_Amr_SidFirstP1: rmsg = l1_to_rtppayload_amr(payload, payload_len, lchan); break; - /* FIXME: what about GsmL1_TchPlType_Amr_SidBad? not well documented. */ } - if (rmsg) - return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, - data_ind->measParam.fBer * 10000, - data_ind->measParam.fLinkQuality * 10, - data_ind->measParam.fRssi, - data_ind->measParam.i16BurstTiming * 64, - 0); + if (!rmsg) { + LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_NOTICE, + "Unhandled payload type %s, generating empty RTP tick\n", + get_value_string(femtobts_tch_pl_names, payload_type)); + rmsg = msgb_alloc_headroom(256, 128, "L1P-to-RTP"); + if (!rmsg) + return -ENOMEM; + } - return 0; + return add_l1sap_header(trx, rmsg, lchan, chan_nr, data_ind->u32Fn, + data_ind->measParam.fBer * 10000, + data_ind->measParam.fLinkQuality * 10, + data_ind->measParam.fRssi, + data_ind->measParam.i16BurstTiming * 64, + 0); err_payload_match: LOGPLCFN(lchan, data_ind->u32Fn, DL1P, LOGL_ERROR, "%s Rx Payload Type %s incompatible with lchan\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 1 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com>

1 0

Jump to page:

2026

2025

2024

2023

2022

gerrit-log March 2026