Attention is currently required from: fixeria.

pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: pfcp_peer: add configurable heartbeat miss count + association reset ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File src/pfcp_peer.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42489/comment/e8e309b1_83686... : PS1, Line 115: hb_missed :: non_neg_integer() unanswered would probably be a better naming. BTW I'd say usually this is implemented as actually a "retrans" variable counting downwards. This allows knowing immediatelly how many tries remain without needing to look at the process config.