March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-gsm-manuals[master]: gsup: align ordering of IEs
by fixeria 18 Mar '26

18 Mar '26

Attention is currently required from: laforge, lynxis lazus, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email ) Change subject: gsup: align ordering of IEs ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS2: > I think the most compatible approach would be not to require any kind of ordering. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:38:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-bsc[master]: nokia_site: Change the LAPD N200 counter for RSL
by laforge 18 Mar '26

18 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email ) Change subject: nokia_site: Change the LAPD N200 counter for RSL ...................................................................... nokia_site: Change the LAPD N200 counter for RSL This commit raises the LAPD RSL N200 (retransmission) counter for Nokia RSL links. The reason is that the readiness of the TRX is not signalled (OML) nor can be queried from the BTS in any way, and on larger macro setups the TRX reset takes ~15 seconds, thus the RSL bootstrap times out before the TRX becomes ready. This issue presents itself with UltraSite types, does not affect InSite or MetroSite (the later two are "integrated TRX" units). More modern macro setups like the Flexi or Multiradio are likely affected. Runtime tested with InSite and UltraSite (multi-TRX). Change-Id: Ie4bb804ea636eba2182586db13a625c5933eff31 --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 3800d45..c5e31b7 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -117,10 +117,13 @@ #endif if (start) { + /* Raise N200 for RSL to fix slow TRX reset */ + if (link->sapi == SAPI_RSL) + ts->lapd->profile.n200 = 20; ts->lapd->profile.t200_sec = 1; ts->lapd->profile.t200_usec = 0; lapd_sap_start(ts->lapd, link->tei, - link->sapi); + link->sapi); } else lapd_sap_stop(ts->lapd, link->tei, link->sapi); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4bb804ea636eba2182586db13a625c5933eff31 Gerrit-Change-Number: 42289 Gerrit-PatchSet: 5 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net>

1 0

[XS] Change in osmo-bsc[master]: nokia_site: Change the LAPD N200 counter for RSL
by laforge 18 Mar '26

18 Mar '26

Attention is currently required from: csaba.sipos, fixeria, pespin. laforge has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email ) Change subject: nokia_site: Change the LAPD N200 counter for RSL ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42289?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie4bb804ea636eba2182586db13a625c5933eff31 Gerrit-Change-Number: 42289 Gerrit-PatchSet: 5 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: domi <domi(a)tomcsanyi.net> Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status
by osmith 18 Mar '26

18 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email ) Change subject: 5gc: Update mobility procedure status ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6bb8672fbd553a1a2a51b97a8360658afa0fddff Gerrit-Change-Number: 42423 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:34:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-gsm-manuals[master]: gsup: align ordering of IEs
by laforge 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email ) Change subject: gsup: align ordering of IEs ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS2: > Wouldn't it much easier to require an ordering based on ascending IE type? This way it wouldn't requ […] I think the most compatible approach would be not to require any kind of ordering. In any case, this patch is not about changing the behaviour, but making documentation agree with implementation. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/38666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I5caa3101da310cddfa311d068ad889bca697b438 Gerrit-Change-Number: 38666 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:34:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by laforge 18 Mar '26

18 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... netdev: netdev_mnl_set_mtu(): drop unneeded variables Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 --- M src/core/netdev.c 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/netdev.c b/src/core/netdev.c index 7e5a409..be7ad2e 100644 --- a/src/core/netdev.c +++ b/src/core/netdev.c @@ -541,8 +541,6 @@ char buf[MNL_SOCKET_BUFFER_SIZE]; struct nlmsghdr *nlh = mnl_nlmsg_put_header(buf); struct ifinfomsg *ifm; - unsigned int change = 0; - unsigned int flags = 0; nlh->nlmsg_type = RTM_NEWLINK; nlh->nlmsg_flags = NLM_F_REQUEST | NLM_F_ACK; @@ -550,8 +548,8 @@ ifm = mnl_nlmsg_put_extra_header(nlh, sizeof(*ifm)); ifm->ifi_family = AF_UNSPEC; - ifm->ifi_change = change; - ifm->ifi_flags = flags; + ifm->ifi_change = 0; + ifm->ifi_flags = 0; ifm->ifi_index = if_index; mnl_attr_put_u32(nlh, IFLA_MTU, mtu); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables
by laforge 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email ) Change subject: netdev: netdev_mnl_set_mtu(): drop unneeded variables ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8f9d39733a80a0ec4e8c462f4ae32b4ac52b5849 Gerrit-Change-Number: 42406 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:33:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: esim/http_json_api: allow URL rewriting
by laforge 18 Mar '26

18 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email ) Change subject: esim/http_json_api: allow URL rewriting ...................................................................... esim/http_json_api: allow URL rewriting The URL used when HTTP requests are performed is defined statically with the url_prefix passed to the constructor of JsonHttpApiClient together with the path property in JsonHttpApiFunction. For applications that require dynamic URLs there is no way to rewrite the URL. Let's add a mechanism that allows API users to apply custom URL reqriting rules by adding a rewrite_url method to JsonHttpApiFunction. API users may then overload this method with a custom implementation as needed. Related: SYS#7918 Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 --- M pySim/esim/http_json_api.py 1 file changed, 33 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/pySim/esim/http_json_api.py b/pySim/esim/http_json_api.py index cd95e0d..0220d25 100644 --- a/pySim/esim/http_json_api.py +++ b/pySim/esim/http_json_api.py @@ -19,7 +19,7 @@ import requests import logging import json -from typing import Optional +from typing import Optional, Tuple import base64 from twisted.web.server import Request @@ -180,7 +180,7 @@ # receives from the a requesting client. The same applies vice versa to class variables that have an "output_" # prefix. - # path of the API function (e.g. '/gsma/rsp2/es2plus/confirmOrder') + # path of the API function (e.g. '/gsma/rsp2/es2plus/confirmOrder', see also method rewrite_url). path = None # dictionary of input parameters. key is parameter name, value is ApiParam class @@ -336,6 +336,22 @@ output[p] = p_class.decode(v) return output + def rewrite_url(self, data: dict, url: str) -> Tuple[dict, str]: + """ + Rewrite a static URL using information passed in the data dict. This method may be overloaded by a derived + class to allow fully dynamic URLs. The input parameters required for the URL rewriting may be passed using + data parameter. In case those parameters are additional parameters that are not intended to be passed to + the encode_client method later, they must be removed explcitly. + + Args: + data: (see JsonHttpApiClient and JsonHttpApiServer) + url: statically generated URL string (see comment in JsonHttpApiClient) + """ + + # This implementation is a placeholder in which we do not perform any URL rewriting. We just pass through data + # and url unmodified. + return data, url + class JsonHttpApiClient(): def __init__(self, api_func: JsonHttpApiFunction, url_prefix: str, func_req_id: Optional[str], session: requests.Session): @@ -352,8 +368,16 @@ self.session = session def call(self, data: dict, func_call_id: Optional[str] = None, timeout=10) -> Optional[dict]: - """Make an API call to the HTTP API endpoint represented by this object. Input data is passed in `data` as - json-serializable dict. Output data is returned as json-deserialized dict.""" + """ + Make an API call to the HTTP API endpoint represented by this object. Input data is passed in `data` as + json-serializable fields. `data` may also contain additional parameters required for URL rewriting (see + rewrite_url in class JsonHttpApiFunction). Output data is returned as json-deserialized dict. + + Args: + data: Input data required to perform the request. + func_call_id: Function Call Identifier, if present a header field is generated automatically. + timeout: Maximum amount of time to wait for the request to complete. + """ # In case a function caller ID is supplied, use it together with the stored function requestor ID to generate # and prepend the header field according to SGP.22, section 6.5.1.1 and 6.5.1.3. (the presence of the header @@ -362,6 +386,11 @@ data = {'header' : {'functionRequesterIdentifier': self.func_req_id, 'functionCallIdentifier': func_call_id}} | data + # The URL used for the HTTP request (see below) normally consists of the initially given url_prefix + # concatenated with the path defined by the JsonHttpApiFunction definition. This static URL path may be + # rewritten by rewrite_url method defined in the JsonHttpApiFunction. + data, url = self.api_func.rewrite_url(data, self.url_prefix + self.api_func.path) + # Encode the message (the presence of mandatory fields is checked during encoding) encoded = json.dumps(self.api_func.encode_client(data)) @@ -373,7 +402,6 @@ req_headers.update(self.api_func.extra_http_req_headers) # Perform HTTP request - url = self.url_prefix + self.api_func.path logger.debug("HTTP REQ %s - hdr: %s '%s'" % (url, req_headers, encoded)) response = self.session.request(self.api_func.http_method, url, data=encoded, headers=req_headers, timeout=timeout) logger.debug("HTTP RSP-STS: [%u] hdr: %s" % (response.status_code, response.headers)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 Gerrit-Change-Number: 42274 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in pysim[master]: esim/http_json_api: allow URL rewriting
by laforge 18 Mar '26

18 Mar '26

Attention is currently required from: dexter, neels. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42274?usp=email ) Change subject: esim/http_json_api: allow URL rewriting ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42274?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id2713a867079cc140517fe312189e5e2162608a5 Gerrit-Change-Number: 42274 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:32:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add README.md
by laforge 18 Mar '26

18 Mar '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42372?usp=email ) Change subject: s1gw: add README.md ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib5c1326c4260bf552b561a42f7ff9d3f28f89579 Gerrit-Change-Number: 42372 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 10:30:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026