Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 7:
(1 comment)
File Transceiver52M/Transceiver.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/183beb9b_4e73dbcf?usp… :
PS6, Line 150: protected:
> Thinking about it, this change is unrelated to this patch. […]
You're right - I've moved this change to the corresponding patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 12:48:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Timur Davydov, pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: transceiver: add optional WebSDR device support
......................................................................
transceiver: add optional WebSDR device support
- Add support for WebSDR devices enabled via the --with-websdr
configure flag.
- add libosmo-trx-websdr library and pkg-config file
- update .gitignore for wasm and pkg-config artifacts
Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
---
M .gitignore
M Transceiver52M/Makefile.am
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
A Transceiver52M/libosmo-trx-websdr.pc.in
A Transceiver52M/osmo-trx-websdr.h
M Transceiver52M/osmo-trx.cpp
M Transceiver52M/radioInterface.cpp
M Transceiver52M/radioInterface.h
M configure.ac
10 files changed, 325 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42411/8
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: transceiver: split control command handling from socket I/O
......................................................................
transceiver: split control command handling from socket I/O
- move control command parsing/response generation into ctrl_cmd_handle()
- keep ctrl_sock_handle_rx() focused on socket read/write
Change-Id: I5413aa511e951522270c75635e89448395fc429e
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
2 files changed, 32 insertions(+), 21 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: fixeria, laforge, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email )
Change subject: transceiver: return -EINVAL for invalid SETSLOT
......................................................................
Patch Set 2:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/5632473a_f7ab76da?usp… :
PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */
> After looking at the follow up commit, I also understand now what @vyanitskiy@sysmocom.de means. […]
I see your point. However, this would change the original behavior.
Before splitting the code, when an invalid timeslot was provided, ctrl_sock_handle_rx() would return 0 and exit the function, so no response was sent. If we keep returning 0 after the refactoring, the command would now be answered, which was not the case before.
So this would slightly change the original logic.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53
Gerrit-Change-Number: 42421
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 12:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS4:
> What I'm still missing here in order to properly review, is an explanation on why do you need a new […]
I've tried to reuse as much of the existing code as possible.
The WebSDR setup has different transport requirements compared to the existing implementations. In this case bursts are not exchanged through the usual socket/file-descriptor path. Instead they are prepared and passed via callbacks to the web frontend, which then communicates with the SDR device over WebUSB.
Originally I placed the WebSDR-related code in separate files in order to keep the existing implementation as untouched as possible. The intention was to reuse the original logic where possible and only provide alternative implementations for the parts where the transport mechanism differs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 12:21:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: Timur Davydov.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: transceiver: add optional WebSDR device support
......................................................................
transceiver: add optional WebSDR device support
- Add support for WebSDR devices enabled via the --with-websdr
configure flag.
- add libosmo-trx-websdr library and pkg-config file
- update .gitignore for wasm and pkg-config artifacts
Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
---
M .gitignore
M Transceiver52M/Makefile.am
M Transceiver52M/Transceiver.cpp
M Transceiver52M/Transceiver.h
A Transceiver52M/libosmo-trx-websdr.pc.in
A Transceiver52M/osmo-trx-websdr.h
M Transceiver52M/osmo-trx.cpp
M Transceiver52M/radioInterface.cpp
M Transceiver52M/radioInterface.h
M configure.ac
10 files changed, 325 insertions(+), 28 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42411/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 7
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email )
Change subject: [REST] Implement eNB/MME selection by addr-port
......................................................................
Patch Set 1:
(1 comment)
File src/rest_server.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429/comment/5fcbbfe1_37f5… :
PS1, Line 275: %% parse address/port from a string like "192.168.1.1-36412"
> why are we using this format? why not usual ":" to separate IP and port? (and "[ipv6]:port" for ipv6 […]
I don't remember why I choose `addr-port` over `addr:port`. Perhaps because `:` is already used for separating the selector and value in `#/components/parameters/MmeId`. Let's see if I can quickly rework it to use `:` instead, before it's implemented.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If02c8de1e1b7214bba868eee35233a79d0704dc5
Gerrit-Change-Number: 42429
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 12:03:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>