Attention is currently required from: Hoernchen.
jolly has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )
Change subject: firmware: replace libosmocore fsm timers
......................................................................
Patch Set 4:
(1 comment)
File ccid_common/iso7816_fsm.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481/comment/86b5131d_32… :
PS4, Line 271: ip->uart->wtime_deadline = timeout_ms ? (jiffies + timeout_ms) + 1 : 0;
You are reading 'jiffies', which is incremented by interrupt. I think that this 64 bit read is not atomic, so it may glitch, if an SysTick interrupt fires between reading lower and upper part of that jiffies value. But this is quite unlikely.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd
Gerrit-Change-Number: 42481
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 08:51:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42496?usp=email )
Change subject: s1gw: generalize f_TC_e_rab_setup_failure() for N E-RABs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42496?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8a5dc338d28013dc85e1ce4b3bdac92cb3b35304
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:24:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42486?usp=email )
Change subject: pfcp_peer: make assoc_setup and heartbeat_req timeouts configurable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42486?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I58a472a3bbbbad029a2f0246b084428ab3b1905c
Gerrit-Change-Number: 42486
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:23:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42485?usp=email )
Change subject: config/sys.config: group pfcp_peer params into a map
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42485?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iba954746fe20e6b9eeaec3196e1f83e3fc3e7fc2
Gerrit-Change-Number: 42485
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:22:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42484?usp=email )
Change subject: gtpu_kpi: use ?ENV_DEFAULT_GTPU_KPI_{TABLE_NAME,INTERVAL}
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42484?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ia8194966b20da1adc26c02f416b8ec0508191d98
Gerrit-Change-Number: 42484
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:22:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42483?usp=email )
Change subject: [REST] PfcpAssocState: field 'lrts' is required
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42483?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic766ebc56ce1810fc27cb49ddcac50bc94e539d9
Gerrit-Change-Number: 42483
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:21:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email )
Change subject: firmware: replace libosmocore fsm timers
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
I would prefer if the host code would simply get a jiffies variable + a timer updating it. It's sad that basically from the point you took over the host target went into bitrot. I do still think that it is easier to test for some things in a host implementation than in the firmware. But well it is what it is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Id2bd67b3946bb451008965f0b68b4a919f4d10bd
Gerrit-Change-Number: 42481
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 00:19:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email )
Change subject: s1ap_proxy: fix build_erab_setup_response_failure() to report all E-RABs
......................................................................
s1ap_proxy: fix build_erab_setup_response_failure() to report all E-RABs
The previous implementation only included the first E-RAB from the
registry in the failure response (a FIXME was left in place).
Fix it to extract all E-RAB IDs from the original E-RAB SETUP REQUEST
and include each of them in the failure list, as required by 3GPP.
Change-Id: I7933fceb0edcdfdc95ace35416297b11c83f0bc9
Related: osmo-ttcn3-hacks.git I8a5dc338d28013dc85e1ce4b3bdac92cb3b35304
---
M src/s1ap_proxy.erl
1 file changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/97/42497/1
diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl
index dcd053e..078b73b 100644
--- a/src/s1ap_proxy.erl
+++ b/src/s1ap_proxy.erl
@@ -329,7 +329,13 @@
{{error, Reason}, S1} ->
?LOG_NOTICE("Failed to process E-RAB SETUP REQUEST: ~p", [Reason]),
ctr_inc(?S1GW_CTR_S1AP_PROXY_IN_PKT_PROC_ERROR, S1),
- PDU = build_erab_setup_response_failure(S1),
+ ERABIds = [ERABId ||
+ #'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupListBearerSUReq',
+ value = Items} <- C0#'E-RABSetupRequest'.protocolIEs,
+ #'ProtocolIE-Field'{id = ?'id-E-RABToBeSetupItemBearerSUReq',
+ value = #'E-RABToBeSetupItemBearerSUReq'{'e-RAB-ID' = ERABId}}
+ <- Items],
+ PDU = build_erab_setup_response_failure(ERABIds, S1),
ctr_inc(?S1GW_CTR_S1AP_PROXY_OUT_PKT_REPLY_ERAB_SETUP_RSP, S1),
{{reply, PDU}, S1} %% reply PDU back to sender
end;
@@ -1102,18 +1108,15 @@
{{ok, IEs}, S}.
-build_erab_setup_response_failure(#proxy_state{erabs = ERABs,
- mme_ue_id = MmeUeId,
+build_erab_setup_response_failure(ERABIds,
+ #proxy_state{mme_ue_id = MmeUeId,
enb_ue_id = EnbUeId}) ->
- %% FIXME: Currently we respond with E-RAB-ID of the first E-RAB in the registry.
- %% Instead, we need to iterate over E-RABs in the REQUEST and reject them all.
- [{_, FirstERABid}|_] = dict:fetch_keys(ERABs),
Cause = {transport, 'transport-resource-unavailable'},
- ERABitem = #'E-RABItem'{'e-RAB-ID' = FirstERABid,
- cause = Cause},
ERABlist = [#'ProtocolIE-Field'{id = ?'id-E-RABItem',
criticality = ignore,
- value = ERABitem}],
+ value = #'E-RABItem'{'e-RAB-ID' = ERABId,
+ cause = Cause}}
+ || ERABId <- ERABIds],
IEs = [#'ProtocolIE-Field'{id = ?'id-MME-UE-S1AP-ID',
criticality = ignore,
value = MmeUeId},
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7933fceb0edcdfdc95ace35416297b11c83f0bc9
Gerrit-Change-Number: 42497
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>