March 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by fixeria 25 Mar '26

25 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by dexter, Code-Review+1 by laforge, Verified+1 by Jenkins Builder, Verified+1 by dexter Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... global_platform: install_cap_parser: argument groups cannot be nested pySim-shell currently does not work on systems with Python 3.14+: File ".../pysim/pySim/global_platform/__init__.py", line 868, in AddlShellCommands install_cap_parser_inst_prm_g_grp = install_cap_parser_inst_prm_g.add_argument_group() File "/usr/lib/python3.14/argparse.py", line 1794, in add_argument_group raise ValueError('argument groups cannot be nested') ValueError('argument groups cannot be nested') The problem is that install_cap_parser creates a nested group inside of mutually exclusive group. argparse never supported group nesting properly, so it has been deprecated since Python 3.11, and eventually got removed in Python 3.14. Remove group nesting, adjust the usage string, and implement the mutual exclusiveness enforcement manually in do_install_cap(). Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 --- M pySim/global_platform/__init__.py 1 file changed, 29 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/42310/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: global_platform: refactor gen_install_parameters()
by fixeria 25 Mar '26

25 Mar '26

Attention is currently required from: dexter, laforge, osmith. Hello Jenkins Builder, dexter, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42378?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+2 by dexter, Verified+1 by Jenkins Builder, Verified+1 by dexter The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: global_platform: refactor gen_install_parameters() ...................................................................... global_platform: refactor gen_install_parameters() gen_install_parameters() had contradictory logic: the outer guard required all three arguments to be non-None/non-empty (making them mutually inclusive), while the inner checks then treated each one as optional. Make each parameter independently optional (defaulting to None) and remove the all-or-nothing check. Simplify the function body to a straightforward single-pass construction of system_specific_params. Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f --- M pySim/global_platform/install_param.py M tests/unittests/test_globalplatform.py 2 files changed, 17 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/78/42378/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42378?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f Gerrit-Change-Number: 42378 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by fixeria 25 Mar '26

25 Mar '26

Attention is currently required from: dexter. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Patch Set 3: (1 comment) File pySim/global_platform/__init__.py: https://gerrit.osmocom.org/c/pysim/+/42310/comment/52866453_f7d3268e?usp=em… : PS3, Line 898: if opts.install_parameters is not None: > Now there is no check that makes sure that none of the opts.install_parameters_* is set. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 12:41:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/
by pespin 25 Mar '26

25 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42499?usp=email ) Change subject: GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/ ...................................................................... GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/ The function can also be (and is) used to ping IPv6 hosts. Change-Id: I195cb048176aefddcb477083ddc949b86ec592fa --- M 5gc/ConnHdlr.ttcn M library/GTPv1U_Emulation.ttcnpp M pgw/PGW_Tests.ttcn 3 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/42499/1 diff --git a/5gc/ConnHdlr.ttcn b/5gc/ConnHdlr.ttcn index 5294b50..8f5e5c5 100644 --- a/5gc/ConnHdlr.ttcn +++ b/5gc/ConnHdlr.ttcn @@ -1406,7 +1406,7 @@ /* execute ping command and wait for result */ function f_ping(charstring host, integer interval := 1, integer count := 10) runs on ConnHdlr { - /* command will be filled in by f_gtp1u_ping4() below: */ + /* command will be filled in by f_gtp1u_ping() below: */ var UECUPS_StartProgram sprog := f_run_prog_init(""); var charstring bind_addr; @@ -1416,14 +1416,14 @@ bind_addr := g_pars.ue_pars.sess_pars.ue_ip4; } - f_gtp1u_ping4(sprog, host, interval, count, bind_addr, + f_gtp1u_ping(sprog, host, interval, count, bind_addr, redirect_output := true, redirect_output_path_prefix := f_run_prog_unique_log_path()); } function f_ping_async(charstring host, integer interval := 1, integer count := 10) runs on ConnHdlr return integer { - /* command will be filled in by f_gtp1u_ping4() below: */ + /* command will be filled in by f_gtp1u_ping() below: */ var UECUPS_StartProgram sprog := f_run_prog_init(""); var charstring bind_addr; @@ -1433,10 +1433,10 @@ bind_addr := g_pars.ue_pars.sess_pars.ue_ip4; } - var integer pid := f_gtp1u_ping4_async(sprog, host, - interval, count, bind_addr, - redirect_output := true, - redirect_output_path_prefix := f_run_prog_unique_log_path()); + var integer pid := f_gtp1u_ping_async(sprog, host, + interval, count, bind_addr, + redirect_output := true, + redirect_output_path_prefix := f_run_prog_unique_log_path()); return pid; } diff --git a/library/GTPv1U_Emulation.ttcnpp b/library/GTPv1U_Emulation.ttcnpp index 7b1db12..0d3abb8 100644 --- a/library/GTPv1U_Emulation.ttcnpp +++ b/library/GTPv1U_Emulation.ttcnpp @@ -502,7 +502,7 @@ f_gtp1u_wait_term(pid, exit_code, tout, port_idx); } -function f_gtp1u_ping4_async(UECUPS_StartProgram sprog, +function f_gtp1u_ping_async(UECUPS_StartProgram sprog, charstring host, integer interval := 1, integer count := 10, template (omit) charstring src_ip := omit, boolean redirect_output := false, @@ -523,7 +523,7 @@ } /* execute ping command and wait for result. sprog.command is filled in based on params. */ -function f_gtp1u_ping4(UECUPS_StartProgram sprog, +function f_gtp1u_ping(UECUPS_StartProgram sprog, charstring host, integer interval := 1, integer count := 10, template (omit) charstring src_ip := omit, boolean redirect_output := false, diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index fba057e..b3f104b 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -925,11 +925,11 @@ if (not isbound(g_ip4_addr)) { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_ping4(): g_ip4_addr is unset!"); } - /* command will be filled in by f_gtp1u_ping4() below: */ + /* command will be filled in by f_gtp1u_ping() below: */ var UECUPS_StartProgram sprog := f_run_prog_init(""); - f_gtp1u_ping4(sprog, host, interval, count, f_inet_ntoa(g_ip4_addr), - redirect_output := true, - redirect_output_path_prefix := f_run_prog_unique_log_path()); + f_gtp1u_ping(sprog, host, interval, count, f_inet_ntoa(g_ip4_addr), + redirect_output := true, + redirect_output_path_prefix := f_run_prog_unique_log_path()); } /* send echo request; expect response */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I195cb048176aefddcb477083ddc949b86ec592fa Gerrit-Change-Number: 42499 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite
by pespin 25 Mar '26

25 Mar '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email ) Change subject: GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite ...................................................................... GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760 --- M library/GTPv2_Templates.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 44 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/42498/1 diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn index 925735a..539251c 100644 --- a/library/GTPv2_Templates.ttcn +++ b/library/GTPv2_Templates.ttcn @@ -13,6 +13,15 @@ import from Osmocom_Types all; import from GTPv2_Types all; +/* 8.14 */ +type enumerated GTP2C_PDN_Type { + GTP2C_PDN_IPv4 ('001'B), + GTP2C_PDN_IPv6 ('010'B), + GTP2C_PDN_IPv4v6 ('011'B), + GTP2C_PDN_non_IP ('100'B), + GTP2C_PDN_Ethernet ('101'B) +} with { variant "FIELDLENGTH(3)" encode "RAW" }; + private function fs_GTP2C_t_bit(template (omit) OCT4 teid) return BIT1 { if (istemplatekind(teid, "omit")) { return '0'B; diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 1ba58f4..fba057e 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -154,7 +154,7 @@ charstring apn, /* Apn subscribed or non-subscribed */ boolean selection_mode, - BIT3 pdn_type, + GTP2C_PDN_Type pdn_type, /* PAA */ /* Max APN Restriction */ /* APN-AMBR */ @@ -181,7 +181,7 @@ GTP2C_RAT_Type rat_type := GTP2C_RAT_EUTRAN, charstring apn := "internet", boolean selection_mode := false, - BIT3 pdn_type := '001'B) := { + GTP2C_PDN_Type pdn_type := GTP2C_PDN_IPv4) := { imsi := imsi, msisdn := msisdn, rat_type := rat_type, @@ -748,7 +748,7 @@ rat_type := enum2int(g_pars.rat_type), sender_fteid := fteid_c_ie, apn := f_enc_dns_hostname(g_pars.apn), - pdn_type := g_pars.pdn_type, + pdn_type := int2bit(enum2int(g_pars.pdn_type), 3), teid_list := { fteid_u_ie }, chg_car := '0000'O, bearer_id := g_pars.bearer.ebi, @@ -993,6 +993,36 @@ } } +/* create a session, then execute a ping command on the user plane */ +private function f_TC_createSession_ping6() runs on PGW_Session_CT { + f_s5s8_create_session(); + f_ping4(mp_ping_hostname); + setverdict(pass); +} +testcase TC_createSession_ping6() runs on PGW_Test_CT { + var PGW_Session_CT vc_conn; + var SessionPars pars := valueof(t_SessionPars('001010123456789'H, "tun23")); + f_init(); + vc_conn := f_start_handler(refers(f_TC_createSession_ping6), pars); + vc_conn.done; +} +testcase TC_createSession_ping6_256() runs on PGW_Test_CT { + var PGW_Session_CT vc_conn[256]; + var integer i; + + f_init(); + + for (i := 0; i < sizeof(vc_conn); i:=i+1) { + var charstring tundev := "ping" & int2str(i); + var SessionPars pars := valueof(t_SessionPars(f_gen_imsi(i), tundev)); + vc_conn[i] := f_start_handler(refers(f_TC_createSession_ping6), pars); + } + + for (i := 0; i < lengthof(vc_conn); i:=i+1) { + vc_conn[i].done; + } +} + /* create a session, then delete it again */ private function f_TC_createSession_deleteSession() runs on PGW_Session_CT { @@ -1126,6 +1156,8 @@ execute( TC_createSession() ); execute( TC_createSession_ping4() ); execute( TC_createSession_ping4_256() ); + execute( TC_createSession_ping6() ); + execute( TC_createSession_ping6_256() ); execute( TC_createSession_deleteSession() ); execute( TC_deleteSession_unknown() ); execute( TC_gy_charging_cc_time() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760 Gerrit-Change-Number: 42498 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor...
by dexter 25 Mar '26

25 Mar '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, neels. Hello Jenkins Builder, daniel, fixeria, laforge, lynxis lazus, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: docs/put_key: add tutorial that explains how to manage global platform keys ...................................................................... docs/put_key: add tutorial that explains how to manage global platform keys With the increased interest in using GlobalPlatform features of UICC and eUICCs (OTA-SMS, applets, etc.), also comes an increased interest in how the related GlobalPlatform keys can be managed (key rotation, adding/removing keysets from/to a Security Domain). Unfortunately, many aspects of this topic are not immediately obvious for the average user. Let's add a tutorial that contains some practical examples to shine some light on the topic. Related: SYS#7881 Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e --- A docs/put_key-tutorial.rst M docs/shell.rst 2 files changed, 837 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/53/42353/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e Gerrit-Change-Number: 42353 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor...
by dexter 25 Mar '26

25 Mar '26

Attention is currently required from: daniel, fixeria, laforge, lynxis lazus, neels. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42353?usp=email ) Change subject: docs/put_key: add tutorial that explains how to manage global platform keys ...................................................................... Patch Set 7: (2 comments) File docs/put_key-tutorial.rst: https://gerrit.osmocom.org/c/pysim/+/42353/comment/5796edb8_7625f39b?usp=em… : PS5, Line 38: an ISD-P (Issuer : Security Domain - Profile) exist. (see also: https://euicc-manual.osmocom.org/docs/lpa/applet-id/) : : On top of this, an eSIM profile may establish its own `securityDomain`. This `securityDomain` is comparable to the : Issuer Security Domain (ISD) we also find on UICCs. > I also understood it this way. I have now checked this back in SGP.02. […] (It might be better to reference to SGP.22 instead as this is the more commonly used spec and regarding the MNO-SD SGP.22 and SGP.02 tell the same. However I think SGP.02 explains it a bit better.) https://gerrit.osmocom.org/c/pysim/+/42353/comment/988cadab_acc5df78?usp=em… : PS5, Line 138: --key-ver 48 > You're saying "The SCP03 keyset we use is tied to KVN 50" above, so this one should also be `--key-v […] I changed the example later where I used a different KVN. I have now made it consistent with the text above. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42353?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I163dfedca3df572cb8442e9a4a280e6c5b00327e Gerrit-Change-Number: 42353 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 25 Mar 2026 12:02:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf
by osmith 25 Mar '26

25 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email ) Change subject: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8 Gerrit-Change-Number: 42482 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 11:52:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_pdu_sess_est_always_on
by osmith 25 Mar '26

25 Mar '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42478?usp=email ) Change subject: 5gc: Introduce test TC_pdu_sess_est_always_on ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I282e0c8072172fa633bf82ed6b9492b0bb4362cc Gerrit-Change-Number: 42478 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 11:51:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by dexter 25 Mar '26

25 Mar '26

Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 8: (3 comments) File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/672d4e8e_8c823d30?usp=em… : PS6, Line 121: val = random.randbytes(self.num_digits // 2) # TODO secure random source? > Done Ah ok, I understand. The caller can digest hexstrings and bytearrays. I wasn not aware of this. To mee it looked a bit off that all get_next methods return hexstrings except this one. However, if it is ok to return either a hexstring or bytes. Then you could also add a comment + type annotation to the get_next method in ParamSource. File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/7d8fe705_08fed5ad?usp=em… : PS8, Line 116: I wonder what happens when input_str is something like this: "12..345". Then num_digits is 2 but the last_value actually has 3 digits. As you assign self.num_digits I guess that you need this value for something later. I would recommend to check back if it is ok when self.num_digits is not equal to the actual number of digits in self.last_value. https://gerrit.osmocom.org/c/pysim/+/41845/comment/65c55d8e_d701d5b5?usp=em… : PS8, Line 131: val = random.randint(*self.val_first_last) # TODO secure random source? The line where you assign self.val_first_last in DecimalRangeSource has been removed (this also seems to be the reason why pylint fails). Maybe you can do: random.randint(self.first_value, self.last_value) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 8 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2026 11:46:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026