March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: align RSP version number in HTTP header
by dexter 19 Mar '26

19 Mar '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email ) Change subject: eIM_Tests: align RSP version number in HTTP header ...................................................................... eIM_Tests: align RSP version number in HTTP header The RSP version number in the x-admin-protocol header string should be set to v.2.1.0 (gsma/rsp/v2.1.0), even though the ASN.1 spec we currently use is at version 2.5. This is to maintain compatibility with older IPAd versions and also stated explicitly in GSMA SGP.32 V2.1, section 6.1. Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71 Related: SYS#7945 --- M eim/eIM_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/42434/1 diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index 5dcbdab..b3a3519 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -378,7 +378,7 @@ template (value) HeaderLines ts_esipa_HTTP_Header := { { header_name := "User-Agent", header_value := "TTCN3 eIM testsuite" }, - { header_name := "X-Admin-Protocol", header_value := "gsma/rsp/v2.5.0" }, + { header_name := "X-Admin-Protocol", header_value := "gsma/rsp/v2.1.0" }, { header_name := "Content-Type", header_value := "application/x-gsma-rsp-asn1" } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42434?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I125c3b13697c71d35788e54b7d88a9f943bb7a71 Gerrit-Change-Number: 42434 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email ) Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic2556f6add9c6a24f6da03f4388d7f86dde0c5dc Gerrit-Change-Number: 42368 Gerrit-PatchSet: 6 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:50:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email ) Change subject: [REST] Implement eNB/MME selection by addr-port ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If02c8de1e1b7214bba868eee35233a79d0704dc5 Gerrit-Change-Number: 42429 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:50:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov, fixeria, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/4486ff30_f461185c?usp… : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > Then if you prefer change this patch to set rc = -EINVAL in that case and "return rc" at the end of […] Scratch that, See my comment in https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/4c991da9_eb4a9244/ -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:46:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 7: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/4c991da9_eb4a9244?usp… : PS7, Line 1090: return rc; Ok I think I'm starting to understand the problem here: In your logic, returning error means "don't send a response", but that's actually decoupled. See how caller of ctrl_sock_handle_rx() uses the rc<0 to trigger stop of osmo-trx program. The idea of returning 0 in the SETSLOT failure was to simply tell the other peer that the cmd failed, but it kept osmo-trx alive. It is ofc a bug that no answer was being sent in that case. So your ctrl_cmd_handle() function should actually return 2 independent type of information, as per the above: * Whether a response needs to be transmitted * Whether a failure occurred which should trigger osmo-trx process stop. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 7: (1 comment) File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/63f1f2a5_231da713?usp… : PS6, Line 150: protected: > You're right - I've moved this change to the corresponding patch. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by pespin 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov, fixeria, laforge. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/08e96264_804af34b?usp… : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > I see your point. However, this would change the original behavior. […] Then if you prefer change this patch to set rc = -EINVAL in that case and "return rc" at the end of the function instead of early return. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:35:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port
by fixeria 19 Mar '26

19 Mar '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email ) Change subject: [REST] Implement eNB/MME selection by addr-port ...................................................................... Patch Set 3: (1 comment) File src/rest_server.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429/comment/c471dac3_8119… : PS1, Line 275: %% parse address/port from a string like "192.168.1.1-36412" > I don't remember why I choose `addr-port` over `addr:port`. […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42429?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If02c8de1e1b7214bba868eee35233a79d0704dc5 Gerrit-Change-Number: 42429 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 13:59:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release}
by fixeria 19 Mar '26

19 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42430?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: [REST] Implement PfcpAssoc{Setup,Release} ...................................................................... [REST] Implement PfcpAssoc{Setup,Release} Change-Id: I2e24544563e4c4d23bb3d8a4a7b5434191b482d8 Related: SYS#7066 --- M contrib/osmo-s1gw-cli.py M doc/manuals/chapters/cli.adoc M src/pfcp_peer.erl M src/rest_server.erl 4 files changed, 65 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/30/42430/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42430?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2e24544563e4c4d23bb3d8a4a7b5434191b482d8 Gerrit-Change-Number: 42430 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME
by fixeria 19 Mar '26

19 Mar '26

Attention is currently required from: fixeria. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42431?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: [REST] EnbItem: expose name of the selected MME ...................................................................... [REST] EnbItem: expose name of the selected MME For each eNB connection, include the name of the MME that was selected from the pool. Update the OpenAPI spec, CLI (enb_list/enb_info tables), and user manual accordingly. Change-Id: I4839275efa5d3545e84d684ad1b8b989214ef76a Related: SYS#7066, SYS#7052 --- M contrib/openapi.yaml M contrib/osmo-s1gw-cli.py M doc/manuals/chapters/cli.adoc M doc/manuals/chapters/rest.adoc M priv/openapi.json M src/rest_server.erl 6 files changed, 18 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/31/42431/3 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42431?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4839275efa5d3545e84d684ad1b8b989214ef76a Gerrit-Change-Number: 42431 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026