Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 07:32:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42433?usp=email )
Change subject: [REST] Add MME source address/port to EnbItem
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42433?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I15bbddf96ac7d5b6f9962a8d745db58fdec334e7
Gerrit-Change-Number: 42433
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 19 Mar 2026 00:52:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email )
Change subject: library/HTTP_Adapter: bail out early on failure
......................................................................
library/HTTP_Adapter: bail out early on failure
Replace `self.stop` with `Misc_Helpers.f_shutdown()`, and add it after
existing `setverdict(fail, ...)` calls that previously fell through.
In all these cases there is no meaningful way to continue: the caller
of these functions usually expects a valid value to be returned, and
continuing (not stopping) oftentimes results in confusing DTEs.
Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235
---
M library/HTTP_Adapter.ttcn
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/42437/1
diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn
index 161ca23..bd34a5f 100644
--- a/library/HTTP_Adapter.ttcn
+++ b/library/HTTP_Adapter.ttcn
@@ -16,6 +16,7 @@
import from HTTPmsg_Types all;
import from HTTPmsg_PortType all;
import from Native_Functions all;
+import from Misc_Helpers all;
type component http_CT {
port HTTPmsg_PT HTTP;
@@ -82,6 +83,7 @@
/* Make sure we never use body or binary_body at the same time */
if (not istemplatekind(body, "omit") and not istemplatekind(binary_body, "omit")) {
setverdict(fail, "use wither (ascii) body or binary_body");
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
/* Build default header */
@@ -198,7 +200,7 @@
/* The user is expected to either pass global http_pars with on initialization (f_http_init) or
* to pass individual http_pars with each request. */
setverdict(fail, "no HTTP parameters set");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
/* Use globally set HTTP parameters */
use_http_pars := valueof(g_http_pars);
@@ -215,11 +217,11 @@
[] HTTP.receive(Connect_result:?) -> value rc;
[] HTTP.receive {
setverdict(fail, "HTTP connection to client failed");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] T.timeout {
setverdict(fail, "Timeout waiting for completion of HTTP connection");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
use_client_id := rc.client_id;
@@ -243,6 +245,7 @@
custom_hdr := custom_hdr, client_id := use_client_id));
} else {
setverdict(fail, "either binary_body or body must be used (a request can contain either ASCII data or binary data, not both!");
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
@@ -260,13 +263,15 @@
}
[] HTTP.receive(tr_HTTP_Resp) -> value resp {
setverdict(fail, "Unexpected HTTP response ", resp);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] HTTP.receive(tr_HTTP_Resp_Bin) -> value resp {
setverdict(fail, "Unexpected (binary) HTTP response ", resp);
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
[] T.timeout {
setverdict(fail, "Timeout waiting for HTTP response");
- self.stop;
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235
Gerrit-Change-Number: 42437
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: Hoernchen.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email )
Change subject: irq: make default IRQ handler Dummy_Handler weak
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> you're modifying asf4 code anyway, what's the point having a weak-weak alias chain instead of just r […]
I would like to keep the changes to the atmel start code as minimal as possible.
We might want to share the hal code with the bootloader or if someone opens an upstream git repo for the atmel code. E.g. there is adafruits asf4 repo on github.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465
Gerrit-Change-Number: 42224
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 19:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email )
Change subject: dfu: set poll timeout to 128 ms to reduce EPIPE errors
......................................................................
dfu: set poll timeout to 128 ms to reduce EPIPE errors
The previous 10 ms poll timeout creates ERROR_PIPE errors when the
octsim is connected to a more busy bus.
E.g. when a network device is connected to the same bus or when flashing
multiple OCTSIMs at the same time.
From usb captures 70 ms should be already enough, but adding an additional
safety margin.
It is unclear why the EPIPE errors happens.
Related: SYS#7910
Change-Id: I4abe812e17194f37ce5d97fd1d866aeebd1d4239
---
M usb/class/dfu/device/dfudf.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/35/42435/1
diff --git a/usb/class/dfu/device/dfudf.c b/usb/class/dfu/device/dfudf.c
index 4b010bd..87a97b8 100644
--- a/usb/class/dfu/device/dfudf.c
+++ b/usb/class/dfu/device/dfudf.c
@@ -187,7 +187,7 @@
break;
}
response[0] = dfu_status; // set status
- response[1] = 10; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll
+ response[1] = 128; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll
response[2] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll
response[3] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll
response[4] = dfu_state; // set state (post-transition)
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I4abe812e17194f37ce5d97fd1d866aeebd1d4239
Gerrit-Change-Number: 42435
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O
......................................................................
Patch Set 8:
(1 comment)
File Transceiver52M/Transceiver.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/687766e3_5b0a1d92?usp… :
PS7, Line 1090: return rc;
> Ok I think I'm starting to understand the problem here: […]
Thanks for the explanation, that makes sense.
I've updated the implementation to use two states: a success flag (whether a response should be sent) and a retcode (whether a failure occurred that should propagate to the caller).
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 15:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>