March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: bail out early on failure
by fixeria 19 Mar '26

19 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email ) Change subject: library/HTTP_Adapter: bail out early on failure ...................................................................... library/HTTP_Adapter: bail out early on failure Replace `self.stop` with `Misc_Helpers.f_shutdown()`, and add it after existing `setverdict(fail, ...)` calls that previously fell through. In all these cases there is no meaningful way to continue: the caller of these functions usually expects a valid value to be returned, and continuing (not stopping) oftentimes results in confusing DTEs. Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235 --- M library/HTTP_Adapter.ttcn 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/42437/1 diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn index 161ca23..bd34a5f 100644 --- a/library/HTTP_Adapter.ttcn +++ b/library/HTTP_Adapter.ttcn @@ -16,6 +16,7 @@ import from HTTPmsg_Types all; import from HTTPmsg_PortType all; import from Native_Functions all; +import from Misc_Helpers all; type component http_CT { port HTTPmsg_PT HTTP; @@ -82,6 +83,7 @@ /* Make sure we never use body or binary_body at the same time */ if (not istemplatekind(body, "omit") and not istemplatekind(binary_body, "omit")) { setverdict(fail, "use wither (ascii) body or binary_body"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* Build default header */ @@ -198,7 +200,7 @@ /* The user is expected to either pass global http_pars with on initialization (f_http_init) or * to pass individual http_pars with each request. */ setverdict(fail, "no HTTP parameters set"); - self.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } /* Use globally set HTTP parameters */ use_http_pars := valueof(g_http_pars); @@ -215,11 +217,11 @@ [] HTTP.receive(Connect_result:?) -> value rc; [] HTTP.receive { setverdict(fail, "HTTP connection to client failed"); - self.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } [] T.timeout { setverdict(fail, "Timeout waiting for completion of HTTP connection"); - self.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } use_client_id := rc.client_id; @@ -243,6 +245,7 @@ custom_hdr := custom_hdr, client_id := use_client_id)); } else { setverdict(fail, "either binary_body or body must be used (a request can contain either ASCII data or binary data, not both!"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } @@ -260,13 +263,15 @@ } [] HTTP.receive(tr_HTTP_Resp) -> value resp { setverdict(fail, "Unexpected HTTP response ", resp); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } [] HTTP.receive(tr_HTTP_Resp_Bin) -> value resp { setverdict(fail, "Unexpected (binary) HTTP response ", resp); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } [] T.timeout { setverdict(fail, "Timeout waiting for HTTP response"); - self.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I229028d551d5cf9651e6e65314cd40f414bfe235 Gerrit-Change-Number: 42437 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: clarify response template restriction
by fixeria 19 Mar '26

19 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42436?usp=email ) Change subject: library/HTTP_Adapter: clarify response template restriction ...................................................................... library/HTTP_Adapter: clarify response template restriction Change-Id: I1a5ee842c30de9ec22d9e375f6b1b24b3eaee1e0 --- M library/HTTP_Adapter.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/36/42436/1 diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn index 8f15958..161ca23 100644 --- a/library/HTTP_Adapter.ttcn +++ b/library/HTTP_Adapter.ttcn @@ -153,7 +153,7 @@ } } -template HTTPMessage tr_HTTP_Resp(template integer sts := ?) := { +template (present) HTTPMessage tr_HTTP_Resp(template integer sts := ?) := { response := { client_id := ?, version_major := ?, @@ -165,7 +165,7 @@ } }; -template HTTPMessage tr_HTTP_Resp_Bin(template integer sts := ?) := { +template (present) HTTPMessage tr_HTTP_Resp_Bin(template integer sts := ?) := { response_binary := { client_id := ?, version_major := ?, @@ -177,7 +177,7 @@ } }; -template HTTPMessage tr_HTTP_Resp2xx := tr_HTTP_Resp((200..299)); +template (present) HTTPMessage tr_HTTP_Resp2xx := tr_HTTP_Resp((200..299)); function f_http_tx_request(charstring url, charstring method := "GET", template (omit) charstring body := omit, @@ -246,7 +246,7 @@ } } -function f_http_rx_response(template HTTPMessage exp := tr_HTTP_Resp2xx, +function f_http_rx_response(template (present) HTTPMessage exp := tr_HTTP_Resp2xx, float tout := 2.0, template (omit) integer client_id := omit, boolean keep_connection := false) @@ -282,7 +282,7 @@ template (omit) charstring body := omit, template (omit) octetstring binary_body := omit, charstring content_type := "application/json", - template HTTPMessage exp := tr_HTTP_Resp2xx, + template (present) HTTPMessage exp := tr_HTTP_Resp2xx, float tout := 2.0, HeaderLines custom_hdr := { }, template (omit) integer client_id := omit, boolean keep_connection := false, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42436?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a5ee842c30de9ec22d9e375f6b1b24b3eaee1e0 Gerrit-Change-Number: 42436 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?)
by fixeria 19 Mar '26

19 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42438?usp=email ) Change subject: s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?) ...................................................................... s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?) Pass `exp := tr_HTTP_RespBody(decmatch T:?)` to f_http_transact() in every REST helper that decodes the response body. This ensures both a 2xx status code and a decodable body are required before any decode attempt is made, producing an informative "Unexpected HTTP response" verdict (rather than a confusing DTE) when e.g. an older osmo-s1gw returns HTTP 404 with an empty body for an unsupported endpoint. Change-Id: I6997dae5314d4a4588386183832426ab5b8d0843 --- M library/HTTP_Adapter.ttcn M s1gw/S1GW_REST_Functions.ttcn 2 files changed, 32 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/42438/1 diff --git a/library/HTTP_Adapter.ttcn b/library/HTTP_Adapter.ttcn index bd34a5f..2b2e2b7 100644 --- a/library/HTTP_Adapter.ttcn +++ b/library/HTTP_Adapter.ttcn @@ -181,6 +181,14 @@ template (present) HTTPMessage tr_HTTP_Resp2xx := tr_HTTP_Resp((200..299)); +template (present) HTTPMessage +tr_HTTP_RespBody(template (present) charstring body := ?) +modifies tr_HTTP_Resp2xx := { + response := { + body := body + } +}; + function f_http_tx_request(charstring url, charstring method := "GET", template (omit) charstring body := omit, template (omit) octetstring binary_body := omit, diff --git a/s1gw/S1GW_REST_Functions.ttcn b/s1gw/S1GW_REST_Functions.ttcn index 454d77e..6f4b42b 100644 --- a/s1gw/S1GW_REST_Functions.ttcn +++ b/s1gw/S1GW_REST_Functions.ttcn @@ -21,42 +21,48 @@ function f_REST_MetricsList(charstring metric_type := "all", charstring path := "") runs on http_CT return MetricsList { - var HTTPMessage rsp := f_http_transact("/metrics-list?type=" & metric_type & "&path=" & path); + var HTTPMessage rsp := f_http_transact("/metrics-list?type=" & metric_type & "&path=" & path, + exp := tr_HTTP_RespBody(decmatch MetricsList:?)); return dec_MetricsList(char2oct(rsp.response.body)); } /* Get the PFCP association state */ function f_REST_PfcpAssocState() runs on http_CT return PfcpAssocInfo { - var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "GET"); + var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "GET", + exp := tr_HTTP_RespBody(decmatch PfcpAssocInfo:?)); return dec_PfcpAssocInfo(char2oct(rsp.response.body)); } /* Initiate the PFCP Association Setup procedure */ function f_REST_PfcpAssocSetup() runs on http_CT return OperationResult { - var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "POST"); + var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "POST", + exp := tr_HTTP_RespBody(decmatch OperationResult:?)); return dec_OperationResult(char2oct(rsp.response.body)); } /* Initiate the PFCP Association Release procedure */ function f_REST_PfcpAssocRelease() runs on http_CT return OperationResult { - var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "DELETE"); + var HTTPMessage rsp := f_http_transact("/pfcp/assoc", method := "DELETE", + exp := tr_HTTP_RespBody(decmatch OperationResult:?)); return dec_OperationResult(char2oct(rsp.response.body)); } /* Send a PFCP Heartbeat Request to the peer */ function f_REST_PfcpHeartbeat() runs on http_CT return OperationResult { - var HTTPMessage rsp := f_http_transact("/pfcp/heartbeat", method := "POST"); + var HTTPMessage rsp := f_http_transact("/pfcp/heartbeat", method := "POST", + exp := tr_HTTP_RespBody(decmatch OperationResult:?)); return dec_OperationResult(char2oct(rsp.response.body)); } /* Get a list of MMEs in the pool */ function f_REST_MmeList() runs on http_CT return MmeList { - var HTTPMessage rsp := f_http_transact("/mme-list", method := "GET"); + var HTTPMessage rsp := f_http_transact("/mme-list", method := "GET", + exp := tr_HTTP_RespBody(decmatch MmeList:?)); return dec_MmeList(char2oct(rsp.response.body)); } @@ -72,7 +78,8 @@ function f_REST_MmeInfo(ParamMmeId mme_id) runs on http_CT return MmeItem { var charstring p_mme_id := enc_ParamMmeId(mme_id); - var HTTPMessage rsp := f_http_transact("/mme/" & p_mme_id, method := "GET"); + var HTTPMessage rsp := f_http_transact("/mme/" & p_mme_id, method := "GET", + exp := tr_HTTP_RespBody(decmatch MmeItem:?)); return dec_MmeItem(char2oct(rsp.response.body)); } @@ -87,7 +94,8 @@ /* Get a list of eNB connections */ function f_REST_EnbList() runs on http_CT return EnbList { - var HTTPMessage rsp := f_http_transact("/enb-list", method := "GET"); + var HTTPMessage rsp := f_http_transact("/enb-list", method := "GET", + exp := tr_HTTP_RespBody(decmatch EnbList:?)); return dec_EnbList(char2oct(rsp.response.body)); } @@ -95,7 +103,8 @@ function f_REST_EnbInfo(ParamEnbId enb_id) runs on http_CT return EnbItem { var charstring p_enb_id := enc_ParamEnbId(enb_id); - var HTTPMessage rsp := f_http_transact("/enb/" & p_enb_id, method := "GET"); + var HTTPMessage rsp := f_http_transact("/enb/" & p_enb_id, method := "GET", + exp := tr_HTTP_RespBody(decmatch EnbItem:?)); return dec_EnbItem(char2oct(rsp.response.body)); } @@ -103,14 +112,16 @@ function f_REST_EnbErabList(ParamEnbId enb_id) runs on http_CT return ErabList { var charstring p_enb_id := enc_ParamEnbId(enb_id); - var HTTPMessage rsp := f_http_transact("/enb/" & p_enb_id & "/erab-list", method := "GET"); + var HTTPMessage rsp := f_http_transact("/enb/" & p_enb_id & "/erab-list", method := "GET", + exp := tr_HTTP_RespBody(decmatch ErabList:?)); return dec_ErabList(char2oct(rsp.response.body)); } /* Get E-RAB list for all eNBs */ function f_REST_ErabList() runs on http_CT return ErabList { - var HTTPMessage rsp := f_http_transact("/erab-list", method := "GET"); + var HTTPMessage rsp := f_http_transact("/erab-list", method := "GET", + exp := tr_HTTP_RespBody(decmatch ErabList:?)); return dec_ErabList(char2oct(rsp.response.body)); } @@ -118,7 +129,8 @@ function f_REST_ErabInfo(ParamErabId erab_id) runs on http_CT return ErabItem { var charstring p_erab_id := enc_ParamErabId(erab_id); - var HTTPMessage rsp := f_http_transact("/erab/" & p_erab_id, method := "GET"); + var HTTPMessage rsp := f_http_transact("/erab/" & p_erab_id, method := "GET", + exp := tr_HTTP_RespBody(decmatch ErabItem:?)); return dec_ErabItem(char2oct(rsp.response.body)); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42438?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6997dae5314d4a4588386183832426ab5b8d0843 Gerrit-Change-Number: 42438 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: irq: make default IRQ handler Dummy_Handler weak
by lynxis lazus 19 Mar '26

19 Mar '26

Attention is currently required from: Hoernchen. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: irq: make default IRQ handler Dummy_Handler weak ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > you're modifying asf4 code anyway, what's the point having a weak-weak alias chain instead of just r […] I would like to keep the changes to the atmel start code as minimal as possible. We might want to share the hal code with the bootloader or if someone opens an upstream git repo for the atmel code. E.g. there is adafruits asf4 repo on github. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 19:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in osmo-asf4-dfu[master]: dfu: set poll timeout to 128 ms to reduce EPIPE errors
by lynxis lazus 19 Mar '26

19 Mar '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email ) Change subject: dfu: set poll timeout to 128 ms to reduce EPIPE errors ...................................................................... dfu: set poll timeout to 128 ms to reduce EPIPE errors The previous 10 ms poll timeout creates ERROR_PIPE errors when the octsim is connected to a more busy bus. E.g. when a network device is connected to the same bus or when flashing multiple OCTSIMs at the same time. From usb captures 70 ms should be already enough, but adding an additional safety margin. It is unclear why the EPIPE errors happens. Related: SYS#7910 Change-Id: I4abe812e17194f37ce5d97fd1d866aeebd1d4239 --- M usb/class/dfu/device/dfudf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/35/42435/1 diff --git a/usb/class/dfu/device/dfudf.c b/usb/class/dfu/device/dfudf.c index 4b010bd..87a97b8 100644 --- a/usb/class/dfu/device/dfudf.c +++ b/usb/class/dfu/device/dfudf.c @@ -187,7 +187,7 @@ break; } response[0] = dfu_status; // set status - response[1] = 10; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll + response[1] = 128; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll response[2] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll response[3] = 0; // set poll timeout (24 bits, in milliseconds) to small value for periodical poll response[4] = dfu_state; // set state (post-transition) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42435?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I4abe812e17194f37ce5d97fd1d866aeebd1d4239 Gerrit-Change-Number: 42435 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support
by Jenkins Builder 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov, pespin. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email ) Change subject: transceiver: add optional WebSDR device support ...................................................................... Patch Set 10: (11 comments) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/695a8c4f_1cd43401?usp… : PS10, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7b7c5491_0ed461cb?usp… : PS10, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/c2f166d5_c9309b05?usp… : PS10, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/fe7cc3d4_8c63c847?usp… : PS10, Line 258: bool driveReceiveFIFO(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b74a6f6d_10a78d66?usp… : PS10, Line 264: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2010a7f5_f682f9dd?usp… : PS10, Line 265: @param chan channel number please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/77e6c8d4_c3ec6ed5?usp… : PS10, Line 266: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/326f3ef2_2a686015?usp… : PS10, Line 267: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/00447d61_17d49de6?usp… : PS10, Line 270: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line File Transceiver52M/radioInterface.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1052ab8f_b86ae496?usp… : PS10, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9a83a74b_ab4f20ea?usp… : PS10, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 10 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 18 Mar 2026 15:54:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 19 Mar '26

19 Mar '26

Attention is currently required from: pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 8: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/687766e3_5b0a1d92?usp… : PS7, Line 1090: return rc; > Ok I think I'm starting to understand the problem here: […] Thanks for the explanation, that makes sense. I've updated the implementation to use two states: a success flag (whether a response should be sent) and a retcode (whether a failure occurred that should propagate to the caller). -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 15:53:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Timur Davydov 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: transceiver: split control command handling from socket I/O ...................................................................... transceiver: split control command handling from socket I/O - move control command parsing/response generation into ctrl_cmd_handle() - keep ctrl_sock_handle_rx() focused on socket read/write Change-Id: I5413aa511e951522270c75635e89448395fc429e --- M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h 2 files changed, 33 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/42410/8 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 8 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support
by Timur Davydov 19 Mar '26

19 Mar '26

Attention is currently required from: Timur Davydov, pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: transceiver: add optional WebSDR device support ...................................................................... transceiver: add optional WebSDR device support - Add support for WebSDR devices enabled via the --with-websdr configure flag. - add libosmo-trx-websdr library and pkg-config file - update .gitignore for wasm and pkg-config artifacts Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h A Transceiver52M/libosmo-trx-websdr.pc.in A Transceiver52M/osmo-trx-websdr.h M Transceiver52M/osmo-trx.cpp M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterface.h M configure.ac 10 files changed, 328 insertions(+), 28 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/42411/10 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 10 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT
by Timur Davydov 19 Mar '26

19 Mar '26

Attention is currently required from: fixeria, laforge, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email ) Change subject: transceiver: return -EINVAL for invalid SETSLOT ...................................................................... Patch Set 2: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42421/comment/d30a2c34_aadef775?usp… : PS1, Line 1090: return rc == -EINVAL ? 0 : rc; /* Ignore invalid values, but report other errors */ > Scratch that, See my comment in https://gerrit.osmocom. […] I see — in that case I'll just drop this commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I90bda68268abdeee9c766a3bf4189fba8f13da53 Gerrit-Change-Number: 42421 Gerrit-PatchSet: 2 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 18 Mar 2026 15:25:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026