Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite
......................................................................
GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite
Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760
---
M library/GTPv2_Templates.ttcn
M pgw/PGW_Tests.ttcn
2 files changed, 12 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/42498/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760
Gerrit-Change-Number: 42498
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, fixeria, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf
......................................................................
5gc: Introduce test TC_pdu_sess_est_pco_pcscf
Our deps/nas fork is modified to fix multiple incorrect definitions
around ProtocolContainer record.
Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8
---
M 5gc/C5G_Tests.ttcn
M 5gc/ConnHdlr.ttcn
M 5gc/expected-results.xml
M 5gc/open5gs/open5gs-smf.yaml
M deps/Makefile
M library/NG_NAS_Osmo_Templates.ttcn
6 files changed, 59 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/42482/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8
Gerrit-Change-Number: 42482
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42499?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/
......................................................................
GTPv1U_Emulation: Rename s/f_gtp1u_ping4/f_gtp1u_ping/
The function can also be (and is) used to ping IPv6 hosts.
Change-Id: I195cb048176aefddcb477083ddc949b86ec592fa
---
M 5gc/ConnHdlr.ttcn
M library/GTPv1U_Emulation.ttcnpp
M pgw/PGW_Tests.ttcn
3 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/42499/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42499?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I195cb048176aefddcb477083ddc949b86ec592fa
Gerrit-Change-Number: 42499
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email )
Change subject: GTPv2_Templates: Add enum for PDN Type and use it in pgw testsuite
......................................................................
Patch Set 1:
(1 comment)
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498/comment/eb0c4d5f_0e5d… :
PS1, Line 1002: TC_createSession_ping6
> Looks like this should be done in a separate commit? […]
That's not part of this patch, I'll fix it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42498?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9833e998522a09a15b93c8fed0e18a5e8159d760
Gerrit-Change-Number: 42498
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 16:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email )
Change subject: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf
......................................................................
Patch Set 1:
(1 comment)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482/comment/a9516e27_2162… :
PS1, Line 410: valueof
> I'll have a look, IIRC I applied it this way because otherwise it said it was expecting a value. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8
Gerrit-Change-Number: 42482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 16:28:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email )
Change subject: 5gc: Introduce test TC_pdu_sess_est_pco_pcscf
......................................................................
Patch Set 1:
(1 comment)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482/comment/d0676a51_dacc… :
PS1, Line 410: valueof
> These `valueof` are not really needed here because `cs_ExtdPCO` expects the second argument to be a […]
I'll have a look, IIRC I applied it this way because otherwise it said it was expecting a value. It's true that meanwhile I modified a bit the code, let's see.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42482?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic7b22ad647bcac944551ac1c29080f895ca72cf8
Gerrit-Change-Number: 42482
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 16:21:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42480?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: 5gc: Remove arleady tested TODO
......................................................................
5gc: Remove arleady tested TODO
PDU Sess Est Req with emeregency services is already tested in test
TC_normal_reg_emergency_services.
Change-Id: I5e2d202ffd019b22a006637534922e0ba1d09ca0
---
M 5gc/C5G_Tests.ttcn
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/5gc/C5G_Tests.ttcn b/5gc/C5G_Tests.ttcn
index b871b42..2bcc1d3 100644
--- a/5gc/C5G_Tests.ttcn
+++ b/5gc/C5G_Tests.ttcn
@@ -1146,7 +1146,6 @@
* - 3GPP TS 23.632 5.2.3 Vector Generation in UDM/ARPF: Not supported by open5gs (missing Nudm_UEAuthentication_GetHssAv in UDM)
* - 3GPP TS 23.502 Annex G (normative): Support of GERAN/UTRAN access by SMF+PGW-C: Not supported by open5gs (Gn<->N7 (to PCF) in open5gs-smfd)
*
- * - Emergency call (PDU Sess Establish "Request Type"="Emergency Request")
* - VoLTE:
* -- " If the UE requested P-CSCF discovery then the message shall also include the P-CSCF IP address(es) as determined by the SMF and as described in clause 5.16.3.4 of TS 23.50"
* - Fill in PCO during PDU Sess Establish Req.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42480?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5e2d202ffd019b22a006637534922e0ba1d09ca0
Gerrit-Change-Number: 42480
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>