Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email )
Change subject: global_platform: install_cap_parser: argument groups cannot be nested
......................................................................
Patch Set 3: Code-Review+1 Verified+1
(2 comments)
Patchset:
PS3:
This is not perfect yet. Nothing bad happens and everything still works but maybe there are users that believe they can pass a half baked --install-parameter hexstring and use --install-parameter-stk to add STK parameters. That would not work of course.
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42310/comment/27682eb8_69b8aea1?usp=em… :
PS3, Line 898: if opts.install_parameters is not None:
Now there is no check that makes sure that none of the opts.install_parameters_* is set. This means that when someone passes --install-parameters xyz in addition with for e.g. --install-parameters-volaitile-memory-quota 1234, the --install-parameters-volaitile-memory-quota parameter gets silently ignored.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579
Gerrit-Change-Number: 42310
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email )
Change subject: s1ap_proxy: fix build_erab_setup_response_failure() to report all E-RABs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497/comment/90b4bbb8_f79c… :
PS1, Line 334: value = Items} <- C0#'E-RABSetupRequest'.protocolIEs,
Can you move the "<- part to a line below so the whole block becomes clearer?
It's difficult to read as is.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7933fceb0edcdfdc95ace35416297b11c83f0bc9
Gerrit-Change-Number: 42497
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42496?usp=email )
Change subject: s1gw: generalize f_TC_e_rab_setup_failure() for N E-RABs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42496?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8a5dc338d28013dc85e1ce4b3bdac92cb3b35304
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:31:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42495?usp=email )
Change subject: s1gw: add more PFCP Heartbeat test cases
......................................................................
Patch Set 1:
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42495/comment/6748476c_1baa… :
PS1, Line 1246: * Response differs from the value stored during Association Setup, and resets the
the recovery timestamp from Association Setup shall be ignored according to newer PFCP specs.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42495?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ac25b1ca4bb11e61bff220449397c271b11464
Gerrit-Change-Number: 42495
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492?usp=email )
Change subject: library/PFCP_Emulation: add f_PFCPEM_set_recovery_timestamp()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492/comment/6581404a_fe39… :
PS1, Line 12: peer restart between test cases.
> Why would you like to avoid the IUT not detecting the restart? After all we are resetting the state […]
Ah ok so it's not in between tests, it's in the same test because you are spwarning a different ConnHdlr to do the Assoc Setup...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47e06d26b42081a28aacb6e06b5aeabf945362c
Gerrit-Change-Number: 42492
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:23:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: laforge, osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42378?usp=email )
Change subject: global_platform: refactor gen_install_parameters()
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> I have now looked at this again. I think the code is 100% correct now. […]
Thank you, Philipp!
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42378?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8756fb38016cdf0527fe2e21edb44381d1dc557f
Gerrit-Change-Number: 42378
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493?usp=email )
Change subject: s1gw: f_ConnHdlr_pfcp_assoc_handler(): handle already-connected case
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493/comment/24f58fd8_d245… :
PS1, Line 143: vc_conn := f_ConnHdlr_spawn(refers(f_ConnHdlr_pfcp_assoc_handler),
I wonder why do you need to spawn a new ConnHdlr to do some non-session related stuff. Sounds like it would be better to do it from test_CT instead?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42493?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9d2ebb1ddb3d3896dd24e2a37e9d21335441d52
Gerrit-Change-Number: 42493
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:22:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492?usp=email )
Change subject: library/PFCP_Emulation: add f_PFCPEM_set_recovery_timestamp()
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492/comment/916b4623_b99e… :
PS1, Line 12: peer restart between test cases.
Why would you like to avoid the IUT not detecting the restart? After all we are resetting the state in our PFCP endpoint after every test...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42492?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If47e06d26b42081a28aacb6e06b5aeabf945362c
Gerrit-Change-Number: 42492
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42491?usp=email )
Change subject: s1gw/rest: PfcpAssocInfo: field 'lrts' is mandatory
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42491?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I332e95a32935e0c8da99e600e8d30af14bd36b16
Gerrit-Change-Number: 42491
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:17:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes