[S] Change in ...osmo-s1gw[master]: s1ap_proxy: fix build_erab_setup_response_failure() to report all E-RABs - gerrit-log

25 Mar 2026


      Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email )
Change subject: s1ap_proxy: fix build_erab_setup_response_failure() to report all E-RABs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497/comment/90b4bbb8_f79cc... :
PS1, Line 334:                                     value = Items} <- C0#'E-RABSetupRequest'.protocolIEs,
Can you move the "<- part to a line below so the whole block becomes clearer?
It's difficult to read as is.
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42497?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7933fceb0edcdfdc95ace35416297b11c83f0bc9
Gerrit-Change-Number: 42497
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 25 Mar 2026 10:39:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes