Re: Pirelli DP-L10 keypad - baseband-devel

7 Jul 2012

Hi Kevin,

On 07.07.2012 11:15, Kevin Redon wrote:
...
  - the additional volume up/down and camera buttons
press are detected
 by keypad_poll(), but not visible in KBR_LATCH_REG 
Yes, for that you need to increase the number of rows/columns that are
scanned (can exactly remember which one). The Compal phones don't use
all of them.

...
  - the power button press is not detected by
keypad_poll() (or ignored
 by
 "with_interrupts && !polling") 
As it seems the power button is not connected to the keyboard scan
matrix. You get an interrupt from Iota though when the button is
pressed, see [2]. That code was removed again from master.

...
  - the keypad.h file is in target/firmware/include/,
but it's board
 dependent. is there a clean way to handle that? 
Did you check out the steve-m/pirelli branch [2]? It already contains
the modified keypad header.

Those changes should definitely be cleaned up and put into master,
especially make the UARTs runtime configurable to have them swapped for
the DP-L10.

Regards,
Steve

[1] 
http://cgit.osmocom.org/cgit/osmocom-bb/commit/?id=4f0825a352af5499beee068d…
[2] http://cgit.osmocom.org/cgit/osmocom-bb/commit/?h=steve-m/pirelli