Hi laf0rge,
I was building the firmware with a GCC 4.5.2 created by Steve-m's script and had to include limits.h for UINT_MAX. While reading the code I stumbled across a typo... I think the patches can be picked to master as well.
holger
Zecke,
On Mon, Jan 31, 2011 at 01:54:09PM +0100, Holger Freyther wrote:
I was building the firmware with a GCC 4.5.2 created by Steve-m's script and had to include limits.h for UINT_MAX. While reading the code I stumbled across a typo... I think the patches can be picked to master as well.
sure, feel free to just commit them to master. no need to ask for such trivial compile and typo fixes.
On Mon, Jan 31, 2011 at 04:26:29PM +0100, Holger Freyther wrote:
On 01/31/2011 04:12 PM, Harald Welte wrote:
Zecke,
sure, feel free to just commit them to master. no need to ask for such trivial compile and typo fixes.
You will have to grant me access first.
sorry, didn't realize it was in the openpcd tree. I've applied your patches meanwhile.
The real solution is probably to bring some modularity into the openpcd tree and find a way how the shared code can come from the openpcd repo, while only the simtrace specific code comes from the simtrace repository.
However, the OpenPCD firmware and its build system was not designed that way :(
Regards, Harald
baseband-devel@lists.osmocom.org
-
Harald Welte -
Holger Freyther