Hi,
I noticed in src/target/firmware/calypso/dsp.c:
static void dsp_pre_boot(const struct dsp_section *bootcode) { dputs("Assert DSP into Reset\n"); calypso_reset_set(RESET_DSP, 1);
if (bootcode) { dputs("Loading initial DSP bootcode (API boot mode)\n"); dsp_upload_sections_api(dsp_bootcode, DSP_BASE_API_MIRROR);
It seems that the intention is to pass bootcode to dsp_upload_sections_api, but it is still using the hardcoded dsp_bootcode.
No functional impact as it is nowhere used with any other bootcode.
Best regards,
Job
Hi,
It seems that the intention is to pass bootcode to dsp_upload_sections_api, but it is still using the hardcoded dsp_bootcode.
Yes indeed, nice catch.
however that code is purely theoritical because that particular code would only work on development calypso devices anyway. (the other boot a hardcoded boot loader whatever we do)
I fixed it anyway in git.
Cheers,
Sylvain
baseband-devel@lists.osmocom.org